)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a481e5dbc88a1769718e776cd605c637f2c981fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b9d51195_b0236c33","updated":"2024-07-24 08:09:40.000000000","message":"As mentioned in the bug report, IMO there is no bug in kolla currently, so nothing to fix really. this whole stack should IMO be squashed into a single patch that adds the queue_manager flag and the config options that are necessary for it to work","commit_id":"ec67e5a09b391246c469e83d31895f85ce2b210d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0e3cb89077ffe713bb1ffffe7478262b64f35890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"abd580f7_d977122c","updated":"2024-07-24 07:58:54.000000000","message":"why did you push a new PS without any changes? this is confusing for reviewers, please try not to do that","commit_id":"ec67e5a09b391246c469e83d31895f85ce2b210d"}],"ansible/roles/heat/templates/heat.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a9852d60f4c7a747008d3e4568f4ed1306aaacd5","unresolved":true,"context_lines":[{"line_number":90,"context_line":"{% endif %}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[oslo_concurrency]"},{"line_number":93,"context_line":"lock_path \u003d /var/lib/heat/tmp"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"[clients]"},{"line_number":96,"context_line":"endpoint_type \u003d internalURL"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8f1c9467_17bcd652","line":93,"updated":"2024-07-22 15:23:21.000000000","message":"The docs say:\n\nFor security, the specified directory should only be writable by the user running the processes that need locking.\n\nDo we need to ensure this?\n\nI also wonder whether this is rather a bug in heat. What sense is there in using local filesystem locks if the service is running distributed over multiple servers? Maybe compare to what OSA or others are doing?","commit_id":"35e0e7284c59d64a463179dc48690a732b515e69"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0e3cb89077ffe713bb1ffffe7478262b64f35890","unresolved":true,"context_lines":[{"line_number":90,"context_line":"{% endif %}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[oslo_concurrency]"},{"line_number":93,"context_line":"lock_path \u003d /var/lib/heat/tmp"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"[clients]"},{"line_number":96,"context_line":"endpoint_type \u003d internalURL"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bfbd6d98_40beca44","line":93,"in_reply_to":"1808eaf2_03180d05","updated":"2024-07-24 07:58:54.000000000","message":"that opens more questions than it resolves. I don\u0027t use heat myself, though, so I can\u0027t really answer any of this, deferring to other reviewers","commit_id":"35e0e7284c59d64a463179dc48690a732b515e69"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2083007e2650f3431badfbb756a70325799b7a5f","unresolved":true,"context_lines":[{"line_number":90,"context_line":"{% endif %}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[oslo_concurrency]"},{"line_number":93,"context_line":"lock_path \u003d /var/lib/heat/tmp"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"[clients]"},{"line_number":96,"context_line":"endpoint_type \u003d internalURL"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1808eaf2_03180d05","line":93,"in_reply_to":"8f1c9467_17bcd652","updated":"2024-07-22 15:34:50.000000000","message":"It\u0027s, do you think we should change also root ? \n\n(heat-engine)[root@controller0 /]# ls -la /var/lib/heat/\ntotal 20\ndrwxr-xr-x 1 heat heat 4096 Jul 22 14:50 .\ndrwxr-xr-x 1 root root 4096 Jul 22 11:34 ..\ndrwxr-xr-x 3 heat heat 4096 Jul 22 14:50 .cache\ndrwxr-xr-x 2 heat heat 4096 Jul 22 14:50 tmp\n\n\nI think it\u0027s caused by oslo.messaging queue manager as it saves the name of queue to that location I would say...\n\n(heat-engine)[root@controller0 /]# ls -la  /var/lib/heat/tmp/oslo_read_shm_controller0_heat-engine \n-rw-r--r-- 1 heat heat 0 Jul 22 14:50 /var/lib/heat/tmp/oslo_read_shm_controller0_heat-engine","commit_id":"35e0e7284c59d64a463179dc48690a732b515e69"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"adeb6618a4351c1517232fefbb6ce70389bd9b34","unresolved":true,"context_lines":[{"line_number":90,"context_line":"{% endif %}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[oslo_concurrency]"},{"line_number":93,"context_line":"lock_path \u003d /var/lib/heat/tmp"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"[clients]"},{"line_number":96,"context_line":"endpoint_type \u003d internalURL"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bb2abca4_18e61ff1","line":93,"in_reply_to":"bfbd6d98_40beca44","updated":"2024-07-29 14:02:21.000000000","message":"it\u0027s at least weird if this is a required value that it\u0027s neither documented in https://docs.openstack.org/heat/latest/configuration/config-options.html\nnor in https://docs.openstack.org/heat/latest/install/install-ubuntu.html\n\nI also can\u0027t find any default values with regards to this in the codebase itself.\n\nit seems oslo_concurrency is used both in the engine itself as a way to start a number of workers:\nhttps://github.com/openstack/heat/blob/57e686bdfb8ed9aa12e518ba947989c21a35e89f/heat/cmd/engine.py#L82\n\nand in the wsgi server:\n\nhttps://github.com/openstack/heat/blob/57e686bdfb8ed9aa12e518ba947989c21a35e89f/heat/common/wsgi.py#L263\n\nso that would at least explain which type of concurrency it\u0027s used for.","commit_id":"35e0e7284c59d64a463179dc48690a732b515e69"}]}