)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d505c54fa586bcf9d0cf9e7fb69a56cf44c11edf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18546195_f24c1b6b","updated":"2024-08-21 12:28:00.000000000","message":"I h","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9289f2017003aa41d60d2cdd552089322ab466df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c483510f_462301ff","updated":"2024-08-21 09:41:47.000000000","message":"Out of curiosity, why do you just want to use this for Heat?","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8c826eebf7fc0cdfd44d731867c8250851eafdd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"abee7730_10d1d2d6","updated":"2024-07-23 14:59:04.000000000","message":"recheck ubuntu","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b649d3ee38ea5c9d50092787e15722ab4b11a572","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55cd4ec4_b075b94a","in_reply_to":"c483510f_462301ff","updated":"2024-08-21 10:30:42.000000000","message":"why? because Kolla using quorum queues for every service but heat need also transient to be quorum queues - how do I know it ? I tested it as CI is not available for heat.\n\nafter some time rabbitmq is overloaded because there is a thousands of unconsumed messages ...heat bug ? yeah probably...but this is fixing current queus setup in Kolla default deployment ...just test it manually","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"}],"ansible/roles/heat/templates/heat.conf.j2":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9289f2017003aa41d60d2cdd552089322ab466df","unresolved":true,"context_lines":[{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":84,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":85,"context_line":"rabbit_transient_quorum_queue \u003d true"},{"line_number":86,"context_line":"{% endif %}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"{% if heat_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"40a4a864_dce31f6b","line":85,"updated":"2024-08-21 09:41:47.000000000","message":"We probably want to consider using QManager here: https://review.opendev.org/c/openstack/oslo.messaging/+/889425\n\nTo quote the reno:\n\u003e It\u0027s also higlhy recommended to enable this feature when using quorum\n  queues for transient (option named ``rabbit_transient_quorum_queue``) to\n  avoid consuming all erlang atoms after some time.","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"7d62e2bf517dfb1e350be303bd4209b8d764b869","unresolved":true,"context_lines":[{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":84,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":85,"context_line":"rabbit_transient_quorum_queue \u003d true"},{"line_number":86,"context_line":"{% endif %}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"{% if heat_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"2c20a5df_457c6822","line":85,"in_reply_to":"13db9ff4_16f07116","updated":"2024-08-21 11:53:09.000000000","message":"Yes I agree. What I mean is that patch should merge before this one, so we don\u0027t risk hitting that erlang atoms limit","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d505c54fa586bcf9d0cf9e7fb69a56cf44c11edf","unresolved":true,"context_lines":[{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":84,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":85,"context_line":"rabbit_transient_quorum_queue \u003d true"},{"line_number":86,"context_line":"{% endif %}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"{% if heat_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"83bcb6a0_9999bc8f","line":85,"in_reply_to":"2c20a5df_457c6822","updated":"2024-08-21 12:28:00.000000000","message":"It is on my todo list, there is also need to add oslo_lock path for qmanager to work... I will squash my commits and propose as one .","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b649d3ee38ea5c9d50092787e15722ab4b11a572","unresolved":true,"context_lines":[{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":84,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":85,"context_line":"rabbit_transient_quorum_queue \u003d true"},{"line_number":86,"context_line":"{% endif %}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"{% if heat_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e57ebe1e_f02b68d7","line":85,"in_reply_to":"40a4a864_dce31f6b","updated":"2024-08-21 10:30:42.000000000","message":"yeah it is in my other patch","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0d65869880d20bbd832abd689bf19e235743811d","unresolved":true,"context_lines":[{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":84,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":85,"context_line":"rabbit_transient_quorum_queue \u003d true"},{"line_number":86,"context_line":"{% endif %}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"{% if heat_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"13db9ff4_16f07116","line":85,"in_reply_to":"6ed0a1be_a79fa6c9","updated":"2024-08-21 11:32:12.000000000","message":"I think we should turn on globally as the names  is then more readable in rabbit ..","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"846c956dce630dce39b5369334c5917e2a18e5fc","unresolved":true,"context_lines":[{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":84,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":85,"context_line":"rabbit_transient_quorum_queue \u003d true"},{"line_number":86,"context_line":"{% endif %}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"{% if heat_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"6ed0a1be_a79fa6c9","line":85,"in_reply_to":"e57ebe1e_f02b68d7","updated":"2024-08-21 10:54:03.000000000","message":"Good stuff, I\u0027d missed that patch. IMO we should make this one depend on that. It\u0027s not a technical requirement, but I think it would be good to follow the recommendation.","commit_id":"e96f2694967de0491b88546ab7dd8e5414b2e81f"}]}