)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"838524f3791aa804dda37582e0744edb99bc6738","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-07-23 16:56:21 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add queue manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iae5f268e778fbbd2b744dc71a84253ec9e758a99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4798f9d7_b7181729","line":8,"updated":"2024-07-24 08:01:04.000000000","message":"this needs a commit message that explains not only what is being done, but also why. likely also a reno","commit_id":"dfc8d54592a87e89663b651728640e517c98d6a6"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"80a72d4de8d424062b365e5364404e4997519a71","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-07-23 16:56:21 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add queue manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iae5f268e778fbbd2b744dc71a84253ec9e758a99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4fa2d8ee_5022672d","line":8,"in_reply_to":"4798f9d7_b7181729","updated":"2025-01-13 15:24:04.000000000","message":"Done","commit_id":"dfc8d54592a87e89663b651728640e517c98d6a6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"6db5cbdd65bec12ff26dd7cd29e6afb3916bbd44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f4d5aba7_6c017dcc","updated":"2025-01-15 15:43:01.000000000","message":"I reckon this is now ready for review. @michal.arbet@ultimum.io could you bring it out of WIP please?","commit_id":"207e0cd82b064a44c798fefd3772730f3b16dc24"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3fc80b4d5375fa5c4bf679ae7c71496739fa3662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4ed54b62_931edfe2","updated":"2025-01-17 11:09:51.000000000","message":"recheck holding a node for debugging","commit_id":"a0de0e9f23f912461e4e4ccc0b762b473c673636"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9a7b80fc528b64c7817ebaae15a4d5108f08deb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"93607b1f_b433c911","updated":"2025-01-30 08:10:23.000000000","message":"Nova discover now fixed.","commit_id":"bbe658c875988cea3800103c48dda9d620a18d80"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d468af440263472da33de1621508cc84a89f88fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"0e0502bd_728558ce","updated":"2025-01-30 08:11:01.000000000","message":"Adding +2 as I am not the only one who was working on patch - Thanks @mattc@stackhpc.com","commit_id":"487ec8a372aefd51f92e7dd364666957d67bc84c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"4212e7ced6d42dc4478ce90e5b541e55fa5fee18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"6ff2285f_e05fd716","updated":"2025-01-30 14:08:14.000000000","message":"Done some thorough testing of this, I say it\u0027s good to go now","commit_id":"aed85cec18ac885fa60df82cbd46eeed6c2d9681"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"86b1e54e9d19a2fda8ac113593c928f373da5a58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"054d0f4a_9ed323cc","updated":"2025-01-31 16:43:35.000000000","message":"recheck new images","commit_id":"3208c0781a1d7dd2d3cfc97a5f44640aca838383"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c8e0543791e76ee4f513cb257bfc0b8b670f26c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"098af17e_d8a81ef7","updated":"2025-01-31 13:29:41.000000000","message":"recheck new images","commit_id":"3208c0781a1d7dd2d3cfc97a5f44640aca838383"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d5b2b7a7d135190b7e1c41c253a288b4f1b464ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"94ca90f8_5cd36f75","updated":"2025-01-31 14:28:49.000000000","message":"recheck new images","commit_id":"3208c0781a1d7dd2d3cfc97a5f44640aca838383"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4ae55599c2855d01c6e6a4f21dc26d99eb638e16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"e0502e58_7ac6ed7f","updated":"2025-01-31 12:36:06.000000000","message":"recheck new images","commit_id":"3208c0781a1d7dd2d3cfc97a5f44640aca838383"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cfa591c6b00e8704bec56906521085252bd6b141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3ae89382_0c061ffa","updated":"2025-02-04 21:27:50.000000000","message":"recheck build errors because of opendev mirrors","commit_id":"58102b2fc754a66fe2ae58a8cf37536c796c8602"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bf0603c6afbe7da78dd01869d95de0a36f75fd88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"74b2bae6_0f200fc0","updated":"2025-02-07 15:31:03.000000000","message":"the slurp upgrade jobs are all failing, this looks suspicous, didn\u0027t check in detail yet, but it looks like new instances don\u0027t have connectivity","commit_id":"58102b2fc754a66fe2ae58a8cf37536c796c8602"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1bb5e5f6c04fdf4f3271f570f8413f5889827e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"7e1ff076_617320ed","in_reply_to":"3b0774ad_b6005922","updated":"2025-02-10 17:35:07.000000000","message":"Instance has connectivity I would say ... \n\n```\n+ ssh -v -o BatchMode\u003dyes -o StrictHostKeyChecking\u003dno cirros@198.51.100.193 hostname\nOpenSSH_8.7p1, OpenSSL 3.2.2 4 Jun 2024\ndebug1: Reading configuration data /etc/ssh/ssh_config\ndebug1: Reading configuration data /etc/ssh/ssh_config.d/50-redhat.conf\ndebug1: Reading configuration data /etc/crypto-policies/back-ends/openssh.config\ndebug1: configuration requests final Match pass\ndebug1: re-parsing configuration\ndebug1: Reading configuration data /etc/ssh/ssh_config\ndebug1: Reading configuration data /etc/ssh/ssh_config.d/50-redhat.conf\ndebug1: Reading configuration data /etc/crypto-policies/back-ends/openssh.config\ndebug1: Connecting to 198.51.100.193 [198.51.100.193] port 22.\ndebug1: connect to address 198.51.100.193 port 22: Connection refused\nssh: connect to host 198.51.100.193 port 22: Connection refused\n+ [[ 10 -eq 12 ]]\n+ echo \u0027Cannot access server - retrying\u0027\nCannot access server - retrying\n+ sleep 10\n+ for i in $(seq 1 ${attempts})\n+ ping -c1 -W1 198.51.100.193\nPING 198.51.100.193 (198.51.100.193) 56(84) bytes of data.\n64 bytes from 198.51.100.193: icmp_seq\u003d1 ttl\u003d63 time\u003d1.23 ms```\n\nBut it\u0027s refused ? Don\u0027t know why... still not UP ? i really don\u0027t know","commit_id":"58102b2fc754a66fe2ae58a8cf37536c796c8602"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b3e9b4a0e9a1ef5e4e95853a74953effe68f3657","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3b0774ad_b6005922","in_reply_to":"74b2bae6_0f200fc0","updated":"2025-02-10 14:07:25.000000000","message":"Hmm, yeah, I see, but is this caused by a a QueueManager ? It\u0027s look unrelated.","commit_id":"58102b2fc754a66fe2ae58a8cf37536c796c8602"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"df64d584edb0c360742e874c9318aaa9cf77c6ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"7717d0bd_b3f4a557","in_reply_to":"7e1ff076_617320ed","updated":"2025-02-11 10:39:02.000000000","message":"Okay, thanks @frickler@offenerstapel.de , good catch. This was caused by same thing as @mattc@stackhpc.com described above in a comments - added processname also for nova-metadata service (needed after uwsgi nova support was merged). So, now also slurp upgrades are fixed 😊","commit_id":"58102b2fc754a66fe2ae58a8cf37536c796c8602"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"743765110c948794a52707d4b6c8ab70b51db7f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"b2c02a09_06aff47e","updated":"2025-02-17 15:46:08.000000000","message":"Adding +2 as I am not the only one who was working on patch - Thanks @mattc@stackhpc.com, and also @mnasiadka@gmail.com already gave +2 before.\n\nSo, approving.","commit_id":"c48403b33aa63a1982c0aa484f5a1f3252d9a5ee"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"38fd0669175e113d8ff35750c82c52426b3670a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"708bd650_3027847e","updated":"2025-02-17 12:07:07.000000000","message":"recheck timeout","commit_id":"c48403b33aa63a1982c0aa484f5a1f3252d9a5ee"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d074dcfba18b35f27a08e1c383dcce3405915372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"f5678d66_221b22b5","updated":"2025-02-11 10:35:47.000000000","message":"this looks like it should work better now","commit_id":"c48403b33aa63a1982c0aa484f5a1f3252d9a5ee"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"df64d584edb0c360742e874c9318aaa9cf77c6ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"ca47b79f_2a626276","in_reply_to":"f5678d66_221b22b5","updated":"2025-02-11 10:39:02.000000000","message":"yep, I\u0027ve also noticed that ironic was missing some messages, I changed this \u0027processname\u0027 option  also for ironic and waiting for result. Also, I was wondering ..if we have service_name variable present in template while rendering for a service...conditional is not needed there ...","commit_id":"c48403b33aa63a1982c0aa484f5a1f3252d9a5ee"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1ba31cc3c61d31fd9500adf9a309749332c6f806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"751d7588_10061bb6","updated":"2025-02-24 18:53:51.000000000","message":"recheck timeouts","commit_id":"8c93aa5c9680df7bd380e43ecf3a26451a2656d1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"485ea66abab8fbddfe4646ededdd85dadec76d17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"873c764d_ea6e51b6","updated":"2025-02-24 21:42:31.000000000","message":"recheck timeouts","commit_id":"8c93aa5c9680df7bd380e43ecf3a26451a2656d1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3a2c894bbaa5aa5c8129eae3441a075402244557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"6dbc35a4_51414e81","updated":"2025-02-25 12:01:51.000000000","message":"Ironic fixed - ready to merge","commit_id":"5fae5210ba9fc67b318fe04cc4dde68a2ddf4009"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1dbe08f6c100af839d3e293be4a598c6833a4d85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"676e822d_4e9f5016","updated":"2025-02-28 22:47:14.000000000","message":"recheck as lastly CI was overloaded","commit_id":"f80530a92f149ab3f91520562b6f5d6951a9f9b9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"600d6829da75bc804ed8fa27cab000157c9dbb34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"afac1222_742dbc15","updated":"2025-02-27 16:34:40.000000000","message":"recheck debian podman timeout","commit_id":"f80530a92f149ab3f91520562b6f5d6951a9f9b9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8a25f4c4ff859b9e43416996ad9cad3c643e395e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"e2b3b8aa_6d13f412","updated":"2025-02-27 17:46:18.000000000","message":"recheck timeouts","commit_id":"f80530a92f149ab3f91520562b6f5d6951a9f9b9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dcd29afe0ad6d1b4e19ce567341f754db2eb798c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"4bed2920_136bbeda","updated":"2025-03-04 16:06:53.000000000","message":"recheck timeouts","commit_id":"27d19aa30d02c70c14afe4bf64d4e1adbd18bff3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"708b58cbca9bb3ca6d97a8ddca7a14f85b60d4be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"6cbbcd52_103f2437","updated":"2025-03-19 21:14:40.000000000","message":"reno could be amended in a follow-up","commit_id":"e4af635bc57479da07fb7fe87f34b69a15212c91"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0c67fdffb2b59249f094ce353edb262a12643d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"77cc7067_d6ed120e","updated":"2025-03-24 10:18:34.000000000","message":"Merging given previous +2s","commit_id":"4e0c0aa767d993026dbd927e3dca98f17fed7895"}],"ansible/roles/aodh/templates/aodh.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"430844ca6feecd56f7f240fdee4bed60f4c95a3e","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[oslo_messaging_rabbit]"},{"line_number":64,"context_line":"{% if om_enable_queue_manager | bool %}"},{"line_number":65,"context_line":"use_queue_manager \u003d True"},{"line_number":66,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":67,"context_line":"processname \u003d {{ service_name }}"},{"line_number":68,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"d8eec04e_7c89db58","line":65,"updated":"2025-03-12 14:36:58.000000000","message":"I thought we agreed long time ago to use \u0027true\u0027, not \u0027True\u0027... let\u0027s not create entropy in the configs (well, at least not bigger entropy)","commit_id":"27d19aa30d02c70c14afe4bf64d4e1adbd18bff3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"07ad47a218bc78645e1f4379aacdbdb5c3d80264","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[oslo_messaging_rabbit]"},{"line_number":64,"context_line":"{% if om_enable_queue_manager | bool %}"},{"line_number":65,"context_line":"use_queue_manager \u003d True"},{"line_number":66,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":67,"context_line":"processname \u003d {{ service_name }}"},{"line_number":68,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"fb8e50f5_6c199dbb","line":65,"in_reply_to":"6ae32da2_378f74cf","updated":"2025-03-13 11:26:57.000000000","message":"https://review.opendev.org/c/openstack/kolla-ansible/+/944124","commit_id":"27d19aa30d02c70c14afe4bf64d4e1adbd18bff3"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"ddfb6a9a4351ed390983d2cc6f8c03fd88583609","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[oslo_messaging_rabbit]"},{"line_number":64,"context_line":"{% if om_enable_queue_manager | bool %}"},{"line_number":65,"context_line":"use_queue_manager \u003d True"},{"line_number":66,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":67,"context_line":"processname \u003d {{ service_name }}"},{"line_number":68,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"6ae32da2_378f74cf","line":65,"in_reply_to":"d8eec04e_7c89db58","updated":"2025-03-12 14:45:52.000000000","message":"Have to admit I never liked that! 😄","commit_id":"27d19aa30d02c70c14afe4bf64d4e1adbd18bff3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2c8978ab4cc5f8ed0c3a78ca1915d2f9a6530b2f","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[oslo_messaging_rabbit]"},{"line_number":64,"context_line":"{% if om_enable_queue_manager | bool %}"},{"line_number":65,"context_line":"use_queue_manager \u003d True"},{"line_number":66,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":67,"context_line":"processname \u003d {{ service_name }}"},{"line_number":68,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"410acce5_c98de498","line":65,"in_reply_to":"fb8e50f5_6c199dbb","updated":"2025-03-14 12:14:36.000000000","message":"Done","commit_id":"27d19aa30d02c70c14afe4bf64d4e1adbd18bff3"}],"ansible/roles/nova-cell/tasks/discover_computes.yml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"4212e7ced6d42dc4478ce90e5b541e55fa5fee18","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - name: Discover nova hosts"},{"line_number":15,"context_line":"      become: true"},{"line_number":16,"context_line":"      command: \u003e"},{"line_number":17,"context_line":"        {{ kolla_container_engine }} exec -t nova_conductor nova-manage cell_v2 discover_hosts --by-service --cell_uuid {{ nova_cell_settings.cell_uuid }}"},{"line_number":18,"context_line":"      changed_when: False"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Delegate to a cell conductor."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"fbbc85bd_e24dc6df","line":17,"updated":"2025-01-30 14:08:14.000000000","message":"Just to mention for others, this works around this bug in the podman scenario: https://bugs.launchpad.net/oslo.messaging/+bug/2095178\n\nI\u0027m happy to merge with this :)","commit_id":"aed85cec18ac885fa60df82cbd46eeed6c2d9681"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"08266b7f4d29e9be3fd97b206cb9b50b6ec65235","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    - name: Discover nova hosts"},{"line_number":15,"context_line":"      become: true"},{"line_number":16,"context_line":"      command: \u003e"},{"line_number":17,"context_line":"        {{ kolla_container_engine }} exec -t nova_conductor nova-manage cell_v2 discover_hosts --by-service --cell_uuid {{ nova_cell_settings.cell_uuid }}"},{"line_number":18,"context_line":"      changed_when: False"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Delegate to a cell conductor."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"0dea1291_b5ac49ae","line":17,"updated":"2025-02-17 15:53:46.000000000","message":"why does it need a terminal now? please add a NOTE","commit_id":"c48403b33aa63a1982c0aa484f5a1f3252d9a5ee"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9e809e77e9b365611514697bc3a7e21211e6e40f","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    - name: Discover nova hosts"},{"line_number":15,"context_line":"      become: true"},{"line_number":16,"context_line":"      command: \u003e"},{"line_number":17,"context_line":"        {{ kolla_container_engine }} exec -t nova_conductor nova-manage cell_v2 discover_hosts --by-service --cell_uuid {{ nova_cell_settings.cell_uuid }}"},{"line_number":18,"context_line":"      changed_when: False"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Delegate to a cell conductor."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3044fed1_06c05c15","line":17,"in_reply_to":"0dea1291_b5ac49ae","updated":"2025-02-17 16:32:44.000000000","message":"Well, the main reason is that Podman behaves differently from Docker regarding exec. If -t is not used, the process runs as a child of podman exec without a PTY, which causes Python inside the container to get PGID\u003d0 because the pseudo-terminal is missing, leading to a non-existent /proc/0/....\n\nYou can also find more details here:\nhttps://review.opendev.org/c/openstack/oslo.messaging/+/939540\n\nI’d probably leave this review as it is... but before that, I might fix all similar calls in kolla-ansible (I think there are only a few—if I remember correctly, there’s one in Swift). Then I’d rebase it on top of this one.\n\nOr do you want to specify this in this patch? Should I add comments for all similar calls? For example, update-pools in Designate and similar ones? Or is it enough to add comment just here?\n\n\nHere it should be potentially fixed (of course except non-openstack services - just services with oslo.messaging )\n\nmichalarbet@pixla:~/ultimum/git/upstream/kolla-ansible$ grep -ri \u0027exec\u0027 ansible/roles/ | grep \u0027container_engine\u0027 | grep -v \u0027\\-t\u0027  | awk -F \u0027/\u0027 \u0027{print $3}\u0027 | sort | uniq | sort  \nbifrost\netcd\nhacluster\nironic\nkeystone\nloadbalancer\nmariadb\nnova-cell\noctavia\nopenvswitch\novn-db\novs-dpdk\nprometheus\nrabbitmq\nredis\nservice-config-validate\nswift","commit_id":"c48403b33aa63a1982c0aa484f5a1f3252d9a5ee"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"985bc0255d10762068636b3bf628dace83b01505","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    - name: Discover nova hosts"},{"line_number":15,"context_line":"      become: true"},{"line_number":16,"context_line":"      command: \u003e"},{"line_number":17,"context_line":"        {{ kolla_container_engine }} exec -t nova_conductor nova-manage cell_v2 discover_hosts --by-service --cell_uuid {{ nova_cell_settings.cell_uuid }}"},{"line_number":18,"context_line":"      changed_when: False"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Delegate to a cell conductor."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"91ed2cac_34bbfd91","line":17,"in_reply_to":"3044fed1_06c05c15","updated":"2025-02-17 17:04:47.000000000","message":"Thanks for the extended explanation - I’d still like to have that in the commit message at least for context.","commit_id":"c48403b33aa63a1982c0aa484f5a1f3252d9a5ee"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5cb7da17c5a58f4f0788e48903a8e55571d358b0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - name: Discover nova hosts"},{"line_number":15,"context_line":"      become: true"},{"line_number":16,"context_line":"      command: \u003e"},{"line_number":17,"context_line":"        {{ kolla_container_engine }} exec -t nova_conductor nova-manage cell_v2 discover_hosts --by-service --cell_uuid {{ nova_cell_settings.cell_uuid }}"},{"line_number":18,"context_line":"      changed_when: False"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Delegate to a cell conductor."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"338f0784_a23ca0d4","line":17,"in_reply_to":"91ed2cac_34bbfd91","updated":"2025-02-24 14:39:43.000000000","message":"Done - Commit message updated.","commit_id":"c48403b33aa63a1982c0aa484f5a1f3252d9a5ee"}],"releasenotes/notes/add-queue-manager-3ce79655ac37c345.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7a2b2f5b63b49d655608b83544dd73106b8c1a25","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Note that this requires bind mounting"},{"line_number":7,"context_line":"    ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"58637cc7_d7f1cad3","line":6,"updated":"2025-01-21 10:40:16.000000000","message":"That sounds a bit like it requires the user to bind mount /dev/shm - can we just write that the effect of om_enable_queue_manager \u003d\u003d yes is that /dev/shm is mounted in OpenStack service containers?","commit_id":"86dbf56738330d801440a401574d3c5621b834b6"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"25fd7422aed0e85ce8024bf20769659cbe7cd78c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Note that this requires bind mounting"},{"line_number":7,"context_line":"    ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fc0e23fd_738b78bd","line":6,"in_reply_to":"58637cc7_d7f1cad3","updated":"2025-01-21 10:46:29.000000000","message":"Done","commit_id":"86dbf56738330d801440a401574d3c5621b834b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"708b58cbca9bb3ca6d97a8ddca7a14f85b60d4be","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Setting ``om_enable_queue_manager\u003dtrue`` will"},{"line_number":7,"context_line":"    bind mount  ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"84634b7d_8ac285e4","line":8,"range":{"start_line":6,"start_character":33,"end_line":8,"end_character":19},"updated":"2025-03-19 21:14:40.000000000","message":"The bind mount is no longer part of this change, so this should go to a different reno?\n\nAlso the default is changed to true by this change, so explicitly setting this var to true no longer has any effect?","commit_id":"e4af635bc57479da07fb7fe87f34b69a15212c91"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"08aa847d76021e4b0cfab669d52f1ac56f113829","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Setting ``om_enable_queue_manager\u003dtrue`` will"},{"line_number":7,"context_line":"    bind mount  ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"0a144a47_807fdedd","line":8,"range":{"start_line":6,"start_character":33,"end_line":8,"end_character":19},"in_reply_to":"1388de5a_4704f67a","updated":"2025-03-24 09:18:11.000000000","message":"Done","commit_id":"e4af635bc57479da07fb7fe87f34b69a15212c91"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b439cfabd0671834a780d98bc713e884a18fd01b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Setting ``om_enable_queue_manager\u003dtrue`` will"},{"line_number":7,"context_line":"    bind mount  ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"9b53881a_cf04c8fe","line":8,"range":{"start_line":6,"start_character":33,"end_line":8,"end_character":19},"in_reply_to":"3130b834_1732e81b","updated":"2025-03-21 09:58:09.000000000","message":"A reno should always reflect the state after the current patch is merged, as you never can predict what will happen with the remainder of the patch stack. If it then needs to be amended by later patches, then so be it.","commit_id":"e4af635bc57479da07fb7fe87f34b69a15212c91"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"755ca9a59bcde461b89ea78e9f5b9dfa63942546","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Setting ``om_enable_queue_manager\u003dtrue`` will"},{"line_number":7,"context_line":"    bind mount  ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3130b834_1732e81b","line":8,"range":{"start_line":6,"start_character":33,"end_line":8,"end_character":19},"in_reply_to":"82d885e5_ce9bc22b","updated":"2025-03-20 14:01:53.000000000","message":"First of all, stop writing value\u003dtrue, that\u0027s not yaml syntax 😊 I don\u0027t remember a writeup of the om_enable_queue_manager plan that involves deleting the variable.\nJust remove that line and add a line that om_enable_queue_manager is now enabled by default.","commit_id":"e4af635bc57479da07fb7fe87f34b69a15212c91"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"942bd5f9c403162b2a0891b024276836d1e13958","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Setting ``om_enable_queue_manager\u003dtrue`` will"},{"line_number":7,"context_line":"    bind mount  ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"82d885e5_ce9bc22b","line":8,"range":{"start_line":6,"start_character":33,"end_line":8,"end_character":19},"in_reply_to":"84634b7d_8ac285e4","updated":"2025-03-20 12:55:55.000000000","message":"Added support for using oslo.messaging Queue Manager to all services which\n    use RabbitMQ. This is enabled by default, but can be configured using\n    ``om_enable_queue_manager`` \u003c\u003c This is still valid for now ...\n    \n    \nSetting ``om_enable_queue_manager\u003dtrue`` will\n    bind mount  ``/dev/shm`` into all OpenStack service containers which use\n    oslo.messaging. \u003c\u003c This should be changed to \u003dfalse ... unmount /dev/shm.. for now \n    \nBut on the end when all will be merged and ``om_enable_queue_manager`` will be removed, it\u0027s really question if this reno should be added ... As the result will be no ``om_enable_queue_manager`` option...\n\nMaybe remove that information about ``om_enable_queue_manager`` ?? \n\nWDYT @frickler@offenerstapel.de ?","commit_id":"e4af635bc57479da07fb7fe87f34b69a15212c91"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fd6280d2c8f5fb4a0fc79fa32b2743e8a48e2860","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Setting ``om_enable_queue_manager\u003dtrue`` will"},{"line_number":7,"context_line":"    bind mount  ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"1388de5a_4704f67a","line":8,"range":{"start_line":6,"start_character":33,"end_line":8,"end_character":19},"in_reply_to":"8b138eec_dd8e72b5","updated":"2025-03-21 16:40:16.000000000","message":"One thing at a time, update that reno so we can merge this.","commit_id":"e4af635bc57479da07fb7fe87f34b69a15212c91"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"8f6b912f007d44e07dae589a93d69429bc31807a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"},{"line_number":5,"context_line":"    use RabbitMQ. This is enabled by default, but can be configured using"},{"line_number":6,"context_line":"    ``om_enable_queue_manager``. Setting ``om_enable_queue_manager\u003dtrue`` will"},{"line_number":7,"context_line":"    bind mount  ``/dev/shm`` into all OpenStack service containers which use"},{"line_number":8,"context_line":"    oslo.messaging."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Added support for using oslo.messaging Queue Manager to all services which"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"8b138eec_dd8e72b5","line":8,"range":{"start_line":6,"start_character":33,"end_line":8,"end_character":19},"in_reply_to":"9b53881a_cf04c8fe","updated":"2025-03-21 16:38:33.000000000","message":"\u003e I don\u0027t remember a writeup of the om_enable_queue_manager plan that involves deleting the variable.\n\nIt\u0027s something I didn\u0027t think to propose until more recently: https://review.opendev.org/c/openstack/kolla-ansible/+/940691. It makes sense to remove the config option once we change RabbitMQ to 4.0, as it won\u0027t work without quorum queues and queue_manager is needed for that.","commit_id":"e4af635bc57479da07fb7fe87f34b69a15212c91"}]}