)]}'
{"ansible/roles/octavia/templates/octavia.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"083a3a25570213713859442a80f949e794514166","unresolved":true,"context_lines":[{"line_number":141,"context_line":"{% endif %}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"[oslo_concurrency]"},{"line_number":144,"context_line":"lock_path \u003d /var/lib/octavia/tmp"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"[glance]"},{"line_number":147,"context_line":"region_name \u003d {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0f50df50_ac066e63","line":144,"updated":"2024-07-22 15:26:54.000000000","message":"Same comments as for heat:\n\nFor security, the specified directory should only be writable by the user running the processes that need locking.\n\nDo we need to create the directory and ensure this? Is this a bug in oslo.concurrency or in octavia?","commit_id":"527400ad10474629b09d1a91292f5055b2bd0d71"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a9c6c5eb277b379a6d67102443c63c5472005569","unresolved":true,"context_lines":[{"line_number":141,"context_line":"{% endif %}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"[oslo_concurrency]"},{"line_number":144,"context_line":"lock_path \u003d /var/lib/octavia/tmp"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"[glance]"},{"line_number":147,"context_line":"region_name \u003d {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"be9f75d2_d8267c90","line":144,"in_reply_to":"0f50df50_ac066e63","updated":"2024-08-22 06:16:55.000000000","message":"Michal, if you want us to review your patches - please respond sooner than in a month :-)","commit_id":"527400ad10474629b09d1a91292f5055b2bd0d71"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eb708f9940ca6913038bca25cfd0502982fab697","unresolved":true,"context_lines":[{"line_number":141,"context_line":"{% endif %}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"[oslo_concurrency]"},{"line_number":144,"context_line":"lock_path \u003d /var/lib/octavia/tmp"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"[glance]"},{"line_number":147,"context_line":"region_name \u003d {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"118dd420_dd35249a","line":144,"in_reply_to":"41514b76_59b16e9b","updated":"2024-08-22 10:23:11.000000000","message":"Ack, i will go from top to bottom of my list. Thanks","commit_id":"527400ad10474629b09d1a91292f5055b2bd0d71"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"da3cb180e65ba5468d5bb3ebf0c310820fcb41c8","unresolved":true,"context_lines":[{"line_number":141,"context_line":"{% endif %}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"[oslo_concurrency]"},{"line_number":144,"context_line":"lock_path \u003d /var/lib/octavia/tmp"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"[glance]"},{"line_number":147,"context_line":"region_name \u003d {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"41514b76_59b16e9b","line":144,"in_reply_to":"79d52c16_4f5aa89f","updated":"2024-08-22 10:22:09.000000000","message":"So remove RP from those patches you\u0027re not working on, it makes us confused.","commit_id":"527400ad10474629b09d1a91292f5055b2bd0d71"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"58d162d7507fe890116731cc7e1ea3b863539b66","unresolved":true,"context_lines":[{"line_number":141,"context_line":"{% endif %}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"[oslo_concurrency]"},{"line_number":144,"context_line":"lock_path \u003d /var/lib/octavia/tmp"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"[glance]"},{"line_number":147,"context_line":"region_name \u003d {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"79d52c16_4f5aa89f","line":144,"in_reply_to":"be9f75d2_d8267c90","updated":"2024-08-22 10:12:00.000000000","message":"Michal, if you looked at all the patchsets in this chain, you would see that this exact same question from frickler is also in the review for heat https://review.opendev.org/c/openstack/kolla-ansible/+/924607/3 (as frickler himself writes: \"Same comments as for heat:\") where I obviously responded to him. Or should I just copy and paste my response everywhere? Would that be better? With the growing number of reviews I need to merge, some are more important — I\u0027m not working on all of them at once, unfortunately.","commit_id":"527400ad10474629b09d1a91292f5055b2bd0d71"}]}