)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"df7d4de5c32031e9cbc6d463681faea07d8082be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6854298_64b9e442","updated":"2024-08-07 09:15:28.000000000","message":"you have a duplicate whitespace everywhere, apart from that the code LGTM","commit_id":"0daaa82575ca6da6da09200c65fe750f8c781c66"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5cdb6f759f1eb4c57a4ccbbcfe07f6ffb6ea93a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"463c8023_ef070651","updated":"2024-08-08 08:00:14.000000000","message":"LGTM and thanks for adding the docs reference!\nstill need to check CI results though, once they come in (I currently see magnum and octavia jobs failing in https://zuul.opendev.org/t/openstack/status#925444).","commit_id":"d35e1142624ab813e44aa9748815ed646d3110e4"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"a9561a59c9c44bd62c108916432319e97d5ebe6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c9ce10b_7b1b7b05","in_reply_to":"463c8023_ef070651","updated":"2024-08-12 09:14:17.000000000","message":"Looks like some changes to octavia and magnum testing were pushed to master recently, which look like they could fix these failures. I rebased the patchset, so we\u0027ll see.","commit_id":"d35e1142624ab813e44aa9748815ed646d3110e4"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"77aecf0a7cafd04334177c3ad41ec4625583ed44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eb58aa8c_27ae0bc2","in_reply_to":"4c9ce10b_7b1b7b05","updated":"2024-08-12 13:05:30.000000000","message":"Yes, that seems to do it. :) Tests look better now","commit_id":"d35e1142624ab813e44aa9748815ed646d3110e4"}],"ansible/roles/barbican/templates/barbican.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"df7d4de5c32031e9cbc6d463681faea07d8082be","unresolved":true,"context_lines":[{"line_number":70,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":71,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"memcache_security_strategy \u003d {{ memcache_security_strategy  }}"},{"line_number":74,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":75,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a5c2d425_fab66c39","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":2},"updated":"2024-08-07 09:15:28.000000000","message":"duplicate whitespace\n```suggestion\nmemcache_security_strategy \u003d {{ memcache_security_strategy }}\n```","commit_id":"0daaa82575ca6da6da09200c65fe750f8c781c66"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"12e6046b5943984a5130b72f9ce1ef8a85360711","unresolved":false,"context_lines":[{"line_number":70,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":71,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"memcache_security_strategy \u003d {{ memcache_security_strategy  }}"},{"line_number":74,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":75,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"452608a3_05c75979","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":2},"in_reply_to":"a5c2d425_fab66c39","updated":"2024-08-08 07:03:37.000000000","message":"Done","commit_id":"0daaa82575ca6da6da09200c65fe750f8c781c66"}],"ansible/roles/blazar/templates/blazar.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"df7d4de5c32031e9cbc6d463681faea07d8082be","unresolved":true,"context_lines":[{"line_number":33,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":34,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"memcache_security_strategy \u003d {{ memcache_security_strategy  }}"},{"line_number":37,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":38,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"b20c258e_27da01f0","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"updated":"2024-08-07 09:15:28.000000000","message":"duplicate whitespace:\n```suggestion\nmemcache_security_strategy \u003d {{ memcache_security_strategy }}\n```","commit_id":"0daaa82575ca6da6da09200c65fe750f8c781c66"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"12e6046b5943984a5130b72f9ce1ef8a85360711","unresolved":false,"context_lines":[{"line_number":33,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":34,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"memcache_security_strategy \u003d {{ memcache_security_strategy  }}"},{"line_number":37,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":38,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a77d7834_d0eccd7d","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"b20c258e_27da01f0","updated":"2024-08-08 07:03:37.000000000","message":"Done","commit_id":"0daaa82575ca6da6da09200c65fe750f8c781c66"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"df7d4de5c32031e9cbc6d463681faea07d8082be","unresolved":true,"context_lines":[{"line_number":128,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":129,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"memcache_security_strategy \u003d {{ memcache_security_strategy  }}"},{"line_number":132,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":133,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"027fcded_d20710cb","line":131,"updated":"2024-08-07 09:15:28.000000000","message":"duplicate whitespace:\n```suggestion\nmemcache_security_strategy \u003d {{ memcache_security_strategy }}\n```","commit_id":"0daaa82575ca6da6da09200c65fe750f8c781c66"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"12e6046b5943984a5130b72f9ce1ef8a85360711","unresolved":false,"context_lines":[{"line_number":128,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":129,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"memcache_security_strategy \u003d {{ memcache_security_strategy  }}"},{"line_number":132,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":133,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e3493d39_7357182f","line":131,"in_reply_to":"027fcded_d20710cb","updated":"2024-08-08 07:03:37.000000000","message":"Done","commit_id":"0daaa82575ca6da6da09200c65fe750f8c781c66"}],"releasenotes/notes/bug-1850733-aa3b0d335c8e4e1e.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"71f8a47d1eefedacfa44f07e99d8d7aabdc37bdc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Put memcache_security_strategy in single place."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    `LP#1850733 \u003chttps://launchpad.net/bugs/1850733\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f7dc01ec_5556ceaa","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":1},"updated":"2024-08-06 16:06:53.000000000","message":"this should at least mention that place (all.yml) and maybe even link to the documented allowed values:\nhttps://docs.openstack.org/keystonemiddleware/latest/middlewarearchitecture.html\n\nor just put them directly here, because there is no good way to directly link them (I searched!):\n\n```\n# (Optional) If defined, indicate whether token data should be authenticated or\n# authenticated and encrypted. If MAC, token data is authenticated (with HMAC)\n# in the cache. If ENCRYPT, token data is encrypted and authenticated in the\n# cache. If the value is not one of these options or empty, auth_token will\n# raise an exception on initialization. (string value)\n# Possible values:\n# None - \u003cNo description provided\u003e\n# MAC - \u003cNo description provided\u003e\n# ENCRYPT - \u003cNo description provided\u003e\n```","commit_id":"358576b293a78c5808fac4ec9c2725aa073b8d3a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5cdb6f759f1eb4c57a4ccbbcfe07f6ffb6ea93a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Put memcache_security_strategy in single place."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    `LP#1850733 \u003chttps://launchpad.net/bugs/1850733\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4a30ba67_c5e32111","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":1},"in_reply_to":"2a3e1660_dae048a9","updated":"2024-08-08 08:00:14.000000000","message":"Done","commit_id":"358576b293a78c5808fac4ec9c2725aa073b8d3a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1bc23b4089628dbcdde854cbcf1cc981cdd96e77","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Put memcache_security_strategy in single place."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    `LP#1850733 \u003chttps://launchpad.net/bugs/1850733\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2a3e1660_dae048a9","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":1},"in_reply_to":"f7dc01ec_5556ceaa","updated":"2024-08-07 07:19:42.000000000","message":"I was just pointed to these docs, maybe a link to those would be sufficient:\n\nhttps://docs.openstack.org/keystonemiddleware/latest/middlewarearchitecture.html#memcache-protection","commit_id":"358576b293a78c5808fac4ec9c2725aa073b8d3a"}]}