)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4d93b1f7e5eb9cc1704fe9aff76c2f515ace14fb","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2076335"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://docs.nvidia.com/networking/display/mlnxofedv590560125/ovs+offload+using+asap²+direct#src-2408744670_safe-id-T1ZTT2ZmbG9hZFVzaW5nQVNBUMKyRGlyZWN0LU9wZW52U3dpdGNoQ29uZmlndXJhdGlvbg"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I444fc345e5d21ed969f48aa9a6230905cc411149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"377a8d68_d17e5c0f","line":14,"updated":"2024-08-09 05:39:05.000000000","message":"That URL looks both complicated and unstable, is there really no reference to this within the \"normal\" OVS docs?","commit_id":"e6855d771caf34dab846df7176ea016cf88f357f"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"67e09b565cbf6c676b08d934bf56413f72e8573d","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2076335"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://docs.nvidia.com/networking/display/mlnxofedv590560125/ovs+offload+using+asap²+direct#src-2408744670_safe-id-T1ZTT2ZmbG9hZFVzaW5nQVNBUMKyRGlyZWN0LU9wZW52U3dpdGNoQ29uZmlndXJhdGlvbg"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I444fc345e5d21ed969f48aa9a6230905cc411149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"badebd4d_4fb19141","line":14,"in_reply_to":"377a8d68_d17e5c0f","updated":"2024-08-09 08:39:45.000000000","message":"Done","commit_id":"e6855d771caf34dab846df7176ea016cf88f357f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"24a64b1b763c11e2996099e0e3826e1be65a2a25","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db6dade3_e9b0b10b","updated":"2024-08-09 09:21:12.000000000","message":"lgtm, but no reno","commit_id":"416574c8b48a342fac5c99806a227cabb1782841"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dc30e50d362ebfbf3eb9de5a6e431d684ff6585a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7d1b7082_31f455f9","updated":"2024-08-09 08:47:16.000000000","message":"reno is absent","commit_id":"416574c8b48a342fac5c99806a227cabb1782841"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4a89b7fee03a763a5d47b3e0b3edb35dba3520f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e066f3cb_84fbac70","updated":"2024-08-09 08:50:44.000000000","message":"thx, adding a reno for backports would be nice indeed","commit_id":"416574c8b48a342fac5c99806a227cabb1782841"}],"ansible/roles/openvswitch/tasks/post-config.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4d93b1f7e5eb9cc1704fe9aff76c2f515ace14fb","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  loop:"},{"line_number":17,"context_line":"    - { col: \"external_ids\", name: \"system-id\", value: \"{{ openvswitch_system_id }}\" }"},{"line_number":18,"context_line":"    - { col: \"external_ids\", name: \"hostname\", value: \"{{ openvswitch_hostname }}\" }"},{"line_number":19,"context_line":"    - { col: \"other_config\", name: \"hw-offload\", value: true, state: \"{{ \u0027present\u0027 if openvswitch_hw_offload | bool else \u0027absent\u0027 }}\" }"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":22,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2b753d98_c35695e4","side":"PARENT","line":19,"updated":"2024-08-09 05:39:05.000000000","message":"Are you sure that changing the system-id and hostname can be done without a restart? To me it sounds like instead of special casing the hw-offload, triggering a restart on any change here might be a better option","commit_id":"3a322ce592e78e395247e89cfbedeeb77114f416"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"67e09b565cbf6c676b08d934bf56413f72e8573d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  loop:"},{"line_number":17,"context_line":"    - { col: \"external_ids\", name: \"system-id\", value: \"{{ openvswitch_system_id }}\" }"},{"line_number":18,"context_line":"    - { col: \"external_ids\", name: \"hostname\", value: \"{{ openvswitch_hostname }}\" }"},{"line_number":19,"context_line":"    - { col: \"other_config\", name: \"hw-offload\", value: true, state: \"{{ \u0027present\u0027 if openvswitch_hw_offload | bool else \u0027absent\u0027 }}\" }"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":22,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"87752fae_49c84aec","side":"PARENT","line":19,"in_reply_to":"2b753d98_c35695e4","updated":"2024-08-09 08:39:45.000000000","message":"Done","commit_id":"3a322ce592e78e395247e89cfbedeeb77114f416"}]}
