)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5965fe7d96fb47c709bb08b436af21dbee0faac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"542be457_c82b1d8c","updated":"2024-08-12 11:13:11.000000000","message":"Just to avoid confusion with the previous patch in the chain, this should not be backported at all.","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a4f5b1f1fc2327309c2d3ee11bf2f7db2a5118f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d66ab265_889a6bba","updated":"2024-08-23 08:35:37.000000000","message":"CI only and trivial","commit_id":"d79698ae9035abc26aeeb52f8283383eeaeb02bd"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"887568deb740c96e4062411df2d3da7494f7cbb8","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    vars:"},{"line_number":167,"context_line":"      base_distro: rocky"},{"line_number":168,"context_line":"      is_upgrade: yes"},{"line_number":169,"context_line":"      is_slurp: True"},{"line_number":170,"context_line":"      previous_release: 2023.1"},{"line_number":171,"context_line":"      tls_enabled: true"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"886ee258_fccb66be","line":169,"updated":"2024-08-21 11:28:56.000000000","message":"we have historically used yes, not True - what\u0027s the problem with that?","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"c368450bfd0d026efbda2bc888a0ea30f4c98bbf","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    vars:"},{"line_number":167,"context_line":"      base_distro: rocky"},{"line_number":168,"context_line":"      is_upgrade: yes"},{"line_number":169,"context_line":"      is_slurp: True"},{"line_number":170,"context_line":"      previous_release: 2023.1"},{"line_number":171,"context_line":"      tls_enabled: true"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"52fa722a_560fefa7","line":169,"in_reply_to":"2f4735aa_ccc97170","updated":"2024-08-23 08:35:00.000000000","message":"Done","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"638e9d296ab1579d0cd0cb61f86c39e201b25c3e","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    vars:"},{"line_number":167,"context_line":"      base_distro: rocky"},{"line_number":168,"context_line":"      is_upgrade: yes"},{"line_number":169,"context_line":"      is_slurp: True"},{"line_number":170,"context_line":"      previous_release: 2023.1"},{"line_number":171,"context_line":"      tls_enabled: true"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff03372f_22d7cded","line":169,"in_reply_to":"48789f93_bdfbb3d5","updated":"2024-08-22 14:47:51.000000000","message":"If you just want us to set ``is_slurp: yes`` instead of ``is_slurp: True`` in the jobs vars, that will work with the current run.yml and upgrade.sh in this patchset.","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"57e3795b9983f956f938db6dcdd1e80f15c0f3d5","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    vars:"},{"line_number":167,"context_line":"      base_distro: rocky"},{"line_number":168,"context_line":"      is_upgrade: yes"},{"line_number":169,"context_line":"      is_slurp: True"},{"line_number":170,"context_line":"      previous_release: 2023.1"},{"line_number":171,"context_line":"      tls_enabled: true"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"48789f93_bdfbb3d5","line":169,"in_reply_to":"78b6ea02_8880bcf0","updated":"2024-08-21 17:44:01.000000000","message":"oh boy,so maybe let\u0027s do very odd but simplistic approach of IS_SLURP: \"{{ \u0027yes\u0027 if is_slurp else \u0027no\u0027 }}\" ?\nI mean it just looks weird that we set this to True, and others to yes.\nAnother option is rewriting upgrade.sh to an Ansible role I guess, but let\u0027s not add complexity to that patch.","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"3e9fc86828a40699f8e121af5a4083505a6420f7","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    vars:"},{"line_number":167,"context_line":"      base_distro: rocky"},{"line_number":168,"context_line":"      is_upgrade: yes"},{"line_number":169,"context_line":"      is_slurp: True"},{"line_number":170,"context_line":"      previous_release: 2023.1"},{"line_number":171,"context_line":"      tls_enabled: true"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bb9b44c3_71c34847","line":169,"in_reply_to":"886ee258_fccb66be","updated":"2024-08-21 11:51:59.000000000","message":"It\u0027s mainly for clarity because Ansible automatically converts truthy strings to ``True``, see here for our collective confusion: https://review.opendev.org/c/openstack/kolla-ansible/+/909971/comment/bc79cb25_f71508e1/","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"96214bbd8df0a5bb871223eb479095602a336330","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    vars:"},{"line_number":167,"context_line":"      base_distro: rocky"},{"line_number":168,"context_line":"      is_upgrade: yes"},{"line_number":169,"context_line":"      is_slurp: True"},{"line_number":170,"context_line":"      previous_release: 2023.1"},{"line_number":171,"context_line":"      tls_enabled: true"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c0fd70e6_7ee27aec","line":169,"in_reply_to":"bb9b44c3_71c34847","updated":"2024-08-21 13:08:41.000000000","message":"So why not IS_SLURP \u003d\u003d \"yes\"?\nI don\u0027t want to invent new way - let\u0027s keep some sanity here","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1f48252f962dce09b18afd9357a0b1525fc90806","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    vars:"},{"line_number":167,"context_line":"      base_distro: rocky"},{"line_number":168,"context_line":"      is_upgrade: yes"},{"line_number":169,"context_line":"      is_slurp: True"},{"line_number":170,"context_line":"      previous_release: 2023.1"},{"line_number":171,"context_line":"      tls_enabled: true"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"78b6ea02_8880bcf0","line":169,"in_reply_to":"c0fd70e6_7ee27aec","updated":"2024-08-21 13:19:11.000000000","message":"This doesn\u0027t work because Ansible will convert boolean-like environment variables to ``True``. (See here: https://github.com/ansible/ansible/issues/11905#issuecomment-130496173)\n\nSo even if we set ``is_slurp: yes`` under the job vars, the env var IS_SLURP will be ``True`` in the bash script.","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"be13d28c3fb09b4b307c89b07154f3df3ee2ab80","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    vars:"},{"line_number":167,"context_line":"      base_distro: rocky"},{"line_number":168,"context_line":"      is_upgrade: yes"},{"line_number":169,"context_line":"      is_slurp: True"},{"line_number":170,"context_line":"      previous_release: 2023.1"},{"line_number":171,"context_line":"      tls_enabled: true"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2f4735aa_ccc97170","line":169,"in_reply_to":"ff03372f_22d7cded","updated":"2024-08-22 14:55:39.000000000","message":"I think that would be more obvious, and add a NOTE in the script that \"yes\" goes through Ansible filtering and ends up with \"True\" ;-)","commit_id":"e2cc7cd94e855dcc07df7bf004704a4a9bc59603"}]}