)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4f63c258a8cab3a4706a92e964c7ef5de7212376","unresolved":true,"context_lines":[{"line_number":10,"context_line":"upgrade to an intermediary RabbitMQ version needed before a skip-level"},{"line_number":11,"context_line":"upgrade can be performed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/926145"},{"line_number":14,"context_line":"Change-Id: Id8a5ebe19a50ebdc59d12667889472c803b8d7c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"aa2066a2_e67e9710","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2024-08-29 11:36:54.000000000","message":"nit: doesn\u0027t depend on this anymore, I don\u0027t know if gerrit can track\nthat a revert for this was created and fails merging then, I would assume so, but not sure.","commit_id":"46aa787bbf130543191474caf3497d27c9c99968"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"ae7fb454ac7cbfff8303f0ebdc5858d1c1db1df9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"upgrade to an intermediary RabbitMQ version needed before a skip-level"},{"line_number":11,"context_line":"upgrade can be performed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/926145"},{"line_number":14,"context_line":"Change-Id: Id8a5ebe19a50ebdc59d12667889472c803b8d7c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"338b737b_8842672d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"in_reply_to":"aa2066a2_e67e9710","updated":"2024-08-29 11:47:54.000000000","message":"Good point, I\u0027ve removed the depends-on","commit_id":"46aa787bbf130543191474caf3497d27c9c99968"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ff119e941583523aa56fd2e6a9a6f9ff635f4894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f6fb644_9b888e5d","updated":"2024-08-19 08:51:35.000000000","message":"I think we shouldn\u0027t use regex for the version comparison, because there is dedicated tooling for this in ansible which handles edge cases easier, see my other comments.","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"51c94d546913ffd9fd38d5fb073da327db25078f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e05adffa_c610fe25","updated":"2024-08-12 15:30:02.000000000","message":"Will need backporting to stable/2024.1","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"69e57233dc822c1f5227b80789527f42be85ad0d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"69eb0e36_fb7df07f","updated":"2024-08-23 13:19:00.000000000","message":"Not sure why the precheck is failing in the upgrade jobs, this should make the assertion true when the current and new versions match:\n```\ncurrent_version_major \u003d\u003d new_version_major and\nnew_version_minor | float - current_version_minor | float \u003c\u003d 0.1\n```","commit_id":"4387dd975c94a2fd214745a5d63a5f127d68104a"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"b3c2f23edc605263aba44937b6d0feeb8629a2b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"75ee6499_4b7aa9d5","in_reply_to":"69eb0e36_fb7df07f","updated":"2024-08-23 14:00:14.000000000","message":"The regex is converting the minor versions to whole integers, not float (0.x), so should it be\nnew_version_minor | int - current_version_minor | int \u003c\u003d 1?","commit_id":"4387dd975c94a2fd214745a5d63a5f127d68104a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"161070fd8bf64091cf3f6786783055b17e9376fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81df93ca_053cec64","in_reply_to":"75ee6499_4b7aa9d5","updated":"2024-08-23 14:04:41.000000000","message":"Ah good spot, that\u0027s a remnant of when I was trying to compare the versions and one float. Fixed","commit_id":"4387dd975c94a2fd214745a5d63a5f127d68104a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f1448b9c32f7f65cd6e5b63aece3ce10886be1a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b04432db_d6ba7b62","in_reply_to":"81df93ca_053cec64","updated":"2024-08-23 14:10:48.000000000","message":"Done","commit_id":"4387dd975c94a2fd214745a5d63a5f127d68104a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"0cec3d1e9fb4d41170b61230c80b4ff61bc0ad32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0156be34_606757ac","in_reply_to":"905b42b2_d8453178","updated":"2024-08-27 11:07:36.000000000","message":"I\u0027ve figured out the issue, I missed this previously because I wasn\u0027t using certs in my test env.\n\nIt is expected that we see extra lines in stdout as these come from running kolla_copy_cacerts. Given the rabbitmq version check is the last thing to be run, I can fix this by just taking the last line from stdout.","commit_id":"4387dd975c94a2fd214745a5d63a5f127d68104a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"141baca91e352369642b856b30d17f40fc73d7d7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"905b42b2_d8453178","in_reply_to":"9cdff7f3_55c5cfc1","updated":"2024-08-26 09:14:24.000000000","message":"mhm that sounds like a bug we should fix in a dedicated patchset, don\u0027t you think?","commit_id":"4387dd975c94a2fd214745a5d63a5f127d68104a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"50881ed651d2c4dcf1edcf314130f30de17fa0a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cbce311c_513782b1","in_reply_to":"b04432db_d6ba7b62","updated":"2024-08-23 15:28:03.000000000","message":"This was incorrect logic, but it\u0027s not why the CI is failing. For some reason, there\u0027s a bunch of extra stuff in the stdout for rabbitmqctl --version:\n```\n\"stdout_lines\": [\n        \"Updating certificates in /etc/ssl/certs...\",\n        \"1 added, 0 removed; done.\",\n        \"Running hooks in /etc/ca-certificates/update.d...\",\n        \"done.\",\n        \"3.13.6\"\n    ]\n```","commit_id":"4387dd975c94a2fd214745a5d63a5f127d68104a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"90d7254e31c023aea9d32f0c8a3c5f8c0df38918","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9cdff7f3_55c5cfc1","in_reply_to":"cbce311c_513782b1","updated":"2024-08-23 15:53:01.000000000","message":"Seems it doesn\u0027t wait for copy_cacerts.sh to finish running before calling extend_start, so the certs updates get captured in stdout","commit_id":"4387dd975c94a2fd214745a5d63a5f127d68104a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"29a01383d953d6b81cb02ec0f35281f436b8a7ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6fd063fa_b1bc1b60","updated":"2024-08-27 13:36:58.000000000","message":"recheck: error seems unrelated - \"FAILED: Instance failed to become active after resize confirm\"","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4f63c258a8cab3a4706a92e964c7ef5de7212376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9e4f386e_97666020","updated":"2024-08-29 11:36:54.000000000","message":"Code LGTM, just one nit.","commit_id":"46aa787bbf130543191474caf3497d27c9c99968"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1cbd8de6a97a96b5d6717b5e06eead471a8bdbab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c26e9010_d039daab","updated":"2024-09-18 10:34:22.000000000","message":"Let\u0027s merge, since Sven already did +1 ;-)","commit_id":"4731e7f2b4abbba27bb472e00e28b64315e26cc3"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d0f4cb094280a84ad8d5d8653da6cc1583bf5afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dd20d95a_8a179cf4","updated":"2024-09-19 08:13:35.000000000","message":"recheck","commit_id":"4731e7f2b4abbba27bb472e00e28b64315e26cc3"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"dd8735e225286a3224e4e959053d1855cd6df123","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5f96deff_3f531a06","updated":"2024-09-18 11:57:15.000000000","message":"recheck: failure in rocky test-core-openstack seems unrelated: `FAILED: Instance failed to become active after resize confirm`","commit_id":"4731e7f2b4abbba27bb472e00e28b64315e26cc3"}],"ansible/roles/rabbitmq/tasks/version-check.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ff119e941583523aa56fd2e6a9a6f9ff635f4894","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        fail_msg: \u003e"},{"line_number":15,"context_line":"          The RabbitMQ image you are trying to deploy does not support"},{"line_number":16,"context_line":"          KOLLA_RABBITMQ_VERSION_CHECK. Please build or download a new image"},{"line_number":17,"context_line":"          from the latest Kolla codebase."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Get current RabbitMQ version"},{"line_number":20,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eedeec76_b597534b","line":17,"range":{"start_line":17,"start_character":19,"end_line":17,"end_character":25},"updated":"2024-08-19 08:51:35.000000000","message":"```suggestion\n          from the latest matching stable Kolla git branch.\n```\n\nnot sure about the wording here","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"205ed3e3a98012f86930a40bdcf9c12b73ebf994","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        fail_msg: \u003e"},{"line_number":15,"context_line":"          The RabbitMQ image you are trying to deploy does not support"},{"line_number":16,"context_line":"          KOLLA_RABBITMQ_VERSION_CHECK. Please build or download a new image"},{"line_number":17,"context_line":"          from the latest Kolla codebase."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Get current RabbitMQ version"},{"line_number":20,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c5d1808c_f8205ba1","line":17,"range":{"start_line":17,"start_character":19,"end_line":17,"end_character":25},"in_reply_to":"eedeec76_b597534b","updated":"2024-08-20 14:10:05.000000000","message":"Done","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ff119e941583523aa56fd2e6a9a6f9ff635f4894","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    # upgrade_version \u003d 3.12"},{"line_number":55,"context_line":"    - name: Check if running RabbitMQ is at most one version behind"},{"line_number":56,"context_line":"      vars:"},{"line_number":57,"context_line":"        current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^.\u0027) }}\""},{"line_number":58,"context_line":"        current_version_minor: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":59,"context_line":"        current_version: \"{{ rabbitmq_version_current.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":60,"context_line":"        new_version_major: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027^.\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0bea8f7a_ac4a06ee","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":2},"updated":"2024-08-19 08:51:35.000000000","message":"This would be more future proof imho:\n```suggestion\n        current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^[0-9]+\u0027) }}\"\n```\n\n- matches all starting digits until the first different char, so e.g. works if rmq hits double digit version numbers.\n- doesn\u0027t match any arbitrary first character\n- subjective: imho also easier to read","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"205ed3e3a98012f86930a40bdcf9c12b73ebf994","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    # upgrade_version \u003d 3.12"},{"line_number":55,"context_line":"    - name: Check if running RabbitMQ is at most one version behind"},{"line_number":56,"context_line":"      vars:"},{"line_number":57,"context_line":"        current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^.\u0027) }}\""},{"line_number":58,"context_line":"        current_version_minor: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":59,"context_line":"        current_version: \"{{ rabbitmq_version_current.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":60,"context_line":"        new_version_major: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027^.\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5d20c56e_6e33fdb1","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":2},"in_reply_to":"0bea8f7a_ac4a06ee","updated":"2024-08-20 14:10:05.000000000","message":"I\u0027d be surprised if they hit double digits given how long 3.x has stayed around, but that seems like a fine change anyway. Done.","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ff119e941583523aa56fd2e6a9a6f9ff635f4894","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    - name: Check if running RabbitMQ is at most one version behind"},{"line_number":56,"context_line":"      vars:"},{"line_number":57,"context_line":"        current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^.\u0027) }}\""},{"line_number":58,"context_line":"        current_version_minor: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":59,"context_line":"        current_version: \"{{ rabbitmq_version_current.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":60,"context_line":"        new_version_major: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027^.\u0027) }}\""},{"line_number":61,"context_line":"        new_version_minor: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":62,"context_line":"        new_version: \"{{ rabbitmq_version_new.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":63,"context_line":"        # Note: this assumes 3.13 will be the last release before 4.0."},{"line_number":64,"context_line":"        upgrade_version: \"{{ \u00274.0\u0027 if current_version \u003d\u003d \u00273.13\u0027 else current_version_major + \u0027.\u0027 + (current_version_minor | int + 1) | string }}\""},{"line_number":65,"context_line":"      assert:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5e7bb6f6_d4aa298d","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":87},"updated":"2024-08-19 08:51:35.000000000","message":"instead of all this regex foo (which I tried to improve first, see my other comment which I left undeleted for posterity), I\u0027d suggest to just use https://docs.ansible.com/ansible/latest/collections/ansible/builtin/version_test.html instead, what do you think?\nwe could use it with semver, or the \"strict\" version policy I think.\n\nI looked it up, but rabbitmq upstream has no clearly stated algorithm on how they chose version numbers, but at least they seem to stick to some classic major.minor.patch approach for now.","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"ba10a53df44841ff2e2ad9a3950584125239899e","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    - name: Check if running RabbitMQ is at most one version behind"},{"line_number":56,"context_line":"      vars:"},{"line_number":57,"context_line":"        current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^.\u0027) }}\""},{"line_number":58,"context_line":"        current_version_minor: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":59,"context_line":"        current_version: \"{{ rabbitmq_version_current.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":60,"context_line":"        new_version_major: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027^.\u0027) }}\""},{"line_number":61,"context_line":"        new_version_minor: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":62,"context_line":"        new_version: \"{{ rabbitmq_version_new.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":63,"context_line":"        # Note: this assumes 3.13 will be the last release before 4.0."},{"line_number":64,"context_line":"        upgrade_version: \"{{ \u00274.0\u0027 if current_version \u003d\u003d \u00273.13\u0027 else current_version_major + \u0027.\u0027 + (current_version_minor | int + 1) | string }}\""},{"line_number":65,"context_line":"      assert:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf1dfd3f_b65ecb78","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":87},"in_reply_to":"5e7bb6f6_d4aa298d","updated":"2024-08-20 13:58:03.000000000","message":"I did come across the version_test plugin, but the issue is we need to check if the current rabbit is exactly one version behind, rather than just less then the new version.","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3d617456d3c45060c77205e4eab8f7c5119012d1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    - name: Check if running RabbitMQ is at most one version behind"},{"line_number":56,"context_line":"      vars:"},{"line_number":57,"context_line":"        current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^.\u0027) }}\""},{"line_number":58,"context_line":"        current_version_minor: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":59,"context_line":"        current_version: \"{{ rabbitmq_version_current.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":60,"context_line":"        new_version_major: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027^.\u0027) }}\""},{"line_number":61,"context_line":"        new_version_minor: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":62,"context_line":"        new_version: \"{{ rabbitmq_version_new.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":63,"context_line":"        # Note: this assumes 3.13 will be the last release before 4.0."},{"line_number":64,"context_line":"        upgrade_version: \"{{ \u00274.0\u0027 if current_version \u003d\u003d \u00273.13\u0027 else current_version_major + \u0027.\u0027 + (current_version_minor | int + 1) | string }}\""},{"line_number":65,"context_line":"      assert:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"defd40e1_131308a2","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":87},"in_reply_to":"bf1dfd3f_b65ecb78","updated":"2024-08-22 15:28:51.000000000","message":"Done","commit_id":"1a9775efdfea826dc04edd459ac6d811466a4e2a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b304bbfe8d1fc8a1c7acc55eba6bca720b127136","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      register: rabbitmq_version_current"},{"line_number":26,"context_line":"      changed_when: false"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Get new RabbitMQ version"},{"line_number":29,"context_line":"      become: true"},{"line_number":30,"context_line":"      vars:"},{"line_number":31,"context_line":"        rabbitmq_container: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e593d721_7c48143b","line":28,"updated":"2024-08-28 10:14:09.000000000","message":"why not command: rabbitmqctl --version ? we don\u0027t need to run the whole kolla_set_configs and what is in config.json - do we?","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"311241af2ca54466da2e98260df762015de767b2","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      register: rabbitmq_version_current"},{"line_number":26,"context_line":"      changed_when: false"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Get new RabbitMQ version"},{"line_number":29,"context_line":"      become: true"},{"line_number":30,"context_line":"      vars:"},{"line_number":31,"context_line":"        rabbitmq_container: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"35713e0f_d5ebae9f","line":28,"in_reply_to":"101ad854_5501e1c9","updated":"2024-08-28 11:03:43.000000000","message":"We found the issue: needed to specify `detach: false` so that kolla_docker_worker will register the results. I\u0027ll get this patch updated, and propose reverting the KOLLA_RABBITMQ_VERSION_CHECK in kolla","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d63240f1a8e5680e6cf5dde7f532838798b2c20e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      register: rabbitmq_version_current"},{"line_number":26,"context_line":"      changed_when: false"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Get new RabbitMQ version"},{"line_number":29,"context_line":"      become: true"},{"line_number":30,"context_line":"      vars:"},{"line_number":31,"context_line":"        rabbitmq_container: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a1afef0_f89c53e2","line":28,"in_reply_to":"35713e0f_d5ebae9f","updated":"2024-08-28 12:32:13.000000000","message":"Done","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a0e62fcd5827cb55f64bf3fdc86d8638711ba6d9","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      register: rabbitmq_version_current"},{"line_number":26,"context_line":"      changed_when: false"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Get new RabbitMQ version"},{"line_number":29,"context_line":"      become: true"},{"line_number":30,"context_line":"      vars:"},{"line_number":31,"context_line":"        rabbitmq_container: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f1f746b2_b51f1913","line":28,"in_reply_to":"e593d721_7c48143b","updated":"2024-08-28 10:22:49.000000000","message":"I wasn\u0027t able to get this to work, I couldn\u0027t find a way to get the result out. It would just return ``result: false``. quick example:\n\n```\n\"invocation\": {                                                                                                                                                                                    \n        \"module_args\": {                                                                                                                                                                               \n            \"action\": \"start_container\",                                                                                                                                                               \n            \"api_version\": \"auto\",                                                                                                                                                                     \n            \"cap_add\": [],                                                                                                                                                                             \n            \"client_timeout\": 120,                                                                                                                                                                     \n            \"command\": \"rabbitmqctl --version\",                                                                                                                                                        \n            \"container_engine\": \"docker\",\n            \"detach\": true,                                                                                                                                                                            \n            \"dimensions\": {},                                                                                                                                                                          \n            \"environment\": {      \n                \"KOLLA_CONFIG_STRATEGY\": \"COPY_ALWAYS\",                                                                                                                                                \n                \"KOLLA_SERVICE_NAME\": \"rabbitmq-version-check\"                                                                                                                                         \n            },                                                                                                                                                                                         \n            \"graceful_timeout\": 10,\n            \"ignore_missing\": false,    \n            \"image\": \"kolla/rabbitmq:caracal-new-2\",                                                                                                                                                   \n            \"labels\": {        \n                \"UPGRADE\": null                                                                                                                                                                        \n            },                                                                                                                                                                                         \n            \"name\": \"rabbitmq_version_check\",\n            \"privileged\": false,\n            \"remove_on_exit\": true,                                                                \n            \"restart_policy\": \"oneshot\",                                                           \n            \"restart_retries\": 10,                                                                 \n            \"security_opt\": [],               \n            \"state\": \"running\",             \n            \"tls_verify\": false,\n            \"tty\": false,\n            \"volumes\": [\n                \"/etc/kolla/rabbitmq/:/var/lib/kolla/config_files/:ro\",                            \n                \"/etc/localtime:/etc/localtime:ro\",                                                \n                \"/etc/timezone:/etc/timezone:ro\",                                                  \n                \"rabbitmq:/var/lib/rabbitmq/\",                                                                                                                                                         \n                \"kolla_logs:/var/log/kolla/\"                                                                                                                                                           \n            ]                     \n        }                                                                                                                                                                                              \n    },                                                                                                                                                                                                 \n    \"result\": false\n```\n\nThis seemed like the nicest alternative, based on what we do for nova upgrade-checks","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"05b548094eddfe30515a387d3d74a6e8e9afd712","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      register: rabbitmq_version_current"},{"line_number":26,"context_line":"      changed_when: false"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Get new RabbitMQ version"},{"line_number":29,"context_line":"      become: true"},{"line_number":30,"context_line":"      vars:"},{"line_number":31,"context_line":"        rabbitmq_container: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fdf2d837_c18274bf","line":28,"in_reply_to":"f1f746b2_b51f1913","updated":"2024-08-28 10:25:00.000000000","message":"try without the upgrade LABEL? because we do upgrade\u0027y things in extend_start.sh based on that LABEL?","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"0e85a0153a51499190b9a7abd158ef899220a9b3","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      register: rabbitmq_version_current"},{"line_number":26,"context_line":"      changed_when: false"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Get new RabbitMQ version"},{"line_number":29,"context_line":"      become: true"},{"line_number":30,"context_line":"      vars:"},{"line_number":31,"context_line":"        rabbitmq_container: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"101ad854_5501e1c9","line":28,"in_reply_to":"fdf2d837_c18274bf","updated":"2024-08-28 10:33:42.000000000","message":"Still no result","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2edd9e8d39b547135aaa117388581a0327bee6d5","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    # rabbitmqctl --version is the last command run in extend_start."},{"line_number":51,"context_line":"    - name: Parse new RabbitMQ version"},{"line_number":52,"context_line":"      set_fact:"},{"line_number":53,"context_line":"        rabbitmq_version_new: \"{{ rabbitmq_version_check.stdout_lines[-1] }}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # As an example, when the new RabbitMQ version is 3.13.6:"},{"line_number":56,"context_line":"    # new_major_version \u003d 3"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e6a080a1_eecd1de3","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"updated":"2024-08-27 16:17:46.000000000","message":"ftr: I think this could be a little brittle (could easily fail if stdout somehow changes) but I also have currently no better idea myself how to fix this, thus +1.\n\nideally the `kolla_copy_cacerts` stuff would not be visible at this point on stdout.\n\nMarking as unresolved for now to highlight this for other reviewers, maybe someone else has a better idea?\n\nIf that will not be the case I will mark this as resolved once we merge it, thanks!","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"081b64f0aed0b93fe8c11107b47790b080e545f8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    # rabbitmqctl --version is the last command run in extend_start."},{"line_number":51,"context_line":"    - name: Parse new RabbitMQ version"},{"line_number":52,"context_line":"      set_fact:"},{"line_number":53,"context_line":"        rabbitmq_version_new: \"{{ rabbitmq_version_check.stdout_lines[-1] }}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # As an example, when the new RabbitMQ version is 3.13.6:"},{"line_number":56,"context_line":"    # new_major_version \u003d 3"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ec57afb1_4832d72c","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"in_reply_to":"73d59dc5_1909b178","updated":"2024-08-29 09:19:43.000000000","message":"Done","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b174a7d911d916d79e12e57a242028f876a08c4d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    # rabbitmqctl --version is the last command run in extend_start."},{"line_number":51,"context_line":"    - name: Parse new RabbitMQ version"},{"line_number":52,"context_line":"      set_fact:"},{"line_number":53,"context_line":"        rabbitmq_version_new: \"{{ rabbitmq_version_check.stdout_lines[-1] }}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # As an example, when the new RabbitMQ version is 3.13.6:"},{"line_number":56,"context_line":"    # new_major_version \u003d 3"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"73d59dc5_1909b178","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"in_reply_to":"e6a080a1_eecd1de3","updated":"2024-08-28 13:30:26.000000000","message":"Done","commit_id":"f3f4aac2319901439e9a0c460a4f132702601e10"}]}