)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"031bd5c28b5a9f619bf989ae5a2c1367f09199fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b988dd0f_e5b8c5fb","updated":"2024-08-20 12:49:40.000000000","message":"Also, I don\u0027t like to start container only because of run one python command. Now it\u0027s for horizon ... but what for other services using distro_python_version ?","commit_id":"3524ac05e2b571b6291320e16a2a29e4c61ab82b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3a27b7a8f1ef14b3b5c3c93b033f9ce13ebf531c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b09c34f_d689fe1c","updated":"2024-08-20 12:47:36.000000000","message":"What about to propose shared role which will fetch variable from container (because every container has KOLLA_DISTRO_PYTHON_VERSION) and fix this globally ...\n\nBecause distro_python_version is used in kolla-ansible and has 120 occurences ...\nWhy fix only for horizon ?","commit_id":"3524ac05e2b571b6291320e16a2a29e4c61ab82b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"064b820b68ce0457c9e95f92246f98644d00b350","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8dbf872d_2a8c0187","in_reply_to":"6fe2bdb4_44b13361","updated":"2024-08-20 12:54:20.000000000","message":"I\u0027ll answer - skyline and ironic:\n% grep -ri distro_python_version | grep -v dev_repos                                                                                                                                                  \n./skyline/templates/nginx.conf.j2:        root /var/lib/kolla/venv/lib/python{{ distro_python_version }}/site-packages/skyline_console/static;\n./skyline/templates/skyline-console.json.j2:            \"dest\": \"/var/lib/kolla/venv/lib/python{{ distro_python_version }}/site-packages/skyline_console/static\",\n./ironic/templates/ironic-prometheus-exporter-wsgi.conf.j2:{% set python_path \u003d \u0027/var/lib/kolla/venv/lib/python\u0027 + distro_python_version + \u0027/site-packages\u0027 %}","commit_id":"3524ac05e2b571b6291320e16a2a29e4c61ab82b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ebcd227e03c6abdeb2ef87d38c8b7200aa99f2ce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa42bb3d_320cd994","in_reply_to":"7f2859ad_9b9c5f39","updated":"2024-08-20 13:08:01.000000000","message":"I will propose my solution, and let\u0027s discuss tomorrow on irc during the meeting ...","commit_id":"3524ac05e2b571b6291320e16a2a29e4c61ab82b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b0883f0ddfdb89cdd8c1fa799a607a5f5563182d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f2859ad_9b9c5f39","in_reply_to":"8dbf872d_2a8c0187","updated":"2024-08-20 12:56:13.000000000","message":"yep, occurences - 7. \n\nSo, but still ..","commit_id":"3524ac05e2b571b6291320e16a2a29e4c61ab82b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"85d313b78b75e50ecda69390b3fca0e7dd49de49","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6fe2bdb4_44b13361","in_reply_to":"b988dd0f_e5b8c5fb","updated":"2024-08-20 12:53:36.000000000","message":"First of all - which other services are using it apart dev mode?","commit_id":"3524ac05e2b571b6291320e16a2a29e4c61ab82b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8bcf1b6f952f94249039d5a26945175961699465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04e8cc90_3c3f3a78","in_reply_to":"fa42bb3d_320cd994","updated":"2024-08-21 11:21:58.000000000","message":"Acknowledged","commit_id":"3524ac05e2b571b6291320e16a2a29e4c61ab82b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"15d144961e81890bab638e5b3260d6fb2622438d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ad7571b5_da8ddcdc","updated":"2024-08-21 11:49:29.000000000","message":"Still needs dev_mode handling and removing distro_python_version","commit_id":"a70717be1ec83f206023cf0d0cc5ed655d14c49b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a366a0f89945d3f12a68290c9bf636bb67367347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"43ad1195_3f5ddb45","in_reply_to":"6de91d45_fc6cad9f","updated":"2024-08-21 13:44:53.000000000","message":"and here: https://review.opendev.org/c/openstack/kolla-ansible/+/926745","commit_id":"a70717be1ec83f206023cf0d0cc5ed655d14c49b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b810aff7e2b176724894c3dac54048e4df7b194a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6de91d45_fc6cad9f","in_reply_to":"ad7571b5_da8ddcdc","updated":"2024-08-21 13:42:41.000000000","message":"Actually that handling is going to be fixed by https://review.opendev.org/c/openstack/kolla-ansible/+/925714","commit_id":"a70717be1ec83f206023cf0d0cc5ed655d14c49b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fe74b51a78ade74a85ec097c844d99f45c3a78a3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d3663905_9fa09373","updated":"2024-08-21 17:25:46.000000000","message":"recheck rocky9 upgrade failed, let\u0027s see if it\u0027s permanent.","commit_id":"148d6d788c6e03e86d7799cd1c4254d33420e8bf"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90e5734c4f6d596e6151aaf2628623f87c6ede5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d8a36103_23a0aa88","in_reply_to":"d3663905_9fa09373","updated":"2024-08-30 14:54:39.000000000","message":"Done","commit_id":"148d6d788c6e03e86d7799cd1c4254d33420e8bf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"050948d17b37ae8cde590c8c20d228ccabd40253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f81c9d22_f78e72f8","updated":"2024-08-30 15:14:33.000000000","message":"I still think https://review.opendev.org/c/openstack/kolla/+/926744 is more elegant and better ..fix it in image not in orchestration","commit_id":"af49ef0c21b81d008cda734e0ed023ecfa5be22c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90e5734c4f6d596e6151aaf2628623f87c6ede5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5a427e57_a763b8bc","updated":"2024-08-30 14:54:39.000000000","message":"code LGTM, might warrant a reno for introducing a new role, even if not directly intended for users (maybe we should have split renos for devs and users? ).","commit_id":"af49ef0c21b81d008cda734e0ed023ecfa5be22c"}],"ansible/roles/service-python-path/tasks/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"40b8a617f7d7905dba79f26e965880f1e8687340","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container:"},{"line_number":5,"context_line":"    action: \"start_container\""},{"line_number":6,"context_line":"    command: \"/var/lib/kolla/venv/bin/python3 -c \u0027import horizon; print(horizon.__file__)\u0027\""},{"line_number":7,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":8,"context_line":"    detach: False"},{"line_number":9,"context_line":"    environment:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ff99a89_280e9d47","line":6,"range":{"start_line":6,"start_character":50,"end_line":6,"end_character":89},"updated":"2024-08-20 15:15:38.000000000","message":"this needs to be changed to be generic for every service I guess, something like this?\n\n```suggestion\n    command: \"/var/lib/kolla/venv/bin/python3 -c \u0027import \"{{ project_name }}\"; print(\"{{ project_name }}\".__file__)\u0027\"\n```\n\nmight not work for all project names and I bet the quoting is broken 😄","commit_id":"a9bff4283cbf0c1dc0214c14e5da19ab8f2218f1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8858b8a198039f1ebb5d68c7c6e02c6f5afe1e6d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container:"},{"line_number":5,"context_line":"    action: \"start_container\""},{"line_number":6,"context_line":"    command: \"/var/lib/kolla/venv/bin/python3 -c \u0027import horizon; print(horizon.__file__)\u0027\""},{"line_number":7,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":8,"context_line":"    detach: False"},{"line_number":9,"context_line":"    environment:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a3da1ad4_02cd71af","line":6,"range":{"start_line":6,"start_character":50,"end_line":6,"end_character":89},"in_reply_to":"1ff99a89_280e9d47","updated":"2024-08-21 10:31:49.000000000","message":"Done","commit_id":"a9bff4283cbf0c1dc0214c14e5da19ab8f2218f1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b97b3d4a8a2714c0b9ed583b0027526aa93a4907","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container:"},{"line_number":5,"context_line":"    action: \"start_container\""},{"line_number":6,"context_line":"    command: \"/var/lib/kolla/venv/bin/python3 -c \u0027import {{ python_library }}; print({{ python_library }}.__file__)\u0027\""},{"line_number":7,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":8,"context_line":"    detach: False"},{"line_number":9,"context_line":"    environment:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c31de4d9_0b0314d3","line":6,"updated":"2024-08-21 14:05:21.000000000","message":"This role should work against all containers, this will not work for kolla-toolbox.","commit_id":"148d6d788c6e03e86d7799cd1c4254d33420e8bf"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90e5734c4f6d596e6151aaf2628623f87c6ede5a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container:"},{"line_number":5,"context_line":"    action: \"start_container\""},{"line_number":6,"context_line":"    command: \"/var/lib/kolla/venv/bin/python3 -c \u0027import {{ python_library }}; print({{ python_library }}.__file__)\u0027\""},{"line_number":7,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":8,"context_line":"    detach: False"},{"line_number":9,"context_line":"    environment:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bc55d465_1ca1e293","line":6,"in_reply_to":"55a64d2f_97d45f92","updated":"2024-08-30 14:54:39.000000000","message":"maybe just document it in the commit message/reno?\n\nmight be helpful if people run this manually/by accident on the \"wrong\" service.","commit_id":"148d6d788c6e03e86d7799cd1c4254d33420e8bf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9e8fc9956bc1c814ce40612b6aa0114896e4e927","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container:"},{"line_number":5,"context_line":"    action: \"start_container\""},{"line_number":6,"context_line":"    command: \"/var/lib/kolla/venv/bin/python3 -c \u0027import {{ python_library }}; print({{ python_library }}.__file__)\u0027\""},{"line_number":7,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":8,"context_line":"    detach: False"},{"line_number":9,"context_line":"    environment:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"55a64d2f_97d45f92","line":6,"in_reply_to":"c31de4d9_0b0314d3","updated":"2024-08-21 17:19:48.000000000","message":"And why do we need that for kolla_toolbox?","commit_id":"148d6d788c6e03e86d7799cd1c4254d33420e8bf"}],"ansible/roles/skyline/tasks/config.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"40b8a617f7d7905dba79f26e965880f1e8687340","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- import_role:"},{"line_number":3,"context_line":"    name: service-python-path"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service: \"{{ horizon_services[\u0027skyline-console\u0027] }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Ensuring config directories exist"},{"line_number":8,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ca63d0a_89ab7463","line":5,"range":{"start_line":5,"start_character":17,"end_line":5,"end_character":33},"updated":"2024-08-20 15:15:38.000000000","message":"horizon?","commit_id":"a9bff4283cbf0c1dc0214c14e5da19ab8f2218f1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8858b8a198039f1ebb5d68c7c6e02c6f5afe1e6d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- import_role:"},{"line_number":3,"context_line":"    name: service-python-path"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service: \"{{ horizon_services[\u0027skyline-console\u0027] }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Ensuring config directories exist"},{"line_number":8,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"eba09977_5de23492","line":5,"range":{"start_line":5,"start_character":17,"end_line":5,"end_character":33},"in_reply_to":"7ca63d0a_89ab7463","updated":"2024-08-21 10:31:49.000000000","message":"Done","commit_id":"a9bff4283cbf0c1dc0214c14e5da19ab8f2218f1"}]}