)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1883559ec9a955f68627a93b1ff44aeb5fbe417b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-09-11 21:09:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove distro_python_version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/926744"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I85431b058b4184d96600cf17aaf8de871a018d61"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f98c092d_cdc24ae2","line":8,"updated":"2024-09-18 13:41:30.000000000","message":"A sentence or two that explains this change and mentions the symlinking solution would be nice.","commit_id":"a18328ae02417750884a3e1a23128a8d9adaf275"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3fd6c1fd668d4bb2f8def41a6277919dad736ed5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-09-11 21:09:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove distro_python_version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/926744"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I85431b058b4184d96600cf17aaf8de871a018d61"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3510f00b_c47ea1d9","line":8,"in_reply_to":"f98c092d_cdc24ae2","updated":"2024-09-18 15:19:44.000000000","message":"Done","commit_id":"a18328ae02417750884a3e1a23128a8d9adaf275"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ba37da46ab7bea3d7e133f836030d8a9931a7ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17fda6c6_fc36bb59","updated":"2024-08-21 12:55:45.000000000","message":"recheck new revision of kolla patch","commit_id":"4685b972d84f277078985c5d72a057f13d2f6bb9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"728e756c85710e768dd870ac77837103d107a41c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a6358020_a54e68ba","updated":"2024-08-21 13:58:53.000000000","message":"recheck new version of kolla","commit_id":"4685b972d84f277078985c5d72a057f13d2f6bb9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1883559ec9a955f68627a93b1ff44aeb5fbe417b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2be15c99_8d0cd255","updated":"2024-09-18 13:41:30.000000000","message":"I\u0027m +2 to the solution itself, just -1 for some details, see my comments please","commit_id":"a18328ae02417750884a3e1a23128a8d9adaf275"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4e07aa9ff73943edd2c1ed75611a3acf662410b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec9cf2eb_28704de3","updated":"2024-09-14 13:48:38.000000000","message":"recheck as gate is now fixed","commit_id":"a18328ae02417750884a3e1a23128a8d9adaf275"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"71c3ffa11951538f8fc73b0ab67b115d4b7be411","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c262840e_2d2e4b11","updated":"2024-09-18 19:42:36.000000000","message":"As per IRC:\n\nfrickler -\u003e kevko: well my idea is just to avoid repeating long strings twice or more in a file by keeping the variable, some kind of deduplication. but as I said feel free to revert or amend as you like. I\u0027ll be offline now, will +2 when back either way\n\n+\n\nBased on the previous comment from frickler to keep the variable static (even though I understood it a bit differently than he meant), this really seems better to me. Because when I think about it, it\u0027s a minimal change, easily backportable for downstream users for example, and additionally, we could switch all Python versions to, for example to Python 4 in the distant future :)\n\nSo, reverted to change 7.","commit_id":"78902e35cec33617e398442ee5153a61d872851f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5d90144637ccd116d9ccf726e216daf5e28a5be3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0ce07748_01cd9411","updated":"2024-09-19 07:48:18.000000000","message":"missing reno that a variable was dropped","commit_id":"78902e35cec33617e398442ee5153a61d872851f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"fa4bacd45494063a8ee95b4acaaf61a6aeabc688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5555d21c_476dba6e","updated":"2024-09-19 00:28:26.000000000","message":"recheck as it can\u0027t be related","commit_id":"78902e35cec33617e398442ee5153a61d872851f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"df48413b7c034988ed9683342490d83aa309afdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8a7a08a2_440f931a","in_reply_to":"0ce07748_01cd9411","updated":"2024-09-19 11:13:37.000000000","message":"actually changed default, but let\u0027s have a reno still","commit_id":"78902e35cec33617e398442ee5153a61d872851f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"44208d43290c39212f7d94c297acb49e341aa3fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bf0bff07_275682ba","updated":"2024-09-23 18:51:45.000000000","message":"Hmm, jobs are failing because master images not pushed to quay.io yet ?\n\n[[ -f /var/lib/kolla/venv/lib/python3.11/site-packages/openstack_dashboard/local/enabled/_9010_manila_admin_add_shares_panel_to_share_panel_group.py ]]\n\nvs dockerfile\n\nSITE_PACKAGES\u003d\"/var/lib/kolla/venv/lib/python3/site-packages\"\n\nMANAGE_PY\u003d\"/var/lib/kolla/venv/bin/python /var/lib/kolla/venv/bin/manage.py\"\n\nif [[ ! -f ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py ]]; then\n\nWe probably need to publish images or wait for periodic job (i don\u0027t know how this works)","commit_id":"91a4d8f74b3e879bc0092571ff20937b27adfec5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e895b60b4b25e8bd2a208fb1ba7ae491e10eed2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"274f3205_13e6f49a","updated":"2024-09-23 11:13:28.000000000","message":"Ping @frickler@offenerstapel.de to merge also this after https://review.opendev.org/c/openstack/kolla/+/926744 is now merged.","commit_id":"91a4d8f74b3e879bc0092571ff20937b27adfec5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23511994e4387874911ee289f124b10f2ab8590e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1e3f37f1_d6bf0fe4","updated":"2024-09-24 05:25:26.000000000","message":"recheck new images built","commit_id":"91a4d8f74b3e879bc0092571ff20937b27adfec5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3d47b8888ae286e1fc856342d59b5f3507cd2550","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c24a7d25_d6c888b0","in_reply_to":"66ec0071_ce52b908","updated":"2024-09-23 19:14:47.000000000","message":"yeah, what time is it ?","commit_id":"91a4d8f74b3e879bc0092571ff20937b27adfec5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8a9e0385a52b4f82b5a88e3c73006978f38b37c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"66ec0071_ce52b908","in_reply_to":"bf0bff07_275682ba","updated":"2024-09-23 18:55:49.000000000","message":"So then needs to wait until tomorrows periodics","commit_id":"91a4d8f74b3e879bc0092571ff20937b27adfec5"}],"ansible/roles/horizon/templates/horizon.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1883559ec9a955f68627a93b1ff44aeb5fbe417b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% set python_path \u003d \u0027/var/lib/kolla/venv/lib/python\u0027 + distro_python_version + \u0027/site-packages\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% if horizon_enable_tls_backend | bool %}"},{"line_number":4,"context_line":"{% if kolla_base_distro in [\u0027centos\u0027, \u0027rocky\u0027]  %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"002bab61_68f5ea2b","side":"PARENT","line":1,"updated":"2024-09-18 13:41:30.000000000","message":"keep this var but make it static, avoids duplicating the whole path below","commit_id":"753a7e1a127d5f8a1118f07d19207d126ef758a5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3fd6c1fd668d4bb2f8def41a6277919dad736ed5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set python_path \u003d \u0027/var/lib/kolla/venv/lib/python\u0027 + distro_python_version + \u0027/site-packages\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% if horizon_enable_tls_backend | bool %}"},{"line_number":4,"context_line":"{% if kolla_base_distro in [\u0027centos\u0027, \u0027rocky\u0027]  %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"27f9597f_6f3e072f","side":"PARENT","line":1,"in_reply_to":"002bab61_68f5ea2b","updated":"2024-09-18 15:19:44.000000000","message":"Done","commit_id":"753a7e1a127d5f8a1118f07d19207d126ef758a5"}],"ansible/roles/ironic/templates/ironic-prometheus-exporter-wsgi.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1883559ec9a955f68627a93b1ff44aeb5fbe417b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% set ironic_log_dir \u003d \u0027/var/log/kolla/ironic\u0027 %}"},{"line_number":2,"context_line":"{% set python_path \u003d \u0027/var/lib/kolla/venv/lib/python\u0027 + distro_python_version + \u0027/site-packages\u0027 %}"},{"line_number":3,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ ironic_prometheus_exporter_port }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ServerSignature Off"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ead18ec5_354b67ed","side":"PARENT","line":2,"updated":"2024-09-18 13:41:30.000000000","message":"I\u0027d still keep using this var in order to avoid repeating the constant below","commit_id":"753a7e1a127d5f8a1118f07d19207d126ef758a5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3fd6c1fd668d4bb2f8def41a6277919dad736ed5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ironic_log_dir \u003d \u0027/var/log/kolla/ironic\u0027 %}"},{"line_number":2,"context_line":"{% set python_path \u003d \u0027/var/lib/kolla/venv/lib/python\u0027 + distro_python_version + \u0027/site-packages\u0027 %}"},{"line_number":3,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ ironic_prometheus_exporter_port }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ServerSignature Off"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"76662b43_49b100e9","side":"PARENT","line":2,"in_reply_to":"ead18ec5_354b67ed","updated":"2024-09-18 15:19:44.000000000","message":"Done","commit_id":"753a7e1a127d5f8a1118f07d19207d126ef758a5"}]}