)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9d4dcd03bf75ac9edad671912e76b6b433038f65","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Bialas \u003cgrzegorz@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-08-23 15:43:37 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes bug: https://bugs.launchpad.net/kolla-ansible/+bug/2066052"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7e30ee5754ca2ecf9d4a2d3519f9e0bdf3f0aeea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"eeb6ab8c_7f0c7d71","line":7,"updated":"2024-08-23 13:52:45.000000000","message":"I would recommend a meaningful subject and \"Closes-Bug: #2066052\" in the commit message body","commit_id":"3065e3504919c00946e0756d25bf2dd35f4b6e30"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"433a2394daae1c62c2480610db662ce534a5abb7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Bialas \u003cgrzegorz@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-08-23 15:43:37 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes bug: https://bugs.launchpad.net/kolla-ansible/+bug/2066052"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7e30ee5754ca2ecf9d4a2d3519f9e0bdf3f0aeea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8fa761aa_a277ad49","line":7,"in_reply_to":"eeb6ab8c_7f0c7d71","updated":"2024-08-23 14:17:43.000000000","message":"Fixed.","commit_id":"3065e3504919c00946e0756d25bf2dd35f4b6e30"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"cfea47ed302fe09965ead8f12fe3ef414a65015c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"pointing to stable/\u003crelease\u003e branches in repository. Instead they"},{"line_number":11,"context_line":"should point to unmaintained/\u003crelease\u003e. This patch aims to fix that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug:: https://bugs.launchpad.net/kolla-ansible/+bug/2066052"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7e30ee5754ca2ecf9d4a2d3519f9e0bdf3f0aeea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4b9d081f_b0bf05b9","line":13,"updated":"2024-08-23 15:23:25.000000000","message":"Closes-Bug: #BUG_NUMBER","commit_id":"5e0d4244d7ed9ef300a34789d24ca7ddbdae8b1b"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"c94356a1ab292d0dff7a3dd999b3553b748550c7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"pointing to stable/\u003crelease\u003e branches in repository. Instead they"},{"line_number":11,"context_line":"should point to unmaintained/\u003crelease\u003e. This patch aims to fix that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug:: https://bugs.launchpad.net/kolla-ansible/+bug/2066052"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7e30ee5754ca2ecf9d4a2d3519f9e0bdf3f0aeea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8fd8acc2_d35b631b","line":13,"in_reply_to":"4b9d081f_b0bf05b9","updated":"2024-08-26 08:25:52.000000000","message":"Fixed","commit_id":"5e0d4244d7ed9ef300a34789d24ca7ddbdae8b1b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"a1e51de5e86d603fe27ca6df2d8f53ce3376819e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"458ec34d_d8d7be01","updated":"2024-08-26 10:33:44.000000000","message":"Hi, it looks like this variable really should be string not list. After adding it ci failed: https://zuul.opendev.org/t/openstack/build/32b18698ad484f97b865ecdbd91af743\n\nI have cherry-picked this patch without this change and build docks: https://4e240f8fa4f8989d230c-b3141299f569dd5d6d8f436de9f6d947.ssl.cf5.rackcdn.com/927092/1/check/openstack-tox-docs/da73fd1/docs/reference/bare-metal/ironic-guide.html \nI have checked all sub-pages where this variable is used, and all looks good. \nExample: https://4e240f8fa4f8989d230c-b3141299f569dd5d6d8f436de9f6d947.ssl.cf5.rackcdn.com/927092/1/check/openstack-tox-docs/da73fd1/docs/reference/bare-metal/ironic-guide.html \nand \nhttps://4e240f8fa4f8989d230c-b3141299f569dd5d6d8f436de9f6d947.ssl.cf5.rackcdn.com/927092/1/check/openstack-tox-docs/da73fd1/docs/user/operating-kolla.html","commit_id":"f414a1fc42ba0bed975590d9c51a1d62acce5c00"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b43dcadda11c05ae443d4d5b6a0efa559e7bd930","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ed20b908_7725e55c","in_reply_to":"458ec34d_d8d7be01","updated":"2024-08-27 08:56:49.000000000","message":"You need to extend conf.py then to convert your list of strings to just a string.\nAt least in theory this should be possible, but I\u0027m also not very familiar with this part of the code.","commit_id":"f414a1fc42ba0bed975590d9c51a1d62acce5c00"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"e18a227524a420942bde22ba634221e2f3ad656f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5badc250_155bb4f4","in_reply_to":"ed20b908_7725e55c","updated":"2024-08-27 12:02:21.000000000","message":"I have altered comment, like we discussed in IRC channel.","commit_id":"f414a1fc42ba0bed975590d9c51a1d62acce5c00"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ec6d3ebe541c872df82c2140d0396060d676a7de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ab629b87_c03d5767","updated":"2024-09-09 08:34:28.000000000","message":"trivial and docs only","commit_id":"c0ce3802ab30c2ffc00f34c7a630623821cba83b"}],"doc/source/conf.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b9410b98ee75b1fe6cc9494076280088529bcfa9","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    \u0027|KOLLA_OPENSTACK_RELEASE|\u0027: KOLLA_OPENSTACK_RELEASE,"},{"line_number":153,"context_line":"    \u0027|KOLLA_BRANCH_NAME|\u0027: KOLLA_BRANCH_NAME,"},{"line_number":154,"context_line":"    \u0027|KOLLA_BRANCH_NAME_DASHED|\u0027: KOLLA_BRANCH_NAME.replace(\u0027/\u0027, \u0027-\u0027),"},{"line_number":155,"context_line":"    \u0027|TESTED_RUNTIMES_GOVERNANCE_URL|\u0027: TESTED_RUNTIMES_GOVERNANCE_URL,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"0db9b3f7_af5e158a","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":2},"updated":"2024-08-26 08:53:11.000000000","message":"this needs to be added here as well:\n\n```suggestion\n    \u0027|TESTED_RUNTIMES_GOVERNANCE_URL|\u0027: TESTED_RUNTIMES_GOVERNANCE_URL,\n    `|KOLLA_OPENSTACK_RELEASE_UNMAINTAINED|`: KOLLA_OPENSTACK_RELEASE_UNMAINTAINED,\n```","commit_id":"eb7232f89c64338ca42fa19bfb715de675a2df8f"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"67d0bfe61086db86cb65f18fedf29e20f9030ae6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \u0027|KOLLA_OPENSTACK_RELEASE|\u0027: KOLLA_OPENSTACK_RELEASE,"},{"line_number":153,"context_line":"    \u0027|KOLLA_BRANCH_NAME|\u0027: KOLLA_BRANCH_NAME,"},{"line_number":154,"context_line":"    \u0027|KOLLA_BRANCH_NAME_DASHED|\u0027: KOLLA_BRANCH_NAME.replace(\u0027/\u0027, \u0027-\u0027),"},{"line_number":155,"context_line":"    \u0027|TESTED_RUNTIMES_GOVERNANCE_URL|\u0027: TESTED_RUNTIMES_GOVERNANCE_URL,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bd9aa474_dd82488d","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":2},"in_reply_to":"0db9b3f7_af5e158a","updated":"2024-08-26 09:12:29.000000000","message":"Yup. I wasn\u0027t sure if variable containing list also should be here. Thanks!","commit_id":"eb7232f89c64338ca42fa19bfb715de675a2df8f"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"a1e51de5e86d603fe27ca6df2d8f53ce3376819e","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    \u0027|KOLLA_OPENSTACK_RELEASE|\u0027: KOLLA_OPENSTACK_RELEASE,"},{"line_number":153,"context_line":"    \u0027|KOLLA_BRANCH_NAME|\u0027: KOLLA_BRANCH_NAME,"},{"line_number":154,"context_line":"    \u0027|KOLLA_BRANCH_NAME_DASHED|\u0027: KOLLA_BRANCH_NAME.replace(\u0027/\u0027, \u0027-\u0027),"},{"line_number":155,"context_line":"    \u0027|TESTED_RUNTIMES_GOVERNANCE_URL|\u0027: TESTED_RUNTIMES_GOVERNANCE_URL,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"63d03a8b_acbcae04","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":2},"in_reply_to":"1c518dde_662b800c","updated":"2024-08-26 10:33:44.000000000","message":"Fix applied.","commit_id":"eb7232f89c64338ca42fa19bfb715de675a2df8f"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"e18a227524a420942bde22ba634221e2f3ad656f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \u0027|KOLLA_OPENSTACK_RELEASE|\u0027: KOLLA_OPENSTACK_RELEASE,"},{"line_number":153,"context_line":"    \u0027|KOLLA_BRANCH_NAME|\u0027: KOLLA_BRANCH_NAME,"},{"line_number":154,"context_line":"    \u0027|KOLLA_BRANCH_NAME_DASHED|\u0027: KOLLA_BRANCH_NAME.replace(\u0027/\u0027, \u0027-\u0027),"},{"line_number":155,"context_line":"    \u0027|TESTED_RUNTIMES_GOVERNANCE_URL|\u0027: TESTED_RUNTIMES_GOVERNANCE_URL,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4de126cc_d88c1fcc","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":2},"in_reply_to":"63d03a8b_acbcae04","updated":"2024-08-27 12:02:21.000000000","message":"I have removed this fix and added comment clarifying why this variable isn\u0027t added to GLOBAL_VARIABLE_MAP.","commit_id":"eb7232f89c64338ca42fa19bfb715de675a2df8f"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"aeb8f6a41860a50b392e195efbb089bd56b4ccb1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \u0027|KOLLA_OPENSTACK_RELEASE|\u0027: KOLLA_OPENSTACK_RELEASE,"},{"line_number":153,"context_line":"    \u0027|KOLLA_BRANCH_NAME|\u0027: KOLLA_BRANCH_NAME,"},{"line_number":154,"context_line":"    \u0027|KOLLA_BRANCH_NAME_DASHED|\u0027: KOLLA_BRANCH_NAME.replace(\u0027/\u0027, \u0027-\u0027),"},{"line_number":155,"context_line":"    \u0027|TESTED_RUNTIMES_GOVERNANCE_URL|\u0027: TESTED_RUNTIMES_GOVERNANCE_URL,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1c518dde_662b800c","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":2},"in_reply_to":"bd9aa474_dd82488d","updated":"2024-08-26 09:29:28.000000000","message":"Fix applied.","commit_id":"eb7232f89c64338ca42fa19bfb715de675a2df8f"}]}
