)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"da942477dcfc2399aa74514d5de0936eb58c9da3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This is a prerequisite for patchset #924651"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":12,"context_line":"is started for that purpouse. This container uses the new nova-api"},{"line_number":13,"context_line":"image, but the old config.json file. The image expects CA certificates"},{"line_number":14,"context_line":"in certain location, but due to the old config.json file, they will be"},{"line_number":15,"context_line":"not present. This results in the container not trusting keystone SSL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"39754cf5_eb8781a7","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":28},"updated":"2024-09-12 15:23:11.000000000","message":"nit: purpose","commit_id":"2d076d7e1917fe01e41feb1efcaaa21686167ab9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"b71e564e8bba057b0bd08033e64c4d3615163ad0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is a prerequisite for patchset #924651"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":12,"context_line":"is started for that purpouse. This container uses the new nova-api"},{"line_number":13,"context_line":"image, but the old config.json file. The image expects CA certificates"},{"line_number":14,"context_line":"in certain location, but due to the old config.json file, they will be"},{"line_number":15,"context_line":"not present. This results in the container not trusting keystone SSL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"07a3d1eb_b9915b56","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":28},"in_reply_to":"39754cf5_eb8781a7","updated":"2024-09-13 09:07:58.000000000","message":"Done","commit_id":"2d076d7e1917fe01e41feb1efcaaa21686167ab9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"da942477dcfc2399aa74514d5de0936eb58c9da3","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":12,"context_line":"is started for that purpouse. This container uses the new nova-api"},{"line_number":13,"context_line":"image, but the old config.json file. The image expects CA certificates"},{"line_number":14,"context_line":"in certain location, but due to the old config.json file, they will be"},{"line_number":15,"context_line":"not present. This results in the container not trusting keystone SSL"},{"line_number":16,"context_line":"certificate and the upgrade fails, since it can\u0027t connect. Moving the"},{"line_number":17,"context_line":"config section before the checks ensures that the new container has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9e4c2c42_ea802fc7","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":19},"updated":"2024-09-12 15:23:11.000000000","message":"either: in a certain location\nor: in certain locations","commit_id":"2d076d7e1917fe01e41feb1efcaaa21686167ab9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"b71e564e8bba057b0bd08033e64c4d3615163ad0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":12,"context_line":"is started for that purpouse. This container uses the new nova-api"},{"line_number":13,"context_line":"image, but the old config.json file. The image expects CA certificates"},{"line_number":14,"context_line":"in certain location, but due to the old config.json file, they will be"},{"line_number":15,"context_line":"not present. This results in the container not trusting keystone SSL"},{"line_number":16,"context_line":"certificate and the upgrade fails, since it can\u0027t connect. Moving the"},{"line_number":17,"context_line":"config section before the checks ensures that the new container has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"32db9bbb_22f9e27e","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":19},"in_reply_to":"9e4c2c42_ea802fc7","updated":"2024-09-13 09:07:58.000000000","message":"Done","commit_id":"2d076d7e1917fe01e41feb1efcaaa21686167ab9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"230cbabec479ee77109c0fa6ec7fae866a71aea3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d0f3f206_838e4893","updated":"2024-09-13 07:40:06.000000000","message":"LGTM","commit_id":"2d076d7e1917fe01e41feb1efcaaa21686167ab9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"da942477dcfc2399aa74514d5de0936eb58c9da3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26782368_8ab0ab2e","updated":"2024-09-12 15:23:11.000000000","message":"Thanks for the nice commit message, only two small nits I guess, but I still need to look at the dependent changesets before voting.","commit_id":"2d076d7e1917fe01e41feb1efcaaa21686167ab9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"181e673f62852155c1b03bfd7207ff6d64619512","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b51d743c_71b82897","updated":"2024-09-13 11:38:29.000000000","message":"accounting for previous +2 from Michal, as this only changed the commit message wording slightly.","commit_id":"41448f2077b5469bedd62fe4b96cb0aff6c60938"}],"releasenotes/notes/refactor-nova-upgrade-2474a97fc38ef0b8.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9853d55e73e57c91777a46dabba2f3eafc81f7bd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refactor nova upgrade task"},{"line_number":5,"context_line":"    This is a prerequisite for patchset #924651"},{"line_number":6,"context_line":"    Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":7,"context_line":"    is started for that purpouse. This container uses the new nova-api"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6d87a457_914253f1","line":4,"updated":"2024-09-11 13:45:58.000000000","message":"That\u0027s a bit too long - can you raise a bug in launchpad for this behaviour (not picking up ca certificates/old config.json)? and link it to the commit message?\nReno can be removed, since we don\u0027t require them on bug fixes (but if you persist - just use the template for bug fix reno).","commit_id":"589311653689a31b6b93c57700a37e2c644a30b9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"548b3f6138d36a2f60a5ba3ae94355c4e0cfb9f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refactor nova upgrade task"},{"line_number":5,"context_line":"    This is a prerequisite for patchset #924651"},{"line_number":6,"context_line":"    Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":7,"context_line":"    is started for that purpouse. This container uses the new nova-api"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"007bb5fa_4daa9aca","line":4,"in_reply_to":"38dca1cd_0542a393","updated":"2024-09-13 06:50:27.000000000","message":"Done","commit_id":"589311653689a31b6b93c57700a37e2c644a30b9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4385fcccef3f781c10559384d015c703db68eed3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refactor nova upgrade task"},{"line_number":5,"context_line":"    This is a prerequisite for patchset #924651"},{"line_number":6,"context_line":"    Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":7,"context_line":"    is started for that purpouse. This container uses the new nova-api"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e89ed918_feabc62a","line":4,"in_reply_to":"38dca1cd_0542a393","updated":"2024-09-12 14:24:58.000000000","message":"very short) lol","commit_id":"589311653689a31b6b93c57700a37e2c644a30b9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"330f7605d42b806d8b7ecba4755b41c0204d2c65","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refactor nova upgrade task"},{"line_number":5,"context_line":"    This is a prerequisite for patchset #924651"},{"line_number":6,"context_line":"    Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":7,"context_line":"    is started for that purpouse. This container uses the new nova-api"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ed8fa0a_54bf0678","line":4,"in_reply_to":"6d87a457_914253f1","updated":"2024-09-12 07:42:04.000000000","message":"I did not create bug report since it doesn\u0027t really concern the master or stable branches. It only becomes a bug in #924651, because that\u0027s the place where we start adding the certificates to `config.json`\n\nHowever, if you still think I should raise it in launchpad, I\u0027ll gladly do so with more detail. :)\n\nAnd I\u0027ll change the reno to the bug fix reno as you suggested.","commit_id":"589311653689a31b6b93c57700a37e2c644a30b9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ff3a249391e1b3980df15f679303ebfeb27509f6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refactor nova upgrade task"},{"line_number":5,"context_line":"    This is a prerequisite for patchset #924651"},{"line_number":6,"context_line":"    Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":7,"context_line":"    is started for that purpouse. This container uses the new nova-api"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e1c4b1c1_b10cc878","line":4,"in_reply_to":"7ed8fa0a_54bf0678","updated":"2024-09-12 10:48:58.000000000","message":"Ah, I misunderstood yesterday - ok then, no bug required.\nSecond of all - this doesn\u0027t seem there\u0027s user impact on this, but you can just a reno that now nova_upgrade_checks container uses a newly generated config.json - something short and simple.","commit_id":"589311653689a31b6b93c57700a37e2c644a30b9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"984c33cf5515a1964a0686526ca3d2b5a7839959","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refactor nova upgrade task"},{"line_number":5,"context_line":"    This is a prerequisite for patchset #924651"},{"line_number":6,"context_line":"    Nova runs checks before upgrading. A new nova_upgrade_checks container"},{"line_number":7,"context_line":"    is started for that purpouse. This container uses the new nova-api"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"38dca1cd_0542a393","line":4,"in_reply_to":"e1c4b1c1_b10cc878","updated":"2024-09-12 11:03:19.000000000","message":"Made it shorter and under `fixes:` tag","commit_id":"589311653689a31b6b93c57700a37e2c644a30b9"}]}
