)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"97d3a79d2797317a2cff855f34126415c6ed6422","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49950ee9_43c85487","updated":"2024-09-09 15:05:00.000000000","message":"We\u0027re testing proxysql in the cells scenario - should we add prometheus in there to get that tested?","commit_id":"d32e11f5cb24f295fe26bdd4168537b24d5898f0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7f5da1d22c49f2b0f71925c3522b53a56a50184a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81a66244_fc124174","in_reply_to":"4703019f_6c7eddb4","updated":"2024-09-14 08:17:58.000000000","message":"I\u0027ve added test that proxysql prometheus exporter itself is working, i don\u0027t think we need to test whole prometheus implementation.","commit_id":"d32e11f5cb24f295fe26bdd4168537b24d5898f0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1c4dda657e753ead64869fa4e3dbd83ca5db8e8c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4703019f_6c7eddb4","in_reply_to":"49950ee9_43c85487","updated":"2024-09-10 07:53:18.000000000","message":"seems like a good addition, I like the idea.","commit_id":"d32e11f5cb24f295fe26bdd4168537b24d5898f0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1c4dda657e753ead64869fa4e3dbd83ca5db8e8c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b87b4432_281d01a2","updated":"2024-09-10 07:53:18.000000000","message":"not sure if it\u0027s a good idea to expose the metrics via the public API endpoint, without authentication?\nIt seems the endpoint doesn\u0027t support authentication, at least I could not find it on https://proxysql.com/documentation/prometheus-exporter/.\n\nDid anybody check if these metrics contain no sensitive data?","commit_id":"0f7ad8167589f9fdb59e6f246f3e83b2b3b89961"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4bd54ab470e537a9c955a1dffe7f4db5d52657e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ddbbda27_f971d7fe","in_reply_to":"ab81526d_b3034032","updated":"2024-09-13 12:31:24.000000000","message":"nvm, I confused the `api_interface_address` with the public vip endpoint.","commit_id":"0f7ad8167589f9fdb59e6f246f3e83b2b3b89961"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"519fd0612fdf311b6b27ae88187d1925cb7db572","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffc8d611_03fa1d21","in_reply_to":"b87b4432_281d01a2","updated":"2024-09-10 07:54:13.000000000","message":"forgot to write that the code itself LGTM! I\u0027m just unsure about the chosen endpoint and if we would need additional auth there.","commit_id":"0f7ad8167589f9fdb59e6f246f3e83b2b3b89961"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f46b9997ce9b20dfac3eb326144ff5e53da6d62a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ab81526d_b3034032","in_reply_to":"ffc8d611_03fa1d21","updated":"2024-09-10 10:08:36.000000000","message":"Please, can u show me where did you see that it\u0027s on public endpoint ? It\u0027s internal..","commit_id":"0f7ad8167589f9fdb59e6f246f3e83b2b3b89961"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4bd54ab470e537a9c955a1dffe7f4db5d52657e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cce9a26f_9aa2dc4a","updated":"2024-09-13 12:31:24.000000000","message":"Code LGTM, but could you add a barebones proxysql exporter test with prometheus in the cells scenario like Michal suggested? So we have a test if it actually works?\n\nThank you!","commit_id":"96944b13bcc1639849f1a6cdfaaf198e478f978e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a5eda14c441a7c96b55207237577536f5be55d35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ddfe5994_4b41e628","updated":"2024-09-11 20:25:08.000000000","message":"gate failures 😞","commit_id":"96944b13bcc1639849f1a6cdfaaf198e478f978e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bcb3954993f543e9b550a4397627ad1a79fd0598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e9b6da3d_624986b2","updated":"2024-09-12 15:34:35.000000000","message":"recheck as gate should be fixed","commit_id":"96944b13bcc1639849f1a6cdfaaf198e478f978e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8534e66b0e078d33f47346f2f2834f37d59ed484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0e1fe894_aa5c7ec8","in_reply_to":"cce9a26f_9aa2dc4a","updated":"2024-09-14 08:16:44.000000000","message":"Done","commit_id":"96944b13bcc1639849f1a6cdfaaf198e478f978e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8e64f095a5de022845c38b9d5c7c3eb2c55cfb16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d2704441_47039230","updated":"2024-09-14 12:57:52.000000000","message":"Done","commit_id":"e1665e25b17638fc52312ad42571c2681ff562a6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"37d29fc67489354acdea526af55f3d2fabb12638","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ab96583f_8578c766","updated":"2024-09-17 06:03:06.000000000","message":"In podman jobs for arm only there are some errors non-related to this change and it can\u0027t be merge then 😞\n\nprimary/logs/kolla/all-ERROR.txt:2024-09-17 04:53:10.979 1035 ERROR oslo.messaging._drivers.impl_rabbit [-] Internal amqp error (541) during queue declare,retrying in 2 seconds. Queue: [q-server-resource-versions], error message: [Queue.declare: (541) INTERNAL_ERROR - Cannot declare quorum queue \u0027q-server-resource-versions\u0027 in vhost \u0027/\u0027 on node \u0027rabbit@primary\u0027 with leader on node \u0027rabbit@primary\u0027: cluster_not_formed]: amqp.exceptions.InternalError: Queue.declare: (541) INTERNAL_ERROR - Cannot declare quorum queue \u0027q-server-resource-versions\u0027 in vhost \u0027/\u0027 on node \u0027rabbit@primary\u0027 with leader on node \u0027rabbit@primary\u0027: cluster_not_formed\nprimary/logs/kolla/all-ERROR.txt:2024-09-17 04:53:13.030 1035 ERROR oslo.messaging._drivers.impl_rabbit [-] [1d4b15c6-459f-47ba-9309-e5858afe0ec0] AMQP server on 192.0.2.1:5671 is unreachable: connection already closed. Trying again in 1 seconds.: amqp.exceptions.RecoverableConnectionError: connection already closed","commit_id":"f68e3c4fef80751a00a22101c00c7eeb9b170df6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"70c7b6af0042fb1b49670a296d3550e47f291bca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"12bfb5b5_e069b8af","updated":"2024-09-16 23:02:45.000000000","message":"recheck arm failed","commit_id":"f68e3c4fef80751a00a22101c00c7eeb9b170df6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b0b77da15f9cb4ba81b018973411fd1eebda1753","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a1692d57_35bb2d33","updated":"2024-09-17 02:39:59.000000000","message":"recheck non-related network is unavailable","commit_id":"f68e3c4fef80751a00a22101c00c7eeb9b170df6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7b0d7c7e679db307d8e1771aa65aa05a5a3e7b17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d437ba76_792e61c1","updated":"2024-09-16 16:45:41.000000000","message":"recheck upgrade non-related fail","commit_id":"f68e3c4fef80751a00a22101c00c7eeb9b170df6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf9ce613c2fcac442a0c0647d6f39dff083fc997","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ea0d2ae9_fe3965ad","updated":"2024-09-16 07:19:27.000000000","message":"works: https://zuul.opendev.org/t/openstack/build/6c0fc040e10f4f7f99e3b994c42f4910/log/primary/logs/ansible/test-core-openstack","commit_id":"f68e3c4fef80751a00a22101c00c7eeb9b170df6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f2d488d08ea0351480ee1ce3eb88ba40252f1adf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"abcb921d_407b7a12","updated":"2024-09-17 08:06:15.000000000","message":"accounting previous +w as nothing changed, just rebased because of gerrit bug or something","commit_id":"de79f77ef003a0e771548a6f2dab4e3b8ee58e19"}],"ansible/roles/loadbalancer/tasks/precheck.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"db10e3fbc85c9f7429f4383e1ed3ba05c03ce571","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    - container_facts[\u0027proxysql\u0027] is not defined"},{"line_number":204,"context_line":"    - inventory_hostname in groups[\u0027loadbalancer\u0027]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"- name: Checking free port for ProxySQL prometheus exporter (vip interface)"},{"line_number":207,"context_line":"  wait_for:"},{"line_number":208,"context_line":"    host: \"{{ kolla_internal_vip_address }}\""},{"line_number":209,"context_line":"    port: \"{{ proxysql_prometheus_exporter_port }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"aa7ddbc8_9808a004","line":206,"updated":"2024-09-16 14:40:17.000000000","message":"not really interface, but meh","commit_id":"f68e3c4fef80751a00a22101c00c7eeb9b170df6"}]}