)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"cba394e432f8b49c90128ec7811910fca9a16ec2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"177d095d_f2d752a5","updated":"2024-12-11 13:48:43.000000000","message":"Overall, the implementation here works well. I\u0027ve deployed with it and can see /dev/shm fine within the containers.\n\nHowever, we\u0027re missing Ironic here.","commit_id":"cb5adaccf23101c162be0bae4198bf1d24e1d06d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4c5361bdd5ca0cd2174f93293b3acb6d5e734d79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d6af319_714a53a1","updated":"2024-09-14 13:49:41.000000000","message":"recheck again","commit_id":"cb5adaccf23101c162be0bae4198bf1d24e1d06d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3ac9591538b4080c7beeeabcea04a07761b18e3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dab1e475_b53c9ef0","updated":"2024-09-09 18:56:45.000000000","message":"recheck as it is not related to this patch - floating ip deassociate","commit_id":"cb5adaccf23101c162be0bae4198bf1d24e1d06d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6371c808b557126f594327ce681114fae749efbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4191a91e_b0a078cc","in_reply_to":"177d095d_f2d752a5","updated":"2024-12-11 14:26:05.000000000","message":"Done","commit_id":"cb5adaccf23101c162be0bae4198bf1d24e1d06d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"689d2d6635098d1f97a919d916297f5c64b03924","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fbcc3a4e_697e8273","updated":"2025-01-10 09:44:45.000000000","message":"Given we\u0027re targetting Epoxy for RabbitMQ 4.0, we\u0027ll want to backport this to Dalmatian and Caracal so we can migrate away from transient queues before upgrading to Epoxy.\n\nShould we make this, lock_path and queue manager dependent on some variable, say `om_enable_queue_manager`?","commit_id":"bd2b2535fdd136ef860c0cf2bfb3cce5d60afea4"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"8af8bed3da169f87b2f81963a4acf8a70d545ac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"51338aa9_66bc334f","updated":"2024-12-12 13:38:34.000000000","message":"LGTM now, thanks :)","commit_id":"bd2b2535fdd136ef860c0cf2bfb3cce5d60afea4"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2d492c9fb2d47790a8c2f28513fedf4473cff7c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a823b56a_76a01b17","in_reply_to":"21083c45_b787a4e5","updated":"2025-01-15 15:42:03.000000000","message":"Done","commit_id":"bd2b2535fdd136ef860c0cf2bfb3cce5d60afea4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9f646acddece24195054d4a9b8136dbed25585cd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"21083c45_b787a4e5","in_reply_to":"fbcc3a4e_697e8273","updated":"2025-01-13 16:43:12.000000000","message":"Yes, users that don\u0027t want to enable this should not be affected (as in no changes for them doing a deploy using backported code)","commit_id":"bd2b2535fdd136ef860c0cf2bfb3cce5d60afea4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"627a846074914fb9116635442daf51444df63564","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"74cc5d4c_5f0280e1","updated":"2025-01-15 19:03:25.000000000","message":"I would like to have a better understanding about why this is needed before approving. in the end this is weakening the security that we try to achieve by separating services into containers, so it should be only done with good reasoning.\n\nisn\u0027t it possible in theory to run each container on a dedicated host? in that case, this patch should be a no-op. so what communication is happening here that makes this required?","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9a63e1c841d7556d74d00de02be3ce7cc15aabaf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a944a237_d90ed032","in_reply_to":"74cc5d4c_5f0280e1","updated":"2025-01-16 11:06:16.000000000","message":"It\u0027s needed to avoid creating queues with the same name. The queue manager will name queues based on hostname, process name and a counter from shared memory.\n\nWe hit this where multiple services run under mod_wsgi for example:\n```\n[stack@mattc-controller-01 ~]$  docker exec -it rabbitmq rabbitmqctl list_queues name type | grep wsgi\nreply_mattc-controller-03:mod_wsgi:1    quorum\nreply_mattc-controller-02:mod_wsgi:2    quorum\nreply_mattc-controller-03:mod_wsgi:2    quorum\nreply_mattc-controller-01:mod_wsgi:2    quorum\nreply_mattc-controller-01:mod_wsgi:1    quorum\nreply_mattc-controller-02:mod_wsgi:1    quorum\n\ncat /dev/shm/mattc-controller-01_mod_wsgi_qmanager\n1:2:110369919\n```\n\nWe also hit this with Magnum just within a single service, as it needs to create multiple reply queues. So it would still be required with each container on a dedicated host.\n```\ndocker exec -it rabbitmq rabbitmqctl list_queues name type | grep magnum\nreply_mattc-controller-01:magnum-api:4  quorum\nreply_mattc-controller-01:magnum-api:2  quorum\nreply_mattc-controller-01:magnum-api:8  quorum\n\ncat /dev/shm/mattc-controller-01_magnum-api_qmanager \n1:10:110380369\n```","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2adf672d21a1613be1c20b0d60ac5efa9fc47e1e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c94d7c4e_9f25a85f","in_reply_to":"a944a237_d90ed032","updated":"2025-01-16 11:07:59.000000000","message":"Perhaps we wouldn\u0027t need this for all services, some do appear to just create one queue and re-use it, but it would need us to investigate how every single service uses oslo.messaging which is no small task","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c812210178b9aa7e8e5ff64ccbbb129c553e8944","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ef688c19_a6ce01df","in_reply_to":"c94d7c4e_9f25a85f","updated":"2025-01-17 11:53:28.000000000","message":"Ah, ok, that sounds reasonable, thx. Might be worth adding this explanation to the commit message, but not a blocker to me.","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f51d8eda0bb002fb72f840b761e5746ba33abd16","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"db5b8b34_b168ea04","updated":"2025-01-20 17:26:56.000000000","message":"I think we need a reno for this - it\u0027s fine if you add this in the queue manager reno - as in users are informed that enabling this mounts /dev/shm (may be some might not be interested due to some security concerns)","commit_id":"337b835122fc1f140d841fc3860de141fb60296b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"4a91d672e94a22dc63c7573a12b4cbaa23b86ed2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"587329e4_a0e6bf67","in_reply_to":"db5b8b34_b168ea04","updated":"2025-01-21 10:30:28.000000000","message":"Makes sense, I\u0027ve added it in the queue manager patch","commit_id":"337b835122fc1f140d841fc3860de141fb60296b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7631feed24d090f708ac7c368639a78454fff928","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d2b5efe0_9d11a12d","updated":"2025-01-28 23:27:29.000000000","message":"Approving as there is already +2 from Michal and I was actually working on this just on the beggining and Matt finished it.","commit_id":"3a8bfc0ace403e59c0c2073b3d8790cccdf84fa5"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"546a3c2740adc0e9367f978dafe6d88496726b53","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e858d96b_ca625224","updated":"2025-01-22 14:32:02.000000000","message":"Marking -1 because I\u0027ve discovered another issue with using this in containers. Where we run multiple services under wsgi, we get different services trying to use the same queue name (because they have the same process name). These fail to share the same file in shared memory because each service runs as a different user.\n\nFor example, cinder wrote to shared memory first, so nova fails to do so afterwards:\n```\n2025-01-22 13:44:23.591 42 ERROR nova.api.openstack.wsgi   File \"/var/lib/kolla/venv/lib64/python3.9/site-packages/oslo_messaging/_drivers/amqpdriver.py\", line 104, in read_from_shm\n2025-01-22 13:44:23.591 42 ERROR nova.api.openstack.wsgi     with open(self.file_name, \u0027w\u0027) as f:\n2025-01-22 13:44:23.591 42 ERROR nova.api.openstack.wsgi PermissionError: [Errno 13] Permission denied: \u0027/dev/shm/mattc-controller-01_mod_wsgi_qmanager\u0027\n```\n```\ndocker exec -it nova_api ls -lh /dev/shm | grep wsgi\n-rw-r--r--. 1 cinder    cinder    11 Jan 22 12:23 mattc-controller-01_mod_wsgi_qmanage\n```","commit_id":"3a8bfc0ace403e59c0c2073b3d8790cccdf84fa5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"93dd953cc8c84077552be76f8ffe0c3f155a29bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"49493394_7d6c9bf8","in_reply_to":"254af10d_cfe3cc5d","updated":"2025-01-24 18:18:03.000000000","message":"You are saying that you\u0027ve proposed a patch for override processname for wsgi servicess.. Your -1 is for patchset 7, then you reset to 0. So where is the patch ? Is it actually problem ?","commit_id":"3a8bfc0ace403e59c0c2073b3d8790cccdf84fa5"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"428e104f45f705803f25657bf37b867d678baf94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d04d3853_75c4f151","in_reply_to":"49493394_7d6c9bf8","updated":"2025-01-27 09:01:32.000000000","message":"There was a problem, but because it only happened when queue manager is enabled, I put the fix here instead: https://review.opendev.org/c/openstack/kolla-ansible/+/924623/11..13","commit_id":"3a8bfc0ace403e59c0c2073b3d8790cccdf84fa5"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"bc5aaf2f4da14d7e4d528a48ca54f27fc0b0c75c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"254af10d_cfe3cc5d","in_reply_to":"e858d96b_ca625224","updated":"2025-01-22 16:28:26.000000000","message":"I\u0027ve proposed a fix - overriding processname for wsgi services. Put this into the queue manager patch as it seemed more appropriate.","commit_id":"3a8bfc0ace403e59c0c2073b3d8790cccdf84fa5"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"627a846074914fb9116635442daf51444df63564","unresolved":true,"context_lines":[{"line_number":387,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":388,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":389,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":390,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 if om_enable_queue_manager | bool else \u0027\u0027 }}\""},{"line_number":391,"context_line":"  - \"libvirtd:/var/lib/libvirt\""},{"line_number":392,"context_line":"  - \"{{ nova_instance_datadir_volume }}:/var/lib/nova/\""},{"line_number":393,"context_line":"  - \"{% if enable_shared_var_lib_nova_mnt | bool %}/var/lib/nova/mnt:/var/lib/nova/mnt:shared{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"78717a39_23f52197","line":390,"updated":"2025-01-15 19:03:25.000000000","message":"shouldn\u0027t be needed since we already bindmount /dev above?\n\nalso libvirt doesn\u0027t run oslo.messaging?","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"91712c66a2a6388a3e25e0a8db5fbfc279b08663","unresolved":false,"context_lines":[{"line_number":387,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":388,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":389,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":390,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 if om_enable_queue_manager | bool else \u0027\u0027 }}\""},{"line_number":391,"context_line":"  - \"libvirtd:/var/lib/libvirt\""},{"line_number":392,"context_line":"  - \"{{ nova_instance_datadir_volume }}:/var/lib/nova/\""},{"line_number":393,"context_line":"  - \"{% if enable_shared_var_lib_nova_mnt | bool %}/var/lib/nova/mnt:/var/lib/nova/mnt:shared{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6778e248_b65757fc","line":390,"in_reply_to":"78717a39_23f52197","updated":"2025-01-16 15:22:14.000000000","message":"Done","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"627a846074914fb9116635442daf51444df63564","unresolved":true,"context_lines":[{"line_number":437,"context_line":"  - \"/run:/run{{ \u0027:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\""},{"line_number":438,"context_line":"  - \"/dev:/dev\""},{"line_number":439,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":440,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 if om_enable_queue_manager | bool else \u0027\u0027 }}\""},{"line_number":441,"context_line":"  - \"{% if enable_iscsid | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":442,"context_line":"  - \"{{ nova_libvirt_volume }}:/var/lib/libvirt\""},{"line_number":443,"context_line":"  - \"{{ nova_instance_datadir_volume }}:/var/lib/nova/\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9cd77cab_4ddaf3fc","line":440,"updated":"2025-01-15 19:03:25.000000000","message":"also not needed because of /dev mount?","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"91712c66a2a6388a3e25e0a8db5fbfc279b08663","unresolved":false,"context_lines":[{"line_number":437,"context_line":"  - \"/run:/run{{ \u0027:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\""},{"line_number":438,"context_line":"  - \"/dev:/dev\""},{"line_number":439,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":440,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 if om_enable_queue_manager | bool else \u0027\u0027 }}\""},{"line_number":441,"context_line":"  - \"{% if enable_iscsid | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":442,"context_line":"  - \"{{ nova_libvirt_volume }}:/var/lib/libvirt\""},{"line_number":443,"context_line":"  - \"{{ nova_instance_datadir_volume }}:/var/lib/nova/\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"037db95f_b18902e1","line":440,"in_reply_to":"9cd77cab_4ddaf3fc","updated":"2025-01-16 15:22:14.000000000","message":"Done","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"}],"ansible/roles/nova/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"627a846074914fb9116635442daf51444df63564","unresolved":true,"context_lines":[{"line_number":225,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":226,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":227,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":228,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 if om_enable_queue_manager | bool else \u0027\u0027 }}\""},{"line_number":229,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/nova:/dev-mode/nova\u0027 if nova_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"nova_extra_volumes: \"{{ default_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"37a1e969_83ffa4be","line":228,"updated":"2025-01-15 19:03:25.000000000","message":"I don\u0027t think bootstrapping uses oslo.messaging?","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"91712c66a2a6388a3e25e0a8db5fbfc279b08663","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":226,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":227,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":228,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 if om_enable_queue_manager | bool else \u0027\u0027 }}\""},{"line_number":229,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/nova:/dev-mode/nova\u0027 if nova_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"nova_extra_volumes: \"{{ default_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"54792ba6_cdf9e231","line":228,"in_reply_to":"37a1e969_83ffa4be","updated":"2025-01-16 15:22:14.000000000","message":"Indeed. I gave it a try without, it worked.","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"}],"ansible/roles/venus/defaults/main.yml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"cba394e432f8b49c90128ec7811910fca9a16ec2","unresolved":true,"context_lines":[{"line_number":90,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":91,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":92,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":93,"context_line":"  - \"/dev/shm:/dev/shm\""},{"line_number":94,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/venus:/dev-mode/venus\u0027 if venus_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":95,"context_line":"  - \"venus:/var/lib/venus/\""},{"line_number":96,"context_line":"venus_manager_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7811d0a3_eedab98d","line":93,"updated":"2024-12-11 13:48:43.000000000","message":"Does Venus actually use RabbitMQ? We don\u0027t set any of the [oslo_messaging_rabbit] config for it https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/venus/templates/venus.conf.j2","commit_id":"cb5adaccf23101c162be0bae4198bf1d24e1d06d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a38d097a4700b7333d9fa057cb27f6ac72ddf8a8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":91,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":92,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":93,"context_line":"  - \"/dev/shm:/dev/shm\""},{"line_number":94,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/venus:/dev-mode/venus\u0027 if venus_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":95,"context_line":"  - \"venus:/var/lib/venus/\""},{"line_number":96,"context_line":"venus_manager_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5e0d4648_52b7db48","line":93,"in_reply_to":"7811d0a3_eedab98d","updated":"2024-12-11 14:25:57.000000000","message":"Venus has transport_url in default as per https://opendev.org/openstack/venus/src/branch/master/etc/venus/venus.conf and we set it in https://github.com/openstack/kolla-ansible/blob/4ac270174070b0b42e32cc005ff04d482d7650d5/ansible/roles/venus/templates/venus.conf.j2#L16 so it\u0027s ok.\n\nFor ironic i\u0027ve added /dev/shm mapping for ironic-api as conductor already maps whole /dev","commit_id":"cb5adaccf23101c162be0bae4198bf1d24e1d06d"}],"ansible/roles/zun/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"627a846074914fb9116635442daf51444df63564","unresolved":true,"context_lines":[{"line_number":190,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":191,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":192,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":193,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 if om_enable_queue_manager | bool else \u0027\u0027 }}\""},{"line_number":194,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/zun:/dev-mode/zun\u0027 if zun_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":195,"context_line":"  - \"/run:/run{{ \u0027:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\""},{"line_number":196,"context_line":"  - \"/usr/lib/docker:/usr/lib/docker\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"66a4fba9_5b29a65d","line":193,"updated":"2025-01-15 19:03:25.000000000","message":"not needed with /dev mount below?","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"91712c66a2a6388a3e25e0a8db5fbfc279b08663","unresolved":false,"context_lines":[{"line_number":190,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":191,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":192,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":193,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 if om_enable_queue_manager | bool else \u0027\u0027 }}\""},{"line_number":194,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/zun:/dev-mode/zun\u0027 if zun_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":195,"context_line":"  - \"/run:/run{{ \u0027:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\""},{"line_number":196,"context_line":"  - \"/usr/lib/docker:/usr/lib/docker\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0b8ef17e_c8550be6","line":193,"in_reply_to":"66a4fba9_5b29a65d","updated":"2025-01-16 15:22:14.000000000","message":"True, I\u0027ve removed in where /dev is already mounted.","commit_id":"e009b37bcc34e7608523b459d8781c158a8f0717"}]}