)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6482d7c3946355f38112e4b8d8821c1c89c561d8","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix indentation in haproxy config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit [1] introduced a bug into kolla-ansible"},{"line_number":10,"context_line":"where there is incorrect indentation in the haproxy"},{"line_number":11,"context_line":"configuration file. This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/kolla-ansible/commit/b13fa5a92cb6d768c5839bd11667e2ca72a7cd2f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"59a31fe4_18f265aa","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":2},"updated":"2024-09-10 07:42:44.000000000","message":"super nit: there is no \"incorrect\" haproxy indentation, as indentation is ignored by the haproxy config parser, so there is neither \"correct\" nor \"incorrect\" indentation possible, as the parser just doesn\u0027t care.","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7a079d834ca023afde4065815b7315a8a00ba6bd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix indentation in haproxy config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit [1] introduced a bug into kolla-ansible"},{"line_number":10,"context_line":"where there is incorrect indentation in the haproxy"},{"line_number":11,"context_line":"configuration file. This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/kolla-ansible/commit/b13fa5a92cb6d768c5839bd11667e2ca72a7cd2f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dce25d1a_b3aa348d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":2},"in_reply_to":"59a31fe4_18f265aa","updated":"2024-09-11 18:06:39.000000000","message":"Done","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c5355a3521e9056d5b33de3417948a32ef3d90d9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"where there is incorrect indentation in the haproxy"},{"line_number":11,"context_line":"configuration file. This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/kolla-ansible/commit/b13fa5a92cb6d768c5839bd11667e2ca72a7cd2f"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #2080034"},{"line_number":16,"context_line":"Change-Id: I3375e303bc358fc79d1fa2e219e6ec1dba7a38ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2462a263_005ac3e5","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2024-09-10 07:33:25.000000000","message":"nit: please use our own infrastructure for links:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/915403\nor\nhttps://opendev.org/openstack/kolla-ansible/commit/b13fa5a92cb6d768c5839bd11667e2ca72a7cd2f","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7a079d834ca023afde4065815b7315a8a00ba6bd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"where there is incorrect indentation in the haproxy"},{"line_number":11,"context_line":"configuration file. This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/kolla-ansible/commit/b13fa5a92cb6d768c5839bd11667e2ca72a7cd2f"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #2080034"},{"line_number":16,"context_line":"Change-Id: I3375e303bc358fc79d1fa2e219e6ec1dba7a38ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6f265861_871440ff","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"in_reply_to":"2462a263_005ac3e5","updated":"2024-09-11 18:06:39.000000000","message":"Done","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d5dc82f782399e0bfaa74aa9f14bffddec2cef83","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78be0c2a_91d5a803","updated":"2024-09-09 18:35:00.000000000","message":"How is that possible we don\u0027t see it in CI?","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2f9f4c64f9ced339130cfdc7ab76b059b8cc3a5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7901a4a5_6eae4ed4","updated":"2024-09-10 10:01:25.000000000","message":"So should I drop this patch or will we just merge ?","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"60282db290f01138a566383f21ad9422de7d31eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"033e5583_dcc69dcf","updated":"2024-09-10 10:04:51.000000000","message":"and 1x +2, Thanks Michal","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"edc85dc849e4470491de712b3592c5ea6755da89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19e94028_3a1e40b4","updated":"2024-09-10 07:26:18.000000000","message":"inspected https://zuul.opendev.org/t/openstack/build/49fb42fbe8d642b5aa2e96a516c6cc9c/log/primary/logs/kolla_configs/haproxy/haproxy.cfg which looks correct now, thanks for catching this!","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c5355a3521e9056d5b33de3417948a32ef3d90d9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90243cc8_c4d8597e","updated":"2024-09-10 07:33:25.000000000","message":"well reading up on this, I\u0027m not sure this is a \"bug\" per se.\nthe haproxy config file is actually not sensitive to indentation afaik, so it\u0027s only a cosmetic change.\nI still agree it should be fixed, of course, as it\u0027s easier to read with proper indentation.\n\nbackport voting -1 because this didn\u0027t hit any stable branches.","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"406c3006608aad1bdb21f1f881374b2d52d58fae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f694f5e7_00840c41","in_reply_to":"0ec6b608_e72e5419","updated":"2024-09-10 10:04:35.000000000","message":"Yeah, I can see already 2x +1 :)","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d2543d55137bb3aab913a15758bfa4b2cb5fb370","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd86c31c_263ef672","in_reply_to":"2e40392d_e4394d4a","updated":"2024-09-09 19:17:38.000000000","message":"Well, good thing haproxy works with such indentation ;-)","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"37b68cf826783d5ecfae04054f6fe6249a8d7ff4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be455f09_ab4b583b","in_reply_to":"627f7d48_f8b9623e","updated":"2024-09-09 19:19:30.000000000","message":"Done","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d105021a0905cad0ad671f1a168f086c327b027c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e40392d_e4394d4a","in_reply_to":"78be0c2a_91d5a803","updated":"2024-09-09 18:54:36.000000000","message":"of course we see 😊, just check it here https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_144/915403/13/gate/kolla-ansible-debian/144de2c/primary/logs/kolla_configs/haproxy/haproxy.cfg\n\nreview: https://review.opendev.org/c/openstack/kolla-ansible/+/915403\n\nit looks like nobody checked how it is actually rendered in config file...","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f276093befdd417fd7855f4838be77721b0de7b6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ec6b608_e72e5419","in_reply_to":"7901a4a5_6eae4ed4","updated":"2024-09-10 10:03:26.000000000","message":"It\u0027s not a bakery, it\u0027s an open source project - let people review it?","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e55d37a864171548b8cd2db62d6f93d5322994ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cfcdc941_1a14e092","in_reply_to":"90243cc8_c4d8597e","updated":"2024-09-10 07:36:51.000000000","message":"so if anyone is curious or unsure about this, to quote the haproxy docs[1]:\n\n\u003e Another important point is that according to rules 2 and 3 above, empty lines,\nspaces, tabs, and comments following and unprotected \"#\" character are not part\nof the configuration as they are just used as delimiters.\n\n\u003e This implies that the\nfollowing configurations are strictly equivalent:\n\n\n```\n         global#this is the global section\n     daemon#daemonize\n         frontend         foo\n     mode             http   # or tcp\n\nand:\n\n     global\n         daemon\n\n     # this is the public web frontend\n     frontend foo\n         mode http\n```\n\n[1]: https://www.haproxy.com/documentation/haproxy-configuration-manual/latest/#2.1","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"edc85dc849e4470491de712b3592c5ea6755da89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6339129a_33f76c0f","in_reply_to":"be455f09_ab4b583b","updated":"2024-09-10 07:26:18.000000000","message":"\u003e it looks like nobody checked how it is actually rendered in config file...\n\nI actually thought I did check, when writing that code, seems I didn\u0027t look close enough, thanks for catching this!","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e610cbf4cfe55497e13e6f7b816c8504a5404df5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"627f7d48_f8b9623e","in_reply_to":"dd86c31c_263ef672","updated":"2024-09-09 19:18:53.000000000","message":"yeah, but still","commit_id":"757319f0c64b14521918b742cf90f92fe710a91a"}]}