)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"198317df50c2e4014a378d19f599ca013287b888","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"32f71ea1_808e2e63","updated":"2024-09-13 07:15:16.000000000","message":"LGTM, but shouldn\u0027t we also use a supported ansible.posix version? ;-)","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4200b102b4b8d22b4aa281f2305e6ed3652b3d86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a8bb44c7_aabf2f02","updated":"2024-09-13 14:39:16.000000000","message":"backport to unblock CI on stable branches.","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8cfbab45261604da7c3a57e9ce78354557f576ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0b7673b3_4123436c","updated":"2024-09-13 13:47:54.000000000","message":"not sure about backport voting on this one. separating stdout and stderr could break existing applications relying on this to be unified, but it could be argued that this is an implementation detail of kolla-toolbox?","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c5674c4b9ab69b9aff0f73c4211307d9f273b05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a77dda5b_6917101c","updated":"2024-09-13 12:23:28.000000000","message":"should this patch also fix this in kolla_docker_worker.py?\nhttps://github.com/openstack/kolla-ansible/blob/753a7e1a127d5f8a1118f07d19207d126ef758a5/ansible/module_utils/kolla_docker_worker.py#L153","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"649e48ec9ea0db576eae1d109d960f24f6791a18","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64038537_6356bbc4","in_reply_to":"102213e1_c93182cb","updated":"2024-09-13 08:02:57.000000000","message":"https://review.opendev.org/c/openstack/kolla/+/929219","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1cc2df084ea0b2f60a9154c53766ac97ef0ebf83","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"102213e1_c93182cb","in_reply_to":"32f71ea1_808e2e63","updated":"2024-09-13 07:48:44.000000000","message":"I just found what suddenly caused this to appear: release of ansible.posix 1.6.0 dropped support for ansible-core\u003c\u003d2.14.\n\nI will propose another change.","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e10999dfa2b5454a47b4697f9d78a51457e45c57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56ef492a_0155a97b","in_reply_to":"64038537_6356bbc4","updated":"2024-09-13 13:19:20.000000000","message":"Done","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"78d857166f7be1be98c106d30a14c49e34c85ce3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b4d0aaa4_1798e420","in_reply_to":"a77dda5b_6917101c","updated":"2024-09-13 12:38:13.000000000","message":"I don\u0027t think it is useful there, because the output is only used to be displayed in case of error (exit code not in [0, 1, 137]). It doesn\u0027t matter if stdout and stderr are mixed.","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"}],"ansible/library/kolla_toolbox.py":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4de97b236aef0cfa1d358eeae27015b47f0a9493","unresolved":true,"context_lines":[{"line_number":164,"context_line":"                             environment\u003denvironment, **kwargs)"},{"line_number":165,"context_line":"    json_output, error \u003d client.exec_start(job, demux\u003dTrue)"},{"line_number":166,"context_line":"    if error:"},{"line_number":167,"context_line":"        module.log(msg\u003d\u0027Inner module stderr: %s\u0027 % error)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    try:"},{"line_number":170,"context_line":"        output \u003d json.loads(json_output)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9e10e1c7_8e2337cb","line":167,"range":{"start_line":167,"start_character":24,"end_line":167,"end_character":29},"updated":"2024-09-12 20:28:52.000000000","message":"Extra (unneeded) word IMHO","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c0b3f6216c5e3f7a612aabb744597d760e1386ff","unresolved":true,"context_lines":[{"line_number":164,"context_line":"                             environment\u003denvironment, **kwargs)"},{"line_number":165,"context_line":"    json_output, error \u003d client.exec_start(job, demux\u003dTrue)"},{"line_number":166,"context_line":"    if error:"},{"line_number":167,"context_line":"        module.log(msg\u003d\u0027Inner module stderr: %s\u0027 % error)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    try:"},{"line_number":170,"context_line":"        output \u003d json.loads(json_output)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7b33317_6f0b52f5","line":167,"range":{"start_line":167,"start_character":24,"end_line":167,"end_character":29},"in_reply_to":"9e10e1c7_8e2337cb","updated":"2024-09-12 21:37:59.000000000","message":"If you look at the other message used in fail_json below, this is the terminology currently used.\n\nThis is to differentiate between the kolla_toolbox module and the module called by kolla_toolbox.","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"584e9bbc983b325176e7c0a85a7df5c734e99028","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                             environment\u003denvironment, **kwargs)"},{"line_number":165,"context_line":"    json_output, error \u003d client.exec_start(job, demux\u003dTrue)"},{"line_number":166,"context_line":"    if error:"},{"line_number":167,"context_line":"        module.log(msg\u003d\u0027Inner module stderr: %s\u0027 % error)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    try:"},{"line_number":170,"context_line":"        output \u003d json.loads(json_output)"}],"source_content_type":"text/x-python","patch_set":4,"id":"aa59540c_dcbb411a","line":167,"range":{"start_line":167,"start_character":24,"end_line":167,"end_character":29},"in_reply_to":"f7b33317_6f0b52f5","updated":"2024-09-12 22:02:36.000000000","message":"don\u0027t see any difference. anyway lgtm.","commit_id":"540766203884ab072b65fd1d14eaa75e60696cab"}]}