)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37013,"name":"Ivan Vnučko","display_name":"Ivan Vnucko","email":"ivan@vnucko.com","username":"ivnucko"},"change_message_id":"c64dc5b784e37bb7df38abf3083ebe715d4789dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"512c4484_a1480487","updated":"2024-09-19 08:42:50.000000000","message":"There is a small error in this patch, which non-voting zuul tests showed, I will fix it shortly.","commit_id":"8c5f0a8ad79216c7faa2f1b97dd40b2a4c16a2ee"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e59005751aa6ae00ceb7d5c2ecf4628a666b48c4","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"##################"},{"line_number":1063,"context_line":"# Whether nova and masakari instancemonitor should communicate with libvirt"},{"line_number":1064,"context_line":"# encrypted"},{"line_number":1065,"context_line":"libvirt_tls: false"},{"line_number":1066,"context_line":"# Whether libvirt TLS certificates should be copied from control"},{"line_number":1067,"context_line":"libvirt_tls_manage_certs: true"},{"line_number":1068,"context_line":"# Whether to enable libvirt SASL authentication."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0fd82364_d19dcc22","line":1065,"range":{"start_line":1065,"start_character":13,"end_line":1065,"end_character":18},"updated":"2024-12-16 16:02:04.000000000","message":"\"no\"\nas other settings in this document","commit_id":"92804f328cec091f32bde00d1f86634700dbe12a"},{"author":{"_account_id":37013,"name":"Ivan Vnučko","display_name":"Ivan Vnucko","email":"ivan@vnucko.com","username":"ivnucko"},"change_message_id":"b636577c671b069eef1cdea1e33a1b15cd53cd04","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"##################"},{"line_number":1063,"context_line":"# Whether nova and masakari instancemonitor should communicate with libvirt"},{"line_number":1064,"context_line":"# encrypted"},{"line_number":1065,"context_line":"libvirt_tls: false"},{"line_number":1066,"context_line":"# Whether libvirt TLS certificates should be copied from control"},{"line_number":1067,"context_line":"libvirt_tls_manage_certs: true"},{"line_number":1068,"context_line":"# Whether to enable libvirt SASL authentication."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"582956e5_a4a9bb7d","line":1065,"range":{"start_line":1065,"start_character":13,"end_line":1065,"end_character":18},"in_reply_to":"0fd82364_d19dcc22","updated":"2024-12-19 15:53:58.000000000","message":"Done","commit_id":"92804f328cec091f32bde00d1f86634700dbe12a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e59005751aa6ae00ceb7d5c2ecf4628a666b48c4","unresolved":true,"context_lines":[{"line_number":1064,"context_line":"# encrypted"},{"line_number":1065,"context_line":"libvirt_tls: false"},{"line_number":1066,"context_line":"# Whether libvirt TLS certificates should be copied from control"},{"line_number":1067,"context_line":"libvirt_tls_manage_certs: true"},{"line_number":1068,"context_line":"# Whether to enable libvirt SASL authentication."},{"line_number":1069,"context_line":"libvirt_enable_sasl: true"},{"line_number":1070,"context_line":"# Username for libvirt SASL."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"abbd17eb_4c1e1d19","line":1067,"range":{"start_line":1067,"start_character":26,"end_line":1067,"end_character":30},"updated":"2024-12-16 16:02:04.000000000","message":"\"yes\"\nas other settings in this document","commit_id":"92804f328cec091f32bde00d1f86634700dbe12a"},{"author":{"_account_id":37013,"name":"Ivan Vnučko","display_name":"Ivan Vnucko","email":"ivan@vnucko.com","username":"ivnucko"},"change_message_id":"b636577c671b069eef1cdea1e33a1b15cd53cd04","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"# encrypted"},{"line_number":1065,"context_line":"libvirt_tls: false"},{"line_number":1066,"context_line":"# Whether libvirt TLS certificates should be copied from control"},{"line_number":1067,"context_line":"libvirt_tls_manage_certs: true"},{"line_number":1068,"context_line":"# Whether to enable libvirt SASL authentication."},{"line_number":1069,"context_line":"libvirt_enable_sasl: true"},{"line_number":1070,"context_line":"# Username for libvirt SASL."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1650ff0a_8f9bada4","line":1067,"range":{"start_line":1067,"start_character":26,"end_line":1067,"end_character":30},"in_reply_to":"abbd17eb_4c1e1d19","updated":"2024-12-19 15:53:58.000000000","message":"Done","commit_id":"92804f328cec091f32bde00d1f86634700dbe12a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e59005751aa6ae00ceb7d5c2ecf4628a666b48c4","unresolved":true,"context_lines":[{"line_number":1066,"context_line":"# Whether libvirt TLS certificates should be copied from control"},{"line_number":1067,"context_line":"libvirt_tls_manage_certs: true"},{"line_number":1068,"context_line":"# Whether to enable libvirt SASL authentication."},{"line_number":1069,"context_line":"libvirt_enable_sasl: true"},{"line_number":1070,"context_line":"# Username for libvirt SASL."},{"line_number":1071,"context_line":"libvirt_sasl_authname: \"nova\""},{"line_number":1072,"context_line":"# List of enabled libvirt SASL authentication mechanisms."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c71242d0_311e8ad1","line":1069,"range":{"start_line":1069,"start_character":21,"end_line":1069,"end_character":25},"updated":"2024-12-16 16:02:04.000000000","message":"\"yes\"\nas other settings in this document","commit_id":"92804f328cec091f32bde00d1f86634700dbe12a"},{"author":{"_account_id":37013,"name":"Ivan Vnučko","display_name":"Ivan Vnucko","email":"ivan@vnucko.com","username":"ivnucko"},"change_message_id":"b636577c671b069eef1cdea1e33a1b15cd53cd04","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"# Whether libvirt TLS certificates should be copied from control"},{"line_number":1067,"context_line":"libvirt_tls_manage_certs: true"},{"line_number":1068,"context_line":"# Whether to enable libvirt SASL authentication."},{"line_number":1069,"context_line":"libvirt_enable_sasl: true"},{"line_number":1070,"context_line":"# Username for libvirt SASL."},{"line_number":1071,"context_line":"libvirt_sasl_authname: \"nova\""},{"line_number":1072,"context_line":"# List of enabled libvirt SASL authentication mechanisms."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"529bad88_96780d8f","line":1069,"range":{"start_line":1069,"start_character":21,"end_line":1069,"end_character":25},"in_reply_to":"c71242d0_311e8ad1","updated":"2024-12-19 15:53:58.000000000","message":"Done","commit_id":"92804f328cec091f32bde00d1f86634700dbe12a"}],"ansible/roles/masakari/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"91a2c4cb67b8bc0894893ebe777fab3eae342b86","unresolved":true,"context_lines":[{"line_number":185,"context_line":"libvirt_sasl_mech_list:"},{"line_number":186,"context_line":"  - \"{{ \u0027SCRAM-SHA-256\u0027 if libvirt_tls | bool else \u0027DIGEST-MD5\u0027 }}\""},{"line_number":187,"context_line":"# libvirt TLS certificates are using hostnames, not IPs"},{"line_number":188,"context_line":"libvirt_hostname: \"{{ ansible_facts.nodename }}\""},{"line_number":189,"context_line":"libvirt_tls: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a678f94f_becca29f","line":188,"updated":"2024-09-18 10:10:54.000000000","message":"Can we prefix those variables with masakari_? I know the previous ones don\u0027t have it, but we shouldn\u0027t continue bad practice...","commit_id":"8c5f0a8ad79216c7faa2f1b97dd40b2a4c16a2ee"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f0b91cb4734c5aa08c4727f611ec6059fde40930","unresolved":false,"context_lines":[{"line_number":185,"context_line":"libvirt_sasl_mech_list:"},{"line_number":186,"context_line":"  - \"{{ \u0027SCRAM-SHA-256\u0027 if libvirt_tls | bool else \u0027DIGEST-MD5\u0027 }}\""},{"line_number":187,"context_line":"# libvirt TLS certificates are using hostnames, not IPs"},{"line_number":188,"context_line":"libvirt_hostname: \"{{ ansible_facts.nodename }}\""},{"line_number":189,"context_line":"libvirt_tls: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c0b2b819_5c40a751","line":188,"in_reply_to":"6b72b861_afff9e47","updated":"2024-09-18 11:33:47.000000000","message":"Well, if those are shared - then most probably best those would be moved to group_vars/all - that\u0027s what we always did I guess.\nBut since it\u0027s a bug fix - let\u0027s not induce any mayhem - let it stay as it is for now...","commit_id":"8c5f0a8ad79216c7faa2f1b97dd40b2a4c16a2ee"},{"author":{"_account_id":37013,"name":"Ivan Vnučko","display_name":"Ivan Vnucko","email":"ivan@vnucko.com","username":"ivnucko"},"change_message_id":"27b7eca58de834b113bf06356f09131e138c68ea","unresolved":true,"context_lines":[{"line_number":185,"context_line":"libvirt_sasl_mech_list:"},{"line_number":186,"context_line":"  - \"{{ \u0027SCRAM-SHA-256\u0027 if libvirt_tls | bool else \u0027DIGEST-MD5\u0027 }}\""},{"line_number":187,"context_line":"# libvirt TLS certificates are using hostnames, not IPs"},{"line_number":188,"context_line":"libvirt_hostname: \"{{ ansible_facts.nodename }}\""},{"line_number":189,"context_line":"libvirt_tls: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6b72b861_afff9e47","line":188,"in_reply_to":"a678f94f_becca29f","updated":"2024-09-18 11:12:04.000000000","message":"To clarify \"those variables\" - libvirt_hostname is local for masakari role, so there the prefix is ok, the other libvirt_ variables are shared with nova role, libvirt_tls, and libvirt_enable_sasl being a system wide flags. Do you recommend the prefix only for libvirt_hostname or others too?","commit_id":"8c5f0a8ad79216c7faa2f1b97dd40b2a4c16a2ee"}]}