)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"13e766eda032945cef36b620c004ed2ce6147138","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e627430_68c472f4","updated":"2024-09-19 15:49:46.000000000","message":"Marked WIP: this fails on initial deploy because the rabbitmq container doesn\u0027t exist yet.","commit_id":"7f73e69c2972e9fcd260efc3e2c90b0967313e17"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf22adf8332df31481f607ac4fd0032a9ee69184","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"35ce58fa_08753aad","updated":"2024-10-24 16:09:55.000000000","message":"Let\u0027s get over with it for the sake of release.","commit_id":"f5ad7829c3a327d367be1ce807d2867f254fab2a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e4cd5cafe61f9eda316ee47e41e89dc159756662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3791d1aa_3d84eeb2","updated":"2024-10-30 11:30:52.000000000","message":"recheck\n\nUnrelated CRITICAL log in Neutron?","commit_id":"f5ad7829c3a327d367be1ce807d2867f254fab2a"}],"ansible/roles/rabbitmq/tasks/version-check.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c23e30cc4f7cd04e54272143427ddb7fd339ef55","unresolved":true,"context_lines":[{"line_number":62,"context_line":"          If you\u0027re absolutely certain you want to do this, please skip the tag `rabbitmq-version-check`."},{"line_number":63,"context_line":"          Otherwise, see these docs for how to pin the version of RabbitMQ:"},{"line_number":64,"context_line":"          https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html#rabbitmq-versions"},{"line_number":65,"context_line":"            "},{"line_number":66,"context_line":"  delegate_to: \"{{ groups[role_rabbitmq_groups] | first }}\""},{"line_number":67,"context_line":"  run_once: true"},{"line_number":68,"context_line":"  tags: rabbitmq-version-check"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b67b5f01_8a53feb2","line":65,"updated":"2024-09-19 19:09:06.000000000","message":"trailing space","commit_id":"7f73e69c2972e9fcd260efc3e2c90b0967313e17"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"3027b0d1c3bc1c7743c2859b6a541c9b2f4bab39","unresolved":false,"context_lines":[{"line_number":62,"context_line":"          If you\u0027re absolutely certain you want to do this, please skip the tag `rabbitmq-version-check`."},{"line_number":63,"context_line":"          Otherwise, see these docs for how to pin the version of RabbitMQ:"},{"line_number":64,"context_line":"          https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html#rabbitmq-versions"},{"line_number":65,"context_line":"            "},{"line_number":66,"context_line":"  delegate_to: \"{{ groups[role_rabbitmq_groups] | first }}\""},{"line_number":67,"context_line":"  run_once: true"},{"line_number":68,"context_line":"  tags: rabbitmq-version-check"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a4700a8_936256f9","line":65,"in_reply_to":"b67b5f01_8a53feb2","updated":"2024-09-30 13:01:08.000000000","message":"Done","commit_id":"7f73e69c2972e9fcd260efc3e2c90b0967313e17"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"162b10b0432eebebfe94bc7cab67221b0dd275ae","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        # upgrade_version \u003d 3.12"},{"line_number":44,"context_line":"        - name: Check if running RabbitMQ is at most one version behind"},{"line_number":45,"context_line":"          vars:"},{"line_number":46,"context_line":"            current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^[0-9]+\u0027) }}\""},{"line_number":47,"context_line":"            current_version_minor: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":48,"context_line":"            current_version: \"{{ rabbitmq_version_current.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":49,"context_line":"            new_version_major: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027^[0-9]+\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c20762a6_9f728faa","line":46,"updated":"2024-10-22 15:12:34.000000000","message":"Tried using https://docs.ansible.com/ansible/latest/collections/ansible/builtin/version_test.html here?","commit_id":"f5ad7829c3a327d367be1ce807d2867f254fab2a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"564a0aa69cfed6a6f430e9a177c49d79f0300532","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # upgrade_version \u003d 3.12"},{"line_number":44,"context_line":"        - name: Check if running RabbitMQ is at most one version behind"},{"line_number":45,"context_line":"          vars:"},{"line_number":46,"context_line":"            current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^[0-9]+\u0027) }}\""},{"line_number":47,"context_line":"            current_version_minor: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":48,"context_line":"            current_version: \"{{ rabbitmq_version_current.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":49,"context_line":"            new_version_major: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027^[0-9]+\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5219755f_f52247c5","line":46,"in_reply_to":"82f5d9da_6f749080","updated":"2024-10-23 08:31:19.000000000","message":"Ah right.","commit_id":"f5ad7829c3a327d367be1ce807d2867f254fab2a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a8c42a5a3ab83d4853ecd0f2a8aa69c0718986ee","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # upgrade_version \u003d 3.12"},{"line_number":44,"context_line":"        - name: Check if running RabbitMQ is at most one version behind"},{"line_number":45,"context_line":"          vars:"},{"line_number":46,"context_line":"            current_version_major: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027^[0-9]+\u0027) }}\""},{"line_number":47,"context_line":"            current_version_minor: \"{{ rabbitmq_version_current.stdout | regex_search(\u0027(?\u003c\u003d.)[^.].\u0027) }}\""},{"line_number":48,"context_line":"            current_version: \"{{ rabbitmq_version_current.stdout | regex_replace(\u0027.[^.]+$\u0027, \u0027\u0027) }}\""},{"line_number":49,"context_line":"            new_version_major: \"{{ rabbitmq_version_new.stdout | regex_search(\u0027^[0-9]+\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"82f5d9da_6f749080","line":46,"in_reply_to":"c20762a6_9f728faa","updated":"2024-10-23 08:29:44.000000000","message":"Yeah, we discussed this on the original patch: https://review.opendev.org/c/openstack/kolla-ansible/+/926146/comment/5e7bb6f6_d4aa298d/\n\nThe issue is we need to check if the current rabbit is exactly one version behind, rather than just less then the new version.","commit_id":"f5ad7829c3a327d367be1ce807d2867f254fab2a"}],"releasenotes/notes/rabbitmq-catch-downgrade-1005c7475a97bf19.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c23e30cc4f7cd04e54272143427ddb7fd339ef55","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a check to stop deploying/upgrading the RabbitMQ containers if it"},{"line_number":5,"context_line":"    will result indowngrading the version of RabbitMQ running."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"beb5d12d_7986ef03","line":5,"updated":"2024-09-19 19:09:06.000000000","message":"missing space","commit_id":"7f73e69c2972e9fcd260efc3e2c90b0967313e17"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"3027b0d1c3bc1c7743c2859b6a541c9b2f4bab39","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a check to stop deploying/upgrading the RabbitMQ containers if it"},{"line_number":5,"context_line":"    will result indowngrading the version of RabbitMQ running."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"59d78540_24b279ff","line":5,"in_reply_to":"beb5d12d_7986ef03","updated":"2024-09-30 13:01:08.000000000","message":"Done","commit_id":"7f73e69c2972e9fcd260efc3e2c90b0967313e17"}]}
