)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80b3971996fb1f28bcbcc8541df037d75e64314a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"efb97d9f_35a9ee6d","updated":"2024-11-15 13:13:25.000000000","message":"thx","commit_id":"0fce4f0f8c75c9d231af28e4f6bff0bf4013e0ad"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"87404d5547d512bf0a1b4df059fb44f5ae3fbc33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2ca87b76_02be3cb6","updated":"2024-11-15 15:10:10.000000000","message":"backport to stable/2024.2 and stable/2024.1","commit_id":"e0c095fd7dc3467a487888809690405f131e6f8b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8529f7e3d893bc2afa29646cae0525f080efd7fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa1a7610_def05f97","updated":"2024-11-15 13:37:57.000000000","message":"is this needed to be backported as a bugfix? I\u0027m a bit worried about the possible impact on upgrades. is 2024.2 enough, then?","commit_id":"e0c095fd7dc3467a487888809690405f131e6f8b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6589277fa9e557e138e3a511db2e71cf899e78ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"481c9267_386571d1","updated":"2024-11-15 20:50:57.000000000","message":"recheck grandparent failed","commit_id":"e0c095fd7dc3467a487888809690405f131e6f8b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"751125a374d2450f24ec32c9d0be9f78410bfc8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f095cbe_8aef7f90","updated":"2024-11-16 06:02:40.000000000","message":"recheck parent failed","commit_id":"e0c095fd7dc3467a487888809690405f131e6f8b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5688a790d24f1b978d4fb620fb742a876bedfd39","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5bb2d6fd_1e8b106d","in_reply_to":"fa1a7610_def05f97","updated":"2024-11-15 13:48:31.000000000","message":"We do need to backport this, Ironic changed the policy for the secure RBAC stuff in 2024.1","commit_id":"e0c095fd7dc3467a487888809690405f131e6f8b"}],"ansible/roles/ironic/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2d5dec7f257936888441ba8b517d6735a019cb5","unresolved":true,"context_lines":[{"line_number":370,"context_line":"    role: \"service\""},{"line_number":371,"context_line":"  - project: \"service\""},{"line_number":372,"context_line":"    user: \"{{ ironic_inspector_keystone_user }}\""},{"line_number":373,"context_line":"    role: \"service\""},{"line_number":374,"context_line":"  - user: \"{{ ironic_inspector_keystone_user }}\""},{"line_number":375,"context_line":"    role: \"service\""},{"line_number":376,"context_line":"    system: \"all\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6b475aa8_cd926932","line":373,"updated":"2024-11-15 12:09:49.000000000","message":"Can\u0027t we then drop this assignment? How about cleaning up existing role assignments on upgrade? Could be done in a follow-up, though.","commit_id":"ce4818ff3b23c5640b05f6b75daeb86b82c739f6"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"efe3aca4570f1f352a31a6848f5a1b88051a5d6e","unresolved":false,"context_lines":[{"line_number":370,"context_line":"    role: \"service\""},{"line_number":371,"context_line":"  - project: \"service\""},{"line_number":372,"context_line":"    user: \"{{ ironic_inspector_keystone_user }}\""},{"line_number":373,"context_line":"    role: \"service\""},{"line_number":374,"context_line":"  - user: \"{{ ironic_inspector_keystone_user }}\""},{"line_number":375,"context_line":"    role: \"service\""},{"line_number":376,"context_line":"    system: \"all\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f272a18a_73cf0f95","line":373,"in_reply_to":"6b475aa8_cd926932","updated":"2024-11-15 12:59:36.000000000","message":"Yes, I reckon we can drop this. I\u0027ll leave it for the follow-up patch though, so behaviour doesn\u0027t differ between new and existing deployments in the meantime.","commit_id":"ce4818ff3b23c5640b05f6b75daeb86b82c739f6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2d5dec7f257936888441ba8b517d6735a019cb5","unresolved":true,"context_lines":[{"line_number":373,"context_line":"    role: \"service\""},{"line_number":374,"context_line":"  - user: \"{{ ironic_inspector_keystone_user }}\""},{"line_number":375,"context_line":"    role: \"service\""},{"line_number":376,"context_line":"    system: \"all\""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f644489_41d2f945","line":376,"updated":"2024-11-15 12:09:49.000000000","message":"nit: to keep the pattern similar to the other role assignments above, the order should be system/user/role.\n\nalso no need to add an extra empty line","commit_id":"ce4818ff3b23c5640b05f6b75daeb86b82c739f6"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"efe3aca4570f1f352a31a6848f5a1b88051a5d6e","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    role: \"service\""},{"line_number":374,"context_line":"  - user: \"{{ ironic_inspector_keystone_user }}\""},{"line_number":375,"context_line":"    role: \"service\""},{"line_number":376,"context_line":"    system: \"all\""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0f69f31e_679e519b","line":376,"in_reply_to":"3f644489_41d2f945","updated":"2024-11-15 12:59:36.000000000","message":"Done","commit_id":"ce4818ff3b23c5640b05f6b75daeb86b82c739f6"}],"ansible/roles/ironic/templates/ironic-inspector.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6b872313ae0fd534e6b6286b328c12ab0d842832","unresolved":true,"context_lines":[{"line_number":31,"context_line":"auth_type \u003d password"},{"line_number":32,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":33,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":34,"context_line":"project_name \u003d service"},{"line_number":35,"context_line":"username \u003d {{ ironic_inspector_keystone_user }}"},{"line_number":36,"context_line":"password \u003d {{ ironic_inspector_keystone_password }}"},{"line_number":37,"context_line":"valid_interfaces \u003d internal"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"96d85599_76215e39","side":"PARENT","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":2},"updated":"2024-11-15 13:11:03.000000000","message":"this is not mentioned in the commit message, why is this removed?","commit_id":"2f124f8e9b5d0c74638cd272c8ecb7d2144ce9eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"20caa39bbdac4e6db732fefbd98577ff30fba0cc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"auth_type \u003d password"},{"line_number":32,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":33,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":34,"context_line":"project_name \u003d service"},{"line_number":35,"context_line":"username \u003d {{ ironic_inspector_keystone_user }}"},{"line_number":36,"context_line":"password \u003d {{ ironic_inspector_keystone_password }}"},{"line_number":37,"context_line":"valid_interfaces \u003d internal"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"f26000a4_1bbcdb1e","side":"PARENT","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":2},"in_reply_to":"96d85599_76215e39","updated":"2024-11-15 13:15:03.000000000","message":"You can only have either system scope or project scope, these cannot be combined","commit_id":"2f124f8e9b5d0c74638cd272c8ecb7d2144ce9eb"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"484ed07362d35b1c642c36e741f1c7ef6948d01b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"auth_type \u003d password"},{"line_number":32,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":33,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":34,"context_line":"project_name \u003d service"},{"line_number":35,"context_line":"username \u003d {{ ironic_inspector_keystone_user }}"},{"line_number":36,"context_line":"password \u003d {{ ironic_inspector_keystone_password }}"},{"line_number":37,"context_line":"valid_interfaces \u003d internal"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9bd75979_17be537f","side":"PARENT","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":2},"in_reply_to":"f26000a4_1bbcdb1e","updated":"2024-11-15 13:25:45.000000000","message":"Exactly that. I\u0027ve updated the commit message to make this clear.","commit_id":"2f124f8e9b5d0c74638cd272c8ecb7d2144ce9eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5031ec9eda0e80dbb042c5d2f04175ff0dbcd3be","unresolved":true,"context_lines":[{"line_number":29,"context_line":"{% if ironic_enable_keystone_integration | bool %}"},{"line_number":30,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":31,"context_line":"auth_type \u003d password"},{"line_number":32,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":33,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":34,"context_line":"username \u003d {{ ironic_inspector_keystone_user }}"},{"line_number":35,"context_line":"password \u003d {{ ironic_inspector_keystone_password }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1d2caeb3_1e69ea3f","line":32,"updated":"2024-11-15 13:15:47.000000000","message":"but actually this line should then be removed, too","commit_id":"0fce4f0f8c75c9d231af28e4f6bff0bf4013e0ad"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"484ed07362d35b1c642c36e741f1c7ef6948d01b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% if ironic_enable_keystone_integration | bool %}"},{"line_number":30,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":31,"context_line":"auth_type \u003d password"},{"line_number":32,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":33,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":34,"context_line":"username \u003d {{ ironic_inspector_keystone_user }}"},{"line_number":35,"context_line":"password \u003d {{ ironic_inspector_keystone_password }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"8e448de2_3a72a84a","line":32,"in_reply_to":"1d2caeb3_1e69ea3f","updated":"2024-11-15 13:25:45.000000000","message":"Good spot, removed it.\nDidn\u0027t catch this in my testing, I think because I only use one domain.","commit_id":"0fce4f0f8c75c9d231af28e4f6bff0bf4013e0ad"}],"releasenotes/notes/give-ironic-inspector-user-system-scope-all-5fe5cb7f9a03ee7b.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2d5dec7f257936888441ba8b517d6735a019cb5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `ironic-inspector` service user is now assigned the system scope `all`."},{"line_number":5,"context_line":"    This allows it to create baremetal ports during node inspection again."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7b716a84_9afc4244","line":2,"updated":"2024-11-15 12:09:49.000000000","message":"I think this also needs an upgrade note, since deployments may have overridden the default list of role assignments?","commit_id":"ce4818ff3b23c5640b05f6b75daeb86b82c739f6"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"efe3aca4570f1f352a31a6848f5a1b88051a5d6e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `ironic-inspector` service user is now assigned the system scope `all`."},{"line_number":5,"context_line":"    This allows it to create baremetal ports during node inspection again."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d2a59e48_6d44a955","line":2,"in_reply_to":"7b716a84_9afc4244","updated":"2024-11-15 12:59:36.000000000","message":"Done","commit_id":"ce4818ff3b23c5640b05f6b75daeb86b82c739f6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2d5dec7f257936888441ba8b517d6735a019cb5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `ironic-inspector` service user is now assigned the system scope `all`."},{"line_number":5,"context_line":"    This allows it to create baremetal ports during node inspection again."},{"line_number":6,"context_line":"    `LP#2064655 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2064655\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bef4835c_9d7632d7","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":25},"updated":"2024-11-15 12:09:49.000000000","message":"the quotations need to be in double-backticks for proper formatting","commit_id":"ce4818ff3b23c5640b05f6b75daeb86b82c739f6"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"efe3aca4570f1f352a31a6848f5a1b88051a5d6e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `ironic-inspector` service user is now assigned the system scope `all`."},{"line_number":5,"context_line":"    This allows it to create baremetal ports during node inspection again."},{"line_number":6,"context_line":"    `LP#2064655 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2064655\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"32dc6ad1_989dc63e","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":25},"in_reply_to":"bef4835c_9d7632d7","updated":"2024-11-15 12:59:36.000000000","message":"Done","commit_id":"ce4818ff3b23c5640b05f6b75daeb86b82c739f6"}]}