)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5d64552d533460c2da282c6840143f26a876a429","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6be53e4_017a2be4","updated":"2024-11-08 14:43:46.000000000","message":"LGTM when looking at the cyborg architecture diagram:\n\nhttps://docs.openstack.org/cyborg/latest/user/architecture.html\n\nmaybe we should also add some minimal testing, which I think is the root cause why this was never catched in the past (the lack of testing), what do you think?","commit_id":"568e186a2a94df318037c0413957f6d844a9a26e"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"eb94641949f541d7898bc48fe11b81d1954967df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a299395_e876ad90","in_reply_to":"b6be53e4_017a2be4","updated":"2024-11-08 22:14:33.000000000","message":"sure, what are you thinking about in terms of testing ? I\u0027m not familiar with the CI stuff on zuul so I\u0027d like so guidance.","commit_id":"568e186a2a94df318037c0413957f6d844a9a26e"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"131b350f631bfcd4606429be269687653c3514a8","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"[cyborg:children]"},{"line_number":134,"context_line":"control"},{"line_number":135,"context_line":"compute"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"[tacker:children]"},{"line_number":138,"context_line":"control"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"e4d6aed4_15af3188","side":"PARENT","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":7},"updated":"2024-11-08 14:34:41.000000000","message":"interesting, this was introduced in the very commit adding cyborg support to kolla-ansible:\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/621409\n\nI never used cyborg myself, so I need to do some research what is the correct behaviour here.","commit_id":"2b61c956e1e236c24905b5ee49786e70d4b2e145"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"eb94641949f541d7898bc48fe11b81d1954967df","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"[cyborg:children]"},{"line_number":134,"context_line":"control"},{"line_number":135,"context_line":"compute"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"[tacker:children]"},{"line_number":138,"context_line":"control"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"790bede3_ae626b01","side":"PARENT","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":7},"in_reply_to":"e4d6aed4_15af3188","updated":"2024-11-08 22:14:33.000000000","message":"we used it quite a bit, and we never noticed it until today, tho we didn\u0027t have critical stuff on it yet. The architecture should be similar to nova I believe, where the api and connector are purely control plane services. The current deployment made me tick and after investigating the other haproxy patch it looks clear that this is not desired behavior.","commit_id":"2b61c956e1e236c24905b5ee49786e70d4b2e145"}]}