)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"ae1c44a736f37aac1786e9876324e198f4c38f85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7619a09f_d9d2506f","updated":"2024-11-14 03:51:58.000000000","message":"recheck","commit_id":"42993ead7fad1bf46d3d50f5845df78b4e0f9968"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdca9b2cba87a256c65d8c517b6ae18f65078c29","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6ccbaaa4_70f618da","updated":"2024-12-11 06:38:19.000000000","message":"Docs are missing as well...","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"a870fed5f62aaf2a4799e1b97a8ca16b7d8df5b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"709a9c29_8f686014","in_reply_to":"6ccbaaa4_70f618da","updated":"2024-12-13 07:52:35.000000000","message":"I have added the documentation to the commit message as well as the release note.","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5ff2dfc17dd9e42d4c2e0f1b1af11705eeed48ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"03082c45_d99db602","updated":"2025-01-14 10:46:30.000000000","message":"Ok, fantastic - can we get that tested in CI?","commit_id":"6c53c6a6e094364cd24a8673a229fde8d32f7308"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"805ac33480b572cc40148c7b03274e55abe8a481","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"26cdd1c6_0e359f64","in_reply_to":"03082c45_d99db602","updated":"2025-01-14 11:39:21.000000000","message":"@mnasiadka@gmail.com could you give me a guide to setup CI for this?","commit_id":"6c53c6a6e094364cd24a8673a229fde8d32f7308"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdca9b2cba87a256c65d8c517b6ae18f65078c29","unresolved":true,"context_lines":[{"line_number":1442,"context_line":"# this is UDP port"},{"line_number":1443,"context_line":"hacluster_corosync_port: 5405"},{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"####################"},{"line_number":1446,"context_line":"# Masakari options"},{"line_number":1447,"context_line":"####################"},{"line_number":1448,"context_line":"# Driver that hostmonitor uses for monitoring hosts."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ef7c590f_94a899da","line":1445,"updated":"2024-12-11 06:38:19.000000000","message":"Does it need to be in group_vars/all? Can you move it to masakari role defaults?","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"a870fed5f62aaf2a4799e1b97a8ca16b7d8df5b5","unresolved":false,"context_lines":[{"line_number":1442,"context_line":"# this is UDP port"},{"line_number":1443,"context_line":"hacluster_corosync_port: 5405"},{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"####################"},{"line_number":1446,"context_line":"# Masakari options"},{"line_number":1447,"context_line":"####################"},{"line_number":1448,"context_line":"# Driver that hostmonitor uses for monitoring hosts."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"007bb810_1296e21d","line":1445,"in_reply_to":"ef7c590f_94a899da","updated":"2024-12-13 07:52:35.000000000","message":"Done","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdca9b2cba87a256c65d8c517b6ae18f65078c29","unresolved":true,"context_lines":[{"line_number":1458,"context_line":"#                 is as such incompatible with OpenStack\u0027s license"},{"line_number":1459,"context_line":"#                 policy. Therefore, you have to deploy Consul clusters yourself."},{"line_number":1460,"context_line":"# Consul internal binding interface"},{"line_number":1461,"context_line":"masakari_consul_internal_interface: \"enp0s7\""},{"line_number":1462,"context_line":"# Consul internal http port"},{"line_number":1463,"context_line":"masakari_consul_internal_port: \"8500\""},{"line_number":1464,"context_line":"# Consul storage binding interface"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8e8d9758_60f10a07","line":1461,"updated":"2024-12-11 06:38:19.000000000","message":"that should not be default, use existing variable for internal network interface","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"a870fed5f62aaf2a4799e1b97a8ca16b7d8df5b5","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"#                 is as such incompatible with OpenStack\u0027s license"},{"line_number":1459,"context_line":"#                 policy. Therefore, you have to deploy Consul clusters yourself."},{"line_number":1460,"context_line":"# Consul internal binding interface"},{"line_number":1461,"context_line":"masakari_consul_internal_interface: \"enp0s7\""},{"line_number":1462,"context_line":"# Consul internal http port"},{"line_number":1463,"context_line":"masakari_consul_internal_port: \"8500\""},{"line_number":1464,"context_line":"# Consul storage binding interface"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"07c90127_13b36486","line":1461,"in_reply_to":"8e8d9758_60f10a07","updated":"2024-12-13 07:52:35.000000000","message":"Done","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdca9b2cba87a256c65d8c517b6ae18f65078c29","unresolved":true,"context_lines":[{"line_number":1462,"context_line":"# Consul internal http port"},{"line_number":1463,"context_line":"masakari_consul_internal_port: \"8500\""},{"line_number":1464,"context_line":"# Consul storage binding interface"},{"line_number":1465,"context_line":"masakari_consul_storage_interface: \"enp0s8\""},{"line_number":1466,"context_line":"# Consul storage http port"},{"line_number":1467,"context_line":"masakari_consul_storage_port: \"8500\""},{"line_number":1468,"context_line":"# Consul management binding interface"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5539704d_c619f13c","line":1465,"updated":"2024-12-11 06:38:19.000000000","message":"ditto","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"a870fed5f62aaf2a4799e1b97a8ca16b7d8df5b5","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"# Consul internal http port"},{"line_number":1463,"context_line":"masakari_consul_internal_port: \"8500\""},{"line_number":1464,"context_line":"# Consul storage binding interface"},{"line_number":1465,"context_line":"masakari_consul_storage_interface: \"enp0s8\""},{"line_number":1466,"context_line":"# Consul storage http port"},{"line_number":1467,"context_line":"masakari_consul_storage_port: \"8500\""},{"line_number":1468,"context_line":"# Consul management binding interface"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5ece9b3d_a4dc3bc7","line":1465,"in_reply_to":"5539704d_c619f13c","updated":"2024-12-13 07:52:35.000000000","message":"Done","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdca9b2cba87a256c65d8c517b6ae18f65078c29","unresolved":true,"context_lines":[{"line_number":1466,"context_line":"# Consul storage http port"},{"line_number":1467,"context_line":"masakari_consul_storage_port: \"8500\""},{"line_number":1468,"context_line":"# Consul management binding interface"},{"line_number":1469,"context_line":"masakari_consul_management_interface: \"enp0s9\""},{"line_number":1470,"context_line":"# Consul management port"},{"line_number":1471,"context_line":"masakari_consul_management_port: \"8500\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"61324df9_3181fb94","line":1469,"updated":"2024-12-11 06:38:19.000000000","message":"ditto","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"a870fed5f62aaf2a4799e1b97a8ca16b7d8df5b5","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"# Consul storage http port"},{"line_number":1467,"context_line":"masakari_consul_storage_port: \"8500\""},{"line_number":1468,"context_line":"# Consul management binding interface"},{"line_number":1469,"context_line":"masakari_consul_management_interface: \"enp0s9\""},{"line_number":1470,"context_line":"# Consul management port"},{"line_number":1471,"context_line":"masakari_consul_management_port: \"8500\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"847bd8f7_941763c3","line":1469,"in_reply_to":"61324df9_3181fb94","updated":"2024-12-13 07:52:35.000000000","message":"Done","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"}],"ansible/roles/masakari/tasks/config.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdca9b2cba87a256c65d8c517b6ae18f65078c29","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    sources:"},{"line_number":96,"context_line":"      - \"{{ role_path }}/files/matrix.yaml\""},{"line_number":97,"context_line":"      - \"{{ node_custom_config }}/masakari/masakari-hostmonitor/matrix.yaml\""},{"line_number":98,"context_line":"      - \"{{ node_custom_config }}/masakari/masakari-hostmonitor/matrix.yml\""},{"line_number":99,"context_line":"    dest: \"{{ node_config_directory }}/masakari-hostmonitor/matrix.yaml\""},{"line_number":100,"context_line":"    mode: \"0660\""},{"line_number":101,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"0d0a87b0_673e6ada","line":98,"updated":"2024-12-11 06:38:19.000000000","message":"why both extensions?","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"a870fed5f62aaf2a4799e1b97a8ca16b7d8df5b5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    sources:"},{"line_number":96,"context_line":"      - \"{{ role_path }}/files/matrix.yaml\""},{"line_number":97,"context_line":"      - \"{{ node_custom_config }}/masakari/masakari-hostmonitor/matrix.yaml\""},{"line_number":98,"context_line":"      - \"{{ node_custom_config }}/masakari/masakari-hostmonitor/matrix.yml\""},{"line_number":99,"context_line":"    dest: \"{{ node_config_directory }}/masakari-hostmonitor/matrix.yaml\""},{"line_number":100,"context_line":"    mode: \"0660\""},{"line_number":101,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"be52afdf_7520174e","line":98,"in_reply_to":"0d0a87b0_673e6ada","updated":"2024-12-13 07:52:35.000000000","message":"Done","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"}],"ansible/roles/masakari/templates/masakari-hostmonitor.json.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdca9b2cba87a256c65d8c517b6ae18f65078c29","unresolved":true,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }{% endif %},"},{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"source\": \"{{ container_config_directory }}/matrix.yaml\","},{"line_number":18,"context_line":"            \"dest\": \"/etc/masakari-monitors/matrix.yaml\","},{"line_number":19,"context_line":"            \"owner\": \"masakari\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"69e9068e_a013918a","line":17,"updated":"2024-12-11 06:38:19.000000000","message":"Do we need it irrespective of the monitoring driver in use?","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"a870fed5f62aaf2a4799e1b97a8ca16b7d8df5b5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }{% endif %},"},{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"source\": \"{{ container_config_directory }}/matrix.yaml\","},{"line_number":18,"context_line":"            \"dest\": \"/etc/masakari-monitors/matrix.yaml\","},{"line_number":19,"context_line":"            \"owner\": \"masakari\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"86ce55c5_b89ec006","line":17,"in_reply_to":"69e9068e_a013918a","updated":"2024-12-13 07:52:35.000000000","message":"Done","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"}],"ansible/roles/masakari/templates/masakari-monitors.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdca9b2cba87a256c65d8c517b6ae18f65078c29","unresolved":true,"context_lines":[{"line_number":50,"context_line":"# Addr for local consul agent in management datacenter."},{"line_number":51,"context_line":"# The addr is make up of the agent\u0027s bind_addr and http port,"},{"line_number":52,"context_line":"# such as \u0027192.168.101.1:8500\u0027."},{"line_number":53,"context_line":"agent_manage \u003d \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + masakari_consul_management_interface | replace(\u0027-\u0027,\u0027_\u0027)].ipv4.address }}:{{ masakari_consul_management_port }}\""},{"line_number":54,"context_line":"# Addr for local consul agent in tenant datacenter."},{"line_number":55,"context_line":"agent_tenant \u003d \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + masakari_consul_internal_interface | replace(\u0027-\u0027,\u0027_\u0027)].ipv4.address }}:{{ masakari_consul_internal_port }}\""},{"line_number":56,"context_line":"# Addr for local consul agent in storage datacenter."}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"cf9cb6ec_6195fdf6","line":53,"updated":"2024-12-11 06:38:19.000000000","message":"use put_address_in_context just like in libvirt section to make ipv6 work","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"a870fed5f62aaf2a4799e1b97a8ca16b7d8df5b5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# Addr for local consul agent in management datacenter."},{"line_number":51,"context_line":"# The addr is make up of the agent\u0027s bind_addr and http port,"},{"line_number":52,"context_line":"# such as \u0027192.168.101.1:8500\u0027."},{"line_number":53,"context_line":"agent_manage \u003d \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + masakari_consul_management_interface | replace(\u0027-\u0027,\u0027_\u0027)].ipv4.address }}:{{ masakari_consul_management_port }}\""},{"line_number":54,"context_line":"# Addr for local consul agent in tenant datacenter."},{"line_number":55,"context_line":"agent_tenant \u003d \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + masakari_consul_internal_interface | replace(\u0027-\u0027,\u0027_\u0027)].ipv4.address }}:{{ masakari_consul_internal_port }}\""},{"line_number":56,"context_line":"# Addr for local consul agent in storage datacenter."}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"b6ab6bf7_130c188b","line":53,"in_reply_to":"cf9cb6ec_6195fdf6","updated":"2024-12-13 07:52:35.000000000","message":"Done","commit_id":"494071c9e3b64750b63084290b2f111be90dc05d"}]}