)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8cf95a71406ae45dfa283a76dcec69e089e0e20e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-01-14 17:28:05 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[masakari] support custom recovery workflow configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"https: //docs.openstack.org/masakari/latest/configuration/recovery_workflow_custom_task.html"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Blueprint: bp/masakari-upgrade"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"65faa590_8d7d95b6","line":8,"updated":"2025-02-07 22:10:22.000000000","message":"please read: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\nand provide a detailed description of the change.","commit_id":"848fa0bea5968e87586038d7c3f16f3b0b5805e1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8cf95a71406ae45dfa283a76dcec69e089e0e20e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[masakari] support custom recovery workflow configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"https: //docs.openstack.org/masakari/latest/configuration/recovery_workflow_custom_task.html"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Blueprint: bp/masakari-upgrade"},{"line_number":12,"context_line":"Change-Id: If12f76b9976f3b15d6d8988d39b375cfa2b016e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1f35cc09_f2bc3250","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":7},"updated":"2025-02-07 22:10:22.000000000","message":"extra space","commit_id":"848fa0bea5968e87586038d7c3f16f3b0b5805e1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"0e0169140e55292a5025729ee00a0ea7d448247d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"95185296_127f697d","updated":"2025-02-06 03:48:27.000000000","message":"recheck","commit_id":"848fa0bea5968e87586038d7c3f16f3b0b5805e1"}],"ansible/roles/masakari/files/masakari-custom-recovery-methods.conf":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cd85d6bee84c7f258ba30c73ce247ad72d4852e6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[taskflow_driver_recovery_flows]"}],"source_content_type":"text/plain","patch_set":3,"id":"bde5258f_88e1e896","line":1,"updated":"2024-12-11 06:40:22.000000000","message":"Why in files? Do you want to copy a configuration file full of comments and no real value?","commit_id":"45414ef1c8ce89aa06e3e1b162478c02e136903b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"76de5b1674de5426efa64ab1384039f64df36809","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[taskflow_driver_recovery_flows]"}],"source_content_type":"text/plain","patch_set":3,"id":"12c9ab56_2eb9b683","line":1,"in_reply_to":"bde5258f_88e1e896","updated":"2024-12-13 08:28:37.000000000","message":"Done","commit_id":"45414ef1c8ce89aa06e3e1b162478c02e136903b"}],"ansible/roles/masakari/tasks/config.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8cf95a71406ae45dfa283a76dcec69e089e0e20e","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Set masakari-custom-recovery-methods file"},{"line_number":55,"context_line":"  set_fact:"},{"line_number":56,"context_line":"    masakari_custom_recovery_methods_file: \"{{ masakari_custom_recovery_methods.results.0.stat.path | basename }}\""},{"line_number":57,"context_line":"    masakari_custom_recovery_methods_file_path: \"{{ masakari_custom_recovery_methods.results.0.stat.path }}\""},{"line_number":58,"context_line":"  when:"},{"line_number":59,"context_line":"    - masakari_custom_recovery_methods.results"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"83e6464c_b63e698a","line":56,"range":{"start_line":56,"start_character":102,"end_line":56,"end_character":110},"updated":"2025-02-07 22:10:22.000000000","message":"an extra, unneeded fact, can be used only one.\nand do we really need \u0027basename\u0027 since the fact used only to check if defined?","commit_id":"848fa0bea5968e87586038d7c3f16f3b0b5805e1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8cf95a71406ae45dfa283a76dcec69e089e0e20e","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  vars:"},{"line_number":63,"context_line":"    service: \"{{ masakari_services[\u0027masakari-engine\u0027] }}\""},{"line_number":64,"context_line":"  copy:"},{"line_number":65,"context_line":"    src: \"{{ masakari_custom_recovery_methods_file_path }}\""},{"line_number":66,"context_line":"    dest: \"{{ node_config_directory }}/masakari-engine/masakari-custom-recovery-methods.conf\""},{"line_number":67,"context_line":"    mode: \"0660\""},{"line_number":68,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff90ce82_04b1744f","line":65,"range":{"start_line":65,"start_character":13,"end_line":65,"end_character":55},"updated":"2025-02-07 22:10:22.000000000","message":"the task will fail if the files are absent and the fact has not been set","commit_id":"848fa0bea5968e87586038d7c3f16f3b0b5805e1"}],"ansible/roles/masakari/templates/masakari-engine.json.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"76de5b1674de5426efa64ab1384039f64df36809","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"masakari-engine --config-file /etc/masakari/masakari.conf --config-file /etc/masakari/masakari-custom-recovery-methods.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/masakari.conf\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"2a7f2d2d_6953627a","line":2,"updated":"2024-12-13 08:28:37.000000000","message":"what if the file does not exist?","commit_id":"06bcd880eb4827e2fd16da83fcbb112d872d0cf3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"6aeeae2a8532e78e0102fd896be67de87a10a2f3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"masakari-engine --config-file /etc/masakari/masakari.conf --config-file /etc/masakari/masakari-custom-recovery-methods.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/masakari.conf\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"525df4ec_37eb1e69","line":2,"in_reply_to":"2a7f2d2d_6953627a","updated":"2024-12-13 08:35:19.000000000","message":"Because this is always a file with default value (that\u0027s why in files), I don\u0027t have to handle the case this file does not exist.\n\nI\u0027ve changed the approach: look for the custom-recovery-methods.conf file first, and if it exists, copy and change Masakari-engine\u0027s command.","commit_id":"06bcd880eb4827e2fd16da83fcbb112d872d0cf3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"24c3b065b430176512620ade89e23ac956b3489d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"masakari-engine --config-file /etc/masakari/masakari.conf --config-file /etc/masakari/masakari-custom-recovery-methods.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/masakari.conf\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c0cf2b35_cf67fd12","line":2,"in_reply_to":"525df4ec_37eb1e69","updated":"2024-12-20 03:14:52.000000000","message":"Done","commit_id":"06bcd880eb4827e2fd16da83fcbb112d872d0cf3"}]}