)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e0689fa026122f8d2ecd708b86bcccb14d7d04ee","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enables override of Octavia notification topics"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Octavia was currently missing an override for enabling notificiation"},{"line_number":10,"context_line":"topics, this aligns the overrides with how all of the other project"},{"line_number":11,"context_line":"roles handle the topic."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cc0a80e1_11a4b149","line":9,"updated":"2024-11-13 09:14:29.000000000","message":"notification","commit_id":"81f47fe94c71831743e7afd2d0b4dea1c9f28514"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"ef7fe6dd980a4ffa7141316e7e2ead0ab57806f1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enables override of Octavia notification topics"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Octavia was currently missing an override for enabling notificiation"},{"line_number":10,"context_line":"topics, this aligns the overrides with how all of the other project"},{"line_number":11,"context_line":"roles handle the topic."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2e2b29b2_ab3b97d0","line":9,"in_reply_to":"cc0a80e1_11a4b149","updated":"2024-11-13 15:45:17.000000000","message":"Done","commit_id":"81f47fe94c71831743e7afd2d0b4dea1c9f28514"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"53c6ad15773e4987caee47052900516a4da3d4d0","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Enables override of Octavia notification topics"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Octavia was missing an override for enabling notification topics,"},{"line_number":10,"context_line":"this aligns the overrides with how all of the other project roles"},{"line_number":11,"context_line":"handle the topic."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2087997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"306e7028_8fbeaa1d","line":10,"updated":"2024-11-18 16:56:51.000000000","message":"Nit: s/all of the/all the/","commit_id":"52dcf6be7bc4fb1548214b4903a2545f6c5a6c6b"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"196003199f7d90c7ed75d7b15289abad9cb67c5e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enables override of Octavia notification topics"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Octavia was missing an override for enabling notification topics,"},{"line_number":10,"context_line":"this aligns the overrides with how all of the other project roles"},{"line_number":11,"context_line":"handle the topic."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2087997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"58353707_8dc46aa1","line":10,"in_reply_to":"306e7028_8fbeaa1d","updated":"2024-11-18 17:56:50.000000000","message":"Done","commit_id":"52dcf6be7bc4fb1548214b4903a2545f6c5a6c6b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e0689fa026122f8d2ecd708b86bcccb14d7d04ee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d90bbc1b_f687098d","updated":"2024-11-13 09:14:29.000000000","message":"Can you please add a release note?","commit_id":"81f47fe94c71831743e7afd2d0b4dea1c9f28514"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"ef7fe6dd980a4ffa7141316e7e2ead0ab57806f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dff33838_6fd86c3c","in_reply_to":"d90bbc1b_f687098d","updated":"2024-11-13 15:45:17.000000000","message":"Done","commit_id":"81f47fe94c71831743e7afd2d0b4dea1c9f28514"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2e5e36a9285c97223cb6784b9548d4cf6e6eca5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d1d986b7_c9c6b8e7","updated":"2025-09-23 17:03:12.000000000","message":"It\u0027s rather a feature per se, but since it improves $operator life - I\u0027ll allow backports. single approving - trivial and has been here for a long time","commit_id":"41b416667cd920303fee357d3a4e4630b6c1ce24"}],"ansible/roles/octavia/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4276cae74ccfe37a356fbe6a3bc13ebcea5bbb36","unresolved":true,"context_lines":[{"line_number":270,"context_line":"####################"},{"line_number":271,"context_line":"octavia_notification_topics:"},{"line_number":272,"context_line":"  - name: notifications"},{"line_number":273,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"octavia_enabled_notification_topics: \"{{ octavia_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":276,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"05b94f5f_4c982480","line":273,"updated":"2024-12-04 18:51:08.000000000","message":"need default filter since this variable not defined in the \u0027octavia\u0027 role.","commit_id":"4cb9e87e11c71ea8587b38aae0fe6368748a863f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"97cf8cb03f70c691c52c6d15c746950b49e3e468","unresolved":false,"context_lines":[{"line_number":270,"context_line":"####################"},{"line_number":271,"context_line":"octavia_notification_topics:"},{"line_number":272,"context_line":"  - name: notifications"},{"line_number":273,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"octavia_enabled_notification_topics: \"{{ octavia_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":276,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7249a8a6_d4042dee","line":273,"in_reply_to":"03f4091b_5a815ef0","updated":"2024-12-04 19:55:10.000000000","message":"ack. checked other roles. all do the same way.","commit_id":"4cb9e87e11c71ea8587b38aae0fe6368748a863f"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"b7909253899c2d3039199fcfe01e51cb6ce135d1","unresolved":true,"context_lines":[{"line_number":270,"context_line":"####################"},{"line_number":271,"context_line":"octavia_notification_topics:"},{"line_number":272,"context_line":"  - name: notifications"},{"line_number":273,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"octavia_enabled_notification_topics: \"{{ octavia_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":276,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"03f4091b_5a815ef0","line":273,"in_reply_to":"05b94f5f_4c982480","updated":"2024-12-04 19:38:29.000000000","message":"This is pretty much how all the other roles define it, so I didn\u0027t want to deviate too much from the other implementations. (Glance for example: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/glance/defaults/main.yml#L111) I\u0027m guessing they are leveraging the enable_ceilometer: no global?","commit_id":"4cb9e87e11c71ea8587b38aae0fe6368748a863f"}],"ansible/roles/octavia/templates/octavia.conf.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"16609788bff0489b2ca5e7aa9d38072806686ed0","unresolved":true,"context_lines":[{"line_number":123,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":124,"context_line":"{% if octavia_enabled_notification_topics %}"},{"line_number":125,"context_line":"driver \u003d messagingv2"},{"line_number":126,"context_line":"topics \u003d {{ octavia_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":127,"context_line":"{% else %}"},{"line_number":128,"context_line":"driver \u003d noop"},{"line_number":129,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f83ffd4_b641cc96","line":126,"range":{"start_line":126,"start_character":50,"end_line":126,"end_character":71},"updated":"2024-12-04 08:37:32.000000000","message":"as I can see \u0027octavia_enabled_notification_topics\u0027 already list here:\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/934827/5/ansible/roles/octavia/defaults/main.yml","commit_id":"4cb9e87e11c71ea8587b38aae0fe6368748a863f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4276cae74ccfe37a356fbe6a3bc13ebcea5bbb36","unresolved":false,"context_lines":[{"line_number":123,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":124,"context_line":"{% if octavia_enabled_notification_topics %}"},{"line_number":125,"context_line":"driver \u003d messagingv2"},{"line_number":126,"context_line":"topics \u003d {{ octavia_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":127,"context_line":"{% else %}"},{"line_number":128,"context_line":"driver \u003d noop"},{"line_number":129,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"aa204d02_42e6fab5","line":126,"range":{"start_line":126,"start_character":50,"end_line":126,"end_character":71},"in_reply_to":"70bb80cb_214a252c","updated":"2024-12-04 18:51:08.000000000","message":"sorry, didn\u0027t catch filter by \u0027enabled\u0027 option. but we need to set default for \u0027enable_ceilometer\u0027 variable since it not declared in the \u0027octavia\u0027 role.","commit_id":"4cb9e87e11c71ea8587b38aae0fe6368748a863f"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"84175bb55c732873a76d687b474228a5271b4f8c","unresolved":true,"context_lines":[{"line_number":123,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":124,"context_line":"{% if octavia_enabled_notification_topics %}"},{"line_number":125,"context_line":"driver \u003d messagingv2"},{"line_number":126,"context_line":"topics \u003d {{ octavia_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":127,"context_line":"{% else %}"},{"line_number":128,"context_line":"driver \u003d noop"},{"line_number":129,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"70bb80cb_214a252c","line":126,"range":{"start_line":126,"start_character":50,"end_line":126,"end_character":71},"in_reply_to":"9f83ffd4_b641cc96","updated":"2024-12-04 16:13:27.000000000","message":"I\u0027m not sure I understand the issue. Are you saying its already in there? I checked master and I don\u0027t see this at all in the template. This just mimics what other roles have to do for the enabling of telemetry.","commit_id":"4cb9e87e11c71ea8587b38aae0fe6368748a863f"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"5e5c3c882ec8a94dff60a63b795454bfc518f806","unresolved":true,"context_lines":[{"line_number":123,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":124,"context_line":"{% if octavia_enabled_notification_topics %}"},{"line_number":125,"context_line":"driver \u003d messagingv2"},{"line_number":126,"context_line":"topics \u003d {{ octavia_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":127,"context_line":"{% else %}"},{"line_number":128,"context_line":"driver \u003d noop"},{"line_number":129,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"e0ca32eb_11e66263","line":126,"range":{"start_line":126,"start_character":50,"end_line":126,"end_character":71},"in_reply_to":"aa204d02_42e6fab5","updated":"2024-12-04 19:30:16.000000000","message":"Isn\u0027t the global default for \u0027enable_ceilometer\u0027 handed here in group_vars/all.yml?\n\nhttps://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L854","commit_id":"4cb9e87e11c71ea8587b38aae0fe6368748a863f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"97cf8cb03f70c691c52c6d15c746950b49e3e468","unresolved":false,"context_lines":[{"line_number":123,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":124,"context_line":"{% if octavia_enabled_notification_topics %}"},{"line_number":125,"context_line":"driver \u003d messagingv2"},{"line_number":126,"context_line":"topics \u003d {{ octavia_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":127,"context_line":"{% else %}"},{"line_number":128,"context_line":"driver \u003d noop"},{"line_number":129,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"50608e7c_9858eea8","line":126,"range":{"start_line":126,"start_character":50,"end_line":126,"end_character":71},"in_reply_to":"e0ca32eb_11e66263","updated":"2024-12-04 19:55:10.000000000","message":"yes. we have default.","commit_id":"4cb9e87e11c71ea8587b38aae0fe6368748a863f"}],"releasenotes/notes/octavia-notifications-98a91ab02d9cbee6.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"53c6ad15773e4987caee47052900516a4da3d4d0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a missing override for octavia_notification_topics so that operators"},{"line_number":5,"context_line":"    can add their own notification topics for Octavia."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9e26a26c_e4a2933c","line":4,"updated":"2024-11-18 16:56:51.000000000","message":"Use double backticks around ``octavia_notification_topics``","commit_id":"52dcf6be7bc4fb1548214b4903a2545f6c5a6c6b"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"196003199f7d90c7ed75d7b15289abad9cb67c5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a missing override for octavia_notification_topics so that operators"},{"line_number":5,"context_line":"    can add their own notification topics for Octavia."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6fd97874_b9a1e262","line":4,"in_reply_to":"9e26a26c_e4a2933c","updated":"2024-11-18 17:56:50.000000000","message":"Done","commit_id":"52dcf6be7bc4fb1548214b4903a2545f6c5a6c6b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc4914fa9941dbbee346ff56384f8ada908bb57d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a missing override for `octavia_notification_topics` so that"},{"line_number":5,"context_line":"    operators can add their own notification topics for Octavia."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4904ad54_ba4b1bad","line":5,"updated":"2024-12-03 15:19:57.000000000","message":"mention that by default it enables notifications to ceilometer","commit_id":"7bb4929c9d5c4fcf9cb731e5fade0ff809a46762"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"1e4fec800789bf0f77d9bb8f5247cbf7ead3aa1f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a missing override for `octavia_notification_topics` so that"},{"line_number":5,"context_line":"    operators can add their own notification topics for Octavia."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6b553e13_4b0ddf1e","line":5,"in_reply_to":"4904ad54_ba4b1bad","updated":"2024-12-03 19:10:15.000000000","message":"Done","commit_id":"7bb4929c9d5c4fcf9cb731e5fade0ff809a46762"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f99791159250e0bb2935cb1a12d1d28bb3f0b77b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a missing override for `octavia_notification_topics` so that"},{"line_number":5,"context_line":"    operators can add their own notification topics for Octavia. By"},{"line_number":6,"context_line":"    default it will send notifications to ceilometer when ceilometer"},{"line_number":7,"context_line":"    is enabled."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5441d487_fe298512","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":61},"updated":"2025-05-13 06:39:06.000000000","message":"Please use double backticks for formatting.","commit_id":"aedeb1d4420bc493e155baa0f13e795416b5c45a"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"667847c7578e7734f52be96992af9927e90a10b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a missing override for `octavia_notification_topics` so that"},{"line_number":5,"context_line":"    operators can add their own notification topics for Octavia. By"},{"line_number":6,"context_line":"    default it will send notifications to ceilometer when ceilometer"},{"line_number":7,"context_line":"    is enabled."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a797fd2e_fb215d8c","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":61},"in_reply_to":"5441d487_fe298512","updated":"2025-05-13 12:41:23.000000000","message":"Done","commit_id":"aedeb1d4420bc493e155baa0f13e795416b5c45a"}]}