)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"170ad244a51d931445f9c3f1e69e338948584338","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-11-21 10:17:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"bug: fix external ceph cinder keyring, change from file to template"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7cbc6a94608baf4f04ef231cc88397fc5dcf0a9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"beb877d6_9f8a4a29","line":8,"updated":"2024-11-21 10:22:24.000000000","message":"please attach the bug into commit message too","commit_id":"b921a3d9385a7826ab1a84ceaf996fc1c89a285d"},{"author":{"_account_id":37503,"name":"Christian Schilling","display_name":"ChristianSchilling","email":"c.schilling@gmx.net","username":"DeadRabbit"},"change_message_id":"8ba4d89149848b044ffd6723b238ee4c9c2cbad7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-11-21 10:17:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"bug: fix external ceph cinder keyring, change from file to template"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7cbc6a94608baf4f04ef231cc88397fc5dcf0a9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7018a8eb_bd67156e","line":8,"in_reply_to":"beb877d6_9f8a4a29","updated":"2024-11-21 10:50:51.000000000","message":"Acknowledged","commit_id":"b921a3d9385a7826ab1a84ceaf996fc1c89a285d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8ed5afd679daf1859f0aeb430d0402855ef2fcdf","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Schilling \u003cc.schilling@gmx.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-21 11:48:51 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"bug 2089229 fix external ceph cinder keyring, change from file to template"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7cbc6a94608baf4f04ef231cc88397fc5dcf0a9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f279496c_7b87ab1d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"updated":"2024-11-21 11:01:53.000000000","message":"this should be written as (I will not comment on the content itself yet, only style):\n\n```\nfix external ceph cinder keyring\n\nchange from file to template\n\nCloses-Bug: #2089229\n```\n\nsee: https://docs.openstack.org/contributors/common/git.html#footers\n\nI can recommend to take a look at the general Openstack contributor guide as well as the kolla specific contribution guide:\n\nhttps://docs.openstack.org/kolla-ansible/latest/contributor/index.html\n\nBut I think you might have already read some things in the kolla guide.\n\nThanks for your first contribution!","commit_id":"25cd5df6259ac39e5914b3d10e9e9b6e75afa6c5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"80d7128f6661f2ba2629147fe25d3066ac51d0c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Schilling \u003cc.schilling@gmx.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-21 11:48:51 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"bug 2089229 fix external ceph cinder keyring, change from file to template"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7cbc6a94608baf4f04ef231cc88397fc5dcf0a9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f93b03ca_ee541881","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"f279496c_7b87ab1d","updated":"2024-11-25 08:42:27.000000000","message":"Done","commit_id":"25cd5df6259ac39e5914b3d10e9e9b6e75afa6c5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37503,"name":"Christian Schilling","display_name":"ChristianSchilling","email":"c.schilling@gmx.net","username":"DeadRabbit"},"change_message_id":"8ba4d89149848b044ffd6723b238ee4c9c2cbad7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fca33b64_848f8ad5","updated":"2024-11-21 10:50:51.000000000","message":"Thanks and done","commit_id":"25cd5df6259ac39e5914b3d10e9e9b6e75afa6c5"},{"author":{"_account_id":34646,"name":"Mathias Fechner","email":"mfechner@wavecon.de","username":"matfechner"},"change_message_id":"66bfe143716e8c513ea3b9d19deea03c49da93c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"02c74bab_56ed032b","updated":"2024-11-22 03:07:54.000000000","message":"Looks good to me","commit_id":"c10743a9508eee62352d2278f0753d6bc07f8c86"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"80d7128f6661f2ba2629147fe25d3066ac51d0c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e56399d6_a0ab196c","updated":"2024-11-25 08:42:27.000000000","message":"please fix those linting errors, the release notes zuul error should be unrelated though:\n\n```\n2024-11-21 12:08:38.038579 | ubuntu-jammy | /home/zuul/src/opendev.org/openstack/kolla-ansible/releasenotes/source/unreleased.rst:: ERROR: Anonymous hyperlink mismatch: 1 references but 0 targets.\n```","commit_id":"c10743a9508eee62352d2278f0753d6bc07f8c86"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"eadcf5e90fea074f9380e8c6fe28d9e7357955e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4d4497fd_2ed4ddf7","in_reply_to":"e56399d6_a0ab196c","updated":"2024-11-25 16:40:39.000000000","message":"Done","commit_id":"c10743a9508eee62352d2278f0753d6bc07f8c86"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8056de5b2d3dc4b7cd22ef9d8819578f36ee17a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b913fb1c_5672e4b4","updated":"2024-11-25 20:33:50.000000000","message":"Sven, I\u0027m wondering why this change should be backported, but the one one with certificates not?","commit_id":"f30dd3e52e914a488b1e6c171eebe233dacfa636"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7e553fe29589af587e1a4f7850ebb0aee1188973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eb68e417_54d4e703","in_reply_to":"b913fb1c_5672e4b4","updated":"2024-11-26 10:18:35.000000000","message":"Because all the other ceph keyrings are templated, except for this one, which is inconsistent, and thus imho more of a bug (an oversight during initial implementaion I would say).\n\nI\u0027m not 100% sure to which other patchset you are referring, I guess you mean this one?\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/934514\n\nThis is clearly a new feature, the certificates details where never configurable beforehand, but now are. Also that changeset is a bit larger and thus more likely to break something in the future, I think. Not that I think that it will break something, but the likelihood is a tiny bit larger.\n\nIt\u0027s always a tradeoff and a bit subjective what to backport and what not. One persons feature is another persons bugfix 😊\n\nI\u0027m only interpreting openstack policy here, which I don\u0027t fully agree with and I think it\u0027s inconsistent applied as well.\n\nBut I think this applies to all rules of humankind, so we can just try to improve, so I actually welcome you asking what my reasoning for my backport voting is!\n\nI hope this is the correct patchset, if you meant another change, please link it.\n\nI hope I could explain my reasoning here, of course everyone else is entitled to their own judgement what they would like to backport.\n\nMarking as \"resolved\" for now, feel free to reopen if something is not clear or you want to further discuss this - though it might be more appropriate to discuss this topic in general on the weekly IRC meetings or on the mailinglist, especially if it is of broader interest to the openstack community.\n\nThanks.","commit_id":"f30dd3e52e914a488b1e6c171eebe233dacfa636"}],"releasenotes/notes/external-ceph-cinder_key-1a4c38fff3e2ab3c.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"80d7128f6661f2ba2629147fe25d3066ac51d0c9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes external ceph cinder keyring is not imported into libvirt if templated"},{"line_number":5,"context_line":"    Per now, ansible/roles/nova-cell/tasks/external_ceph.yml looks"},{"line_number":6,"context_line":"    cinder_cephx_raw_key up as file from cinder_cephx_keyring_file.stat.path"},{"line_number":7,"context_line":"    To allow templated cinderkeyrings, the lookup is changed to \"template\" "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a4badd40_3c1b783b","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2024-11-25 08:42:27.000000000","message":"line too long","commit_id":"c10743a9508eee62352d2278f0753d6bc07f8c86"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f11579bd63aa5ce1c9c56946f5c109eef18d7edb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes external ceph cinder keyring is not imported into libvirt if templated"},{"line_number":5,"context_line":"    Per now, ansible/roles/nova-cell/tasks/external_ceph.yml looks"},{"line_number":6,"context_line":"    cinder_cephx_raw_key up as file from cinder_cephx_keyring_file.stat.path"},{"line_number":7,"context_line":"    To allow templated cinderkeyrings, the lookup is changed to \"template\" "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a698e51f_0d49e284","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"a4badd40_3c1b783b","updated":"2024-11-25 16:29:57.000000000","message":"Done","commit_id":"c10743a9508eee62352d2278f0753d6bc07f8c86"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"80d7128f6661f2ba2629147fe25d3066ac51d0c9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixes external ceph cinder keyring is not imported into libvirt if templated"},{"line_number":5,"context_line":"    Per now, ansible/roles/nova-cell/tasks/external_ceph.yml looks"},{"line_number":6,"context_line":"    cinder_cephx_raw_key up as file from cinder_cephx_keyring_file.stat.path"},{"line_number":7,"context_line":"    To allow templated cinderkeyrings, the lookup is changed to \"template\" "},{"line_number":8,"context_line":"    `LP#2089229 https://bugs.launchpad.net/kolla-ansible/+bug/2089229`__"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f298da6_292dcb25","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"updated":"2024-11-25 08:42:27.000000000","message":"trailing whitespace","commit_id":"c10743a9508eee62352d2278f0753d6bc07f8c86"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f11579bd63aa5ce1c9c56946f5c109eef18d7edb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes external ceph cinder keyring is not imported into libvirt if templated"},{"line_number":5,"context_line":"    Per now, ansible/roles/nova-cell/tasks/external_ceph.yml looks"},{"line_number":6,"context_line":"    cinder_cephx_raw_key up as file from cinder_cephx_keyring_file.stat.path"},{"line_number":7,"context_line":"    To allow templated cinderkeyrings, the lookup is changed to \"template\" "},{"line_number":8,"context_line":"    `LP#2089229 https://bugs.launchpad.net/kolla-ansible/+bug/2089229`__"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6035b554_43eae8bb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"1f298da6_292dcb25","updated":"2024-11-25 16:29:57.000000000","message":"Done","commit_id":"c10743a9508eee62352d2278f0753d6bc07f8c86"}]}