)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c1971594846b82df2e66dc8d647a54a56a5e251","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-12-16 14:19:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add service-uwsgi-config role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I46af6ff709dff4f7a0942df4dadf001c653f44fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"c4916bcc_d692cd73","line":8,"updated":"2024-12-17 10:06:12.000000000","message":"adding a sentence or two describing what the role does wouldn\u0027t hurt IMO ;)","commit_id":"8ae3dbaa651099f371ad5d4916048e5ebe98bd92"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e8f9e109ac2db9997a5dec7f9053b56908fa0fbf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-12-16 14:19:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add service-uwsgi-config role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I46af6ff709dff4f7a0942df4dadf001c653f44fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"96f1572e_45a1125c","line":8,"in_reply_to":"c4916bcc_d692cd73","updated":"2024-12-17 13:00:35.000000000","message":"Done","commit_id":"8ae3dbaa651099f371ad5d4916048e5ebe98bd92"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c1971594846b82df2e66dc8d647a54a56a5e251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3e1e472e_60af8a02","updated":"2024-12-17 10:06:12.000000000","message":"the basic idea lgtm, just some nits inline","commit_id":"8ae3dbaa651099f371ad5d4916048e5ebe98bd92"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"374f3e9b3db456dbf7561e70f26af3249591ab90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"73a4aae8_95aa7a4f","updated":"2024-12-17 21:00:39.000000000","message":"recheck ubuntu upgrade fixed?","commit_id":"755aebf456dec34766b8a970872ae74f785599c8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"807dff20245350373abbb152495c2bee422968b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fca1f763_f4d54039","updated":"2024-12-18 16:30:44.000000000","message":"recheck debian slurp upgrade vm crashed","commit_id":"a1d817d99dc619f5f844ab231d2321277861b22e"}],"ansible/roles/service-uwsgi-config/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c1971594846b82df2e66dc8d647a54a56a5e251","unresolved":true,"context_lines":[{"line_number":3,"context_line":"service_uwsgi_config_file: \"{{ node_config_directory }}/{{ service_name }}/{{ service_name }}-uwsgi.ini\""},{"line_number":4,"context_line":"service_uwsgi_config_tls_backend: false"},{"line_number":5,"context_line":"service_uwsgi_config_worker_timeout: 80"},{"line_number":6,"context_line":"service_uwsgi_config_workers: 1"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"90be78f0_dd451181","line":6,"updated":"2024-12-17 10:06:12.000000000","message":"defaulting to just a single worker sounds very conservative to me, devstack uses a minumum of 2. maybe at least add a comment that this will need tuning for any real world use?","commit_id":"8ae3dbaa651099f371ad5d4916048e5ebe98bd92"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ef1de80a340c563d1a45d7a4a4742818b3af672d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"service_uwsgi_config_file: \"{{ node_config_directory }}/{{ service_name }}/{{ service_name }}-uwsgi.ini\""},{"line_number":4,"context_line":"service_uwsgi_config_tls_backend: false"},{"line_number":5,"context_line":"service_uwsgi_config_worker_timeout: 80"},{"line_number":6,"context_line":"service_uwsgi_config_workers: 1"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e4633bc5_92d2be12","line":6,"in_reply_to":"90be78f0_dd451181","updated":"2024-12-17 13:04:00.000000000","message":"Used openstack_service_workers var as default, but we should pass e.g. nova_api_workers variable in Nova just like we do for apache+mod_wsgi","commit_id":"8ae3dbaa651099f371ad5d4916048e5ebe98bd92"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e8f9e109ac2db9997a5dec7f9053b56908fa0fbf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"service_uwsgi_config_file: \"{{ node_config_directory }}/{{ service_name }}/{{ service_name }}-uwsgi.ini\""},{"line_number":4,"context_line":"service_uwsgi_config_tls_backend: false"},{"line_number":5,"context_line":"service_uwsgi_config_worker_timeout: 80"},{"line_number":6,"context_line":"service_uwsgi_config_workers: 1"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4b4bd370_6a032a39","line":6,"in_reply_to":"90be78f0_dd451181","updated":"2024-12-17 13:00:35.000000000","message":"that looks more reasonable, thx","commit_id":"8ae3dbaa651099f371ad5d4916048e5ebe98bd92"}],"ansible/roles/service-uwsgi-config/templates/uwsgi.ini.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c1971594846b82df2e66dc8d647a54a56a5e251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6719cb61_abaebf4f","updated":"2024-12-17 10:06:12.000000000","message":"except for the https part, this matches what devstack does, so likely should be fine https://opendev.org/openstack/devstack/src/branch/master/lib/apache#L240-L311","commit_id":"8ae3dbaa651099f371ad5d4916048e5ebe98bd92"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ef1de80a340c563d1a45d7a4a4742818b3af672d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"50e06043_2143d58e","in_reply_to":"6719cb61_abaebf4f","updated":"2024-12-17 13:04:00.000000000","message":"Used the devstack config as reference.","commit_id":"8ae3dbaa651099f371ad5d4916048e5ebe98bd92"}]}