)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1c40d33084b862a9e61547bd5ce3f867ffce18bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0876833e_e7a97e86","updated":"2024-12-19 06:15:09.000000000","message":"good catch, I just think the implementation is overly complicated, but maybe I\u0027m missing something?","commit_id":"b7f51142e0bcdde19ff2042862dd2ce43295fb41"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"60f00975ac525dc8926b1cd5161003122eab3317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"46d87e1a_4e0befbe","in_reply_to":"0876833e_e7a97e86","updated":"2024-12-19 08:06:36.000000000","message":"I think I decomplicated it, it was just two approaches in different time with different mindsets ;-)","commit_id":"b7f51142e0bcdde19ff2042862dd2ce43295fb41"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"38a92e9ec27fd2827c1629c89fb13f6510c27d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ec59d909_eb83d48e","updated":"2024-12-19 14:25:15.000000000","message":"looks sensible. thx","commit_id":"638e1e3062a42be9c9a0d4e83ad557c4c006e8a6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5e59e078c5d9fea198b015799eee20fa0c062b3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b225283c_df0b5fa1","updated":"2024-12-19 13:09:31.000000000","message":"thx","commit_id":"638e1e3062a42be9c9a0d4e83ad557c4c006e8a6"}],"kolla_ansible/utils.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1c40d33084b862a9e61547bd5ce3f867ffce18bf","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        args +\u003d [\"--force\"]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    retry_count \u003d itertools.count()"},{"line_number":113,"context_line":"    for i in range(0, 10):"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            run_command(\"ansible-galaxy\", args)"},{"line_number":116,"context_line":"        except subprocess.CalledProcessError as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"265e3156_966b2d10","line":113,"updated":"2024-12-19 06:15:09.000000000","message":"why do you loop until 10 if you never go that far?","commit_id":"b7f51142e0bcdde19ff2042862dd2ce43295fb41"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"662c3f2a8baef316dd46bf0d3dd588dff66cc231","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        args +\u003d [\"--force\"]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    retry_count \u003d itertools.count()"},{"line_number":113,"context_line":"    for i in range(0, 10):"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            run_command(\"ansible-galaxy\", args)"},{"line_number":116,"context_line":"        except subprocess.CalledProcessError as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"10ae38ad_0dc93f18","line":113,"in_reply_to":"265e3156_966b2d10","updated":"2024-12-19 08:05:57.000000000","message":"Done","commit_id":"b7f51142e0bcdde19ff2042862dd2ce43295fb41"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1c40d33084b862a9e61547bd5ce3f867ffce18bf","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            run_command(\"ansible-galaxy\", args)"},{"line_number":116,"context_line":"        except subprocess.CalledProcessError as e:"},{"line_number":117,"context_line":"            if next(retry_count) \u003c\u003d 5:"},{"line_number":118,"context_line":"                LOG.error(\"Failed to install Ansible collections from %s via \""},{"line_number":119,"context_line":"                          \"Ansible Galaxy (error: %s)- will retry in 2s\","},{"line_number":120,"context_line":"                          requirements_file, e)"}],"source_content_type":"text/x-python","patch_set":5,"id":"38da5048_19cfbb70","line":117,"updated":"2024-12-19 06:15:09.000000000","message":"can you explain why you are using itertools here, when you could use the loop variable just as well?","commit_id":"b7f51142e0bcdde19ff2042862dd2ce43295fb41"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"662c3f2a8baef316dd46bf0d3dd588dff66cc231","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            run_command(\"ansible-galaxy\", args)"},{"line_number":116,"context_line":"        except subprocess.CalledProcessError as e:"},{"line_number":117,"context_line":"            if next(retry_count) \u003c\u003d 5:"},{"line_number":118,"context_line":"                LOG.error(\"Failed to install Ansible collections from %s via \""},{"line_number":119,"context_line":"                          \"Ansible Galaxy (error: %s)- will retry in 2s\","},{"line_number":120,"context_line":"                          requirements_file, e)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb85a73a_3331fe76","line":117,"in_reply_to":"38da5048_19cfbb70","updated":"2024-12-19 08:05:57.000000000","message":"Done","commit_id":"b7f51142e0bcdde19ff2042862dd2ce43295fb41"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1c40d33084b862a9e61547bd5ce3f867ffce18bf","unresolved":true,"context_lines":[{"line_number":115,"context_line":"            run_command(\"ansible-galaxy\", args)"},{"line_number":116,"context_line":"        except subprocess.CalledProcessError as e:"},{"line_number":117,"context_line":"            if next(retry_count) \u003c\u003d 5:"},{"line_number":118,"context_line":"                LOG.error(\"Failed to install Ansible collections from %s via \""},{"line_number":119,"context_line":"                          \"Ansible Galaxy (error: %s)- will retry in 2s\","},{"line_number":120,"context_line":"                          requirements_file, e)"},{"line_number":121,"context_line":"                sleep(2)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a7f54701_9388adca","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":25},"updated":"2024-12-19 06:15:09.000000000","message":"when this is no longer fatal, just using warning level might be enough?","commit_id":"b7f51142e0bcdde19ff2042862dd2ce43295fb41"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"662c3f2a8baef316dd46bf0d3dd588dff66cc231","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            run_command(\"ansible-galaxy\", args)"},{"line_number":116,"context_line":"        except subprocess.CalledProcessError as e:"},{"line_number":117,"context_line":"            if next(retry_count) \u003c\u003d 5:"},{"line_number":118,"context_line":"                LOG.error(\"Failed to install Ansible collections from %s via \""},{"line_number":119,"context_line":"                          \"Ansible Galaxy (error: %s)- will retry in 2s\","},{"line_number":120,"context_line":"                          requirements_file, e)"},{"line_number":121,"context_line":"                sleep(2)"}],"source_content_type":"text/x-python","patch_set":5,"id":"07e09f0f_166f7ad8","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":25},"in_reply_to":"a7f54701_9388adca","updated":"2024-12-19 08:05:57.000000000","message":"Done","commit_id":"b7f51142e0bcdde19ff2042862dd2ce43295fb41"}]}