)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"92424bf3cf7d1399d799da97e859bfedc3c934b9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Tempest testing does not work out-the-box without this change, as they"},{"line_number":11,"context_line":"moved to ``block-storage`` already [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also replace references to cinder via catalog_info to just selecting the"},{"line_number":14,"context_line":"interface instead. This makes the configuration more consistent across"},{"line_number":15,"context_line":"all services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"1. https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/QQ7L44VE4MOWOQVOFCZQPTIVI35A6SCK/"},{"line_number":18,"context_line":"2. https://github.com/openstack/tempest/commit/1a744c8042d3c5c5ad153ef1e645975428ba0dfe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"94203e59_638fac5f","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":13},"updated":"2025-03-13 23:10:20.000000000","message":"This is not consistent because we have two different endpoints with different URLs even both are \u0027internal\u0027. We need the new one \u0027block-storage\u0027 without tenant_id\u0027s.","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"46ef05991b68dd6732b18bc12b0d78ab1adf022a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Tempest testing does not work out-the-box without this change, as they"},{"line_number":11,"context_line":"moved to ``block-storage`` already [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also replace references to cinder via catalog_info to just selecting the"},{"line_number":14,"context_line":"interface instead. This makes the configuration more consistent across"},{"line_number":15,"context_line":"all services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"1. https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/QQ7L44VE4MOWOQVOFCZQPTIVI35A6SCK/"},{"line_number":18,"context_line":"2. https://github.com/openstack/tempest/commit/1a744c8042d3c5c5ad153ef1e645975428ba0dfe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5fa20196_cac1219e","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":13},"in_reply_to":"41f4cf5f_dd7b545b","updated":"2025-03-14 11:59:08.000000000","message":"BTW: https://review.opendev.org/c/openstack/cinder/+/931699\nThe official documentation will soon be changed.","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca014e2fe4aff1c97761e4cc76f92c19f367de4a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Tempest testing does not work out-the-box without this change, as they"},{"line_number":11,"context_line":"moved to ``block-storage`` already [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also replace references to cinder via catalog_info to just selecting the"},{"line_number":14,"context_line":"interface instead. This makes the configuration more consistent across"},{"line_number":15,"context_line":"all services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"1. https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/QQ7L44VE4MOWOQVOFCZQPTIVI35A6SCK/"},{"line_number":18,"context_line":"2. https://github.com/openstack/tempest/commit/1a744c8042d3c5c5ad153ef1e645975428ba0dfe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"552eb955_fbe060d7","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":13},"in_reply_to":"5fa20196_cac1219e","updated":"2025-04-28 11:53:26.000000000","message":"Acknowledged","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e452670fca59b406ccbe837031f6a43bfd0b09bd","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Tempest testing does not work out-the-box without this change, as they"},{"line_number":11,"context_line":"moved to ``block-storage`` already [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also replace references to cinder via catalog_info to just selecting the"},{"line_number":14,"context_line":"interface instead. This makes the configuration more consistent across"},{"line_number":15,"context_line":"all services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"1. https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/QQ7L44VE4MOWOQVOFCZQPTIVI35A6SCK/"},{"line_number":18,"context_line":"2. https://github.com/openstack/tempest/commit/1a744c8042d3c5c5ad153ef1e645975428ba0dfe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"41f4cf5f_dd7b545b","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":13},"in_reply_to":"6c376abc_45f26185","updated":"2025-03-14 11:27:24.000000000","message":"we need to. other Openstack projects will follow changes in tempest.\nNB: we planned to switch from bash-scripts to tempest in kolla-ansible on CI.","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"91ad31d1e12b744d2f27f98f48facf0272dc5992","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Tempest testing does not work out-the-box without this change, as they"},{"line_number":11,"context_line":"moved to ``block-storage`` already [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also replace references to cinder via catalog_info to just selecting the"},{"line_number":14,"context_line":"interface instead. This makes the configuration more consistent across"},{"line_number":15,"context_line":"all services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"1. https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/QQ7L44VE4MOWOQVOFCZQPTIVI35A6SCK/"},{"line_number":18,"context_line":"2. https://github.com/openstack/tempest/commit/1a744c8042d3c5c5ad153ef1e645975428ba0dfe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"6c376abc_45f26185","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":13},"in_reply_to":"94203e59_638fac5f","updated":"2025-03-14 08:14:10.000000000","message":"I\u0027m not sure that we actually need to enforce this right away? consumers will switch at the latest when we remove the old service definition, this change just ensures that nothing should fail at that point. or am I missing something?","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d0e2e2bafe8aef8c1a6198fa02beb2bf7acb7cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"009497f3_1c045589","updated":"2024-12-04 15:50:28.000000000","message":"needs a reno","commit_id":"5604671af7f4eee0b1b02880862bf66f2f4fd39e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"73c94d95fc0f5dab19f169a75e120cdbeb547751","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6de579d5_e576b7f1","in_reply_to":"009497f3_1c045589","updated":"2024-12-04 16:05:33.000000000","message":"Done","commit_id":"5604671af7f4eee0b1b02880862bf66f2f4fd39e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"461868619dcb78914c648e5e9237173036600855","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa745fa4_db3a7fc9","updated":"2024-12-04 17:43:31.000000000","message":"What about the old type ? I think it won\u0027t be overriden, will be ?","commit_id":"702fe75a41e99256323298a8d678ab5c177f2448"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3a0442e0dd18c4b167e4485036be8d526f8f80cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55032ce6_a76b841c","in_reply_to":"2a386ca3_5237fb09","updated":"2024-12-05 10:21:41.000000000","message":"just remove the old one only in upgrade.yml","commit_id":"702fe75a41e99256323298a8d678ab5c177f2448"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"238d234d006ceac9e6878dc92f224c2bcddb7fa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3feda624_d802326e","in_reply_to":"4d918c72_4f85e406","updated":"2024-12-05 13:51:40.000000000","message":"Well, that was what we used to do - but I guess it\u0027s fine to have it where it is.","commit_id":"702fe75a41e99256323298a8d678ab5c177f2448"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"e65f4f0e9bf6f33183635680f21719ee7251f37b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d918c72_4f85e406","in_reply_to":"55032ce6_a76b841c","updated":"2024-12-05 10:47:20.000000000","message":"Why only in upgrade.yml?","commit_id":"702fe75a41e99256323298a8d678ab5c177f2448"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"cb4a3b65b10a75af22a7a7b132c6cd9f6c341344","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a386ca3_5237fb09","in_reply_to":"fa745fa4_db3a7fc9","updated":"2024-12-05 10:04:24.000000000","message":"Ah no you\u0027re right, a new service gets created but the old one isn\u0027t removed. I\u0027ll update this patch to do both.","commit_id":"702fe75a41e99256323298a8d678ab5c177f2448"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3471a5063c60075748237d02b36330776b253aba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8d8dfe7d_317b9ebd","updated":"2024-12-18 17:12:25.000000000","message":"seems nova doesn\u0027t like the new name ;-)","commit_id":"3d020b634a148b25fad1f65ef8726ea406829532"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"156b4a7a9883e82f014a05610466f87bb830aeb0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d024355b_59295dfd","in_reply_to":"8d8dfe7d_317b9ebd","updated":"2024-12-18 17:22:35.000000000","message":"strange... all the correct: https://docs.openstack.org/nova/latest/configuration/config.html#cinder","commit_id":"3d020b634a148b25fad1f65ef8726ea406829532"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e98899b22607c28751cf6beb970e3de02e7bffe7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dd3aa541_c53d99a8","in_reply_to":"d024355b_59295dfd","updated":"2024-12-19 12:56:19.000000000","message":"the validation doesn\u0027t allow the `-` :-( https://bugs.launchpad.net/nova/+bug/2092194\n\nsticking to the `volume` alias for now","commit_id":"3d020b634a148b25fad1f65ef8726ea406829532"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"926b0953db9a7554c70bc8bd4a333e9e20c62786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"90de1755_a753652a","in_reply_to":"dd3aa541_c53d99a8","updated":"2024-12-19 14:57:18.000000000","message":"ack","commit_id":"3d020b634a148b25fad1f65ef8726ea406829532"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f539b89a24ee2d59953f38ea2c6e0eed0ce5895a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9437c5a1_e75ba3a3","updated":"2025-03-11 09:03:39.000000000","message":"JFYI, I\u0027ve prepared a bunch of backports: https://review.opendev.org/q/I9a57aa72cc9589cec08b0f8d5797108043747ef6","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3a7888e5c0685263cb13e981aa3e7bad15a9d968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"53a5d845_e93a902b","updated":"2025-03-11 09:02:20.000000000","message":"https://review.opendev.org/c/openstack/nova/+/938053 is merged\nalso we need to land this till 2023.1 since this included in the 42.0.0 release of the tempest (https://docs.openstack.org/releasenotes/tempest/unreleased.html#relnotes-42-0-0)","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a74828249017aae7c321813f4f26786d5ecf6379","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"48cdaeae_16be718b","updated":"2025-03-13 10:04:51.000000000","message":"recheck amqp connection issues in neutron-metadata-agent","commit_id":"78db09de934200167488132638a4236038716d7f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6754b625627a1a50f9a841f305657a5c12541f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fb33b3a5_f0817936","updated":"2025-03-13 05:30:29.000000000","message":"recheck infra logs issues","commit_id":"78db09de934200167488132638a4236038716d7f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fcad0ed73686d386e5423fde998bee9f90fe967f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"11ec76f7_12fc7a0c","updated":"2025-04-28 08:17:57.000000000","message":"@frickler@offenerstapel.de all backports were merged: https://review.opendev.org/q/I9a57aa72cc9589cec08b0f8d5797108043747ef6\nso we need go back and made backports too","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b629abdbc16078b37f8bc84f80eb8ac4d81ce6a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f5a1de1b_5d81cc55","updated":"2025-04-28 11:04:15.000000000","message":"as is it can be backported. sad, but ok.","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7b62641f00d30248d6470d7339e1277f50d434fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"15e4dbc4_bb015d53","updated":"2025-03-19 08:19:37.000000000","message":"recheck CI fixed","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dcf9859b2f6c9ab54e21ccc81e0fbe0eeb762add","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fc70b4fe_807f435c","updated":"2025-03-19 11:46:18.000000000","message":"recheck unlucky timeout on rax","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3b3e62343158abacd7eedbce8dc5c3ca8ec88867","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"362cd1c0_9b11ba0e","in_reply_to":"11ec76f7_12fc7a0c","updated":"2025-04-28 11:02:38.000000000","message":"I don\u0027t see why we should need to, just because nova now allow to support it. I still think this change is fine as-is.","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b21b1c2ef3381383c9a162566e587953f815744","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"075ffd10_ed688c14","in_reply_to":"362cd1c0_9b11ba0e","updated":"2025-04-28 11:04:05.000000000","message":"I agree.","commit_id":"6ed3ff20d0c3c84c434f2508fbd0be8a2dfbeaaf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8629c799ffb92f29645c687225ee382477a34d76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9c780888_2cd1e15c","updated":"2025-04-28 17:45:35.000000000","message":"needed a rebase because it was based on an old version of a merged change","commit_id":"7d1f8d1d4b84908c2e9b9ab304ada9b3a97e7b51"}],"ansible/roles/cinder/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2f030b174a15b241d09ba351862a0a7a659fb19a","unresolved":true,"context_lines":[{"line_number":327,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ cinder_v3_internal_endpoint }}\u0027}"},{"line_number":328,"context_line":"      - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ cinder_v3_public_endpoint }}\u0027}"},{"line_number":329,"context_line":"  - name: \"cinderv3\""},{"line_number":330,"context_line":"    type: \"volumev3\""},{"line_number":331,"context_line":"    description: \"Openstack Block Storage\""},{"line_number":332,"context_line":"    endpoints:"},{"line_number":333,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ cinder_v3_internal_endpoint }}\u0027}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b31c4940_bd1e1827","line":330,"updated":"2024-12-05 11:40:14.000000000","message":"Needs a TODO note to remove it in F cycle","commit_id":"9bd904aa2cbd6cd68b20a01e016182f20864ed14"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2e6ddc44d352f407a9f3bf483301bd96fbe48710","unresolved":false,"context_lines":[{"line_number":327,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ cinder_v3_internal_endpoint }}\u0027}"},{"line_number":328,"context_line":"      - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ cinder_v3_public_endpoint }}\u0027}"},{"line_number":329,"context_line":"  - name: \"cinderv3\""},{"line_number":330,"context_line":"    type: \"volumev3\""},{"line_number":331,"context_line":"    description: \"Openstack Block Storage\""},{"line_number":332,"context_line":"    endpoints:"},{"line_number":333,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ cinder_v3_internal_endpoint }}\u0027}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"43929f74_308e94cb","line":330,"in_reply_to":"b31c4940_bd1e1827","updated":"2024-12-05 13:50:14.000000000","message":"Done","commit_id":"9bd904aa2cbd6cd68b20a01e016182f20864ed14"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"119bf27309ff6d51741f0b42c101634a22f33507","unresolved":true,"context_lines":[{"line_number":211,"context_line":"# OpenStack"},{"line_number":212,"context_line":"####################"},{"line_number":213,"context_line":"cinder_v3_internal_endpoint: \"{{ cinder_internal_base_endpoint }}/v3/%(tenant_id)s\""},{"line_number":214,"context_line":"cinder_v3_public_endpoint: \"{{ cinder_public_base_endpoint }}/v3/%(tenant_id)s\""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"cinder_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ddbec870_c56cf511","line":214,"updated":"2024-12-17 09:07:34.000000000","message":"comparing with what devstack does, the tenant_id part should be dropped from the URL, can we do this for the newly added endpoint, too? https://opendev.org/openstack/devstack/src/branch/master/lib/cinder#L472-L478","commit_id":"32743d18841bd65e2d5caef7a91a482584efeadd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6c1e5639cf5eff3a720c064ec2ebff9f7035c7de","unresolved":false,"context_lines":[{"line_number":211,"context_line":"# OpenStack"},{"line_number":212,"context_line":"####################"},{"line_number":213,"context_line":"cinder_v3_internal_endpoint: \"{{ cinder_internal_base_endpoint }}/v3/%(tenant_id)s\""},{"line_number":214,"context_line":"cinder_v3_public_endpoint: \"{{ cinder_public_base_endpoint }}/v3/%(tenant_id)s\""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"cinder_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"09e28b3c_2c479ad4","line":214,"in_reply_to":"ddbec870_c56cf511","updated":"2024-12-18 16:17:54.000000000","message":"Done","commit_id":"32743d18841bd65e2d5caef7a91a482584efeadd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"119bf27309ff6d51741f0b42c101634a22f33507","unresolved":true,"context_lines":[{"line_number":320,"context_line":"# Keystone"},{"line_number":321,"context_line":"####################"},{"line_number":322,"context_line":"cinder_ks_services:"},{"line_number":323,"context_line":"  - name: \"cinderv3\""},{"line_number":324,"context_line":"    type: \"block-storage\""},{"line_number":325,"context_line":"    description: \"Openstack Block Storage\""},{"line_number":326,"context_line":"    endpoints:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"95cfa978_33ec406a","line":323,"range":{"start_line":323,"start_character":11,"end_line":323,"end_character":19},"updated":"2024-12-17 09:07:34.000000000","message":"I think this should better have a different name, why not use just \"cinder\"?","commit_id":"32743d18841bd65e2d5caef7a91a482584efeadd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6c1e5639cf5eff3a720c064ec2ebff9f7035c7de","unresolved":false,"context_lines":[{"line_number":320,"context_line":"# Keystone"},{"line_number":321,"context_line":"####################"},{"line_number":322,"context_line":"cinder_ks_services:"},{"line_number":323,"context_line":"  - name: \"cinderv3\""},{"line_number":324,"context_line":"    type: \"block-storage\""},{"line_number":325,"context_line":"    description: \"Openstack Block Storage\""},{"line_number":326,"context_line":"    endpoints:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"11e1a43a_4c9dfa4a","line":323,"range":{"start_line":323,"start_character":11,"end_line":323,"end_character":19},"in_reply_to":"95cfa978_33ec406a","updated":"2024-12-18 16:17:54.000000000","message":"Done","commit_id":"32743d18841bd65e2d5caef7a91a482584efeadd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"119bf27309ff6d51741f0b42c101634a22f33507","unresolved":true,"context_lines":[{"line_number":333,"context_line":"    endpoints:"},{"line_number":334,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ cinder_v3_internal_endpoint }}\u0027}"},{"line_number":335,"context_line":"      - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ cinder_v3_public_endpoint }}\u0027}"},{"line_number":336,"context_line":"    state: \"absent\""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"cinder_ks_users:"},{"line_number":339,"context_line":"  - project: \"service\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"89c4282b_b8e4a6cf","line":336,"updated":"2024-12-17 09:07:34.000000000","message":"I don\u0027t think we can remove this right away if people choose to upgrade cinder first and consumers like nova later. so we\u0027d have to keep it in place for one (SLURP?) cycle, change to absent then and drop after another cycle I\u0027d think","commit_id":"32743d18841bd65e2d5caef7a91a482584efeadd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6c1e5639cf5eff3a720c064ec2ebff9f7035c7de","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    endpoints:"},{"line_number":334,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ cinder_v3_internal_endpoint }}\u0027}"},{"line_number":335,"context_line":"      - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ cinder_v3_public_endpoint }}\u0027}"},{"line_number":336,"context_line":"    state: \"absent\""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"cinder_ks_users:"},{"line_number":339,"context_line":"  - project: \"service\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6d1eed7e_34bdaf56","line":336,"in_reply_to":"26c7b71b_b593f11b","updated":"2024-12-18 16:17:54.000000000","message":"Done","commit_id":"32743d18841bd65e2d5caef7a91a482584efeadd"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fa24c5871ffc4f6b4974065997b9faf044f2727b","unresolved":true,"context_lines":[{"line_number":333,"context_line":"    endpoints:"},{"line_number":334,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ cinder_v3_internal_endpoint }}\u0027}"},{"line_number":335,"context_line":"      - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ cinder_v3_public_endpoint }}\u0027}"},{"line_number":336,"context_line":"    state: \"absent\""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"cinder_ks_users:"},{"line_number":339,"context_line":"  - project: \"service\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"26c7b71b_b593f11b","line":336,"in_reply_to":"89c4282b_b8e4a6cf","updated":"2024-12-18 12:25:10.000000000","message":"makes sense","commit_id":"32743d18841bd65e2d5caef7a91a482584efeadd"}],"ansible/roles/nova-cell/templates/nova.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a8865218e8cc51e1a29b0839b0ff57f8295b7f6c","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"catalog_info \u003d volume::internalURL"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"53e944b1_ec395740","line":113,"updated":"2024-12-19 15:47:52.000000000","message":"so using this unversioned alias also does not work. I\u0027m wondering whether we should switch completely and just use\n\n```\ninterface \u003d internal\n```\n\ninstead? that would match what devstack does. what is the reason to use `catalog_info`?","commit_id":"20ec4f52bb0c1e1bf578537325e4eabc84d2405e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"78ec6086a42c5494276fcd96ad0dff976905262d","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"catalog_info \u003d volume::internalURL"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"6171e0e1_22a7f51c","line":113,"in_reply_to":"53e944b1_ec395740","updated":"2024-12-19 15:53:00.000000000","message":"sad. may be wait for https://review.opendev.org/c/openstack/nova/+/938053 get landed?","commit_id":"20ec4f52bb0c1e1bf578537325e4eabc84d2405e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca014e2fe4aff1c97761e4cc76f92c19f367de4a","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"catalog_info \u003d volume::internalURL"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"b88d90cb_125c20d5","line":113,"in_reply_to":"6171e0e1_22a7f51c","updated":"2025-04-28 11:53:26.000000000","message":"Done","commit_id":"20ec4f52bb0c1e1bf578537325e4eabc84d2405e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1246387d988711883c3d79374598d8bd6a57fd69","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7dc876e7_75953d46","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"updated":"2024-12-20 11:37:53.000000000","message":"should we need a TODO comment to change this later?","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"482b3e80c19011703ffc3110337acc4d06ffa64c","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"802ff5f0_9a879994","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"in_reply_to":"2e5827a8_cff7cfa6","updated":"2024-12-22 08:06:21.000000000","message":"well we have two definitions that point to the same URL, so it shouldn\u0027t matter much.\n\nhowever it just occured to me that I should check whether this setting actually works for the volume endpoint or just sets the initial keystone endpoint being used.","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"88ff3a603d9c55ef8057aab5f599ef45a9ed13eb","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"aebc57a3_43bd773a","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"in_reply_to":"56665142_62865aad","updated":"2025-03-12 08:28:15.000000000","message":"do we want to go back to the `catalog_info` version of the change, then? I\u0027m not sure that that would make this change backportable, even if nova did merge the backports of their fix","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7600eadc90ad329af5ef0dbb802f5b6df5a1ad16","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"2e5827a8_cff7cfa6","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"in_reply_to":"7b0b0e49_f4e4fa5f","updated":"2024-12-20 12:12:39.000000000","message":"but we have two internal endpoints at some time? or I\u0027m wrong?","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5630b27f9b128c067c053b921c0d7ceec6819789","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7b0b0e49_f4e4fa5f","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"in_reply_to":"7dc876e7_75953d46","updated":"2024-12-20 12:01:41.000000000","message":"I would see this as a permanent solution, from what I see, the main point of the original line was to make sure that we are using the internal endpoint, and this is what this does, without having to care about what the actual service type designation is","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bf2a54b9a6fc36488554568a2f87730ba09eaa8c","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"56665142_62865aad","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"in_reply_to":"802ff5f0_9a879994","updated":"2024-12-23 07:08:19.000000000","message":"yep, just say we need to check them","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a09f001c9392d4a5772b34aa33c7c64791bfc406","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"b304a1f8_4dc82d78","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"in_reply_to":"aebc57a3_43bd773a","updated":"2025-03-12 09:45:26.000000000","message":"we need to go back and it would be backportable till 2023.1 if nova merge all backports","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9a711bb6451f0077e232ae711f0e57929e91667f","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"c9befa56_37395d1b","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"in_reply_to":"b304a1f8_4dc82d78","updated":"2025-03-12 11:11:47.000000000","message":"Also, there is a need to add \"Depends-On: I9a57aa72cc9589ce08b0f8d5797108043747e6\" if we go back, it wouldn\u0027t work in the CI, but a core reviewer would be notified to check before merging the specified backport.","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca014e2fe4aff1c97761e4cc76f92c19f367de4a","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% if enable_cinder | bool %}"},{"line_number":112,"context_line":"[cinder]"},{"line_number":113,"context_line":"interface \u003d internal"},{"line_number":114,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":115,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":116,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"4b7b3aed_c1182dd7","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":20},"in_reply_to":"c9befa56_37395d1b","updated":"2025-04-28 11:53:26.000000000","message":"Acknowledged","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7c78a6a4b63d319d83aab9f63dfa3dc86e597163","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% if enable_cinder | bool %}"},{"line_number":66,"context_line":"[cinder]"},{"line_number":67,"context_line":"interface \u003d internal"},{"line_number":68,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":69,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":70,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7aa9545d_e8c8e106","line":67,"range":{"start_line":67,"start_character":12,"end_line":67,"end_character":20},"updated":"2024-12-20 11:38:09.000000000","message":"ditto","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca014e2fe4aff1c97761e4cc76f92c19f367de4a","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% if enable_cinder | bool %}"},{"line_number":66,"context_line":"[cinder]"},{"line_number":67,"context_line":"interface \u003d internal"},{"line_number":68,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":69,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":70,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"709502c0_5b4c1384","line":67,"range":{"start_line":67,"start_character":12,"end_line":67,"end_character":20},"in_reply_to":"7aa9545d_e8c8e106","updated":"2025-04-28 11:53:26.000000000","message":"Acknowledged","commit_id":"211a1e64caabadbbb6beb6f424d4195f7205ef96"}]}