)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d853eba8cbe22fa8ffd41859dcd383c9989f4a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"242cf22c_e11177e0","updated":"2024-12-18 08:48:09.000000000","message":"recheck another round","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"}],"ansible/roles/loadbalancer/defaults/main.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":208,"context_line":"mariadb_connect_timeout_client: \"\""},{"line_number":209,"context_line":"mariadb_connect_timeout_server: \"\""},{"line_number":210,"context_line":"mariadb_connect_timeout_server_max: \"\""},{"line_number":211,"context_line":"mariadb_monitor_connect_interval: \"\""},{"line_number":212,"context_line":"mariadb_monitor_connect_timeout: \"\""},{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"f83018fe_f258a9b3","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":32},"updated":"2024-12-18 10:17:51.000000000","message":"do we really want to check mariadb node every 2 minutes ?","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":false,"context_lines":[{"line_number":208,"context_line":"mariadb_connect_timeout_client: \"\""},{"line_number":209,"context_line":"mariadb_connect_timeout_server: \"\""},{"line_number":210,"context_line":"mariadb_connect_timeout_server_max: \"\""},{"line_number":211,"context_line":"mariadb_monitor_connect_interval: \"\""},{"line_number":212,"context_line":"mariadb_monitor_connect_timeout: \"\""},{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"2c0d22ce_9cc95020","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":32},"in_reply_to":"f83018fe_f258a9b3","updated":"2024-12-18 12:58:04.000000000","message":"Nope, keeping the default of 2000","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":210,"context_line":"mariadb_connect_timeout_server_max: \"\""},{"line_number":211,"context_line":"mariadb_monitor_connect_interval: \"\""},{"line_number":212,"context_line":"mariadb_monitor_connect_timeout: \"\""},{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ca2e8ed8_848daaf2","line":213,"range":{"start_line":213,"start_character":0,"end_line":213,"end_character":43},"updated":"2024-12-18 10:17:51.000000000","message":"5000 ms ? Probably ok","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":false,"context_lines":[{"line_number":210,"context_line":"mariadb_connect_timeout_server_max: \"\""},{"line_number":211,"context_line":"mariadb_monitor_connect_interval: \"\""},{"line_number":212,"context_line":"mariadb_monitor_connect_timeout: \"\""},{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"2f9b79ba_eefa4bda","line":213,"range":{"start_line":213,"start_character":0,"end_line":213,"end_character":43},"in_reply_to":"ca2e8ed8_848daaf2","updated":"2024-12-18 12:58:04.000000000","message":"Acknowledged","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":211,"context_line":"mariadb_monitor_connect_interval: \"\""},{"line_number":212,"context_line":"mariadb_monitor_connect_timeout: \"\""},{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3e03d29d_d87c328b","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":42},"updated":"2024-12-18 10:17:51.000000000","message":"800 ms ? Probably OK","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":false,"context_lines":[{"line_number":211,"context_line":"mariadb_monitor_connect_interval: \"\""},{"line_number":212,"context_line":"mariadb_monitor_connect_timeout: \"\""},{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b617c10b_70045f52","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":42},"in_reply_to":"3e03d29d_d87c328b","updated":"2024-12-18 12:58:04.000000000","message":"Acknowledged","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":212,"context_line":"mariadb_monitor_connect_timeout: \"\""},{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bdff8241_171cd87b","line":215,"range":{"start_line":215,"start_character":0,"end_line":215,"end_character":52},"updated":"2024-12-18 10:17:51.000000000","message":"3 ? Probably OK","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":false,"context_lines":[{"line_number":212,"context_line":"mariadb_monitor_connect_timeout: \"\""},{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b6a9b323_1929896f","line":215,"range":{"start_line":215,"start_character":0,"end_line":215,"end_character":52},"in_reply_to":"bdff8241_171cd87b","updated":"2024-12-18 12:58:04.000000000","message":"Acknowledged","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""},{"line_number":219,"context_line":"mariadb_monitor_read_only_interval: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"de56efad_c4dbc24b","line":216,"range":{"start_line":216,"start_character":0,"end_line":216,"end_character":29},"updated":"2024-12-18 10:17:51.000000000","message":"8000 ms ? Probably OK","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":false,"context_lines":[{"line_number":213,"context_line":"mariadb_monitor_galera_healthcheck_interval: \"\""},{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""},{"line_number":219,"context_line":"mariadb_monitor_read_only_interval: \"\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"325c0997_ac978767","line":216,"range":{"start_line":216,"start_character":0,"end_line":216,"end_character":29},"in_reply_to":"de56efad_c4dbc24b","updated":"2024-12-18 12:58:04.000000000","message":"Acknowledged","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""},{"line_number":219,"context_line":"mariadb_monitor_read_only_interval: \"\""},{"line_number":220,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bf1e279f_84b3338b","line":217,"range":{"start_line":217,"start_character":0,"end_line":217,"end_character":28},"updated":"2024-12-18 10:17:51.000000000","message":"1000 ? Probably OK","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":false,"context_lines":[{"line_number":214,"context_line":"mariadb_monitor_galera_healthcheck_timeout: \"\""},{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""},{"line_number":219,"context_line":"mariadb_monitor_read_only_interval: \"\""},{"line_number":220,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"0ffacd67_d5db8f45","line":217,"range":{"start_line":217,"start_character":0,"end_line":217,"end_character":28},"in_reply_to":"bf1e279f_84b3338b","updated":"2024-12-18 12:58:04.000000000","message":"Acknowledged","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""},{"line_number":219,"context_line":"mariadb_monitor_read_only_interval: \"\""},{"line_number":220,"context_line":"#"},{"line_number":221,"context_line":"# Defaults preserved for multinode setup"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"52600c74_5ab8b58f","line":218,"range":{"start_line":218,"start_character":0,"end_line":218,"end_character":33},"updated":"2024-12-18 10:17:51.000000000","message":"3 ? Probably OK","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":false,"context_lines":[{"line_number":215,"context_line":"mariadb_monitor_galera_healthcheck_max_timeout_count: \"\""},{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""},{"line_number":219,"context_line":"mariadb_monitor_read_only_interval: \"\""},{"line_number":220,"context_line":"#"},{"line_number":221,"context_line":"# Defaults preserved for multinode setup"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ab5d4677_09d01eb0","line":218,"range":{"start_line":218,"start_character":0,"end_line":218,"end_character":33},"in_reply_to":"52600c74_5ab8b58f","updated":"2024-12-18 12:58:04.000000000","message":"Acknowledged","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""},{"line_number":219,"context_line":"mariadb_monitor_read_only_interval: \"\""},{"line_number":220,"context_line":"#"},{"line_number":221,"context_line":"# Defaults preserved for multinode setup"},{"line_number":222,"context_line":"# Tweaked for single-node"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f926c38_9c4b47bb","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":34},"updated":"2024-12-18 10:17:51.000000000","message":"The default value for this is 1000 ms ... \n\n - We do not use read-only MariaDB nodes.\n - A node is read-only in Galera when SST is being performed.\n - A node is read-only in Galera when it is in Donor state.\n - A node is read-only in Galera when it is not part of the quorum.\n\nGiven the above, is 1000 ms OK or not?","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":false,"context_lines":[{"line_number":216,"context_line":"mariadb_monitor_ping_interval: \"\""},{"line_number":217,"context_line":"mariadb_monitor_ping_timeout: \"\""},{"line_number":218,"context_line":"mariadb_monitor_ping_max_failures: \"\""},{"line_number":219,"context_line":"mariadb_monitor_read_only_interval: \"\""},{"line_number":220,"context_line":"#"},{"line_number":221,"context_line":"# Defaults preserved for multinode setup"},{"line_number":222,"context_line":"# Tweaked for single-node"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"a014573c_9fc2850f","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":34},"in_reply_to":"7f926c38_9c4b47bb","updated":"2024-12-18 12:58:04.000000000","message":"I\u0027ve seen we had to bump it up on CI nodes, but it was not manifesting all the time.","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e6af623a01de3e6c1cae9a9ac98d40c33d35d5a0","unresolved":true,"context_lines":[{"line_number":228,"context_line":"# giving the backend time to recover without immediate failures."},{"line_number":229,"context_line":"#"},{"line_number":230,"context_line":"# See ProxySQL docs for more: https://proxysql.com/documentation/global-variables/mysql-variables/#mysql-shun_on_failures"},{"line_number":231,"context_line":"mariadb_singlenode: \"{{ mariadb_shards_info.shards.values() | map(attribute\u003d\u0027hosts\u0027) | map(\u0027length\u0027) | select(\u0027\u003c\u003d\u0027, 1) | list | length \u003e 0 }}\""},{"line_number":232,"context_line":"mariadb_shun_on_failures: \"{{ \u002710\u0027 if mariadb_singlenode else \u0027\u0027 }}\""},{"line_number":233,"context_line":"mariadb_connect_retries_delay: \"{{ \u00271000\u0027 if mariadb_singlenode else \u0027\u0027 }}\""},{"line_number":234,"context_line":"mariadb_connect_retries_on_failure: \"{{ \u002720\u0027 if mariadb_singlenode else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"50e610d9_9780346e","line":234,"range":{"start_line":231,"start_character":0,"end_line":234,"end_character":78},"updated":"2024-12-18 10:17:51.000000000","message":"I think this can be also switcheed to default or near defaults. This was mainly amended because of CI is using one-node.\n\nI was trying to somehow modify values to don\u0027t receive proxysql error \"Can\u0027t reach hostgroup 0 after 10000 ms. - But this is probably not possible ..and CI started to pass when @mnasiadka@gmail.com added exclude string with the error to the CI analyzing logs.\n\nMain problem was that CI failed because of error, but services can recover from it and now the error is excluded - it needs to be tested i think.","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2699afe8b1faf0235c075da7a745eed999d7547","unresolved":true,"context_lines":[{"line_number":228,"context_line":"# giving the backend time to recover without immediate failures."},{"line_number":229,"context_line":"#"},{"line_number":230,"context_line":"# See ProxySQL docs for more: https://proxysql.com/documentation/global-variables/mysql-variables/#mysql-shun_on_failures"},{"line_number":231,"context_line":"mariadb_singlenode: \"{{ mariadb_shards_info.shards.values() | map(attribute\u003d\u0027hosts\u0027) | map(\u0027length\u0027) | select(\u0027\u003c\u003d\u0027, 1) | list | length \u003e 0 }}\""},{"line_number":232,"context_line":"mariadb_shun_on_failures: \"{{ \u002710\u0027 if mariadb_singlenode else \u0027\u0027 }}\""},{"line_number":233,"context_line":"mariadb_connect_retries_delay: \"{{ \u00271000\u0027 if mariadb_singlenode else \u0027\u0027 }}\""},{"line_number":234,"context_line":"mariadb_connect_retries_on_failure: \"{{ \u002720\u0027 if mariadb_singlenode else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9e30c67f_089db14f","line":234,"range":{"start_line":231,"start_character":0,"end_line":234,"end_character":78},"in_reply_to":"50e610d9_9780346e","updated":"2024-12-18 12:58:04.000000000","message":"Let\u0027s try to do this in a separate patch.","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"51c2babbab7592e6bcfb1b9b8ea2c9b8ba0730f9","unresolved":false,"context_lines":[{"line_number":228,"context_line":"# giving the backend time to recover without immediate failures."},{"line_number":229,"context_line":"#"},{"line_number":230,"context_line":"# See ProxySQL docs for more: https://proxysql.com/documentation/global-variables/mysql-variables/#mysql-shun_on_failures"},{"line_number":231,"context_line":"mariadb_singlenode: \"{{ mariadb_shards_info.shards.values() | map(attribute\u003d\u0027hosts\u0027) | map(\u0027length\u0027) | select(\u0027\u003c\u003d\u0027, 1) | list | length \u003e 0 }}\""},{"line_number":232,"context_line":"mariadb_shun_on_failures: \"{{ \u002710\u0027 if mariadb_singlenode else \u0027\u0027 }}\""},{"line_number":233,"context_line":"mariadb_connect_retries_delay: \"{{ \u00271000\u0027 if mariadb_singlenode else \u0027\u0027 }}\""},{"line_number":234,"context_line":"mariadb_connect_retries_on_failure: \"{{ \u002720\u0027 if mariadb_singlenode else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"4e63180e_fa5df99b","line":234,"range":{"start_line":231,"start_character":0,"end_line":234,"end_character":78},"in_reply_to":"9e30c67f_089db14f","updated":"2025-01-22 15:52:06.000000000","message":"Acknowledged","commit_id":"8ac8a8d44e625490193265767e42ab045c22d874"}],"ansible/roles/loadbalancer/templates/proxysql/proxysql.yaml.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3cd2c0c7d71e3b78b1affeaca1bf73b68769ee4b","unresolved":true,"context_lines":[{"line_number":20,"context_line":"   threads: {{ proxysql_workers }}"},{"line_number":21,"context_line":"   max_connections: {{ proxysql_max_connections }}"},{"line_number":22,"context_line":"   interfaces: \"{{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":23,"context_line":"   connect_retries_delay: \"{{ mariadb_connect_retries_delay }}\""},{"line_number":24,"context_line":"   connect_retries_on_failure: \"{{ mariadb_connect_retries_on_failure }}\""},{"line_number":25,"context_line":"   shun_on_failures: \"{{ mariadb_shun_on_failures }}\""},{"line_number":26,"context_line":"{% if mariadb_connect_retries_delay | length \u003e 0 %}"},{"line_number":27,"context_line":"   connect_retries_delay: {{ mariadb_connect_retries_delay }}"},{"line_number":28,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"123adcf5_bf5cc68d","line":25,"range":{"start_line":23,"start_character":3,"end_line":25,"end_character":53},"updated":"2024-12-17 12:55:06.000000000","message":"these are duplicated below","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dcdcded880c69e64677434df6b1e865bea2f66c4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"   threads: {{ proxysql_workers }}"},{"line_number":21,"context_line":"   max_connections: {{ proxysql_max_connections }}"},{"line_number":22,"context_line":"   interfaces: \"{{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":23,"context_line":"   connect_retries_delay: \"{{ mariadb_connect_retries_delay }}\""},{"line_number":24,"context_line":"   connect_retries_on_failure: \"{{ mariadb_connect_retries_on_failure }}\""},{"line_number":25,"context_line":"   shun_on_failures: \"{{ mariadb_shun_on_failures }}\""},{"line_number":26,"context_line":"{% if mariadb_connect_retries_delay | length \u003e 0 %}"},{"line_number":27,"context_line":"   connect_retries_delay: {{ mariadb_connect_retries_delay }}"},{"line_number":28,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"d1bb9799_aabc8b32","line":25,"range":{"start_line":23,"start_character":3,"end_line":25,"end_character":53},"in_reply_to":"123adcf5_bf5cc68d","updated":"2024-12-17 13:03:36.000000000","message":"Done","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"}],"releasenotes/notes/proxysql-revert-to-upstream-defaults-235abb7fb10bfcfd.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3cd2c0c7d71e3b78b1affeaca1bf73b68769ee4b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Following ``proxysql`` variables have been reverted to upstream defaults"},{"line_number":5,"context_line":"    (unless overridden using Ansible variables)."},{"line_number":6,"context_line":"    In case of ``shun_on_failures``, ``connect_retries_delay`` and"},{"line_number":7,"context_line":"    ``connect_retries_on_failure`` we still have own defaults for all-in-one"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"6f20b13e_31bf1b0a","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":13},"updated":"2024-12-17 12:55:06.000000000","message":"\"The following\"?","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dcdcded880c69e64677434df6b1e865bea2f66c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Following ``proxysql`` variables have been reverted to upstream defaults"},{"line_number":5,"context_line":"    (unless overridden using Ansible variables)."},{"line_number":6,"context_line":"    In case of ``shun_on_failures``, ``connect_retries_delay`` and"},{"line_number":7,"context_line":"    ``connect_retries_on_failure`` we still have own defaults for all-in-one"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"c7f7bcc0_d4a42d89","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":13},"in_reply_to":"6f20b13e_31bf1b0a","updated":"2024-12-17 13:03:36.000000000","message":"Done","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3cd2c0c7d71e3b78b1affeaca1bf73b68769ee4b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    .. list-table::"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"      * - Variable name"},{"line_number":13,"context_line":"        - K-A default"},{"line_number":14,"context_line":"        - upstream default"},{"line_number":15,"context_line":"      * - connect_retries_delay"},{"line_number":16,"context_line":"        - 1000 (aio) / 1"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"dd4c5aec_a7df5a32","line":13,"updated":"2024-12-17 12:55:06.000000000","message":"IMO we have enough space to spell out \"kolla-ansible\" here, avoids some confusion maybe","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dcdcded880c69e64677434df6b1e865bea2f66c4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    .. list-table::"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"      * - Variable name"},{"line_number":13,"context_line":"        - K-A default"},{"line_number":14,"context_line":"        - upstream default"},{"line_number":15,"context_line":"      * - connect_retries_delay"},{"line_number":16,"context_line":"        - 1000 (aio) / 1"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"27b41cad_89cb6368","line":13,"in_reply_to":"dd4c5aec_a7df5a32","updated":"2024-12-17 13:03:36.000000000","message":"Done","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3cd2c0c7d71e3b78b1affeaca1bf73b68769ee4b","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  - \"evs.inactive_timeout\u003dPT30S\""},{"line_number":43,"context_line":"  - \"evs.keepalive_period\u003dPT3S\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"mariadb_monitor_connect_timeout: \"10000\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"nova_compute_virt_type: \"{{ virt_type }}\""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"51aedf39_2d5cde2f","line":45,"range":{"start_line":45,"start_character":34,"end_line":45,"end_character":39},"updated":"2024-12-17 12:55:06.000000000","message":"the old value was 6000, was that too small?","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dcdcded880c69e64677434df6b1e865bea2f66c4","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  - \"evs.inactive_timeout\u003dPT30S\""},{"line_number":43,"context_line":"  - \"evs.keepalive_period\u003dPT3S\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"mariadb_monitor_connect_timeout: \"10000\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"nova_compute_virt_type: \"{{ virt_type }}\""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"d4da2dbe_ed5e4029","line":45,"range":{"start_line":45,"start_character":34,"end_line":45,"end_character":39},"in_reply_to":"51aedf39_2d5cde2f","updated":"2024-12-17 13:03:36.000000000","message":"During rechecking of that patch I\u0027ve seen it fail on some occasions, let me switch it back to 6000 and let\u0027s see if that fails.","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ea97fc38adc182359c3f8531d9fbd4e3da7f973","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  - \"evs.inactive_timeout\u003dPT30S\""},{"line_number":43,"context_line":"  - \"evs.keepalive_period\u003dPT3S\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"mariadb_monitor_connect_timeout: \"10000\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"nova_compute_virt_type: \"{{ virt_type }}\""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"0d7370b2_c63ea832","line":45,"range":{"start_line":45,"start_character":34,"end_line":45,"end_character":39},"in_reply_to":"d4da2dbe_ed5e4029","updated":"2024-12-18 08:48:23.000000000","message":"looks good","commit_id":"e26b85984ccdf6dba654ad6ebc61517c12b3451a"}]}
