)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"61ba428813cc3bab09ee501cde3311dbdf1b22e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"272f6ca7_f23518d3","updated":"2025-01-13 10:44:32.000000000","message":"Michal, what is your decision?","commit_id":"b735c90e051ac1876995c4062409df582671d8bb"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d26a3782be2bda60569e9dda377eb1d1463d9b11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ffba1025_810b8fe5","updated":"2025-02-19 14:24:54.000000000","message":"ok, as discussed on IRC lets review this","commit_id":"b735c90e051ac1876995c4062409df582671d8bb"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bb567850503f7a764eb84f76a29dc829fdc69bec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"799f5684_0025488c","updated":"2025-01-10 08:15:57.000000000","message":"on the last PTG we agreed not add more cinder backends and make it more generic","commit_id":"b735c90e051ac1876995c4062409df582671d8bb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"e2a2fbdce7cc05978437c1d2f4fb540faf275e44","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4560ae7_e5b5f13b","in_reply_to":"799f5684_0025488c","updated":"2025-01-13 09:57:11.000000000","message":"Hi Maksim,\n\nThank you for reviewing my recent patch. I understand and respect the decision to focus on maintaining a general solution rather than merging vendor-specific functionality.\n\nIf merging this PR is still an option, please consider it as we have users waiting for this functionality.\n\nI’d also like to offer my assistance in refactoring or extending the code to make it align with the project’s goals of generality. Please let me know how I can help with this effort—I’m happy to collaborate on adjustments, tests, or documentation to meet the project’s standards.\n\nLooking forward to hearing your thoughts!","commit_id":"b735c90e051ac1876995c4062409df582671d8bb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"854d219e0f2051a13e3df043c21c7bd7fc0dd405","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb7a9ebb_fca8a338","in_reply_to":"b4560ae7_e5b5f13b","updated":"2025-02-25 15:10:04.000000000","message":"Done","commit_id":"b735c90e051ac1876995c4062409df582671d8bb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"228345caa3adbb070ae960960156f34225806412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b243670f_c7ef6ee3","updated":"2025-02-20 10:09:57.000000000","message":"Missing reno","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"54e99eeddb4f4c3d6c5d6089f4a125396bbe15ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f29f19e_e8a5f569","in_reply_to":"4a814908_9192d87f","updated":"2025-02-20 16:18:11.000000000","message":"Done","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c819b902051d58443a616c23e235b662334366a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a814908_9192d87f","in_reply_to":"546500cc_b4f7a154","updated":"2025-02-20 15:14:36.000000000","message":"release note - documented in Kolla Contributor Guide - https://docs.openstack.org/kolla/latest/contributor/release-notes.html","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"182a48fc62a6cbcfa774da61d2abe7659c974c83","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"546500cc_b4f7a154","in_reply_to":"b243670f_c7ef6ee3","updated":"2025-02-20 14:14:56.000000000","message":"Can you explain what is reno?","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"54e99eeddb4f4c3d6c5d6089f4a125396bbe15ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f99ded55_530f0858","updated":"2025-02-20 16:18:11.000000000","message":"Great comments! thank you, fixed","commit_id":"b60e5380e338fdad258010a3c449f284de308418"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"5671ffddbe03bf1a4ec12c2699d04b06bb6f56bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fc83feb5_d29a2a6d","updated":"2025-03-06 16:33:51.000000000","message":"Can this be merge to be part of expoxy?","commit_id":"e2614a7c1e93abaca74834128a2d3ba9eeda4efc"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"c8b227cd2871fb4a0d06a57f21de9665183fca96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0e25a615_1d99e935","updated":"2025-02-26 09:05:46.000000000","message":"recheck","commit_id":"e2614a7c1e93abaca74834128a2d3ba9eeda4efc"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"c0e702498bc9b3a31958139d9dc15d108e5ae18c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f942e0a3_2cb954a7","updated":"2025-03-13 08:26:59.000000000","message":"recheck","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"044daffbdb7cfe185c46102bc19d2f8c65cd3f9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"74df5c86_814c5f09","updated":"2025-03-27 16:33:49.000000000","message":"recheck - mariadb issue","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"f87b8b26bfb32ef61cfd2f2959d254c3fbd276fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"56be987c_e789ec18","updated":"2025-03-19 10:21:37.000000000","message":"recheck after neutron fix merged","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"16b86a8a2bc102e56dbd456a0bcff653fec3ecf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4e24be2c_f613660b","updated":"2025-03-16 12:29:11.000000000","message":"recheck failed to ssh vm","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"637d3af0f761b7c7f8e86e5231402a4a5f60873b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f528a279_924995d7","updated":"2025-03-16 07:22:31.000000000","message":"recheck neutron_metadata_agent failed","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"405dc5fb22aa3dcb6e9e6b7a078a8d151e08eb4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bdd326d8_febdf1c8","in_reply_to":"4ff02f17_ae117749","updated":"2025-03-13 12:06:24.000000000","message":"got it - will wait.\nalso what you mean by \"bare rechecks\"?","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"88adb11e9ad6a26e07dcedc6dd7e1e6b30c41406","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"901b113f_b9979413","in_reply_to":"a2191306_05b41fe2","updated":"2025-03-13 13:14:35.000000000","message":"got it, Thanks","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"46bff301798e1e0d67413b74c57b9038f0a0a08e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a2191306_05b41fe2","in_reply_to":"bdd326d8_febdf1c8","updated":"2025-03-13 12:16:38.000000000","message":"you need to specify a reason for recheck right after the keyword\nfor example \u0027recheck strange neutron-metadata-agent healthcheck issue\u0027","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"09f3bf8fae1a45a42405897e97e642f198c419f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4ff02f17_ae117749","in_reply_to":"f942e0a3_2cb954a7","updated":"2025-03-13 11:46:07.000000000","message":"please don\u0027t do bare rechecks\nalso please wait for https://review.opendev.org/c/openstack/kolla-ansible/+/944194\nit should fix the CI issue","commit_id":"4b05fa8a5faec3584e40f30b687cf3ea28abf158"}],"ansible/roles/cinder/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1390ef6dc91626dda00dc8d7d078d55a3ac5902e","unresolved":true,"context_lines":[{"line_number":311,"context_line":"# Lightbits Storage Driver"},{"line_number":312,"context_line":"###############################"},{"line_number":313,"context_line":"lightbits_nvme_tcp_backend_name: \"lightbits_nvme_backend\""},{"line_number":314,"context_line":"lightos_skip_ssl_verify: True"},{"line_number":315,"context_line":"lightos_api_port: 443"},{"line_number":316,"context_line":"lightos_default_num_replicas: 3"},{"line_number":317,"context_line":"lightos_api_address:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"20710f0d_c5d50193","line":314,"updated":"2025-02-20 15:16:39.000000000","message":"I\u0027d say by default we don\u0027t want to skip ssl verification, that could be seen as a security bug","commit_id":"7706d3e3236205a738ac38fba8cdf00c4b37bdfa"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"54e99eeddb4f4c3d6c5d6089f4a125396bbe15ce","unresolved":false,"context_lines":[{"line_number":311,"context_line":"# Lightbits Storage Driver"},{"line_number":312,"context_line":"###############################"},{"line_number":313,"context_line":"lightbits_nvme_tcp_backend_name: \"lightbits_nvme_backend\""},{"line_number":314,"context_line":"lightos_skip_ssl_verify: True"},{"line_number":315,"context_line":"lightos_api_port: 443"},{"line_number":316,"context_line":"lightos_default_num_replicas: 3"},{"line_number":317,"context_line":"lightos_api_address:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"13a5fc86_a2b3f7ad","line":314,"in_reply_to":"20710f0d_c5d50193","updated":"2025-02-20 16:18:11.000000000","message":"Done","commit_id":"7706d3e3236205a738ac38fba8cdf00c4b37bdfa"}],"ansible/roles/cinder/tasks/precheck.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1390ef6dc91626dda00dc8d7d078d55a3ac5902e","unresolved":true,"context_lines":[{"line_number":72,"context_line":"- name: Check if Lightbits configurations are defined"},{"line_number":73,"context_line":"  assert:"},{"line_number":74,"context_line":"    that:"},{"line_number":75,"context_line":"      - vars[item] is defined"},{"line_number":76,"context_line":"    msg: \"Cinder Lightbits backend is enabled, the {{ item }} variable must be defined.\""},{"line_number":77,"context_line":"  with_items:"},{"line_number":78,"context_line":"    - lightos_api_address"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"97b5131d_876d1fdf","line":75,"updated":"2025-02-20 15:16:39.000000000","message":"it is defined because we have it in defaults, I\u0027d say we need vars[item] | length \u003e 0","commit_id":"7706d3e3236205a738ac38fba8cdf00c4b37bdfa"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"54e99eeddb4f4c3d6c5d6089f4a125396bbe15ce","unresolved":false,"context_lines":[{"line_number":72,"context_line":"- name: Check if Lightbits configurations are defined"},{"line_number":73,"context_line":"  assert:"},{"line_number":74,"context_line":"    that:"},{"line_number":75,"context_line":"      - vars[item] is defined"},{"line_number":76,"context_line":"    msg: \"Cinder Lightbits backend is enabled, the {{ item }} variable must be defined.\""},{"line_number":77,"context_line":"  with_items:"},{"line_number":78,"context_line":"    - lightos_api_address"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"20ce391a_684af435","line":75,"in_reply_to":"97b5131d_876d1fdf","updated":"2025-02-20 16:18:11.000000000","message":"Done","commit_id":"7706d3e3236205a738ac38fba8cdf00c4b37bdfa"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"db2957c69c9b2340e9f577158200f5c76ec469b7","unresolved":true,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"{% if enable_cinder_backend_lightbits | bool %}"},{"line_number":245,"context_line":"[{{ cinder_backend_lightbits_name }}]"},{"line_number":246,"context_line":"volume_driver: \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name: {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address: {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port: {{ lightbits_api_port}}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c78e750f_ee5e8112","line":246,"updated":"2025-02-19 14:28:18.000000000","message":"are you sure it should be \u0027:\u0027 instead of \u0027\u003d\u0027 ?","commit_id":"b735c90e051ac1876995c4062409df582671d8bb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"9985deeb266a5cfe532e20d1e3179aa0a08f029e","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"{% if enable_cinder_backend_lightbits | bool %}"},{"line_number":245,"context_line":"[{{ cinder_backend_lightbits_name }}]"},{"line_number":246,"context_line":"volume_driver: \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name: {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address: {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port: {{ lightbits_api_port}}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9becb8f3_af3d1a88","line":246,"in_reply_to":"c78e750f_ee5e8112","updated":"2025-02-20 10:05:26.000000000","message":"you are right, fixed","commit_id":"b735c90e051ac1876995c4062409df582671d8bb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"228345caa3adbb070ae960960156f34225806412","unresolved":true,"context_lines":[{"line_number":244,"context_line":"{% if enable_cinder_backend_lightbits | bool %}"},{"line_number":245,"context_line":"[{{ cinder_backend_lightbits_name }}]"},{"line_number":246,"context_line":"volume_driver \u003d \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"d8f9096a_e4c5672c","line":247,"range":{"start_line":247,"start_character":25,"end_line":247,"end_character":56},"updated":"2025-02-20 10:09:57.000000000","message":"no default value - we usually define an empty one and add prechecks that check for this when you enable this backend","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"182a48fc62a6cbcfa774da61d2abe7659c974c83","unresolved":false,"context_lines":[{"line_number":244,"context_line":"{% if enable_cinder_backend_lightbits | bool %}"},{"line_number":245,"context_line":"[{{ cinder_backend_lightbits_name }}]"},{"line_number":246,"context_line":"volume_driver \u003d \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a4c3e15f_62cc1669","line":247,"range":{"start_line":247,"start_character":25,"end_line":247,"end_character":56},"in_reply_to":"d8f9096a_e4c5672c","updated":"2025-02-20 14:14:56.000000000","message":"fixed","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"228345caa3adbb070ae960960156f34225806412","unresolved":true,"context_lines":[{"line_number":245,"context_line":"[{{ cinder_backend_lightbits_name }}]"},{"line_number":246,"context_line":"volume_driver \u003d \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"},{"line_number":251,"context_line":"lightos_skip_ssl_verify \u003d {{ lightbits_skip_ssl_verify }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5b24e1f2_401ea3e9","line":248,"range":{"start_line":248,"start_character":25,"end_line":248,"end_character":45},"updated":"2025-02-20 10:09:57.000000000","message":"no default value - ditto","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"182a48fc62a6cbcfa774da61d2abe7659c974c83","unresolved":false,"context_lines":[{"line_number":245,"context_line":"[{{ cinder_backend_lightbits_name }}]"},{"line_number":246,"context_line":"volume_driver \u003d \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"},{"line_number":251,"context_line":"lightos_skip_ssl_verify \u003d {{ lightbits_skip_ssl_verify }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1a28ce61_fd97dedd","line":248,"range":{"start_line":248,"start_character":25,"end_line":248,"end_character":45},"in_reply_to":"5b24e1f2_401ea3e9","updated":"2025-02-20 14:14:56.000000000","message":"Done","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"228345caa3adbb070ae960960156f34225806412","unresolved":true,"context_lines":[{"line_number":246,"context_line":"volume_driver \u003d \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"},{"line_number":251,"context_line":"lightos_skip_ssl_verify \u003d {{ lightbits_skip_ssl_verify }}"},{"line_number":252,"context_line":"lightos_jwt \u003d {{ lightbits_JWT }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8eee62a7_5bec42cc","line":249,"range":{"start_line":249,"start_character":22,"end_line":249,"end_character":40},"updated":"2025-02-20 10:09:57.000000000","message":"space between variable name and }} - no default value - should we have one in role defaults?","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"182a48fc62a6cbcfa774da61d2abe7659c974c83","unresolved":false,"context_lines":[{"line_number":246,"context_line":"volume_driver \u003d \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"},{"line_number":251,"context_line":"lightos_skip_ssl_verify \u003d {{ lightbits_skip_ssl_verify }}"},{"line_number":252,"context_line":"lightos_jwt \u003d {{ lightbits_JWT }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"001bfd7e_5a231be4","line":249,"range":{"start_line":249,"start_character":22,"end_line":249,"end_character":40},"in_reply_to":"8eee62a7_5bec42cc","updated":"2025-02-20 14:14:56.000000000","message":"Done","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"228345caa3adbb070ae960960156f34225806412","unresolved":true,"context_lines":[{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"},{"line_number":251,"context_line":"lightos_skip_ssl_verify \u003d {{ lightbits_skip_ssl_verify }}"},{"line_number":252,"context_line":"lightos_jwt \u003d {{ lightbits_JWT }}"},{"line_number":253,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fba2cb77_76a81dcf","line":250,"range":{"start_line":250,"start_character":34,"end_line":250,"end_character":64},"updated":"2025-02-20 10:09:57.000000000","message":"no default value - add to role defaults and default to false","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"182a48fc62a6cbcfa774da61d2abe7659c974c83","unresolved":false,"context_lines":[{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"},{"line_number":251,"context_line":"lightos_skip_ssl_verify \u003d {{ lightbits_skip_ssl_verify }}"},{"line_number":252,"context_line":"lightos_jwt \u003d {{ lightbits_JWT }}"},{"line_number":253,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8e783156_d417ea1f","line":250,"range":{"start_line":250,"start_character":34,"end_line":250,"end_character":64},"in_reply_to":"fba2cb77_76a81dcf","updated":"2025-02-20 14:14:56.000000000","message":"Done","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"228345caa3adbb070ae960960156f34225806412","unresolved":true,"context_lines":[{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"},{"line_number":251,"context_line":"lightos_skip_ssl_verify \u003d {{ lightbits_skip_ssl_verify }}"},{"line_number":252,"context_line":"lightos_jwt \u003d {{ lightbits_JWT }}"},{"line_number":253,"context_line":"{% endif %}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"[privsep_entrypoint]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c3ed6416_362fb1a9","line":252,"range":{"start_line":252,"start_character":17,"end_line":252,"end_character":30},"updated":"2025-02-20 10:09:57.000000000","message":"no default value - ditto as previous ones","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"182a48fc62a6cbcfa774da61d2abe7659c974c83","unresolved":false,"context_lines":[{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port}}"},{"line_number":250,"context_line":"lightos_default_num_replicas \u003d {{ lightbits_default_num_replicas }}"},{"line_number":251,"context_line":"lightos_skip_ssl_verify \u003d {{ lightbits_skip_ssl_verify }}"},{"line_number":252,"context_line":"lightos_jwt \u003d {{ lightbits_JWT }}"},{"line_number":253,"context_line":"{% endif %}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"[privsep_entrypoint]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5bbb24ac_cced844b","line":252,"range":{"start_line":252,"start_character":17,"end_line":252,"end_character":30},"in_reply_to":"c3ed6416_362fb1a9","updated":"2025-02-20 14:14:56.000000000","message":"Done","commit_id":"beaf5b9e7e5179b0d62697152e85ac0a2a4615e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f88285ab1ea058c7698704d3edceaf869e72b49b","unresolved":true,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"{% if enable_cinder_backend_lightbits | bool %}"},{"line_number":245,"context_line":"[{{ cinder_backend_lightbits_name }}]"},{"line_number":246,"context_line":"volume_driver \u003d \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1daf7277_4558bb1b","line":246,"range":{"start_line":246,"start_character":16,"end_line":246,"end_character":67},"updated":"2025-03-12 14:11:56.000000000","message":"do we need those quotes?","commit_id":"e2614a7c1e93abaca74834128a2d3ba9eeda4efc"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"5f50d4189f4c9625fae8c7df4741258088178ba5","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"{% if enable_cinder_backend_lightbits | bool %}"},{"line_number":245,"context_line":"[{{ cinder_backend_lightbits_name }}]"},{"line_number":246,"context_line":"volume_driver \u003d \u0027cinder.volume.drivers.lightos.LightOSVolumeDriver\u0027"},{"line_number":247,"context_line":"volume_backend_name \u003d {{ lightbits_nvme_tcp_backend_name }}"},{"line_number":248,"context_line":"lightos_api_address \u003d {{ lightbits_target_ips }}"},{"line_number":249,"context_line":"lightos_api_port \u003d {{ lightbits_api_port }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ee30ee62_30cff349","line":246,"range":{"start_line":246,"start_character":16,"end_line":246,"end_character":67},"in_reply_to":"1daf7277_4558bb1b","updated":"2025-03-12 14:18:14.000000000","message":"removed","commit_id":"e2614a7c1e93abaca74834128a2d3ba9eeda4efc"}]}