)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"9190f2a6c9c05c181223e4f81ee665e352391c29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d813926_35896431","updated":"2026-08-18 07:57:12.000000000","message":"@minsu@cisco.com I don\u0027t think I will have time to work on this in the forseeable future. Please feel free to take over or propose a new patch","commit_id":"3a7c5a0de6cf451d524f2b1fed3b1ef6e5e4d28e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d252129c44903dca4e8691205b49d9a65003c574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"236b34c4_d2c9c166","updated":"2025-01-14 14:40:52.000000000","message":"Shouldn\u0027t that be properly done in kolla_systemd_worker mechanics?","commit_id":"3a7c5a0de6cf451d524f2b1fed3b1ef6e5e4d28e"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"ef906955396fff59aa7168548964c6cb6859b38e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"96e87b86_35f42d0a","in_reply_to":"236b34c4_d2c9c166","updated":"2025-01-14 15:42:12.000000000","message":"From my understanding that would imply:\n\n* Adding a new parameter to the `kolla_container.py` module, e.g. `additional_stop_command: str` or `additional_stop_command_list: [str]`\n* Extending the template in `kolla_systemd_worker.py` and replacing the templating engine with one that supports conditionals or loops, since `string.Template` only supports simple substitutions\n* Extending the ovn-controller handler to set the new parameter\n\nSince I only see this one use case (for now) I thought this less intrusive solution would be more suitable.\n\nWhat is your opinion, do we want/need a generic solution here?","commit_id":"3a7c5a0de6cf451d524f2b1fed3b1ef6e5e4d28e"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"9190f2a6c9c05c181223e4f81ee665e352391c29","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b49a6548_12176e89","in_reply_to":"6bb5252b_8daad9b4","updated":"2026-08-18 07:57:12.000000000","message":"Ack, makes sense","commit_id":"3a7c5a0de6cf451d524f2b1fed3b1ef6e5e4d28e"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"2957e48b371b3ad8fb3894f88f88647996c5a155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c79cabd7_59fe227b","in_reply_to":"8d813926_35896431","updated":"2026-08-18 08:39:18.000000000","message":"Thanks Jan. I’ll take this forward as a replacement stack:\na generic kolla_container/SystemdWorker enhancement for an optional container pre-stop command and order-only systemd dependencies;\nan OVN consumer change using it for graceful ovn-controller shutdown.\nThe regular container-engine stop will remain as a fallback, and the OVN role will not create a separate systemd override. I will reference this change and LP#2093328 from the replacement series.\nMichal, please let me know if you would prefer the two changes squashed.","commit_id":"3a7c5a0de6cf451d524f2b1fed3b1ef6e5e4d28e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"025e7b4477971cf68b428ab2b8c4b09ac4fe3ba7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6bb5252b_8daad9b4","in_reply_to":"96e87b86_35f42d0a","updated":"2026-08-07 11:27:18.000000000","message":"I think we want an elegant generic solution, not overriding the generic mechanism that we have by additional Ansible steps","commit_id":"3a7c5a0de6cf451d524f2b1fed3b1ef6e5e4d28e"}],"releasenotes/notes/bug-2093328-db7299bb092fb12b.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"74605ff4da61bbd3d9098df845f1a8e11986c4b6","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    This will result in graceful failover and failback of external gateway"},{"line_number":7,"context_line":"    logical router ports."},{"line_number":8,"context_line":"    `LP#2093328 \u003chttps://launchpad.net/bugs/2093328\u003e`__"},{"line_number":9,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"71892232_b261e246","line":9,"updated":"2025-01-14 11:41:38.000000000","message":"Nit: remove this extra line including trailing space","commit_id":"eb7e3fb350b25211a56b10f42352b99af11559d7"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"16c318658fa6a90b7b3069a760c610fa4ee2e8c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    This will result in graceful failover and failback of external gateway"},{"line_number":7,"context_line":"    logical router ports."},{"line_number":8,"context_line":"    `LP#2093328 \u003chttps://launchpad.net/bugs/2093328\u003e`__"},{"line_number":9,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0726cc68_1669d97c","line":9,"in_reply_to":"71892232_b261e246","updated":"2025-01-14 13:29:11.000000000","message":"Thanks, that somehow slipped my attention","commit_id":"eb7e3fb350b25211a56b10f42352b99af11559d7"}]}