)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8f4ad967725645f727b2a18734453394358b1d98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9375860_f617fc61","updated":"2025-01-24 14:09:34.000000000","message":"Is the bug also valid for the OpenSearch/Influx datasources?","commit_id":"7d3624acf89eba59d86f6957e0ca282b3414b7ee"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9df7f069d16e6b3c2712475e05d7f50b1e53f5c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4de574a_8fae0091","updated":"2025-01-24 14:07:31.000000000","message":"Thanks, I agree with the bug.","commit_id":"7d3624acf89eba59d86f6957e0ca282b3414b7ee"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5d1f3e8424e03f37ebed23b9fd6d0679e737c95b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"272becca_10294252","updated":"2025-01-24 17:02:17.000000000","message":"Thanks, please add a release note to say the bug has been fixed.","commit_id":"7d3624acf89eba59d86f6957e0ca282b3414b7ee"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"d6ac8e3a00b796d406c912062c32aaf6d84ebfeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"691a913e_7021d436","in_reply_to":"272becca_10294252","updated":"2025-01-25 14:07:53.000000000","message":"Added release notes","commit_id":"7d3624acf89eba59d86f6957e0ca282b3414b7ee"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"f07449b0a608735f91ba52df04bdc36131f5d7a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8636656_9fbc8fc7","in_reply_to":"691a913e_7021d436","updated":"2025-01-27 09:39:56.000000000","message":"\u003e Added release notes\n\nFixed long lines in reno, to satisfy linter","commit_id":"7d3624acf89eba59d86f6957e0ca282b3414b7ee"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"3cfdcb85a729f5b9d5f4fee17ece29568dc59771","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ace8c96d_6f7486c0","in_reply_to":"f9375860_f617fc61","updated":"2025-01-24 14:17:23.000000000","message":"It\u0027s not, we don\u0027t have version hardcoded in place where we define it.\n(./ansible/roles/grafana/defaults/main.yml)","commit_id":"7d3624acf89eba59d86f6957e0ca282b3414b7ee"}],"ansible/roles/grafana/templates/prometheus.yaml.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9df7f069d16e6b3c2712475e05d7f50b1e53f5c1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"apiVersion: 1"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"prune: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"datasources:"},{"line_number":6,"context_line":"- name: Prometheus"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"35e17bb4_68a0500d","line":3,"updated":"2025-01-24 14:07:31.000000000","message":"You would think from the documentation that `prune` isn\u0027t required to fix the bug. Is it removing the `version: 1` that fixes it for you?\n\n```\nYou can manage data sources in Grafana by adding YAML configuration files in the provisioning/datasources directory. Each configuration file can contain a list of datasources to add or update during startup. If the data source already exists, Grafana reconfigures it to match the provisioned configuration file.\n```\nhttps://grafana.com/docs/grafana/latest/administration/provisioning/\n\n\nI see no harm in adding `prune`, but I don\u0027t think we ever remove the provisioning file or the data source from it? (we should really). It\u0027s hard to see how `prune` helps from the documentation.\n\n```\nYou can configure Grafana to automatically delete provisioned data sources when they’re removed from the provisioning file. To do so, add prune: true to the root of your provisioning file. With this configuration, Grafana also removes the provisioned data sources if you remove the provisioning file entirely.\n```","commit_id":"7d3624acf89eba59d86f6957e0ca282b3414b7ee"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"a3716679911af0cab19216df26d8e0ec325bdba4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: 1"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"prune: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"datasources:"},{"line_number":6,"context_line":"- name: Prometheus"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"585b6b07_440a118d","line":3,"in_reply_to":"35e17bb4_68a0500d","updated":"2025-01-24 14:12:50.000000000","message":"That\u0027s right.\nI\u0027ve added prune: true to future-proof it as suggested in commit msg.","commit_id":"7d3624acf89eba59d86f6957e0ca282b3414b7ee"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"26ef1d91b719d76ac280873cc99db663b201f229","unresolved":true,"context_lines":[{"line_number":1,"context_line":"apiVersion: 1"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"prune: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"datasources:"},{"line_number":6,"context_line":"- name: Prometheus"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ef3a58bc_ac68319e","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":11},"updated":"2025-01-27 20:23:51.000000000","message":"do we need to inform users about this change in the relno upgrade section?","commit_id":"d194297909b535affae658ffd5f8ab035c7606f3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1273ca38895c7aa8d4999aa416d08a17634be9e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: 1"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"prune: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"datasources:"},{"line_number":6,"context_line":"- name: Prometheus"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c623b327_e20a605d","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":11},"in_reply_to":"051b684e_6616c731","updated":"2025-01-29 09:42:55.000000000","message":"Thanks - it makes sense to remove prune to me. As far as I can see, it never has any effect, because you can\u0027t override this file.","commit_id":"d194297909b535affae658ffd5f8ab035c7606f3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0ec9a8fb76e5356006898c16d6965da9014ea9da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: 1"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"prune: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"datasources:"},{"line_number":6,"context_line":"- name: Prometheus"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"0b50094c_6ec07fa7","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":11},"in_reply_to":"c623b327_e20a605d","updated":"2025-01-29 09:45:48.000000000","message":"You could consider (not in this change) writing out L6-16 here based on the `enable_prometheus` flag, then remove that flag here https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/grafana/tasks/config.yml#L69 and it should automatically remove the Prometheus datasource when it was disabled using `prune: true`.","commit_id":"d194297909b535affae658ffd5f8ab035c7606f3"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"4f47f13835fa8aed7dc2bfb69bf4425574cfccc2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: 1"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"prune: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"datasources:"},{"line_number":6,"context_line":"- name: Prometheus"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"051b684e_6616c731","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":11},"in_reply_to":"ef3a58bc_ac68319e","updated":"2025-01-29 09:29:13.000000000","message":"I agree. I\u0027ll leave this PR to fix the bug only. (I would like to backport it)\n\nI\u0027ll create a separate PR to add prune where appropriate with proper release notes ( this one we will not backport )","commit_id":"d194297909b535affae658ffd5f8ab035c7606f3"}],"releasenotes/notes/grafana_update_datasources-706e3cdc964c5272.yaml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1273ca38895c7aa8d4999aa416d08a17634be9e9","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    version number and adding `prune: true` option. This ensures proper"},{"line_number":6,"context_line":"    datasource configuration updates and handles edge cases where old"},{"line_number":7,"context_line":"    datasources might need to be removed."},{"line_number":8,"context_line":"    `LP#[2096664] \u003chttps://launchpad.net/bugs/[2096664]\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f096eb47_1020b771","line":8,"updated":"2025-01-29 09:42:55.000000000","message":"nit: This renders to: `https://launchpad.net/bugs/[2096664]`","commit_id":"d194297909b535affae658ffd5f8ab035c7606f3"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"2bef22414561d76807c7c3b0cf7b1f15ba334291","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    version number and adding `prune: true` option. This ensures proper"},{"line_number":6,"context_line":"    datasource configuration updates and handles edge cases where old"},{"line_number":7,"context_line":"    datasources might need to be removed."},{"line_number":8,"context_line":"    `LP#[2096664] \u003chttps://launchpad.net/bugs/[2096664]\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4a55b61c_393eee10","line":8,"in_reply_to":"f096eb47_1020b771","updated":"2025-01-31 08:45:09.000000000","message":"Done","commit_id":"d194297909b535affae658ffd5f8ab035c7606f3"}]}