)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"54137ff56d285422eb456d289f4b60bee48f87c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3d6cd291_684b3955","updated":"2026-01-15 09:01:26.000000000","message":"the same should be done for:\n\nansible/roles/service-check-containers/tasks/main.yml\n...\n- name: \"Notify handlers to restart containers\n...","commit_id":"78b151155a81f2b82de2fe583c4927b69c40cccc"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"cb1cc3afa469f5bdae782e81ff9c0afa40e46cce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"571a262d_8b70b396","in_reply_to":"3d6cd291_684b3955","updated":"2026-01-15 09:05:39.000000000","message":"* ansible/roles/service-check-containers/tasks/iterated.yml","commit_id":"78b151155a81f2b82de2fe583c4927b69c40cccc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"61816102825b03f0c4d96ca5be3a3d39c814fd86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e7952665_a7d4dd41","updated":"2026-01-20 11:26:08.000000000","message":"Merging given previous +2s","commit_id":"3177479dd2224902a1ebffcdbda59ca297089532"}],"ansible/roles/service-check-containers/tasks/iterated.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"ec36a8212c623bff4a9520aeb837955e971d3730","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":32,"context_line":"- name: \"Notify handlers to restart containers for {{ kolla_role_name | default(project_name) }}\""},{"line_number":33,"context_line":"  vars:"},{"line_number":34,"context_line":"    handler: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""},{"line_number":35,"context_line":"  debug:"},{"line_number":36,"context_line":"    msg: \"{{ (\u0027Notifying handlers: \u0027 + handler | join(\u0027,\u0027)) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":37,"context_line":"  changed_when: container_check is changed"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"d38cbc78_e5f095d3","line":34,"updated":"2026-02-09 14:22:49.000000000","message":"This has added a syntax error - item cannot be resolved here","commit_id":"3177479dd2224902a1ebffcdbda59ca297089532"}],"ansible/roles/service-check-containers/tasks/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3687995018d36ed1340d683f21b10ffbec60774a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":33,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":34,"context_line":"  debug:"},{"line_number":35,"context_line":"    msg: \"{{ \u0027Notifying handlers\u0027 if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":36,"context_line":"  changed_when: container_check is changed"},{"line_number":37,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"91644697_05784d06","line":35,"range":{"start_line":35,"start_character":37,"end_line":35,"end_character":63},"updated":"2025-05-15 10:12:40.000000000","message":"I\u0027m not sure I really understand this whole task, but shouldn\u0027t this rather be the full notify condition?","commit_id":"1cdb2e00f765949f1692be01bed6e4dd900f21a5"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"86d14b7b7d712ab58506e2ad922f2e398194e121","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":33,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":34,"context_line":"  debug:"},{"line_number":35,"context_line":"    msg: \"{{ \u0027Notifying handlers\u0027 if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":36,"context_line":"  changed_when: container_check is changed"},{"line_number":37,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c9959d03_bcc6074f","line":35,"range":{"start_line":35,"start_character":37,"end_line":35,"end_character":63},"in_reply_to":"91644697_05784d06","updated":"2025-05-15 10:36:17.000000000","message":"but the same is used in the \u0027changed_when\u0027 stanza","commit_id":"1cdb2e00f765949f1692be01bed6e4dd900f21a5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"67d36dfc803b8f6cb735b0b0baae29616abae2ef","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":33,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":34,"context_line":"  debug:"},{"line_number":35,"context_line":"    msg: \"{{ \u0027Notifying handlers\u0027 if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":36,"context_line":"  changed_when: container_check is changed"},{"line_number":37,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e98b1949_f6660aa5","line":35,"range":{"start_line":35,"start_character":37,"end_line":35,"end_character":63},"in_reply_to":"c9959d03_bcc6074f","updated":"2025-05-15 11:01:06.000000000","message":"Yep, it would be fine, i had similar patch somewhere, but uncompleted. What I remember I was able to also let user know which handler was notified. Can u amend ?","commit_id":"1cdb2e00f765949f1692be01bed6e4dd900f21a5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1600d1e3cb5fdfc80bc8939f47a1687c309eb4d4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":33,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":34,"context_line":"  debug:"},{"line_number":35,"context_line":"    msg: \"{{ \u0027Notifying handlers\u0027 if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":36,"context_line":"  changed_when: container_check is changed"},{"line_number":37,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8e0b3566_7559f49d","line":35,"range":{"start_line":35,"start_character":37,"end_line":35,"end_character":63},"in_reply_to":"e98b1949_f6660aa5","updated":"2025-05-15 11:10:20.000000000","message":"ok, let\u0027s go with this","commit_id":"1cdb2e00f765949f1692be01bed6e4dd900f21a5"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"442a17455977972ca842bbcc5c177ac9948201d0","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    handler: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""},{"line_number":37,"context_line":"    service: \"{{ item.value }}\""},{"line_number":38,"context_line":"  debug:"},{"line_number":39,"context_line":"    msg: \"{{ \u0027Notifying handler: \u0027 + handler if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":40,"context_line":"  changed_when: container_check is changed"},{"line_number":41,"context_line":"  when: not (service.iterate | default(False)) | bool"},{"line_number":42,"context_line":"  notify: \"{{ handler }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3c35593e_a0ce39ea","line":39,"range":{"start_line":39,"start_character":13,"end_line":39,"end_character":44},"updated":"2025-05-15 13:29:46.000000000","message":"```suggestion\n    msg: \"{{ (\u0027Notifying handler: \u0027 + handler) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\"\n```","commit_id":"8fb4a76c20a776e9e396c42c740f1f9ea3456887"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"74b5756c5e85db564cd4289a714a6abbdae1dfed","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    handler: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""},{"line_number":37,"context_line":"    service: \"{{ item.value }}\""},{"line_number":38,"context_line":"  debug:"},{"line_number":39,"context_line":"    msg: \"{{ \u0027Notifying handler: \u0027 + handler if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":40,"context_line":"  changed_when: container_check is changed"},{"line_number":41,"context_line":"  when: not (service.iterate | default(False)) | bool"},{"line_number":42,"context_line":"  notify: \"{{ handler }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"124d50df_1dcf121c","line":39,"range":{"start_line":39,"start_character":13,"end_line":39,"end_character":44},"in_reply_to":"3c35593e_a0ce39ea","updated":"2025-05-15 13:39:32.000000000","message":"Fix applied.","commit_id":"8fb4a76c20a776e9e396c42c740f1f9ea3456887"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"766a332d4323b0f04b24bf0e30b99d11225deb82","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    handler: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""},{"line_number":37,"context_line":"    service: \"{{ item.value }}\""},{"line_number":38,"context_line":"  debug:"},{"line_number":39,"context_line":"    msg: \"{{ (\u0027Notifying handler: \u0027 + handler) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":40,"context_line":"  changed_when: container_check is changed"},{"line_number":41,"context_line":"  when: not (service.iterate | default(False)) | bool"},{"line_number":42,"context_line":"  notify: \"{{ handler }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2337df79_0cd2f685","line":39,"updated":"2026-01-15 05:45:16.000000000","message":"fatal: [primary]: FAILED! \u003d\u003e {\n    \"msg\": \"Task failed: Finalization of task args for \u0027ansible.builtin.debug\u0027 failed: Error while resolving value for \u0027msg\u0027: Error rendering template: can only concatenate str (not \\\"_AnsibleLazyTemplateList\\\") to str\"\n}\n\nmaybe don\u0027t overcomplicate things just for this debug msg? a static \"Notifying handlers if needed\" is good enough IMO","commit_id":"78b151155a81f2b82de2fe583c4927b69c40cccc"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"54137ff56d285422eb456d289f4b60bee48f87c2","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    handler: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""},{"line_number":37,"context_line":"    service: \"{{ item.value }}\""},{"line_number":38,"context_line":"  debug:"},{"line_number":39,"context_line":"    msg: \"{{ (\u0027Notifying handler: \u0027 + handler) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":40,"context_line":"  changed_when: container_check is changed"},{"line_number":41,"context_line":"  when: not (service.iterate | default(False)) | bool"},{"line_number":42,"context_line":"  notify: \"{{ handler }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ffc513cf_0532dadf","line":39,"in_reply_to":"2337df79_0cd2f685","updated":"2026-01-15 09:01:26.000000000","message":"The error occurs because handler is a list and Jinja2 cannot concatenate it directly to a string using the + operator. While I agree we shouldn\u0027t overcomplicate things, we can easily fix this and keep the improved visibility by using the join filter\n\nmsg: \"{{ (\u0027Notifying handlers: \u0027 + handler | join(\u0027, \u0027)) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\"","commit_id":"78b151155a81f2b82de2fe583c4927b69c40cccc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4889e8ce6c7695238da38cbc63b2ec638b52b1f5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    handler: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""},{"line_number":37,"context_line":"    service: \"{{ item.value }}\""},{"line_number":38,"context_line":"  debug:"},{"line_number":39,"context_line":"    msg: \"{{ (\u0027Notifying handler: \u0027 + handler) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":40,"context_line":"  changed_when: container_check is changed"},{"line_number":41,"context_line":"  when: not (service.iterate | default(False)) | bool"},{"line_number":42,"context_line":"  notify: \"{{ handler }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"914b8f68_6d330059","line":39,"in_reply_to":"ffc513cf_0532dadf","updated":"2026-01-20 09:41:58.000000000","message":"Done","commit_id":"78b151155a81f2b82de2fe583c4927b69c40cccc"}]}