)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"f735b5043ef9939a5c3e8cb32f854b7a9d0c6869","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2a726c2_7f051f0b","updated":"2025-01-31 08:50:11.000000000","message":"Looks like a sensible change to me, thanks.","commit_id":"0479d76ea328190e2d30623817f101f8295c6c0d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"12a5751c40b995f6355627a8c975f405f975d5e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26d555ce_21dc631c","updated":"2025-02-05 07:24:27.000000000","message":"I think this can be merged, any votes ?","commit_id":"2523ab4376ee82fb0875368236638d5c8e668c5e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5c7d17d9a69c643242ed01cf618ac573e80485af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"66dcba7c_f5f780be","updated":"2025-02-06 06:02:08.000000000","message":"I\u0027m fine with dropping the conditionals, but I\u0027m not convinced about the other additions","commit_id":"2523ab4376ee82fb0875368236638d5c8e668c5e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5257f3a72119a16bf7f1a003aff07f763d0760b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9db19d07_d2fefaa4","updated":"2025-02-07 09:01:41.000000000","message":"hmm, ok","commit_id":"2523ab4376ee82fb0875368236638d5c8e668c5e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e9e4c612541bb1456cdaafae9b038b5cbe1d0b56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5e766c3_96c2b7fe","updated":"2025-02-05 04:38:55.000000000","message":"recheck registry pull error","commit_id":"2523ab4376ee82fb0875368236638d5c8e668c5e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a48b3f2b260459c5d1e29a6ab677b64a3a044a8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e914154_0a14897f","updated":"2025-02-04 21:25:45.000000000","message":"recheck timeouts","commit_id":"2523ab4376ee82fb0875368236638d5c8e668c5e"}],"ansible/roles/glance/templates/glance-cache.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5c7d17d9a69c643242ed01cf618ac573e80485af","unresolved":true,"context_lines":[{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[oslo_concurrency]"},{"line_number":19,"context_line":"lock_path \u003d /var/lib/glance/tmp"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9cd491e7_d70ccab9","line":19,"updated":"2025-02-06 06:02:08.000000000","message":"does this service actually use oslo.concurrency? it doesn\u0027t have rabbitmq configuration either? you wouldn\u0027t want to add rabbitmq conf here either just for consistency, would you? same goes for all the other additions","commit_id":"2523ab4376ee82fb0875368236638d5c8e668c5e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"62c2e78cb3bbb1fbee6d38fa2fd4f683b1b91802","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[oslo_concurrency]"},{"line_number":19,"context_line":"lock_path \u003d /var/lib/glance/tmp"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0cc601e6_0dc4e337","line":19,"in_reply_to":"9cd491e7_d70ccab9","updated":"2025-02-06 06:43:53.000000000","message":"Of course it uses oslo.concurrency. \n\n```\nmichalarbet@pixla:/tmp$ git clone https://github.com/openstack/glance\nCloning into \u0027glance\u0027...\nremote: Enumerating objects: 71552, done.\nremote: Counting objects: 100% (1044/1044), done.\nremote: Compressing objects: 100% (388/388), done.\nremote: Total 71552 (delta 763), reused 662 (delta 656), pack-reused 70508 (from 4)\nReceiving objects: 100% (71552/71552), 33.16 MiB | 8.65 MiB/s, done.\nResolving deltas: 100% (49138/49138), done.\nmichalarbet@pixla:/tmp$ grep -ri concurrency glance/glance/ | grep lockutils\nglance/glance/api/common.py:from oslo_concurrency import lockutils\nglance/glance/common/scripts/api_image_import/main.py:from oslo_concurrency import lockutils\nglance/glance/common/scripts/image_import/main.py:from oslo_concurrency import lockutils\nglance/glance/image_cache/drivers/centralized_db.py:from oslo_concurrency import lockutils\nglance/glance/image_cache/drivers/sqlite.py:from oslo_concurrency import lockutils\nglance/glance/image_cache/prefetcher.py:from oslo_concurrency import lockutils\nglance/glance/sqlite_migration.py:from oslo_concurrency import lockutils\nglance/glance/tests/unit/base.py:from oslo_concurrency import lockutils\nglance/glance/tests/utils.py:from oslo_concurrency import lockutils\n```\n\nAs i am saing in commit message -\u003e \n\n```\nWhile `oslo.concurrency` itself does not\nrequire a specific path, the implementation of the queue\nmanager expects locks to be placed under\n`/var/lib/\u003cservice\u003e/tmp`, making it necessary to define\nthis path explicitly. Therefore, the lock path is set\naccordingly across all services, regardless of whether\nthe queue manager is used.\n```\n\nSimply said, while others needs to have oslo.concurrency\u0027s lock_path to be in this path, it makes no sense to be in one place here and completely different elsewhere. Therefore, it is set the same way everywhere for consistency.\n\nI believe it is described sufficiently in the commit message, so please reconsider your -1 vote.","commit_id":"2523ab4376ee82fb0875368236638d5c8e668c5e"}]}