)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bad50b29efe2e1ed402fd9179faaac0e99a1c786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c6af5e45_6264a429","updated":"2025-02-06 06:09:18.000000000","message":"I think this should also update the example references in doc/source/reference/storage/external-ceph-guide.rst and maybe even add an explicit use case for this feature?","commit_id":"e39e46a86bb53c70363ce56ecd5285adf05520da"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bad50b29efe2e1ed402fd9179faaac0e99a1c786","unresolved":true,"context_lines":[{"line_number":156,"context_line":"{% for backend in cinder_ceph_backends %}"},{"line_number":157,"context_line":"[{{ backend.name }}]"},{"line_number":158,"context_line":"volume_driver \u003d cinder.volume.drivers.rbd.RBDDriver"},{"line_number":159,"context_line":"volume_backend_name \u003d {{ backend.backend_name | default(backend.name) }}"},{"line_number":160,"context_line":"rbd_pool \u003d {{ backend.pool }}"},{"line_number":161,"context_line":"rbd_ceph_conf \u003d /etc/ceph/{{ backend.cluster }}.conf"},{"line_number":162,"context_line":"rados_connect_timeout \u003d 5"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4a0f95a7_e9d60ffa","line":159,"updated":"2025-02-06 06:09:18.000000000","message":"isn\u0027t the `| default` here redundant with the addition in the defaults file? why do you want both? if it is for migration, add a comment to drop it in the future?","commit_id":"e39e46a86bb53c70363ce56ecd5285adf05520da"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5c917379591b3c3251966298bed35b6cc6f60ab4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{% for backend in cinder_ceph_backends %}"},{"line_number":157,"context_line":"[{{ backend.name }}]"},{"line_number":158,"context_line":"volume_driver \u003d cinder.volume.drivers.rbd.RBDDriver"},{"line_number":159,"context_line":"volume_backend_name \u003d {{ backend.backend_name | default(backend.name) }}"},{"line_number":160,"context_line":"rbd_pool \u003d {{ backend.pool }}"},{"line_number":161,"context_line":"rbd_ceph_conf \u003d /etc/ceph/{{ backend.cluster }}.conf"},{"line_number":162,"context_line":"rados_connect_timeout \u003d 5"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"665bd0fe_ab131292","line":159,"in_reply_to":"4a0f95a7_e9d60ffa","updated":"2025-02-06 06:48:54.000000000","message":"Well, it\u0027s there to simply allow easy backport.\n\nAnd of course, also because people might not use the default and could have it overridden in globals. That way, even if they don\u0027t notice that the defaults have changed and a backend_name was added, they\u0027re completely safe because it falls back to the default name.\n\nBy the way, this is also described directly in the commit message below : \n\n```\nBenefits of this change:\n- Provides flexibility in naming backends without modifying `name`.\n- Allows uniform configuration in environments with multiple Ceph clusters.\n- \u003e\u003e\u003e\u003e\u003e  Maintains backward compatibility – if `backend_name` is not defined,\n  it defaults to `name`, ensuring the same behavior as before.  \u003c\u003c\u003c\u003c\u003c\n```","commit_id":"e39e46a86bb53c70363ce56ecd5285adf05520da"}]}