)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"52052c26105c9f86e486e8d7437daa229dae29ef","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     agarciaws \u003cagarcia@whitestack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-07 10:11:33 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forces docker_registry_password to be casted as string."},{"line_number":8,"context_line":"This prevents failures with some public cloud providers,"},{"line_number":9,"context_line":"which use JSON-based documents for authentication."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c9870112_cdbe34e7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":55},"updated":"2025-02-07 13:59:03.000000000","message":"Commit message fixes:\n\ns/casted/cast/\ns/Forces/Force\n\nRemove period at end of line, add empty line after first line.","commit_id":"f6925eb54bff5ef7dcd2dabec28d376aa8f5e738"},{"author":{"_account_id":34437,"name":"Alejandro Garcia","email":"agarcia@whitestack.com","username":"agarciaws"},"change_message_id":"792b5493c458d4f64c329f3ca29df655bc63fb74","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     agarciaws \u003cagarcia@whitestack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-07 10:11:33 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forces docker_registry_password to be casted as string."},{"line_number":8,"context_line":"This prevents failures with some public cloud providers,"},{"line_number":9,"context_line":"which use JSON-based documents for authentication."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8357c0d1_19afcab1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":55},"in_reply_to":"c9870112_cdbe34e7","updated":"2025-02-07 14:08:56.000000000","message":"Thanx, got it!","commit_id":"f6925eb54bff5ef7dcd2dabec28d376aa8f5e738"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"51b07ed402e86e2cb4640a6f4bc140bcc4f2cbc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a935945_6c21dab7","updated":"2025-02-18 20:24:48.000000000","message":"LGTM","commit_id":"3f2576ff8add96ba2d8a0603a823c0d488dfbc5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9b3ad605c1625f6d4e6084ee8dfd25952cb7cf8d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9ba1a903_9cb56ade","updated":"2025-10-14 14:54:50.000000000","message":"I\u0027d say we need to ensure that on kolla_container level, instead of this ugly hack.","commit_id":"9007d89f476b26c3d671f7351331c0f76a247802"},{"author":{"_account_id":34437,"name":"Alejandro Garcia","email":"agarcia@whitestack.com","username":"agarciaws"},"change_message_id":"210c54278c0cd8534d0e9397f3a2ce8a5f83c1ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dec49734_8a1be37b","in_reply_to":"0c2fff40_a1bbb571","updated":"2025-10-29 12:31:24.000000000","message":"Because this variable may actually be a JSON-string? This \"dict-inference\" could happen for any variable, but it\u0027s not very common to have a JSON-string as the value of any of the other variables in the project. If you did, this would lead to such other variable to be treated as a dict and most likely triggering a failure somewhere else.\n\nThing is, the Docker auth_password can be a JSON-string, and in such cases we want it to be treated as a string. We already have other sanitizing casts on this file (for example, all the enable_ variables are casted to bool) so it doesn\u0027t sound so... unexpected to me to have such casting to string here.","commit_id":"9007d89f476b26c3d671f7351331c0f76a247802"},{"author":{"_account_id":34437,"name":"Alejandro Garcia","email":"agarcia@whitestack.com","username":"agarciaws"},"change_message_id":"dddacae30f884947b2cb5449a03b0c6123a1f4b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db3e6fc3_6ce2ffaf","in_reply_to":"9ba1a903_9cb56ade","updated":"2025-10-29 12:06:22.000000000","message":"Mm how would that work? Ansible is the one inferring the type and casting the JSON-based password. By the time kolla_container receives the auth_password, this was already converted to a Python dict.\n\nOn the other hand, performing the cast at Ansible level ensures that a string is used in any other place where the auth_password may be needed (for example, the auth_password is included in the passwords YAML file).","commit_id":"9007d89f476b26c3d671f7351331c0f76a247802"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d68a23aca23c672c1387e5c3ab20d48698877195","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c2fff40_a1bbb571","in_reply_to":"db3e6fc3_6ce2ffaf","updated":"2025-10-29 12:11:28.000000000","message":"So I\u0027d ask it in a different way - why only that variable in the whole collection of hundreds variables in that project needs that treatment?","commit_id":"9007d89f476b26c3d671f7351331c0f76a247802"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a9f246e719afe842aa749f172bc2b41583d8d4ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"38ce60c6_fc41176e","in_reply_to":"dec49734_8a1be37b","updated":"2025-10-29 12:49:56.000000000","message":"I\u0027m not convinced we should be changing this, but I\u0027ll let other core reviewers chime in.","commit_id":"9007d89f476b26c3d671f7351331c0f76a247802"}]}