)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23ea8895d25376f5591e6f51797a2d9ba76636f8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     amithkotu \u003camith.kotu@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-18 22:10:53 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(docs): Correct typo in variable name from \"neutron_physical_network\" to \"neutron_physical_networks\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit addresses a typo in the documentation where the variable \"neutron_physical_network\" was incorrectly used. The correct variable name is \"neutron_physical_networks\", which reflects the actual value used in the code."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e728d9bf_5af08d11","line":7,"updated":"2025-02-19 06:00:33.000000000","message":"try to keep the first line of the commit message below 50 characters. in this case I\u0027d suggest\n\ndocs: Correct type in variable name\n\nSpecifying the details in the body of the commit message is then enough.","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"4f59491b0e3b6a20a489d36e536129e0f0e699f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     amithkotu \u003camith.kotu@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-18 22:10:53 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(docs): Correct typo in variable name from \"neutron_physical_network\" to \"neutron_physical_networks\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit addresses a typo in the documentation where the variable \"neutron_physical_network\" was incorrectly used. The correct variable name is \"neutron_physical_networks\", which reflects the actual value used in the code."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d0858240_e176eee4","line":7,"in_reply_to":"e728d9bf_5af08d11","updated":"2025-02-19 21:01:21.000000000","message":"Done","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23ea8895d25376f5591e6f51797a2d9ba76636f8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(docs): Correct typo in variable name from \"neutron_physical_network\" to \"neutron_physical_networks\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit addresses a typo in the documentation where the variable \"neutron_physical_network\" was incorrectly used. The correct variable name is \"neutron_physical_networks\", which reflects the actual value used in the code."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Bug: https://bugs.launchpad.net/kolla-ansible/+bug/2088062"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0f6d0ca8_f7a818e9","line":9,"updated":"2025-02-19 06:00:33.000000000","message":"Please wrap lines in the body at 72 characters (or 80 at most).","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"4f59491b0e3b6a20a489d36e536129e0f0e699f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(docs): Correct typo in variable name from \"neutron_physical_network\" to \"neutron_physical_networks\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit addresses a typo in the documentation where the variable \"neutron_physical_network\" was incorrectly used. The correct variable name is \"neutron_physical_networks\", which reflects the actual value used in the code."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Bug: https://bugs.launchpad.net/kolla-ansible/+bug/2088062"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"394e65f0_aceab48b","line":9,"in_reply_to":"0f6d0ca8_f7a818e9","updated":"2025-02-19 21:01:21.000000000","message":"Done","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23ea8895d25376f5591e6f51797a2d9ba76636f8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit addresses a typo in the documentation where the variable \"neutron_physical_network\" was incorrectly used. The correct variable name is \"neutron_physical_networks\", which reflects the actual value used in the code."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Bug: https://bugs.launchpad.net/kolla-ansible/+bug/2088062"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The typo correction ensures that users referencing the documentation will use the correct variable name, preventing potential configuration errors and improving overall clarity."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dbb233e0_ac37f82a","line":11,"updated":"2025-02-19 06:00:33.000000000","message":"Since you have the closes-bug reference below, you do not need to duplicate the link here, I\u0027d suggest to just remove this line","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"4f59491b0e3b6a20a489d36e536129e0f0e699f2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit addresses a typo in the documentation where the variable \"neutron_physical_network\" was incorrectly used. The correct variable name is \"neutron_physical_networks\", which reflects the actual value used in the code."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Bug: https://bugs.launchpad.net/kolla-ansible/+bug/2088062"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The typo correction ensures that users referencing the documentation will use the correct variable name, preventing potential configuration errors and improving overall clarity."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5b55763c_29b4c94b","line":11,"in_reply_to":"dbb233e0_ac37f82a","updated":"2025-02-19 21:01:21.000000000","message":"Done","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23ea8895d25376f5591e6f51797a2d9ba76636f8","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Bug: https://bugs.launchpad.net/kolla-ansible/+bug/2088062"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The typo correction ensures that users referencing the documentation will use the correct variable name, preventing potential configuration errors and improving overall clarity."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1011848"},{"line_number":16,"context_line":"Change-Id: I5d4a7895d54aebcf0612e72d315defeda37bb178"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8b6dce48_4449c8f0","line":13,"updated":"2025-02-19 06:00:33.000000000","message":"As much as I value verbose commit messages, this is a bit much I\u0027d think. Fixing errors is always justified, it doesn\u0027t need extended motivation.","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"4f59491b0e3b6a20a489d36e536129e0f0e699f2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Bug: https://bugs.launchpad.net/kolla-ansible/+bug/2088062"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The typo correction ensures that users referencing the documentation will use the correct variable name, preventing potential configuration errors and improving overall clarity."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1011848"},{"line_number":16,"context_line":"Change-Id: I5d4a7895d54aebcf0612e72d315defeda37bb178"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dc7db9c0_6ba712de","line":13,"in_reply_to":"8b6dce48_4449c8f0","updated":"2025-02-19 21:01:21.000000000","message":"Done","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23ea8895d25376f5591e6f51797a2d9ba76636f8","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The typo correction ensures that users referencing the documentation will use the correct variable name, preventing potential configuration errors and improving overall clarity."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1011848"},{"line_number":16,"context_line":"Change-Id: I5d4a7895d54aebcf0612e72d315defeda37bb178"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c3cf6862_d83e067c","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"updated":"2025-02-19 06:00:33.000000000","message":"Not sure where you got this ID from, please use the correct ID that you used above","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b76eb79cd1d37888502bf00ad2dcc33bbca3f678","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The typo correction ensures that users referencing the documentation will use the correct variable name, preventing potential configuration errors and improving overall clarity."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1011848"},{"line_number":16,"context_line":"Change-Id: I5d4a7895d54aebcf0612e72d315defeda37bb178"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"39da770b_fd36852c","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"updated":"2025-02-19 06:54:59.000000000","message":"wrong bug report. this is Nova project related.","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"4f59491b0e3b6a20a489d36e536129e0f0e699f2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The typo correction ensures that users referencing the documentation will use the correct variable name, preventing potential configuration errors and improving overall clarity."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1011848"},{"line_number":16,"context_line":"Change-Id: I5d4a7895d54aebcf0612e72d315defeda37bb178"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e8d0539c_69366764","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"in_reply_to":"39da770b_fd36852c","updated":"2025-02-19 21:01:21.000000000","message":"Done","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"4f59491b0e3b6a20a489d36e536129e0f0e699f2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The typo correction ensures that users referencing the documentation will use the correct variable name, preventing potential configuration errors and improving overall clarity."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1011848"},{"line_number":16,"context_line":"Change-Id: I5d4a7895d54aebcf0612e72d315defeda37bb178"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"54b5eb69_aa5b6027","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"in_reply_to":"c3cf6862_d83e067c","updated":"2025-02-19 21:01:21.000000000","message":"Done","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"23ea8895d25376f5591e6f51797a2d9ba76636f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"185dbe46_0ba747b0","updated":"2025-02-19 06:00:33.000000000","message":"Welcome as a new contributor, glad to see that this has worked out after our earlier IRC conversation.\n\nSome comments inline, usually I\u0027d just approve the change like Michal just did while I was writing my review, but I think it is a good opportunity for you to pratice amending the change :-)","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c2de4f718221881ecd5ef39fde9878ea23a9d3e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d8148d3_0a1a3c08","updated":"2025-02-19 06:01:37.000000000","message":"recheck just to get rid of the -2","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7adf3acbd636045638657275857ab37e221747d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c388790_71336322","updated":"2025-02-19 05:51:58.000000000","message":"trivial - docs only","commit_id":"04284865725480f8f00ed073b025bf0c9343aff6"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"faf16f213e78e1b013e5de02f7b9d9772b285394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd4bd67d_cbe9c2e8","updated":"2025-02-19 20:23:34.000000000","message":"Fixed the wrong bug number in the commit message.","commit_id":"387b4d1e7d6887d7cc19aab05fd139c388d3f608"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"111432384f87e01f827a427d3200a4441b43523c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ee85ad4_197b8dc1","in_reply_to":"1c2c5d55_da00c2f5","updated":"2025-02-19 21:42:47.000000000","message":"Thanks! Note for next time, there is no need for a bug report for such a trivial issue. You could also just have the commit summary line, without the rest of the body, since the diff is self explanatory.","commit_id":"387b4d1e7d6887d7cc19aab05fd139c388d3f608"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d7430bc68df0a00192b4883f3ac378468368aa51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5474cfc7_8d8fd54c","in_reply_to":"3ee85ad4_197b8dc1","updated":"2025-02-20 05:22:41.000000000","message":"iiuc the bug report was from someone different, so in this case it is good to reference it and get it closed after this fix is merged","commit_id":"387b4d1e7d6887d7cc19aab05fd139c388d3f608"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"4f59491b0e3b6a20a489d36e536129e0f0e699f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c2c5d55_da00c2f5","in_reply_to":"609280c7_6a226747","updated":"2025-02-19 21:01:21.000000000","message":"Made the change to wrap commit message lines at 72 characters.","commit_id":"387b4d1e7d6887d7cc19aab05fd139c388d3f608"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"08d2cf234e980b2c11cdc4251df6677f676ab178","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"609280c7_6a226747","in_reply_to":"fd4bd67d_cbe9c2e8","updated":"2025-02-19 20:31:17.000000000","message":"Thanks for the update. However you still need to wrap commit message lines at 72 characters.","commit_id":"387b4d1e7d6887d7cc19aab05fd139c388d3f608"},{"author":{"_account_id":37739,"name":"Amith Kotu","display_name":"Amith Kotu","email":"amith.kotu@outlook.com","username":"amithkotu"},"change_message_id":"4f59491b0e3b6a20a489d36e536129e0f0e699f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a3c4e95_f171f10b","updated":"2025-02-19 21:01:21.000000000","message":"Made the changes to the commit message as per suggestions.","commit_id":"eb3b79460aca607e0b68520fafaae787e9b0a3b4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d7430bc68df0a00192b4883f3ac378468368aa51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c1ef466c_68d45fbc","updated":"2025-02-20 05:22:41.000000000","message":"thanks for the update, one final remark: it is generally assumed that you approve of any change that you submit, so adding a Code-Review+1 vote to your change is not necessary and even may look a bit strange","commit_id":"eb3b79460aca607e0b68520fafaae787e9b0a3b4"}]}