)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ed41c27b1bec547f3a30699f354a56c7f73ae304","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"742731d1_0481e9de","updated":"2025-03-14 08:06:05.000000000","message":"ok, I\u0027m not completely against doing this, consistency is a good thing. let\u0027s see what other reviewers say","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb77267181d4e35166d73e357913a334ab87c368","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8eeaccdd_5a6b1a47","updated":"2025-03-13 05:53:47.000000000","message":"there is a bug in the first file, but all the other changes don\u0027t seem to be really necessary and thus I\u0027d prefer to avoid them","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5fbb91607bf840e345e8b8e69662383afe73efda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"371594c2_52d36b92","updated":"2025-03-18 08:33:36.000000000","message":"Actually I just found https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#bullet-lists","commit_id":"fd5fabf32f6f7aa4ef41c3a25603502b65cbe4bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f70037d7013048dec3b22f5f0db7a80a76eecfc7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b79bd2e3_d878028c","in_reply_to":"217efce4_ffdbc01f","updated":"2025-06-03 22:27:35.000000000","message":"Good question, I\u0027d assume doc8 should test for this?","commit_id":"fd5fabf32f6f7aa4ef41c3a25603502b65cbe4bc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6139dd6b7144908c45953dd45c8e4866ba011ce4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"217efce4_ffdbc01f","in_reply_to":"371594c2_52d36b92","updated":"2025-03-18 11:48:39.000000000","message":"We currently have 279 instances of `^* ` in our docs and 119 instances of `^- ` which roughly seems to match what this patch would change. I\u0027m still unsure between \"just keep the inconsistency\" and \"let\u0027s do this\", but it does seem to make the \"let\u0027s move to `- ` instead less desirable. If we do it, wouldn\u0027t we also need to make sure that we aren\u0027t back to the same situation two years from now?","commit_id":"fd5fabf32f6f7aa4ef41c3a25603502b65cbe4bc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6252fb9262bee052b5935fc8df5d1bd82a3cd65e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7ce5c67_db2565c3","in_reply_to":"55ad9001_e562078e","updated":"2025-07-10 05:58:10.000000000","message":"That\u0027s actually a good question, if we don\u0027t, we will possibly create merge conflicts for a lot of other backports, if we do, someone will have to amend this change to stable branches. Maybe sticking to the minimal formatting fixes would be the better solution after all, since nobody doesn\u0027t seem to want to actually approve this one?","commit_id":"fd5fabf32f6f7aa4ef41c3a25603502b65cbe4bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b7a1f0319a1f33920d72dfd8e5cd068bf91c1f20","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f3565e42_bcec65cf","in_reply_to":"b79bd2e3_d878028c","updated":"2025-06-03 22:59:17.000000000","message":"Well, tried multiple linters - neither of them checks for that...","commit_id":"fd5fabf32f6f7aa4ef41c3a25603502b65cbe4bc"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3b82f3cc1db9317ba9106e70dd82d43243fdf6c6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"55ad9001_e562078e","in_reply_to":"b8cb100f_27a3ee56","updated":"2025-06-10 19:31:10.000000000","message":"So, we will backport it?","commit_id":"fd5fabf32f6f7aa4ef41c3a25603502b65cbe4bc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e4a101ef0663035f99641f6607a49194ac85ed1f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b8cb100f_27a3ee56","in_reply_to":"f3565e42_bcec65cf","updated":"2025-06-04 04:49:54.000000000","message":"Well I assume that that is because both are indeed valid options. So let\u0027s just move ahead with this and see where we end up?\n\nAlthough when I was ready to push the button, I noticed one issue: I\u0027d consider the current change not well suited for backporting, if we\u0027d just do the minimal formatting fix in the first file, backports would be much easier.","commit_id":"fd5fabf32f6f7aa4ef41c3a25603502b65cbe4bc"}],"doc/source/admin/advanced-configuration.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb77267181d4e35166d73e357913a334ab87c368","unresolved":true,"context_lines":[{"line_number":11,"context_line":"as a series of endpoints. These endpoints are the admin URL, the internal"},{"line_number":12,"context_line":"URL, and the external URL."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Kolla offers two options for assigning these endpoints to network addresses:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Combined - Where all three endpoints share the same IP address"},{"line_number":17,"context_line":"* Separate - Where the external URL is assigned to an IP address that is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e7754f00_28d9165f","line":14,"updated":"2025-03-13 05:53:47.000000000","message":"I think the real bug only was the missing empty line after this. Changing all the `-` to `*` doesn\u0027t seem to change the rendering and so maybe we can avoid that?","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3fbc7d00a671e8293194fbcf67024d6ac5ecd831","unresolved":false,"context_lines":[{"line_number":11,"context_line":"as a series of endpoints. These endpoints are the admin URL, the internal"},{"line_number":12,"context_line":"URL, and the external URL."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Kolla offers two options for assigning these endpoints to network addresses:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Combined - Where all three endpoints share the same IP address"},{"line_number":17,"context_line":"* Separate - Where the external URL is assigned to an IP address that is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"474933af_6a3bd139","line":14,"in_reply_to":"5659e7f5_dd4823a4","updated":"2025-03-18 08:31:05.000000000","message":"I guess it doesn\u0027t hurt to be aligned with sphinx docs ;-)","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a5810b4f751ec49f3da6f4259cde15cd54d3e111","unresolved":true,"context_lines":[{"line_number":11,"context_line":"as a series of endpoints. These endpoints are the admin URL, the internal"},{"line_number":12,"context_line":"URL, and the external URL."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Kolla offers two options for assigning these endpoints to network addresses:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Combined - Where all three endpoints share the same IP address"},{"line_number":17,"context_line":"* Separate - Where the external URL is assigned to an IP address that is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5659e7f5_dd4823a4","line":14,"in_reply_to":"e7754f00_28d9165f","updated":"2025-03-13 20:33:44.000000000","message":"I couldn\u0027t find any reference in the RST docs at https://sublime-and-sphinx-guide.readthedocs.io/en/latest/lists.html to dashes being a supported bulleting format. I can revert the other changes if you want, but these files were inconsistent and this file definitely didn\u0027t render correctly.","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb77267181d4e35166d73e357913a334ab87c368","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Kolla offers two options for assigning these endpoints to network addresses:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Combined - Where all three endpoints share the same IP address"},{"line_number":17,"context_line":"* Separate - Where the external URL is assigned to an IP address that is"},{"line_number":18,"context_line":"  different than the IP address shared by the internal and admin URLs"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1be25348_a99c7750","line":16,"range":{"start_line":16,"start_character":23,"end_line":16,"end_character":28},"updated":"2025-03-13 05:53:47.000000000","message":"the third (admin) endpoint only ever was a thing for keystone, and it has been dropped there with keystone v3. so we should reword this and the paragraph above. doesn\u0027t need to be done in this change, just a note for a followup","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3fbc7d00a671e8293194fbcf67024d6ac5ecd831","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Kolla offers two options for assigning these endpoints to network addresses:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Combined - Where all three endpoints share the same IP address"},{"line_number":17,"context_line":"* Separate - Where the external URL is assigned to an IP address that is"},{"line_number":18,"context_line":"  different than the IP address shared by the internal and admin URLs"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"acf6b910_9f0cde9f","line":16,"range":{"start_line":16,"start_character":23,"end_line":16,"end_character":28},"in_reply_to":"1be25348_a99c7750","updated":"2025-03-18 08:31:05.000000000","message":"Done","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"}],"doc/source/admin/tls.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb77267181d4e35166d73e357913a334ab87c368","unresolved":true,"context_lines":[{"line_number":83,"context_line":"* ``kolla_enable_tls_external``"},{"line_number":84,"context_line":"* ``kolla_enable_tls_internal``"},{"line_number":85,"context_line":"* ``kolla_internal_fqdn_cert``"},{"line_number":86,"context_line":"* ``kolla_external_fqdn_cert``"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"99e02328_a1045a41","line":86,"updated":"2025-03-13 05:53:47.000000000","message":"I don\u0027t see a change in rendering for this, why do you think that it is necessary?","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3fbc7d00a671e8293194fbcf67024d6ac5ecd831","unresolved":false,"context_lines":[{"line_number":83,"context_line":"* ``kolla_enable_tls_external``"},{"line_number":84,"context_line":"* ``kolla_enable_tls_internal``"},{"line_number":85,"context_line":"* ``kolla_internal_fqdn_cert``"},{"line_number":86,"context_line":"* ``kolla_external_fqdn_cert``"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7570bf2d_b9b34e06","line":86,"in_reply_to":"8177bb21_d26dfc11","updated":"2025-03-18 08:31:05.000000000","message":"Done","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a5810b4f751ec49f3da6f4259cde15cd54d3e111","unresolved":true,"context_lines":[{"line_number":83,"context_line":"* ``kolla_enable_tls_external``"},{"line_number":84,"context_line":"* ``kolla_enable_tls_internal``"},{"line_number":85,"context_line":"* ``kolla_internal_fqdn_cert``"},{"line_number":86,"context_line":"* ``kolla_external_fqdn_cert``"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8177bb21_d26dfc11","line":86,"in_reply_to":"99e02328_a1045a41","updated":"2025-03-13 20:33:44.000000000","message":"See my comment on the previous file -- https://sublime-and-sphinx-guide.readthedocs.io/en/latest/lists.html does not list dashes as a supported bulleting format so I figured I\u0027d just fix them all while I was at it.","commit_id":"e2a900a8b8a3353718c9f3d2d1851243f9889712"}]}