)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb59d5073dc4d9fbee332ee4f1bd470c2252a4f5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"mariadb: Use mysql_query instead of command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also fix hardcoded root username in"},{"line_number":10,"context_line":"ansible/roles/mariadb/handlers/main.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9b83e206aff694a9b8caf68da2e50b5c34e7ad23"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"d662d9ef_228a4f06","line":10,"updated":"2025-03-21 09:54:41.000000000","message":"nit: also in three of the other tasks","commit_id":"8262c786bd5bd00b292f8d9fc931eb8efbe746cc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"494ef4f7421500585dd24c3d829bca4699c70638","unresolved":false,"context_lines":[{"line_number":7,"context_line":"mariadb: Use mysql_query instead of command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also fix hardcoded root username in"},{"line_number":10,"context_line":"ansible/roles/mariadb/handlers/main.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9b83e206aff694a9b8caf68da2e50b5c34e7ad23"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"99b8d893_028567b7","line":10,"in_reply_to":"d662d9ef_228a4f06","updated":"2025-03-21 10:01:12.000000000","message":"Done","commit_id":"8262c786bd5bd00b292f8d9fc931eb8efbe746cc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d9c8978aec87f0028f91041252ae7c47150bfaaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"eab25ab6_2e82e19f","updated":"2025-03-19 18:14:43.000000000","message":"recheck debian podman timed out","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"835d9725d5d1594269abcc14e6c673574243d51e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3b726237_f8cd74c9","updated":"2025-03-21 10:17:37.000000000","message":"accounting for previous +2","commit_id":"37b97d46a50ca83b9f34e5a1947ed915763d2162"}],"ansible/roles/mariadb/handlers/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea723e818225d14d39a7629fe2636b69dd5a2ce","unresolved":true,"context_lines":[{"line_number":42,"context_line":"      login_db: \"mysql\""},{"line_number":43,"context_line":"      login_host: \"{{ api_interface_address }}\""},{"line_number":44,"context_line":"      login_port: \"{{ mariadb_port }}\""},{"line_number":45,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":46,"context_line":"      login_password: \"{{ database_password }}\""},{"line_number":47,"context_line":"      query: \u0027SHOW STATUS LIKE \"wsrep_local_state_comment\"\u0027"},{"line_number":48,"context_line":"  register: result"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3ec29262_d6043471","line":45,"updated":"2025-03-20 17:11:32.000000000","message":"so it was a bug that the user was hardcoded to `root` before? might be worth mentioning in the commit message","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b1d0be663cb3743ee9ada1a8f62399019b0497e2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      login_db: \"mysql\""},{"line_number":43,"context_line":"      login_host: \"{{ api_interface_address }}\""},{"line_number":44,"context_line":"      login_port: \"{{ mariadb_port }}\""},{"line_number":45,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":46,"context_line":"      login_password: \"{{ database_password }}\""},{"line_number":47,"context_line":"      query: \u0027SHOW STATUS LIKE \"wsrep_local_state_comment\"\u0027"},{"line_number":48,"context_line":"  register: result"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1c29ce15_5360191b","line":45,"in_reply_to":"3ec29262_d6043471","updated":"2025-03-20 17:25:29.000000000","message":"Done","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"}],"ansible/roles/mariadb/tasks/check.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea723e818225d14d39a7629fe2636b69dd5a2ce","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    module_name: mysql_query"},{"line_number":11,"context_line":"    module_args:"},{"line_number":12,"context_line":"      login_db: \"mysql\""},{"line_number":13,"context_line":"      login_host: \"{{ api_interface_address }}\""},{"line_number":14,"context_line":"      login_port: \"{{ mariadb_port }}\""},{"line_number":15,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":16,"context_line":"      login_password: \"{{ database_password }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"83eb5549_aae98307","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":43},"updated":"2025-03-20 17:11:32.000000000","message":"shouldn\u0027t this be `database_address`?","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd78748f8907912cf00e4b9725dc9d40c8139070","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    module_name: mysql_query"},{"line_number":11,"context_line":"    module_args:"},{"line_number":12,"context_line":"      login_db: \"mysql\""},{"line_number":13,"context_line":"      login_host: \"{{ api_interface_address }}\""},{"line_number":14,"context_line":"      login_port: \"{{ mariadb_port }}\""},{"line_number":15,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":16,"context_line":"      login_password: \"{{ database_password }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5e2b7271_a0e37425","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":43},"in_reply_to":"83eb5549_aae98307","updated":"2025-03-20 17:23:07.000000000","message":"Done","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea723e818225d14d39a7629fe2636b69dd5a2ce","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    module_args:"},{"line_number":12,"context_line":"      login_db: \"mysql\""},{"line_number":13,"context_line":"      login_host: \"{{ api_interface_address }}\""},{"line_number":14,"context_line":"      login_port: \"{{ mariadb_port }}\""},{"line_number":15,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":16,"context_line":"      login_password: \"{{ database_password }}\""},{"line_number":17,"context_line":"      query: \"SHOW DATABASES;\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"51991ef2_20f8dcc7","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":34},"updated":"2025-03-20 17:11:32.000000000","message":"was `database_port` before?","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd78748f8907912cf00e4b9725dc9d40c8139070","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    module_args:"},{"line_number":12,"context_line":"      login_db: \"mysql\""},{"line_number":13,"context_line":"      login_host: \"{{ api_interface_address }}\""},{"line_number":14,"context_line":"      login_port: \"{{ mariadb_port }}\""},{"line_number":15,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":16,"context_line":"      login_password: \"{{ database_password }}\""},{"line_number":17,"context_line":"      query: \"SHOW DATABASES;\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9b92e8be_892ac22b","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":34},"in_reply_to":"51991ef2_20f8dcc7","updated":"2025-03-20 17:23:07.000000000","message":"Done","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"674900f10419e3f86d9ec141f751ccd3de6e7e73","unresolved":true,"context_lines":[{"line_number":12,"context_line":"      login_db: \"mysql\""},{"line_number":13,"context_line":"      login_host: \"{{ api_interface_address }}\""},{"line_number":14,"context_line":"      login_port: \"{{ mariadb_port }}\""},{"line_number":15,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":16,"context_line":"      login_password: \"{{ database_password }}\""},{"line_number":17,"context_line":"      query: \"SHOW DATABASES;\""},{"line_number":18,"context_line":"  register: result"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"cf698d43_f09c5e9a","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":35},"updated":"2025-03-20 10:23:57.000000000","message":"mariadb_shard_database_user","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd78748f8907912cf00e4b9725dc9d40c8139070","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      login_db: \"mysql\""},{"line_number":13,"context_line":"      login_host: \"{{ api_interface_address }}\""},{"line_number":14,"context_line":"      login_port: \"{{ mariadb_port }}\""},{"line_number":15,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":16,"context_line":"      login_password: \"{{ database_password }}\""},{"line_number":17,"context_line":"      query: \"SHOW DATABASES;\""},{"line_number":18,"context_line":"  register: result"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c23212dc_5c36bf36","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":35},"in_reply_to":"cf698d43_f09c5e9a","updated":"2025-03-20 17:23:07.000000000","message":"Done","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"af30493502b75af55026f8c8a17587c2908a1eaa","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  changed_when: False"},{"line_number":21,"context_line":"  retries: 6"},{"line_number":22,"context_line":"  delay: 10"},{"line_number":23,"context_line":"  when: mariadb_shard_id \u003d\u003d mariadb_default_database_shard_id"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"b3f08eba_c4dc46d1","line":23,"range":{"start_line":23,"start_character":1,"end_line":23,"end_character":61},"updated":"2025-03-20 10:25:03.000000000","message":"I think this can be dropped if proxysql is default now.","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"322dca13a56727c166d4a553149e637f0aadcd30","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  changed_when: False"},{"line_number":21,"context_line":"  retries: 6"},{"line_number":22,"context_line":"  delay: 10"},{"line_number":23,"context_line":"  when: mariadb_shard_id \u003d\u003d mariadb_default_database_shard_id"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"cd51372f_5547e67f","line":23,"range":{"start_line":23,"start_character":1,"end_line":23,"end_character":61},"in_reply_to":"29460b20_c94c320f","updated":"2025-03-20 18:08:30.000000000","message":"Hmm, i think it will work in same way without error. Because if user is using haproxy, it also means he use only one DB cluster so ``mariadb_shard_database_user`` will be root_0 on every host check is running.\n\nWhen used with proxysql and several DB clusters ..every server will try to connect to VIP:port with root_0 root_1 root_2 and all should return databases list as proxysql is working ...\n\nNow it is limited only for the first group - what i can see from the code.","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8ff677779724339a0a91321a7d09ef8b2aba268c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  changed_when: False"},{"line_number":21,"context_line":"  retries: 6"},{"line_number":22,"context_line":"  delay: 10"},{"line_number":23,"context_line":"  when: mariadb_shard_id \u003d\u003d mariadb_default_database_shard_id"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"29460b20_c94c320f","line":23,"range":{"start_line":23,"start_character":1,"end_line":23,"end_character":61},"in_reply_to":"b3f08eba_c4dc46d1","updated":"2025-03-20 17:32:02.000000000","message":"What about if somebody is not using proxysql?","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7353ea03ab0cd3ea6fcbf1d6a0719a795ae46fb5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  changed_when: False"},{"line_number":21,"context_line":"  retries: 6"},{"line_number":22,"context_line":"  delay: 10"},{"line_number":23,"context_line":"  when: mariadb_shard_id \u003d\u003d mariadb_default_database_shard_id"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"520c82d9_f8011317","line":23,"range":{"start_line":23,"start_character":1,"end_line":23,"end_character":61},"in_reply_to":"cd51372f_5547e67f","updated":"2025-03-20 21:01:15.000000000","message":"Done","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"}],"ansible/roles/mariadb/tasks/lookup_cluster.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea723e818225d14d39a7629fe2636b69dd5a2ce","unresolved":true,"context_lines":[{"line_number":58,"context_line":"          register: check_mariadb_sync_status"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        - debug:"},{"line_number":61,"context_line":"            msg: \"{{ check_mariadb_sync_status.query_result[0][0][\u0027Value\u0027] }}\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # NOTE(yoctozepto): this is extracted separately to properly escape"},{"line_number":64,"context_line":"        # the TAB character which likes to go wrong due to interaction between"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7d6a0a11_9a351862","line":61,"updated":"2025-03-20 17:11:32.000000000","message":"do you really want to leave the debug statement in here?","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b1d0be663cb3743ee9ada1a8f62399019b0497e2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          register: check_mariadb_sync_status"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        - debug:"},{"line_number":61,"context_line":"            msg: \"{{ check_mariadb_sync_status.query_result[0][0][\u0027Value\u0027] }}\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # NOTE(yoctozepto): this is extracted separately to properly escape"},{"line_number":64,"context_line":"        # the TAB character which likes to go wrong due to interaction between"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bd165830_db041872","line":61,"in_reply_to":"7d6a0a11_9a351862","updated":"2025-03-20 17:25:29.000000000","message":"Done","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea723e818225d14d39a7629fe2636b69dd5a2ce","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # NOTE(yoctozepto): this is extracted separately to properly escape"},{"line_number":64,"context_line":"        # the TAB character which likes to go wrong due to interaction between"},{"line_number":65,"context_line":"        # Python/Ansible/Jinja2/YAML, the way below works"},{"line_number":66,"context_line":"        - name: Extract MariaDB service WSREP sync status"},{"line_number":67,"context_line":"          set_fact:"},{"line_number":68,"context_line":"            mariadb_sync_status: \"{{ check_mariadb_sync_status.query_result[0][0][\u0027Value\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5fa39ac4_6ea710a3","line":65,"updated":"2025-03-20 17:11:32.000000000","message":"this comment no longer applies to the new code","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b1d0be663cb3743ee9ada1a8f62399019b0497e2","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # NOTE(yoctozepto): this is extracted separately to properly escape"},{"line_number":64,"context_line":"        # the TAB character which likes to go wrong due to interaction between"},{"line_number":65,"context_line":"        # Python/Ansible/Jinja2/YAML, the way below works"},{"line_number":66,"context_line":"        - name: Extract MariaDB service WSREP sync status"},{"line_number":67,"context_line":"          set_fact:"},{"line_number":68,"context_line":"            mariadb_sync_status: \"{{ check_mariadb_sync_status.query_result[0][0][\u0027Value\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"10934ee4_3b3e8aff","line":65,"in_reply_to":"5fa39ac4_6ea710a3","updated":"2025-03-20 17:25:29.000000000","message":"Done","commit_id":"3c3fe72cafbf4d78efb911e8fedcfb7bca4b71e6"}]}