)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b78d7ae7556671b83e99473765c9fb1cd8f98b47","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Not needed inside the container, firewalld already runs on host"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Making directory creation more idempotent during bootsrap"},{"line_number":12,"context_line":"Fixing bifrost tests - using baremetal CLI"},{"line_number":13,"context_line":"Openstack client is not installed inside the container"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e3927a4a_6d39d8b8","line":11,"range":{"start_line":11,"start_character":49,"end_line":11,"end_character":57},"updated":"2025-03-26 15:33:34.000000000","message":"bootstrap","commit_id":"88e1f4cdf306dc713e7d25df57e2148e1485d00a"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"05bf45a7c141ea8de49be4eaa9abbf532a0dab3d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Not needed inside the container, firewalld already runs on host"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Making directory creation more idempotent during bootsrap"},{"line_number":12,"context_line":"Fixing bifrost tests - using baremetal CLI"},{"line_number":13,"context_line":"Openstack client is not installed inside the container"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b3c539f8_c4c79a29","line":11,"range":{"start_line":11,"start_character":49,"end_line":11,"end_character":57},"in_reply_to":"e3927a4a_6d39d8b8","updated":"2025-03-27 08:17:32.000000000","message":"Done","commit_id":"88e1f4cdf306dc713e7d25df57e2148e1485d00a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b78d7ae7556671b83e99473765c9fb1cd8f98b47","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Making directory creation more idempotent during bootsrap"},{"line_number":12,"context_line":"Fixing bifrost tests - using baremetal CLI"},{"line_number":13,"context_line":"Openstack client is not installed inside the container"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5b85efe655978214ad02abf3cda4c4d2b9649add"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa04b904_35505a52","line":13,"updated":"2025-03-26 15:33:34.000000000","message":"baremetal CLI is still openstack client, but whatever ;-)","commit_id":"88e1f4cdf306dc713e7d25df57e2148e1485d00a"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"05bf45a7c141ea8de49be4eaa9abbf532a0dab3d","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Making directory creation more idempotent during bootsrap"},{"line_number":12,"context_line":"Fixing bifrost tests - using baremetal CLI"},{"line_number":13,"context_line":"Openstack client is not installed inside the container"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5b85efe655978214ad02abf3cda4c4d2b9649add"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5402d202_692697ab","line":13,"in_reply_to":"fa04b904_35505a52","updated":"2025-03-27 08:17:32.000000000","message":"Tried making it more precise :D","commit_id":"88e1f4cdf306dc713e7d25df57e2148e1485d00a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e59376b237baae931c231b153e62ccb08df4d2cc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable firewalld in Bifrost container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Not needed inside the container, as firewalld runs on the host."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Make directory creation idempotent during bootstrap."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f8029e7_881e696b","line":9,"updated":"2025-03-27 10:58:25.000000000","message":"Mention it was failing if enabled","commit_id":"68874fdbbf74bb01dd42796a0ef0bb7a27912029"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"0fd2071e1cf9c60dd8d1f77caa468f146f613d09","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable firewalld in Bifrost container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Not needed inside the container, as firewalld runs on the host."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Make directory creation idempotent during bootstrap."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c328f1e2_cc21acb7","line":9,"in_reply_to":"5f8029e7_881e696b","updated":"2025-03-27 12:39:33.000000000","message":"Done","commit_id":"68874fdbbf74bb01dd42796a0ef0bb7a27912029"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"23edd32723f6db222e3a9bce5fdc165ce361e049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9152ce28_149b8530","updated":"2025-03-25 20:44:41.000000000","message":"it makes sense","commit_id":"6291e92cc9515951d096756bdb5db9dc76adbd1e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b30ea2bde4d623cb8fd068790360eb180a3057cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c02193ee_31c0b18f","updated":"2025-04-01 06:35:47.000000000","message":"looks reasonable to me and CI is passing","commit_id":"664a79f42f91a10eb919bf65ecc19984b5f1b0a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ab9186b406ea2a5baa2487b1f195ad92243d378a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0b5a1e38_a41c701e","updated":"2025-04-01 08:53:28.000000000","message":"recheck - docker: received unexpected HTTP status: 502 Bad Gateway","commit_id":"664a79f42f91a10eb919bf65ecc19984b5f1b0a3"}],"ansible/roles/bifrost/tasks/bootstrap.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e59376b237baae931c231b153e62ccb08df4d2cc","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  become: true"},{"line_number":28,"context_line":"  command: \u003e"},{"line_number":29,"context_line":"     {{ kolla_container_engine }} exec bifrost_deploy"},{"line_number":30,"context_line":"     bash -c \u0027mkdir -p /root/.ssh ; mkdir -p /home/ironic/.ssh;"},{"line_number":31,"context_line":"     cp -f /etc/bifrost/id_rsa /root/.ssh/id_rsa \u0026\u0026"},{"line_number":32,"context_line":"     cp -f /etc/bifrost/id_rsa.pub /root/.ssh/id_rsa.pub \u0026\u0026"},{"line_number":33,"context_line":"     cp -f /etc/bifrost/ssh_config /root/.ssh/config \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3e35311e_573d5932","line":30,"updated":"2025-03-27 10:58:25.000000000","message":"sneaky, but whatever","commit_id":"68874fdbbf74bb01dd42796a0ef0bb7a27912029"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"b2602d9624482507e070e694588d518728293773","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  become: true"},{"line_number":28,"context_line":"  command: \u003e"},{"line_number":29,"context_line":"     {{ kolla_container_engine }} exec bifrost_deploy"},{"line_number":30,"context_line":"     bash -c \u0027mkdir -p /root/.ssh ; mkdir -p /home/ironic/.ssh;"},{"line_number":31,"context_line":"     cp -f /etc/bifrost/id_rsa /root/.ssh/id_rsa \u0026\u0026"},{"line_number":32,"context_line":"     cp -f /etc/bifrost/id_rsa.pub /root/.ssh/id_rsa.pub \u0026\u0026"},{"line_number":33,"context_line":"     cp -f /etc/bifrost/ssh_config /root/.ssh/config \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7bce0849_2a355919","line":30,"in_reply_to":"3e35311e_573d5932","updated":"2025-03-27 11:07:39.000000000","message":"Same idea as in \n```Ensure log directories exist```\n\nAdhering to standards :D","commit_id":"68874fdbbf74bb01dd42796a0ef0bb7a27912029"}],"ansible/roles/bifrost/templates/bifrost.yml.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1100b8e0f71cfc1795a5583e798fcd64ce34b3dd","unresolved":true,"context_lines":[{"line_number":38,"context_line":"enable_inspector: \"{{ bifrost_enable_ironic_inspector }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Disable firewalld"},{"line_number":41,"context_line":"use_firewalld: false"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a577c4bb_db83b8bf","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":20},"updated":"2025-03-25 20:47:14.000000000","message":"```suggestion\nuse_firewalld: \"{{ enable_external_api_firewalld | bool }}\"\n```","commit_id":"6291e92cc9515951d096756bdb5db9dc76adbd1e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1995bfc63f11af6c78f7e4dcebb02ae693eef929","unresolved":false,"context_lines":[{"line_number":38,"context_line":"enable_inspector: \"{{ bifrost_enable_ironic_inspector }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Disable firewalld"},{"line_number":41,"context_line":"use_firewalld: false"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"60598c35_b0c10050","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":20},"in_reply_to":"12b87712_350c305c","updated":"2025-03-26 16:04:01.000000000","message":"this was only suggestion, not recomendation","commit_id":"6291e92cc9515951d096756bdb5db9dc76adbd1e"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"b18b0648b05faa42c804b0c454ee67a719f5b937","unresolved":false,"context_lines":[{"line_number":38,"context_line":"enable_inspector: \"{{ bifrost_enable_ironic_inspector }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Disable firewalld"},{"line_number":41,"context_line":"use_firewalld: false"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"12b87712_350c305c","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":20},"in_reply_to":"a577c4bb_db83b8bf","updated":"2025-03-26 09:13:11.000000000","message":"But why ? \nI understand enable_external_api_firewalld defaults to false, but even if we want firewalld enabled for external_api... we still don\u0027t want firewalld installed inside the container right ?","commit_id":"6291e92cc9515951d096756bdb5db9dc76adbd1e"}],"tests/test-bifrost.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b78d7ae7556671b83e99473765c9fb1cd8f98b47","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    # TODO(mgoddard): More testing, deploy bare metal nodes."},{"line_number":14,"context_line":"    # TODO(mgoddard): Use openstackclient when clouds.yaml works. See"},{"line_number":15,"context_line":"    # https://bugs.launchpad.net/bifrost/+bug/1754070."},{"line_number":16,"context_line":"    # (gkoper): No openstack client inside bifrost_container atm"},{"line_number":17,"context_line":"    attempts\u003d0"},{"line_number":18,"context_line":"    while [[ $(sudo ${container_engine} exec bifrost_deploy bash -c \"OS_CLOUD\u003dbifrost baremetal driver list -f value\" | wc -l) -eq 0 ]]; do"},{"line_number":19,"context_line":"        attempts\u003d$((attempts + 1))"}],"source_content_type":"text/x-sh","patch_set":4,"id":"71d98b0c_870ade66","line":16,"updated":"2025-03-26 15:33:34.000000000","message":"I don\u0027t think we need that note here, just write in the commit message why we need to change the CLI","commit_id":"88e1f4cdf306dc713e7d25df57e2148e1485d00a"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"05bf45a7c141ea8de49be4eaa9abbf532a0dab3d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    # TODO(mgoddard): More testing, deploy bare metal nodes."},{"line_number":14,"context_line":"    # TODO(mgoddard): Use openstackclient when clouds.yaml works. See"},{"line_number":15,"context_line":"    # https://bugs.launchpad.net/bifrost/+bug/1754070."},{"line_number":16,"context_line":"    # (gkoper): No openstack client inside bifrost_container atm"},{"line_number":17,"context_line":"    attempts\u003d0"},{"line_number":18,"context_line":"    while [[ $(sudo ${container_engine} exec bifrost_deploy bash -c \"OS_CLOUD\u003dbifrost baremetal driver list -f value\" | wc -l) -eq 0 ]]; do"},{"line_number":19,"context_line":"        attempts\u003d$((attempts + 1))"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7e1eba72_0fa7dec0","line":16,"in_reply_to":"71d98b0c_870ade66","updated":"2025-03-27 08:17:32.000000000","message":"Done","commit_id":"88e1f4cdf306dc713e7d25df57e2148e1485d00a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e59376b237baae931c231b153e62ccb08df4d2cc","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        sleep 10"},{"line_number":24,"context_line":"    done"},{"line_number":25,"context_line":"    sudo $container_engine exec bifrost_deploy bash -c \"OS_CLOUD\u003dbifrost baremetal node list\""},{"line_number":26,"context_line":"    sudo $container_engine exec bifrost_deploy bash -c \"OS_CLOUD\u003dbifrost baremetal node create --driver ipmi --name test-node\""},{"line_number":27,"context_line":"    sudo $container_engine exec bifrost_deploy bash -c \"OS_CLOUD\u003dbifrost baremetal node delete test-node\""},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"cca51658_7d06643c","line":26,"updated":"2025-03-27 10:58:25.000000000","message":"should we switch to redfish? ;-)","commit_id":"68874fdbbf74bb01dd42796a0ef0bb7a27912029"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"0fd2071e1cf9c60dd8d1f77caa468f146f613d09","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        sleep 10"},{"line_number":24,"context_line":"    done"},{"line_number":25,"context_line":"    sudo $container_engine exec bifrost_deploy bash -c \"OS_CLOUD\u003dbifrost baremetal node list\""},{"line_number":26,"context_line":"    sudo $container_engine exec bifrost_deploy bash -c \"OS_CLOUD\u003dbifrost baremetal node create --driver ipmi --name test-node\""},{"line_number":27,"context_line":"    sudo $container_engine exec bifrost_deploy bash -c \"OS_CLOUD\u003dbifrost baremetal node delete test-node\""},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"219f8feb_e7534da9","line":26,"in_reply_to":"cca51658_7d06643c","updated":"2025-03-27 12:39:33.000000000","message":"Sure let\u0027s see what breaks :D","commit_id":"68874fdbbf74bb01dd42796a0ef0bb7a27912029"}]}