)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f513ff881d198ab5508db187b17e2b76e375dcec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2bbf74b_6baaec3f","updated":"2025-03-26 14:27:34.000000000","message":"We probably need to wait until after 2025.1 is branched and we are tracking upstream 2025.2?","commit_id":"788b22c592d1b4bb90698d97e1bb1630f95fc0ea"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"a7179d5524717f2421f4567a5c296c89db83ae76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a8e29cd_4b4ad6fe","updated":"2025-03-30 13:05:08.000000000","message":"Thank you. Where are those rules defined ? I am considering adding some additional linter rules to cover what we\u0027re currently missing ( since we do check release notes with reno lint )","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"952004a11a36ac4050a7d8d32602960fd9cce8b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e3153590_d383326d","in_reply_to":"4a8e29cd_4b4ad6fe","updated":"2025-03-30 17:19:38.000000000","message":"I think it\u0027s just standard RST rendering? The previous patch failed to render the release note because of:\n\n\u003creno.sphinxext current branch\u003e:109: ERROR: Unexpected indentation. [docutils]\n/home/zuul/src/opendev.org/openstack/kolla-ansible/releasenotes/source/unreleased.rst:109: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]\n/home/zuul/src/opendev.org/openstack/kolla-ansible/releasenotes/source/unreleased.rst:111: WARNING: Bullet list ends without a blank line; unexpected unindent. [docutils]","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"730e55243e106839c12319c30e42a47a1b801e87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fcddb7af_4943b94f","updated":"2025-04-01 12:48:17.000000000","message":"accounting previous +2s","commit_id":"94b91727a2bc6ee6ea85ccae28277d345772cff9"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c5d0449e7b1c0ae1031cb7222a97e0d1e3acc90","unresolved":true,"context_lines":[{"line_number":497,"context_line":"# where you need to maintain compatibility between different versions"},{"line_number":498,"context_line":"# during the upgrade. For direct version jumps, this should be unset."},{"line_number":499,"context_line":"# See: https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version"},{"line_number":500,"context_line":"ironic_pin_release_version: \"{{ omit }}\""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"iscsi_port: \"3260\""},{"line_number":503,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"498086c0_ff983722","line":500,"updated":"2025-03-30 21:52:26.000000000","message":"Don\u0027t use omit, use empty value (\"\") - and move that to ironic role defaults - I don\u0027t think any other role than Ironic needs that variable?","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"3be1b00a641976b4a66b305d7c49f9cec1ef22e6","unresolved":false,"context_lines":[{"line_number":497,"context_line":"# where you need to maintain compatibility between different versions"},{"line_number":498,"context_line":"# during the upgrade. For direct version jumps, this should be unset."},{"line_number":499,"context_line":"# See: https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version"},{"line_number":500,"context_line":"ironic_pin_release_version: \"{{ omit }}\""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"iscsi_port: \"3260\""},{"line_number":503,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6d80bfbd_0141027a","line":500,"in_reply_to":"498086c0_ff983722","updated":"2025-03-31 17:31:09.000000000","message":"Done","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"}],"ansible/roles/ironic/tasks/rolling_upgrade.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c5d0449e7b1c0ae1031cb7222a97e0d1e3acc90","unresolved":true,"context_lines":[{"line_number":8,"context_line":"- import_tasks: config.yml"},{"line_number":9,"context_line":"  vars:"},{"line_number":10,"context_line":"    pin_release_version: \"{{ ironic_pin_release_version }}\""},{"line_number":11,"context_line":"  when: ironic_pin_release_version is defined"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- import_tasks: check-containers.yml"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7b2fee32_754dce30","line":11,"updated":"2025-03-30 21:52:26.000000000","message":"it will be always defined, use ironic_pin_release_version | length \u003e 0","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"3be1b00a641976b4a66b305d7c49f9cec1ef22e6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- import_tasks: config.yml"},{"line_number":9,"context_line":"  vars:"},{"line_number":10,"context_line":"    pin_release_version: \"{{ ironic_pin_release_version }}\""},{"line_number":11,"context_line":"  when: ironic_pin_release_version is defined"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- import_tasks: check-containers.yml"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ccba18c1_40fd2ac0","line":11,"in_reply_to":"7b2fee32_754dce30","updated":"2025-03-31 17:31:09.000000000","message":"Done","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"}],"releasenotes/notes/improve-ironic-pin-release-version-8f9e2b3c4d5a6b7c.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b99f081e5ba091e74f013a21ad373de3faaf0c75","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":"    - Renaming the variable from `openstack_previous_release_name` to"},{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b939404c_dc5570da","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":73},"updated":"2025-03-30 08:41:02.000000000","message":"Add an empty line below this one.","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"a7179d5524717f2421f4567a5c296c89db83ae76","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":"    - Renaming the variable from `openstack_previous_release_name` to"},{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"35985b75_dfecbd4e","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":73},"in_reply_to":"b939404c_dc5570da","updated":"2025-03-30 13:05:08.000000000","message":"Done","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b99f081e5ba091e74f013a21ad373de3faaf0c75","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":"    - Renaming the variable from `openstack_previous_release_name` to"},{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"},{"line_number":8,"context_line":"    - Adding proper documentation explaining when to use this setting"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f21998f6_00620115","line":5,"range":{"start_line":5,"start_character":33,"end_line":5,"end_character":66},"updated":"2025-03-30 08:41:02.000000000","message":"Use double backticks","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"a7179d5524717f2421f4567a5c296c89db83ae76","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":"    - Renaming the variable from `openstack_previous_release_name` to"},{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"},{"line_number":8,"context_line":"    - Adding proper documentation explaining when to use this setting"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b7714b5a_bdcffc64","line":5,"range":{"start_line":5,"start_character":33,"end_line":5,"end_character":66},"in_reply_to":"f21998f6_00620115","updated":"2025-03-30 13:05:08.000000000","message":"Done","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b99f081e5ba091e74f013a21ad373de3faaf0c75","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":"    - Renaming the variable from `openstack_previous_release_name` to"},{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"},{"line_number":8,"context_line":"    - Adding proper documentation explaining when to use this setting"},{"line_number":9,"context_line":"    See: https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d7c0e1a1_64bb8cf1","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":34},"updated":"2025-03-30 08:41:02.000000000","message":"Use double backticks","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"a7179d5524717f2421f4567a5c296c89db83ae76","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":"    - Renaming the variable from `openstack_previous_release_name` to"},{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"},{"line_number":8,"context_line":"    - Adding proper documentation explaining when to use this setting"},{"line_number":9,"context_line":"    See: https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a8301cb3_38584a9b","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":34},"in_reply_to":"d7c0e1a1_64bb8cf1","updated":"2025-03-30 13:05:08.000000000","message":"Done","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b99f081e5ba091e74f013a21ad373de3faaf0c75","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    - Renaming the variable from `openstack_previous_release_name` to"},{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"},{"line_number":8,"context_line":"    - Adding proper documentation explaining when to use this setting"},{"line_number":9,"context_line":"    See: https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ee62e8c0_730331c5","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":69},"updated":"2025-03-30 08:41:02.000000000","message":"Bullet list ends without a blank line","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"a7179d5524717f2421f4567a5c296c89db83ae76","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    - Renaming the variable from `openstack_previous_release_name` to"},{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"},{"line_number":8,"context_line":"    - Adding proper documentation explaining when to use this setting"},{"line_number":9,"context_line":"    See: https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fccf658c_e339649e","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":69},"in_reply_to":"ee62e8c0_730331c5","updated":"2025-03-30 13:05:08.000000000","message":"Done","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b99f081e5ba091e74f013a21ad373de3faaf0c75","unresolved":true,"context_lines":[{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"},{"line_number":8,"context_line":"    - Adding proper documentation explaining when to use this setting"},{"line_number":9,"context_line":"    See: https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e74795c6_b5bdfeb9","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":103},"updated":"2025-03-30 08:41:02.000000000","message":"This will show the URL as a link, it would be nicer to do something like:\n\nSee `documentation for pin_release_version \u003chttp://blah\u003e`__ for more details.","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"a7179d5524717f2421f4567a5c296c89db83ae76","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      `ironic_pin_release_version`"},{"line_number":7,"context_line":"    - Making the setting optional by default"},{"line_number":8,"context_line":"    - Adding proper documentation explaining when to use this setting"},{"line_number":9,"context_line":"    See: https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9acdadd6_c329e5ef","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":103},"in_reply_to":"e74795c6_b5bdfeb9","updated":"2025-03-30 13:05:08.000000000","message":"Done","commit_id":"676ab0ea22fcf67e9e830b378d188dd316b5d491"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"304f4542131af33e068d5eda3cf08091f3e64f5b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c8e0c49d_381854f7","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2025-03-30 17:18:16.000000000","message":"Should be upgrade?","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"3be1b00a641976b4a66b305d7c49f9cec1ef22e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"007483fa_faffc327","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"c8e0c49d_381854f7","updated":"2025-03-31 17:31:09.000000000","message":"Acknowledged","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"304f4542131af33e068d5eda3cf08091f3e64f5b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    - Making the setting optional by default"},{"line_number":9,"context_line":"    - Adding proper documentation explaining when to use this setting"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    See documentation for pin_release_version \u003chttps://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version\u003e__ for more details."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2a211f90_9c29925a","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":162},"updated":"2025-03-30 17:18:16.000000000","message":"You missed the backticks to generate the link (they got replaced in my comment).","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"3be1b00a641976b4a66b305d7c49f9cec1ef22e6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    - Making the setting optional by default"},{"line_number":9,"context_line":"    - Adding proper documentation explaining when to use this setting"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    See documentation for pin_release_version \u003chttps://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.pin_release_version\u003e__ for more details."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"230de70e_37db9800","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":162},"in_reply_to":"2a211f90_9c29925a","updated":"2025-03-31 17:31:09.000000000","message":"Done","commit_id":"072a6327f75e60d3137413783a6928cc21fc5b76"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b81092482606db7e71b23cdafc9f2a6b04ddae4b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    - Renaming the variable from ``openstack_previous_release_name`` to"},{"line_number":7,"context_line":"      ``ironic_pin_release_version``"},{"line_number":8,"context_line":"    - Making the setting optional by default"},{"line_number":9,"context_line":"    - Adding proper documentation explaining when to use this setting"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c582997d_630dfafc","line":6,"updated":"2025-03-31 20:16:20.000000000","message":"I think we should be more clear that the ``openstack_previous_release_name`` variable has been dropped.","commit_id":"efbce31202f05acb97b066615fb8090ff5bec90e"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"9ad3285dd1db22cb6a1cf9706f86574f86307b0c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improved the configuration of Ironic\u0027s pin_release_version setting by:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    - Renaming the variable from ``openstack_previous_release_name`` to"},{"line_number":7,"context_line":"      ``ironic_pin_release_version``"},{"line_number":8,"context_line":"    - Making the setting optional by default"},{"line_number":9,"context_line":"    - Adding proper documentation explaining when to use this setting"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c3ceeda6_61e43c25","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":0},"in_reply_to":"c582997d_630dfafc","updated":"2025-03-31 22:50:32.000000000","message":"Done","commit_id":"57099c6b32ce174ece73591acc08fc75f4fa7a23"}]}