)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"381f8abb1367b3ce8ead84a4c08665ae03ce024b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d20d23b_2c6bc4ef","updated":"2025-03-26 19:45:48.000000000","message":"TODO: add upgrade task for volume rename","commit_id":"540f35750959aeddcc424ca5f10c66f2069a1722"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"62b78e0cbdf7c87a2a0a8b6b975572f2d8882338","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d387ee22_567e5082","updated":"2025-03-29 21:40:28.000000000","message":"\"Depends-on\" conflicts with \"Needed-by\"? Looks like we need the only one.","commit_id":"3fd2db4beb32b2c26f374abd8c1a91a413ec1f7f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c0646c0de0a750619c3a28faf7a8de9b968d56a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d82b4102_7e2950d6","updated":"2025-03-28 07:48:49.000000000","message":"Needs an upgrade task to rename the volume","commit_id":"3fd2db4beb32b2c26f374abd8c1a91a413ec1f7f"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"22dffc0007379ce87fd39ff7c20b3371792c07f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9f162d94_17df342a","updated":"2025-04-18 11:59:32.000000000","message":"LGTM - tested on lab","commit_id":"4b24aa8121cb967a9fb66e4409f411c67a1c088b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb702831f289b8d29407a468e0c762572e6cdbfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"25045001_1e6ef77d","updated":"2025-04-24 06:41:43.000000000","message":"thx","commit_id":"fe19e7a514f8d780a0f42eccb24050bf883fb709"}],"ansible/roles/prometheus/tasks/upgrade.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f1f6289ffb7f23126a6573df6c3f326fe64e7f9e","unresolved":true,"context_lines":[{"line_number":6,"context_line":"        prometheus_old_volume_name: \"prometheus_v2\""},{"line_number":7,"context_line":"        prometheus_new_volume_name: \"prometheus\""},{"line_number":8,"context_line":"        prometheus_old_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_old_volume_name }}/_data\""},{"line_number":9,"context_line":"        prometheus_new_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/_data\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check for the existence of Prometheus v2 Docker volume"},{"line_number":12,"context_line":"  stat:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"78f279c3_c1243f97","line":9,"updated":"2025-04-17 08:31:56.000000000","message":"seems this doesn\u0027t work, maybe need to split into two steps?\n\n    \"msg\": \"The task includes an option with an undefined variable.. \u0027prometheus_old_volume_name\u0027 is undefined\\n\\nThe error appears to be in \u0027/home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/prometheus/tasks/upgrade.yml\u0027: line 4, column 3, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n\\n- name: Set Prometheus volume migration variables\\n  ^ here\\n\"","commit_id":"26befb9f067c91d8301e980a902987ed0f9eea74"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"97c1dcb72e0f1e31514932a7c90bbb4cbca74f57","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        prometheus_old_volume_name: \"prometheus_v2\""},{"line_number":7,"context_line":"        prometheus_new_volume_name: \"prometheus\""},{"line_number":8,"context_line":"        prometheus_old_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_old_volume_name }}/_data\""},{"line_number":9,"context_line":"        prometheus_new_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/_data\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check for the existence of Prometheus v2 Docker volume"},{"line_number":12,"context_line":"  stat:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ccc7e640_35e4c3d6","line":9,"in_reply_to":"78f279c3_c1243f97","updated":"2025-04-18 11:56:27.000000000","message":"Done","commit_id":"26befb9f067c91d8301e980a902987ed0f9eea74"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3b64a575ef431f5c88ea0cc57f5f02858af0e5a4","unresolved":true,"context_lines":[{"line_number":8,"context_line":"        prometheus_old_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_old_volume_name }}/_data\""},{"line_number":9,"context_line":"        prometheus_new_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/_data\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check for the existence of Prometheus v2 Docker volume"},{"line_number":12,"context_line":"  stat:"},{"line_number":13,"context_line":"    path: \"{{ prometheus_old_data_path }}\""},{"line_number":14,"context_line":"  register: old_data"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8a42bac6_7e754b50","line":11,"range":{"start_line":11,"start_character":49,"end_line":11,"end_character":55},"updated":"2025-04-16 18:26:59.000000000","message":"nit: container","commit_id":"26befb9f067c91d8301e980a902987ed0f9eea74"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"4e6846953ee12067c45923707261c9b2de64ed32","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        prometheus_old_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_old_volume_name }}/_data\""},{"line_number":9,"context_line":"        prometheus_new_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/_data\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check for the existence of Prometheus v2 Docker volume"},{"line_number":12,"context_line":"  stat:"},{"line_number":13,"context_line":"    path: \"{{ prometheus_old_data_path }}\""},{"line_number":14,"context_line":"  register: old_data"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4262d66e_a4dc662d","line":11,"range":{"start_line":11,"start_character":49,"end_line":11,"end_character":55},"in_reply_to":"8a42bac6_7e754b50","updated":"2025-04-17 08:13:50.000000000","message":"Acknowledged","commit_id":"26befb9f067c91d8301e980a902987ed0f9eea74"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2c4a249515491ad4a156bd8a2bdec37d23a698d3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: Set variables for volume names"},{"line_number":5,"context_line":"  set_fact:"},{"line_number":6,"context_line":"    prometheus_old_volume_name: \"prometheus_v2\""},{"line_number":7,"context_line":"    prometheus_new_volume_name: \"prometheus\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"52eb58a2_58c4a20d","line":4,"updated":"2025-04-22 06:38:04.000000000","message":"move that to defaults or just stick with known names instead of set_fact?","commit_id":"25aaf8d2e5709458dbe2b38630c5f797addc1ff4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0d1c5f3cd1a7034db46ebb2cfa9e969cff3d6d44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: Set variables for volume names"},{"line_number":5,"context_line":"  set_fact:"},{"line_number":6,"context_line":"    prometheus_old_volume_name: \"prometheus_v2\""},{"line_number":7,"context_line":"    prometheus_new_volume_name: \"prometheus\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"fa0735b7_b6fbb14b","line":4,"in_reply_to":"52eb58a2_58c4a20d","updated":"2025-04-23 17:20:19.000000000","message":"Done","commit_id":"25aaf8d2e5709458dbe2b38630c5f797addc1ff4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ac97cbf82d09301f5e615b89b3d7e7b94c276345","unresolved":true,"context_lines":[{"line_number":9,"context_line":"- name: Set variables for volume data paths"},{"line_number":10,"context_line":"  set_fact:"},{"line_number":11,"context_line":"    prometheus_old_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_old_volume_name }}/_data\""},{"line_number":12,"context_line":"    prometheus_new_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/_data\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Check for the existence of Prometheus v2 container volume"},{"line_number":15,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a546e76_fe0c29de","line":12,"updated":"2025-04-22 10:16:23.000000000","message":"good point above, actually then having these two in defaults (with prometheus_old/new_volume_name hardcoded) would sound like the best solution to me","commit_id":"25aaf8d2e5709458dbe2b38630c5f797addc1ff4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0d1c5f3cd1a7034db46ebb2cfa9e969cff3d6d44","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- name: Set variables for volume data paths"},{"line_number":10,"context_line":"  set_fact:"},{"line_number":11,"context_line":"    prometheus_old_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_old_volume_name }}/_data\""},{"line_number":12,"context_line":"    prometheus_new_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/_data\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Check for the existence of Prometheus v2 container volume"},{"line_number":15,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9ab61861_31d377a6","line":12,"in_reply_to":"133580aa_47fc9eef","updated":"2025-04-23 17:20:19.000000000","message":"Done","commit_id":"25aaf8d2e5709458dbe2b38630c5f797addc1ff4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"534913162100f61dd5aae29b290d15ded71960d1","unresolved":true,"context_lines":[{"line_number":9,"context_line":"- name: Set variables for volume data paths"},{"line_number":10,"context_line":"  set_fact:"},{"line_number":11,"context_line":"    prometheus_old_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_old_volume_name }}/_data\""},{"line_number":12,"context_line":"    prometheus_new_data_path: \"{{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/_data\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Check for the existence of Prometheus v2 container volume"},{"line_number":15,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"133580aa_47fc9eef","line":12,"in_reply_to":"7a546e76_fe0c29de","updated":"2025-04-22 11:50:38.000000000","message":"we could have them in vars/main.yml so they can\u0027t be overridden ;-)","commit_id":"25aaf8d2e5709458dbe2b38630c5f797addc1ff4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89a251110286521869ec623323ad7ff8ebeb7c06","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - name: Move _data from old to new volume"},{"line_number":30,"context_line":"      become: true"},{"line_number":31,"context_line":"      command: \"mv -f {{ container_engine_volumes_path }}/prometheus_v2/_data {{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/\""},{"line_number":32,"context_line":"      args:"},{"line_number":33,"context_line":"        removes: \"{{ container_engine_volumes_path }}/prometheus_v2/_data\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"c9d101f1_b2e637e1","line":31,"range":{"start_line":31,"start_character":117,"end_line":31,"end_character":143},"updated":"2025-04-23 12:05:55.000000000","message":"this is no longer defined?\n```suggestion\n      command: \"mv -f {{ container_engine_volumes_path }}/prometheus_v2/_data {{ container_engine_volumes_path }}/prometheus/\"\n```\n\nI\u0027m also not sure the `-f` has any effect when moving directories?","commit_id":"066efa599b4d111b101312e0472a4c79465cddd1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0d1c5f3cd1a7034db46ebb2cfa9e969cff3d6d44","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - name: Move _data from old to new volume"},{"line_number":30,"context_line":"      become: true"},{"line_number":31,"context_line":"      command: \"mv -f {{ container_engine_volumes_path }}/prometheus_v2/_data {{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/\""},{"line_number":32,"context_line":"      args:"},{"line_number":33,"context_line":"        removes: \"{{ container_engine_volumes_path }}/prometheus_v2/_data\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ed928fc4_036714bb","line":31,"range":{"start_line":31,"start_character":117,"end_line":31,"end_character":143},"in_reply_to":"c9d101f1_b2e637e1","updated":"2025-04-23 17:20:19.000000000","message":"Done","commit_id":"066efa599b4d111b101312e0472a4c79465cddd1"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"0d6aaeaacd61ca21a8623adcca5e86fcb9b9e2fb","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - name: Move _data from old to new volume"},{"line_number":30,"context_line":"      become: true"},{"line_number":31,"context_line":"      command: \"mv -f {{ container_engine_volumes_path }}/prometheus_v2/_data {{ container_engine_volumes_path }}/{{ prometheus_new_volume_name }}/\""},{"line_number":32,"context_line":"      args:"},{"line_number":33,"context_line":"        removes: \"{{ container_engine_volumes_path }}/prometheus_v2/_data\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ed88765c_20826b90","line":31,"range":{"start_line":31,"start_character":117,"end_line":31,"end_character":143},"in_reply_to":"ed928fc4_036714bb","updated":"2025-04-24 06:59:23.000000000","message":"`-f` is required on RHEL family systems when overwriting target - be it files or directories - `_data` exists even in empty volumes.","commit_id":"066efa599b4d111b101312e0472a4c79465cddd1"}],"releasenotes/notes/upgrade-prometheus-to-v3-bdf73866e7a93194.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3b64a575ef431f5c88ea0cc57f5f02858af0e5a4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates Prometheus version to v3.2.1. Also, switches back to"},{"line_number":5,"context_line":"    \u0027prometheus-server\u0027 generic image name by removing \u0027v2\u0027 part."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Prometheus will be upgraded from v2 to v3 - which introduces minor breaking"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8c0e8df2_bcabd29b","line":5,"updated":"2025-04-16 18:26:59.000000000","message":"I think the second sentence rather belongs to the upgrade section?\n\nDo we also need to warn people who may have overridden prometheus_server_default_volumes to use different volume names?","commit_id":"26befb9f067c91d8301e980a902987ed0f9eea74"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"97c1dcb72e0f1e31514932a7c90bbb4cbca74f57","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates Prometheus version to v3.2.1. Also, switches back to"},{"line_number":5,"context_line":"    \u0027prometheus-server\u0027 generic image name by removing \u0027v2\u0027 part."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Prometheus will be upgraded from v2 to v3 - which introduces minor breaking"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4279e288_af3cfa74","line":5,"in_reply_to":"5ca126e9_a9490c2f","updated":"2025-04-18 11:56:27.000000000","message":"Done","commit_id":"26befb9f067c91d8301e980a902987ed0f9eea74"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"4e6846953ee12067c45923707261c9b2de64ed32","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates Prometheus version to v3.2.1. Also, switches back to"},{"line_number":5,"context_line":"    \u0027prometheus-server\u0027 generic image name by removing \u0027v2\u0027 part."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Prometheus will be upgraded from v2 to v3 - which introduces minor breaking"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5ca126e9_a9490c2f","line":5,"in_reply_to":"8c0e8df2_bcabd29b","updated":"2025-04-17 08:13:50.000000000","message":"Fair point","commit_id":"26befb9f067c91d8301e980a902987ed0f9eea74"}]}