)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1e35a864b3f81fce2415d91223c105e199b38479","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4d2c0f5_cbc46a4d","updated":"2025-04-02 08:28:14.000000000","message":"Can u test with this   ? https://review.opendev.org/c/openstack/kolla-ansible/+/937108","commit_id":"eb5dd001a287dcd33496795ee7a2f7022b5129ff"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"112ca464ef53a7acd67734c3a753be6a7ffc3c89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61e85de0_ab98665f","in_reply_to":"1a16f19d_62b0d6b4","updated":"2025-04-03 17:33:33.000000000","message":"I meant if your problem is not solved by only those patches ..without this ..","commit_id":"eb5dd001a287dcd33496795ee7a2f7022b5129ff"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"7b2e1d8178c639ac7b2d5d6545c3f1fbbec33368","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd9c3727_e652b150","in_reply_to":"61e85de0_ab98665f","updated":"2025-04-04 13:19:13.000000000","message":"Just with your patch, keystone gets stuck in bootstrap because of https://bugs.launchpad.net/kolla-ansible/+bug/2104286\n\nI\u0027ll try testing conmbination of  https://review.opendev.org/c/openstack/kolla-ansible/+/945645 and https://review.opendev.org/c/openstack/kolla-ansible/+/937108","commit_id":"eb5dd001a287dcd33496795ee7a2f7022b5129ff"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"4cdcc75fc75be0210ea53c85077351846514c642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a16f19d_62b0d6b4","in_reply_to":"d4d2c0f5_cbc46a4d","updated":"2025-04-03 11:15:28.000000000","message":"I tested a deployment with https://review.opendev.org/c/openstack/kolla-ansible/+/937108 , https://review.opendev.org/c/openstack/kolla-ansible/+/946022 and https://review.opendev.org/c/openstack/kolla-ansible/+/945645 and all services were deployed with no problem.\nThe cloud also passed refstack tempest test","commit_id":"eb5dd001a287dcd33496795ee7a2f7022b5129ff"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"7b179f4029adcff28bf69cdbc925c69bb9e6d8a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e27dad2_3fc68fa0","in_reply_to":"fd9c3727_e652b150","updated":"2025-05-19 12:06:48.000000000","message":"I tested this combination, it did not work for me. Failed exclusively on compute nodes during `service-cert-copy : neutron | Copying over backend internal TLS certificate`\nError was:\n```\nmsg: \u0027An unhandled exception occurred while templating \u0027\u0027{{ lookup(\u0027\u0027first_found\u0027\u0027, certs) }}\u0027\u0027. Error was a \u003cclass \u0027\u0027ansible.errors.AnsibleLookupError\u0027\u0027\u003e, original message: No file was found when using first_found.\u0027\n```","commit_id":"eb5dd001a287dcd33496795ee7a2f7022b5129ff"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a746c97b34376b6d0db3348bdfcc7ba6b7083565","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"24ef42bb_91d8584b","updated":"2025-05-16 11:05:36.000000000","message":"I don\u0027t think this is really needed ...need to check deeply","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e43caaab872205a74b6605b92ce242465d93b6cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"83b02ad5_233033af","updated":"2025-07-17 09:27:33.000000000","message":"LGTM","commit_id":"e092d33245828b16c07fa4364a91e903dcbe1de0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9e497301f168e271ba6e782c854dbf1fdd16663a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"431f623b_a9184565","updated":"2025-07-16 20:00:06.000000000","message":"very interesting case","commit_id":"e092d33245828b16c07fa4364a91e903dcbe1de0"}],"ansible/roles/service-cert-copy/tasks/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e72ceb539fa08bb9e75f38bdda0a64a5578b7e17","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_copy_backend_tls_files | bool"},{"line_number":27,"context_line":"    - item.value.copy_tls_backend | default(false) | bool"},{"line_number":28,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"{{ project_name }} | Copying over backend internal TLS key\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"078a8b96_51552323","line":27,"updated":"2025-07-15 12:33:19.000000000","message":"So, for majority of services that need backend TLS certs - we have item.value.haproxy.tls_backend and for those that do not have this - let\u0027s introduce item.value.tls_backend boolean - and that fixes the problem with less changes in multiple roles - right?","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"4078b578601342d68c986aedab1703538edb3b84","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_copy_backend_tls_files | bool"},{"line_number":27,"context_line":"    - item.value.copy_tls_backend | default(false) | bool"},{"line_number":28,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"{{ project_name }} | Copying over backend internal TLS key\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b1ab44c0_87f1162c","line":27,"in_reply_to":"078a8b96_51552323","updated":"2025-07-15 14:25:25.000000000","message":"Sorry, I may not understood this well but how does that different to what I just did? The default being true instead of current false?","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"ba4481dddf64377f73f07dea2bf82027bd75ba68","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_copy_backend_tls_files | bool"},{"line_number":27,"context_line":"    - item.value.copy_tls_backend | default(false) | bool"},{"line_number":28,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"{{ project_name }} | Copying over backend internal TLS key\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c84944dd_e93a7ba4","line":27,"in_reply_to":"5ab7e820_8fc65afd","updated":"2025-07-16 11:14:19.000000000","message":"This approach is tested and now the patch is updated.\nI\u0027ll mark this as resolved. Add a new comment to latest patchset if you have any.","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"178390c89b02a065f008c1766ccee44de6238dab","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_copy_backend_tls_files | bool"},{"line_number":27,"context_line":"    - item.value.copy_tls_backend | default(false) | bool"},{"line_number":28,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"{{ project_name }} | Copying over backend internal TLS key\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d78e50ca_98ccd7d1","line":27,"in_reply_to":"94a77963_8b189b71","updated":"2025-07-15 15:07:16.000000000","message":"I\u0027ll test this out. Thank you.","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"5f2970c6c3e8518b44a2b047d28df127005ceb15","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_copy_backend_tls_files | bool"},{"line_number":27,"context_line":"    - item.value.copy_tls_backend | default(false) | bool"},{"line_number":28,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"{{ project_name }} | Copying over backend internal TLS key\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"be09acea_a4734a18","line":27,"in_reply_to":"aeadd866_401a4ae9","updated":"2025-07-15 14:57:41.000000000","message":"Shouldn\u0027t they bonded with OR instead then? Plus, haproxy.tls_backend is not actually available I think. It\u0027s haproxy.\u003cservice name\u003e.tls_backend.","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3345112cf04b96affc6f8dd7a2015ddc20e3e37","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_copy_backend_tls_files | bool"},{"line_number":27,"context_line":"    - item.value.copy_tls_backend | default(false) | bool"},{"line_number":28,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"{{ project_name }} | Copying over backend internal TLS key\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"aeadd866_401a4ae9","line":27,"in_reply_to":"b1ab44c0_87f1162c","updated":"2025-07-15 14:28:58.000000000","message":"```suggestion\n    - item.value.haproxy.tls_backend | default(false) | bool\n    - item.value.tls_backend | default(false) | bool\n```\n\nAfter something like that, you don\u0027t need to set tls_backend (or copy_tls_backend in your version) in a lot of role defaults - because haproxy.tls_backend is already there.","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aa1fad923fdcd6772f42ffe503cdb12b2e7173e0","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_copy_backend_tls_files | bool"},{"line_number":27,"context_line":"    - item.value.copy_tls_backend | default(false) | bool"},{"line_number":28,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"{{ project_name }} | Copying over backend internal TLS key\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"94a77963_8b189b71","line":27,"in_reply_to":"be09acea_a4734a18","updated":"2025-07-15 15:04:51.000000000","message":"That\u0027s still easy to pick out - just needs some work and testing ;-)","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"a37be3ab03091400b8ec4f643b665edbc656856c","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_copy_backend_tls_files | bool"},{"line_number":27,"context_line":"    - item.value.copy_tls_backend | default(false) | bool"},{"line_number":28,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"{{ project_name }} | Copying over backend internal TLS key\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5ab7e820_8fc65afd","line":27,"in_reply_to":"d78e50ca_98ccd7d1","updated":"2025-07-16 09:29:41.000000000","message":"On a second thought, can\u0027t we just use the group ``tls-backend`` for filtering the hosts that are not part of backend TLS?\nFor example: https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/inventory/multinode#L42","commit_id":"52797d88d20d3e9be6574a9b81bead5c57a8552c"}]}