)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a3491540936308fc60510cb170ba10bfcaaab9f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4464d06c_33e85f68","updated":"2025-04-22 08:33:49.000000000","message":"-1 for the ordering + duplication","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8798768ef327c71d9520cf04a813187cb554d64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"94c6346e_515dff74","updated":"2025-04-14 11:07:17.000000000","message":"There are lots of oslo.messaging errors in the ipv6 jobs, see e.g. https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_6dc/openstack/6dceeef22a2d4e3cbbef397cbe95d3d5/primary/logs/kolla/neutron/neutron-server.txt , seems sometimes there are so many that the maximum zuul log limit is triggered. the errors seem related to the recent rmq changes, this needs further investigation, but I agree it is unrelated to this fix.","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dbe5de96561d905ac454973aa960937497d7f38a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b368a3e1_9d5fc5de","updated":"2025-04-11 21:07:57.000000000","message":"okay it look it was intermittent issue not related ..so everything is ok now ..working","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f1e5f096f9936c2e2e76e72d981c77eb29301ee7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b59ff40a_f6ddbb1e","updated":"2025-04-11 18:14:08.000000000","message":"recheck because I am curious why IPv6 on debian is not working ..99 % different issue ..but let\u0027s see","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"513670936fb0ecb87017e270829e6b414b632306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2a2b8e13_98c50ad2","updated":"2025-05-14 00:53:31.000000000","message":"2025.1, 2024.2 merged, 2024.1 still not. But let\u0027s recheck upgrade from 2025.1 -\u003e master which should normally pass now (without block which i will remove in next patch). SLURP should fail ( as 2024.1 still don\u0027t have ansible-collection-kolla patches merged).","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eb5f8ac89376fb578235b40f14cb8314d36f481e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5555d1c5_43628a2a","updated":"2025-05-13 10:28:29.000000000","message":"Can we merge this as -1 for worfklow was because depends-on was DNM, now it\u0027s merged.","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3405cffc4abfcb013ec9aca9bacf3b0cb5ceab62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0bb3649c_87387806","updated":"2025-04-26 03:44:20.000000000","message":"Depends on DNM patch in a-c-k - rather flamingo material","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b1dd409a13b11f02c0b39cb2cbe3709e63aeff3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7bcc4490_3cae5494","updated":"2025-04-26 19:27:00.000000000","message":"Depends-On nits fixed ...ready to merge everything ..and important","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ac07cc2134ffb21b823be006c6393349fbae89ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5b73e0eb_277f8a02","updated":"2025-04-26 19:28:15.000000000","message":"Giving +2 as this is CI only ..but saying that it\u0027s needed and important patch.","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"62832fde225e46c72d5208405c7d4896ee102972","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"03178af2_e7bae0ab","updated":"2025-04-25 09:59:33.000000000","message":"any reviews ?","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b466bbe0dd4a51c7585e90fa4b0894e6ebfd4828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ef5e7e30_b431084d","updated":"2025-05-08 16:56:23.000000000","message":"let\u0027s merge this","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"df6a039468e225f0fa56f318eecce481a109f3b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"062a2b2b_2c93dc93","updated":"2025-04-26 13:45:11.000000000","message":"oh, I missed the dependency, thx for pointing that out","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ede8eabec48b89f0de51ad780cb1fe3c572d0541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f1373c79_7eb3fee5","updated":"2025-04-28 18:08:27.000000000","message":"recheck new patch","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1ab4b90ba3ae88ed87591ca415e3ce22a0a17e66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7bde8eb7_75870cb6","updated":"2025-04-26 13:42:30.000000000","message":"recheck prometheus-server issue fixed","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e8f660ebf0d19478fb686e048efd429db94b886c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"72b58386_b3c95751","updated":"2025-04-28 17:50:05.000000000","message":"recheck tox fix","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3048224a31b76816f6302c2b04951e9727f295b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b8696bdc_8c4d0f36","updated":"2025-04-28 17:42:55.000000000","message":"recheck tox fix","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3a1ceaaf2570e95ae5ccd9320126300cfba428d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e392c6d0_c46393c4","updated":"2025-04-28 17:47:55.000000000","message":"recheck tox fix","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1d99037bd26e008da605e004dda00e9887e2b880","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1df1d244_a4f542db","updated":"2025-04-28 07:22:14.000000000","message":"recheck with new depends-on patch","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b2a7a853d14c41a416f44db0842e6f7b5532d53c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"69bf839d_f554989d","in_reply_to":"0bb3649c_87387806","updated":"2025-04-26 19:27:44.000000000","message":"Done, fixed nits, now ready to merge and I think kind important.","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3c068e9a047fa1496705d6d2c7ef947a1dca0569","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"11f33bfe_c2cb7134","updated":"2025-05-14 09:44:51.000000000","message":"let\u0027s try without become...","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"52241051e0fc5b607e03f5589230a142cfab44ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"7825e2e4_283b5d86","updated":"2025-05-14 06:20:40.000000000","message":"the ovn and octavia jobs are still broken, need to wait for a new octaviaclient release in order to see that this patch really works, cf. https://review.opendev.org/c/openstack/releases/+/949627","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"94e4ef396878f57defb2f7d13c059c39e7706530","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":24,"id":"cb58cff9_47b4ce1a","in_reply_to":"73722f45_986c113c","updated":"2025-05-14 07:38:07.000000000","message":"Michal, we\u0027re not backporting that to 2025.1 (at least not immediately) - it was too late to merge it for 2025.1.\nI backported a-c-k changes so we can get rid of additional handling here.","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0b47d23ae816d2049fbe1ea05452c73a282e8646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"73722f45_986c113c","in_reply_to":"7825e2e4_283b5d86","updated":"2025-05-14 06:36:49.000000000","message":"Okay, I understand, the patch really does look like it fixes it. However, I’d like to point out that this patch changes the CI playbook in terms of the bootstrap and ansible_python_interpreter... And since it only fails during the tests written in Bash, that means the bootstrap went fine and all the playbooks worked. But still – okay, I get it... let’s wait, no problem.","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1aadae92450edcc558da27ccbfe8c8d1247be877","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":24,"id":"d51cbf65_a326b321","in_reply_to":"cb58cff9_47b4ce1a","updated":"2025-05-14 12:38:33.000000000","message":"Okay, no problem - I was asking for master.","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0d049c4215234d7b2a6775fa4f33143d6aa181b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"337e8bbe_e2c05c20","in_reply_to":"d51cbf65_a326b321","updated":"2025-05-14 14:38:50.000000000","message":"Acknowledged","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5013f85dab628b5512a8f8c0c316681155628475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"23f93bdc_c2fae305","updated":"2025-05-14 11:01:05.000000000","message":"@mnasiadka@gmail.com \n\nhttps://zuul.opendev.org/t/openstack/build/215eee8256d6430f9b5d151a96ab3f8e\n\nHere, this is it ...","commit_id":"828c8b1372732025fbf3463b88ab18f0a12432f2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"81999326d0dd3af022a10aa08bba3d64f5157cea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"34b9d2a7_6e33c444","updated":"2025-05-14 11:50:13.000000000","message":"But it\u0027s just a supposition.","commit_id":"828c8b1372732025fbf3463b88ab18f0a12432f2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4b94a91baac668c55f70ea1d34047e05760bd470","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"f7b9682e_4183ffb2","in_reply_to":"11dc69f9_18157585","updated":"2025-05-14 11:48:08.000000000","message":"@mnasiadka@gmail.com I think it\u0027s caused by ansible-collection-kolla [1]. Here in Zuul CI I just took venv directory for kolla-ansible and set as path for \"host\u0027s venv\". So ansible-collection-kolla maintain this path because bootstrap is running before upgrade.\n\nSo, what I think is happening : \n1. CI create venv with some user ( zuul ? )\n2. Deploy everything - works - user changed ( to kolla_user as it\u0027s visible below )\n3. bootstrap-servers - new version of kolla-ansible\n4. Changed permissions - zuul missing become: true\n\n[1] https://github.com/openstack/ansible-collection-kolla/blob/c08ed6c646e35fd529c98edaa97972c3a1a11faf/roles/docker_sdk/tasks/install.yml#L62-L71","commit_id":"828c8b1372732025fbf3463b88ab18f0a12432f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"688d69294bd870f13b5bda77ef42ae0a894b56b5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"4b99cab9_02cddd35","in_reply_to":"23f93bdc_c2fae305","updated":"2025-05-14 11:19:54.000000000","message":"Lol, I just realised we\u0027re upgrading kolla-ansible twice, we\u0027re also upgrading kolla-ansible in \"Upgrade Ansible task\"","commit_id":"828c8b1372732025fbf3463b88ab18f0a12432f2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"234568076822e9b894ecf7fd73fb636c0e3697d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3a037d61_6baa4c04","in_reply_to":"34b9d2a7_6e33c444","updated":"2025-05-14 12:37:15.000000000","message":"Yes, my assumption was correct — bootstrap-servers sets up the virtual environment as the root user because the use of the kolla user is not configured. So instead of setting become: true, I separated the Kolla Ansible virtual environment from the one used for the Docker/Podman SDK and its friends, which is actually the more correct approach.","commit_id":"828c8b1372732025fbf3463b88ab18f0a12432f2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"725db80440cbaae4debeb7bda1864dbca94973b9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"11dc69f9_18157585","in_reply_to":"3d97fbe6_1980b9cf","updated":"2025-05-14 11:30:15.000000000","message":"Yeah, but first upgrade task has when: is_slurp while second does not. So it\u0027s running twice only when slurp, isn\u0027t it ?","commit_id":"828c8b1372732025fbf3463b88ab18f0a12432f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"39c13e9d406890b0b40d19c3f802caa5cd8e612e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3d97fbe6_1980b9cf","in_reply_to":"4b99cab9_02cddd35","updated":"2025-05-14 11:20:57.000000000","message":"But yes, that\u0027s skipped - I have no clue why we have wrong permissions, but I doubt using become is the key to success","commit_id":"828c8b1372732025fbf3463b88ab18f0a12432f2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1aadae92450edcc558da27ccbfe8c8d1247be877","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"6e37c562_5164a595","in_reply_to":"f7b9682e_4183ffb2","updated":"2025-05-14 12:38:33.000000000","message":"Done","commit_id":"828c8b1372732025fbf3463b88ab18f0a12432f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3a3aca6d760011c7a0eb278c867d3e7abf3b766a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"ba36634e_26b99757","updated":"2025-05-14 14:39:26.000000000","message":"Octavia and OVN jobs are failing due to python-octaviaclient not supporting newest osc-lib","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e2509c6e3f931a132d09a490b9e95c09b4ee7dd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"6b5c91ba_b5a2a14c","in_reply_to":"ba36634e_26b99757","updated":"2025-05-14 14:40:07.000000000","message":"But wait a minute, i am going to check if it can be set dynamically ..I have an idea.","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"41ee07ff0329fcdf66469fd7a3a646b38d0a441c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"7002c4c7_21968343","updated":"2025-05-14 16:17:17.000000000","message":"Let\u0027s merge this, I will send another patch for venv auto creation","commit_id":"41267c041dbe5f1516ed854107fd1ad046cf111c"}],"tests/run.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8798768ef327c71d9520cf04a813187cb554d64","unresolved":true,"context_lines":[{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - scenario \u003d\u003d \"lets-encrypt\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Install Python3.12 and dependencies on RHEL derivatives"},{"line_number":56,"context_line":"      dnf:"},{"line_number":57,"context_line":"        name:"},{"line_number":58,"context_line":"          - python3.12"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bc4922a8_aff745e0","line":55,"updated":"2025-04-14 11:07:17.000000000","message":"why are all these tasks now needed on all hosts instead of only the primary?","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"07014cc7aa666ce144f4112d12051cd7e5753437","unresolved":true,"context_lines":[{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - scenario \u003d\u003d \"lets-encrypt\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Install Python3.12 and dependencies on RHEL derivatives"},{"line_number":56,"context_line":"      dnf:"},{"line_number":57,"context_line":"        name:"},{"line_number":58,"context_line":"          - python3.12"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"fec118d7_3102e42e","line":55,"in_reply_to":"bc4922a8_aff745e0","updated":"2025-04-17 10:34:52.000000000","message":"because there is ansible_python_interpreter set to virtualenv ...Ansible transfer tarball with a python code via ssh and then executed with ansible_python_interpreter ..without it ..CI and of course real deployment is mixing pythons ...that\u0027s the reason why Kolla Ansible Octavia-certificates took cryptography from host python and not venv ...","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a3491540936308fc60510cb170ba10bfcaaab9f7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - scenario \u003d\u003d \"lets-encrypt\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Install Python3.12 and dependencies on RHEL derivatives"},{"line_number":56,"context_line":"      dnf:"},{"line_number":57,"context_line":"        name:"},{"line_number":58,"context_line":"          - python3.12"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"4d25675a_f45a1445","line":55,"in_reply_to":"fec118d7_3102e42e","updated":"2025-04-22 08:33:49.000000000","message":"ah, ok","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8798768ef327c71d9520cf04a813187cb554d64","unresolved":true,"context_lines":[{"line_number":93,"context_line":"            - libdbus-1-dev"},{"line_number":94,"context_line":"            - libdbus-glib-1-dev"},{"line_number":95,"context_line":"            - libglib2.0-dev"},{"line_number":96,"context_line":"            - python3-dev"},{"line_number":97,"context_line":"            - python3-venv"},{"line_number":98,"context_line":"            - python3-pip"},{"line_number":99,"context_line":"            - pkg-config"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"d8493bb0_404340ea","line":96,"updated":"2025-04-14 11:07:17.000000000","message":"this is duplicated. please keep the lists sorted alphabetically so that this can be checked more easily","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"901254adc8d392949a2152a3eb3ee89c398da7ce","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            - libdbus-1-dev"},{"line_number":94,"context_line":"            - libdbus-glib-1-dev"},{"line_number":95,"context_line":"            - libglib2.0-dev"},{"line_number":96,"context_line":"            - python3-dev"},{"line_number":97,"context_line":"            - python3-venv"},{"line_number":98,"context_line":"            - python3-pip"},{"line_number":99,"context_line":"            - pkg-config"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"b835712e_d8394082","line":96,"in_reply_to":"d8493bb0_404340ea","updated":"2025-04-25 09:57:12.000000000","message":"Done","commit_id":"8f6155a4133d8d3a6d2be45978d0779a4ccd8ad3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"df6a039468e225f0fa56f318eecce481a109f3b7","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    #"},{"line_number":71,"context_line":"    # Can be removed after [1] will be merged to stable branches."},{"line_number":72,"context_line":"    #"},{"line_number":73,"context_line":"    # [1] https://review.opendev.org/c/openstack/ansible-collection-kolla/+/946983"},{"line_number":74,"context_line":"    #"},{"line_number":75,"context_line":"    - name: Install docker SDK system dependencies based on OS family"},{"line_number":76,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"4522034d_ac764a08","line":73,"updated":"2025-04-26 13:45:11.000000000","message":"you have added this as a dependency for this patch, so this comment seems no longer necessary?","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"250c82e5801a896fe25ff7068075e3e4a45373f6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    #"},{"line_number":71,"context_line":"    # Can be removed after [1] will be merged to stable branches."},{"line_number":72,"context_line":"    #"},{"line_number":73,"context_line":"    # [1] https://review.opendev.org/c/openstack/ansible-collection-kolla/+/946983"},{"line_number":74,"context_line":"    #"},{"line_number":75,"context_line":"    - name: Install docker SDK system dependencies based on OS family"},{"line_number":76,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"2dfdd81c_294b70d8","line":73,"in_reply_to":"4522034d_ac764a08","updated":"2025-04-26 19:37:40.000000000","message":"Actually, that\u0027s exactly why I added this comment.\nOnce the above-mentioned Depends-On patch is merged, everything will work smoothly — but only for the master bootstrap. In other cases, like when testing slurp, a different version of ansible-collection-kolla is bootstrapped, but still using the same CI playbook.\nSince the collection itself doesn\u0027t install dependencies (older ansible-collection-kolla), and the CI pipeline doesn\u0027t either, we currently need this extra step to make sure dependencies are properly installed.\n\nIn short:\nAs long as older versions of the collection don\u0027t contain the bootstrap/dependencies fix, we need to keep this workaround in the CI playbook to help the tests pass. Once the fix propagates to all relevant versions, we can safely remove it.\n\nThis is how test should work, test what user is actually doing ..user is doing bootstrap-servers, not checking CI git to see which packages he need to install to collections start work.","commit_id":"6c49373ec3e4ef4f7d8666a2f2a63ee6847de19a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"37c09cba80304cc8eb5b96391bf7a1ebd262c3a0","unresolved":true,"context_lines":[{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - scenario \u003d\u003d \"lets-encrypt\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Install Python3.12 and dependencies on RHEL derivatives"},{"line_number":56,"context_line":"      dnf:"},{"line_number":57,"context_line":"        name:"},{"line_number":58,"context_line":"          - python3.12"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"92bdc775_2358b763","line":55,"updated":"2025-05-14 07:39:17.000000000","message":"There are no slurp jobs in 2025.2, a-c-k patch merged in 2024.2 - so you can drop this","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8344818a7d403f568820fe8c342e35eaefa800a7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - scenario \u003d\u003d \"lets-encrypt\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Install Python3.12 and dependencies on RHEL derivatives"},{"line_number":56,"context_line":"      dnf:"},{"line_number":57,"context_line":"        name:"},{"line_number":58,"context_line":"          - python3.12"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"0754505b_051c1ead","line":55,"in_reply_to":"92bdc775_2358b763","updated":"2025-05-14 09:44:02.000000000","message":"yep, i\u0027ve already seen that\u0027s passing.","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"37c09cba80304cc8eb5b96391bf7a1ebd262c3a0","unresolved":true,"context_lines":[{"line_number":678,"context_line":"              - \"ansible-core{{ ansible_core_version_constraint }}\""},{"line_number":679,"context_line":"              - \"ara\u003c1.0.0\""},{"line_number":680,"context_line":"            virtualenv: \"{{ kolla_ansible_venv_path }}\""},{"line_number":681,"context_line":"          become: true"},{"line_number":682,"context_line":"          when: is_slurp"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        - name: Upgrade kolla-ansible"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"2a757457_2e58ce1b","line":681,"updated":"2025-05-14 07:39:17.000000000","message":"why?","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8344818a7d403f568820fe8c342e35eaefa800a7","unresolved":false,"context_lines":[{"line_number":678,"context_line":"              - \"ansible-core{{ ansible_core_version_constraint }}\""},{"line_number":679,"context_line":"              - \"ara\u003c1.0.0\""},{"line_number":680,"context_line":"            virtualenv: \"{{ kolla_ansible_venv_path }}\""},{"line_number":681,"context_line":"          become: true"},{"line_number":682,"context_line":"          when: is_slurp"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        - name: Upgrade kolla-ansible"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1a2a5933_50abe520","line":681,"in_reply_to":"2a757457_2e58ce1b","updated":"2025-05-14 09:44:02.000000000","message":"Because in time I was writing this, CI log reported permissions problems, so I\u0027ve added become.","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"37c09cba80304cc8eb5b96391bf7a1ebd262c3a0","unresolved":true,"context_lines":[{"line_number":687,"context_line":"            name:"},{"line_number":688,"context_line":"              - \"{{ kolla_ansible_src_dir }}\""},{"line_number":689,"context_line":"            virtualenv: \"{{ kolla_ansible_venv_path }}\""},{"line_number":690,"context_line":"          become: true"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        - name: Install Ansible collections"},{"line_number":693,"context_line":"          shell: |"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9d1f663a_abae7f74","line":690,"updated":"2025-05-14 07:39:17.000000000","message":"why?","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8344818a7d403f568820fe8c342e35eaefa800a7","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            name:"},{"line_number":688,"context_line":"              - \"{{ kolla_ansible_src_dir }}\""},{"line_number":689,"context_line":"            virtualenv: \"{{ kolla_ansible_venv_path }}\""},{"line_number":690,"context_line":"          become: true"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        - name: Install Ansible collections"},{"line_number":693,"context_line":"          shell: |"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"c83c9285_f57305f8","line":690,"in_reply_to":"9d1f663a_abae7f74","updated":"2025-05-14 09:44:02.000000000","message":"ditto","commit_id":"ff194fdbe0d0d2166101abd0077c3f561a4ed4c1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a16abb27cd88fd7644f0533dd6ae87d2a8d3651b","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      become: true"},{"line_number":74,"context_line":"      when: ansible_facts.os_family !\u003d \u0027RedHat\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Create Kolla runtime venv"},{"line_number":77,"context_line":"      command:"},{"line_number":78,"context_line":"        cmd: \"{{ \u0027python3.12\u0027 if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else \u0027python3\u0027 }} -m venv {{ kolla_runtime_venv_path }}\""},{"line_number":79,"context_line":"        creates: \"{{ kolla_runtime_venv_path }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"6cccfafc_cce3c0b3","line":76,"updated":"2025-05-14 14:20:35.000000000","message":"Won\u0027t ansible-collection-kolla create that venv for us?","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0d049c4215234d7b2a6775fa4f33143d6aa181b2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      become: true"},{"line_number":74,"context_line":"      when: ansible_facts.os_family !\u003d \u0027RedHat\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Create Kolla runtime venv"},{"line_number":77,"context_line":"      command:"},{"line_number":78,"context_line":"        cmd: \"{{ \u0027python3.12\u0027 if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else \u0027python3\u0027 }} -m venv {{ kolla_runtime_venv_path }}\""},{"line_number":79,"context_line":"        creates: \"{{ kolla_runtime_venv_path }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3effc6eb_0aec6119","line":76,"in_reply_to":"0afce6f2_178149c4","updated":"2025-05-14 14:38:50.000000000","message":"Acknowledged","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"87152e26e55eebaf53412e3210eace4f82a4bdde","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      become: true"},{"line_number":74,"context_line":"      when: ansible_facts.os_family !\u003d \u0027RedHat\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Create Kolla runtime venv"},{"line_number":77,"context_line":"      command:"},{"line_number":78,"context_line":"        cmd: \"{{ \u0027python3.12\u0027 if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else \u0027python3\u0027 }} -m venv {{ kolla_runtime_venv_path }}\""},{"line_number":79,"context_line":"        creates: \"{{ kolla_runtime_venv_path }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"b6663c32_daf59870","line":76,"in_reply_to":"6cccfafc_cce3c0b3","updated":"2025-05-14 14:28:36.000000000","message":"No, as ansible runs modules against ansible_python_interpreter remotely which must exist in time of execution of course.\n\nMaybe some extra task which will execute \"os_configured_default_python -m venv /path/to/venv\" ... but if am afraid it needs to be another playbook with different interpreter firstly ?","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"065f63faf57119151c6a771036898e4a225e3515","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      become: true"},{"line_number":74,"context_line":"      when: ansible_facts.os_family !\u003d \u0027RedHat\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Create Kolla runtime venv"},{"line_number":77,"context_line":"      command:"},{"line_number":78,"context_line":"        cmd: \"{{ \u0027python3.12\u0027 if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else \u0027python3\u0027 }} -m venv {{ kolla_runtime_venv_path }}\""},{"line_number":79,"context_line":"        creates: \"{{ kolla_runtime_venv_path }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"d8b5b1db_43d28d45","line":76,"in_reply_to":"b6663c32_daf59870","updated":"2025-05-14 14:31:02.000000000","message":"I\u0027m asking, because we usually use the pip module to create the venv, not bash 😊","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f61939b8b7b084e61a25dc73a77a7fdce3987a10","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      become: true"},{"line_number":74,"context_line":"      when: ansible_facts.os_family !\u003d \u0027RedHat\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Create Kolla runtime venv"},{"line_number":77,"context_line":"      command:"},{"line_number":78,"context_line":"        cmd: \"{{ \u0027python3.12\u0027 if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else \u0027python3\u0027 }} -m venv {{ kolla_runtime_venv_path }}\""},{"line_number":79,"context_line":"        creates: \"{{ kolla_runtime_venv_path }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"837beec5_12b19ab7","line":76,"in_reply_to":"b6663c32_daf59870","updated":"2025-05-14 14:30:31.000000000","message":"It was my idea also \n\nhttps://8237b1297d60ff0c2b20-93f59625c399aa95f9dea77d5f2a531f.ssl.cf1.rackcdn.com/openstack/5d755d744ab04263a83091775587ca76/primary/logs/ansible/bootstrap-servers \n\n^^ here you can see the log.","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"80406ec2af980f2942a5e8c9fe3e04da864dea60","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      become: true"},{"line_number":74,"context_line":"      when: ansible_facts.os_family !\u003d \u0027RedHat\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Create Kolla runtime venv"},{"line_number":77,"context_line":"      command:"},{"line_number":78,"context_line":"        cmd: \"{{ \u0027python3.12\u0027 if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else \u0027python3\u0027 }} -m venv {{ kolla_runtime_venv_path }}\""},{"line_number":79,"context_line":"        creates: \"{{ kolla_runtime_venv_path }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"2d667294_cc563f7a","line":76,"in_reply_to":"d8b5b1db_43d28d45","updated":"2025-05-14 14:33:51.000000000","message":"So basically adding virtualenv_command to the task in line 269 would be enough?\nAh no - because in this play we\u0027re doing that on other hosts.","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b192d49c1d0ceaa6ea166de9ed4c67066435ca1d","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      become: true"},{"line_number":74,"context_line":"      when: ansible_facts.os_family !\u003d \u0027RedHat\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Create Kolla runtime venv"},{"line_number":77,"context_line":"      command:"},{"line_number":78,"context_line":"        cmd: \"{{ \u0027python3.12\u0027 if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else \u0027python3\u0027 }} -m venv {{ kolla_runtime_venv_path }}\""},{"line_number":79,"context_line":"        creates: \"{{ kolla_runtime_venv_path }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"0afce6f2_178149c4","line":76,"in_reply_to":"d8b5b1db_43d28d45","updated":"2025-05-14 14:35:27.000000000","message":"yes, but do you see the mechanism used here ? \nAnsible can create venv via pip Ansible module ...but that module\u0027s python code needs to be interpreted with some interpreter ..which is normally system\u0027s python by default.\n\nIf you override interpreter to venv path and it don\u0027t exist ..you have problem \n\negg or chicken problem","commit_id":"de25432240f1d6fbb096a24ddcdb167ab72775f4"}]}
