)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c465dcd7b396e9272cfe1270d6630a77a4a0c6c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ff3797b_a0e96741","updated":"2025-05-07 08:19:29.000000000","message":"Are you sure this is necessary, given https://review.opendev.org/c/openstack/kolla-ansible/+/945721 was merged?","commit_id":"d92f91f7d47e5467ae33199457d909bd0836649b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"185cf0c4dfa3e860b980162e6fdf10cd3d73d58c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"388ca7bc_0c97c101","updated":"2025-05-07 16:03:58.000000000","message":"Please read the documentation on how a commit message should be written:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"d92f91f7d47e5467ae33199457d909bd0836649b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"c37adfff75136f9cf71621e70e17f0121bba7edb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ca850d83_b3c36bb1","updated":"2025-05-09 12:54:08.000000000","message":"imo this isn\u0027t the right way to fix this, as someone else may add another config option to the end of the block in the future and unknowingly reintroduce the bug.\n\nJinja supports whitespace (and newline) control, perhaps this can be used to fix this issue? https://jinja.palletsprojects.com/en/stable/templates/#whitespace-control","commit_id":"d92f91f7d47e5467ae33199457d909bd0836649b"}],"ansible/roles/octavia/templates/octavia.conf.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"05844e1c8e4e0d3002b72c0387debe305c5b68f2","unresolved":true,"context_lines":[{"line_number":170,"context_line":"jobboard_redis_sentinel \u003d kolla"},{"line_number":171,"context_line":"jobboard_redis_sentinel_ssl_options \u003d ssl:False"},{"line_number":172,"context_line":"persistence_connection \u003d mysql+pymysql://{{ octavia_persistence_database_user }}:{{ octavia_persistence_database_password }}@{{ octavia_persistence_database_address }}/{{ octavia_persistence_database_name }}"},{"line_number":173,"context_line":"jobboard_backend_hosts \u003d {% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":174,"context_line":"{% endif %}"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"[oslo_concurrency]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0d66870c_dcff0686","line":173,"updated":"2025-05-07 16:07:35.000000000","message":"Why did you move the line from 165 to 173?\nIn this case, it is hard to see any changes.","commit_id":"d92f91f7d47e5467ae33199457d909bd0836649b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"0eaa249f112b42c711c76af81abc05d51ca67d6f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"jobboard_redis_sentinel \u003d kolla"},{"line_number":171,"context_line":"jobboard_redis_sentinel_ssl_options \u003d ssl:False"},{"line_number":172,"context_line":"persistence_connection \u003d mysql+pymysql://{{ octavia_persistence_database_user }}:{{ octavia_persistence_database_password }}@{{ octavia_persistence_database_address }}/{{ octavia_persistence_database_name }}"},{"line_number":173,"context_line":"jobboard_backend_hosts \u003d {% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":174,"context_line":"{% endif %}"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"[oslo_concurrency]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1906ac47_13d8218c","line":173,"in_reply_to":"0d66870c_dcff0686","updated":"2025-05-09 12:58:35.000000000","message":"It says in the commit message, this is the workaround to the bug.\n\u003e As a workaround, I moved the jobboard_backend_hosts line to the end of the block for now.","commit_id":"d92f91f7d47e5467ae33199457d909bd0836649b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"19805c230dde4bc44ddb3a8054d0a9b69822ff49","unresolved":false,"context_lines":[{"line_number":170,"context_line":"jobboard_redis_sentinel \u003d kolla"},{"line_number":171,"context_line":"jobboard_redis_sentinel_ssl_options \u003d ssl:False"},{"line_number":172,"context_line":"persistence_connection \u003d mysql+pymysql://{{ octavia_persistence_database_user }}:{{ octavia_persistence_database_password }}@{{ octavia_persistence_database_address }}/{{ octavia_persistence_database_name }}"},{"line_number":173,"context_line":"jobboard_backend_hosts \u003d {% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":174,"context_line":"{% endif %}"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"[oslo_concurrency]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a20bd1c1_c9868318","line":173,"in_reply_to":"1906ac47_13d8218c","updated":"2025-05-09 18:44:39.000000000","message":"I see, but still don\u0027t understand how it helps.","commit_id":"d92f91f7d47e5467ae33199457d909bd0836649b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c46227a46f483fe7ee459485dfb23a68c58f3149","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#jinja2: trim_blocks:False"},{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"debug \u003d {{ octavia_logging_debug }}"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"d304ea45_99e36cde","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":26},"updated":"2025-05-13 15:38:13.000000000","message":"I\u0027m confused why this didn\u0027t work","commit_id":"671b2d330b5c42ab3752551d8f3dafa72a988846"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c46227a46f483fe7ee459485dfb23a68c58f3149","unresolved":true,"context_lines":[{"line_number":162,"context_line":"{% if enable_octavia_jobboard | bool %}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"[task_flow]"},{"line_number":165,"context_line":"jobboard_backend_hosts \u003d {% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"jobboard_backend_password \u003d {{ redis_master_password }}"},{"line_number":168,"context_line":"jobboard_backend_port \u003d {{ redis_sentinel_port }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"edaacdc5_e93fcb04","line":165,"range":{"start_line":165,"start_character":157,"end_line":165,"end_character":169},"updated":"2025-05-13 15:38:13.000000000","message":"try\n{% endfor +%}\ninstead of a newline","commit_id":"671b2d330b5c42ab3752551d8f3dafa72a988846"}]}