)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"36058b7be4fcc373d3dbd5715004938aaae03e4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fce68f2_e9e0c7a2","updated":"2025-05-28 09:32:16.000000000","message":"I can see why this is useful in a single-node deployment, like the AIOs. But we still want to drain on a multinode environment, which all prod systems are, even if just one node is targetted.\n\ntbh I\u0027d argue that even in the AIO case, it doesn\u0027t hurt to call the drain.","commit_id":"a6bac5c3e642e9d6816d90b0273d32ee892e10d9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b83bd6be6ed1a88ec541a664ab72bf4de165caf9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a925e39d_87babd5d","in_reply_to":"0fa17741_e776e349","updated":"2025-05-28 09:59:15.000000000","message":"@mattc@stackhpc.com Don\u0027t be afraid, I have master testing deployed ... will try everything :) This i will test in few minutes.\n\nBtw, did you realize that we are doing maintenance which is draining queues ..but we are not waiting for it ? 😊","commit_id":"a6bac5c3e642e9d6816d90b0273d32ee892e10d9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e0ff2e2e20c080353ca8fe60cc6cc5df8dee15ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0838c0d_660a9db6","in_reply_to":"0fce68f2_e9e0c7a2","updated":"2025-05-28 09:34:43.000000000","message":"Why do you think it\u0027s dynamic ? :) \n```\n      action: \"{{ \u0027drain\u0027 if (play_hosts | length \u003e 1) else \u0027stop\u0027 }}\"\n```\n\nDid you see the stop ?","commit_id":"a6bac5c3e642e9d6816d90b0273d32ee892e10d9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b5d5989a47085732e420ce2474b965a52b0e198b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"818c167a_96e47630","in_reply_to":"79535835_1d7e2c99","updated":"2025-05-28 11:42:05.000000000","message":"@mattc@stackhpc.com yep, I am working on it 😊","commit_id":"a6bac5c3e642e9d6816d90b0273d32ee892e10d9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d87f3d6cfc45e5f33f36e60416ce9e4cd1ecb201","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f7301a2_60679448","in_reply_to":"818c167a_96e47630","updated":"2025-05-28 16:29:19.000000000","message":"Done","commit_id":"a6bac5c3e642e9d6816d90b0273d32ee892e10d9"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2d326f8d839c61d3df440648df644011e5ce96ee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79535835_1d7e2c99","in_reply_to":"a925e39d_87babd5d","updated":"2025-05-28 10:45:48.000000000","message":"Huh that\u0027s fun, I would\u0027ve expected the module to block until it had drained. Guess we need a wait too :P","commit_id":"a6bac5c3e642e9d6816d90b0273d32ee892e10d9"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"c409a5d1ed7deb7404aa01113befbc78c0be9ed8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fa17741_e776e349","in_reply_to":"f0838c0d_660a9db6","updated":"2025-05-28 09:45:16.000000000","message":"`play_hosts` is the deprecated version of `ansible_play_batch`, so it\u0027s just the hosts in the current batch though, so I think if you ran `kolla-ansible deploy -l controllers[0]`, this would skip the drain even though RabbitMQ runs on other controllers.\n\nIt could be based on the length of `groups[\u0027rabbitmq\u0027]` instead?","commit_id":"a6bac5c3e642e9d6816d90b0273d32ee892e10d9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b6c9ad8e858fbd73ba738f03473169b8e6cbb712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f42f744_d080f01d","in_reply_to":"f0838c0d_660a9db6","updated":"2025-05-28 09:35:36.000000000","message":"and this is first patch :) ...maybe i switch to WIP","commit_id":"a6bac5c3e642e9d6816d90b0273d32ee892e10d9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9855da7a612d703906f38d568b476b49a1a7d880","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1de45af9_7945a64e","updated":"2025-05-28 18:09:42.000000000","message":"Thank you @mnasiadka@gmail.com and @frickler@offenerstapel.de","commit_id":"a8b630039f90b240bba2a75b01f280e462b3c571"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c1d1d7cca07369764093462b01284104de5c461c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e9959fa0_ee162468","updated":"2025-05-28 18:02:22.000000000","message":"single approving to unblock gate","commit_id":"a8b630039f90b240bba2a75b01f280e462b3c571"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7f4d4254a9bf83b4b3020e7263ff7e0c1e8f7c2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"306201a2_69b29aec","updated":"2025-05-28 22:20:26.000000000","message":"recheck docker package released","commit_id":"172d701e0a24d2026e1ad2d54777b14814dc983c"}],"ansible/roles/rabbitmq/tasks/restart_services.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d93e10012191d78c80c3ceed6d14151669792c2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  when:"},{"line_number":19,"context_line":"    - container_info.containers | length \u003e 0"},{"line_number":20,"context_line":"    - \"\u0027rabbitmq\u0027 in groups\""},{"line_number":21,"context_line":"    - groups[\u0027rabbitmq\u0027] | length \u003e 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Stop the RabbitMQ application if not in cluster"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f1779bda_057198c2","line":20,"updated":"2025-05-28 13:34:06.000000000","message":"I think more common throughout the codebase is inventory_hostname in groups[\u0027rabbitmq\u0027] - but given that we are running the role only on rabbitmq hosts - do we need that?","commit_id":"b2d117e8de6da5b04d8454713f58cba5358d4bef"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8be23591e2001eea766171a9e67e5b19b887431c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  when:"},{"line_number":19,"context_line":"    - container_info.containers | length \u003e 0"},{"line_number":20,"context_line":"    - \"\u0027rabbitmq\u0027 in groups\""},{"line_number":21,"context_line":"    - groups[\u0027rabbitmq\u0027] | length \u003e 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Stop the RabbitMQ application if not in cluster"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4a167928_66efce8e","line":20,"in_reply_to":"13d3eff5_48aa438d","updated":"2025-05-28 13:52:13.000000000","message":"Yeah, surely we don\u0027t need it here, and it has no chance of failing, at least not with a standard inventory.","commit_id":"b2d117e8de6da5b04d8454713f58cba5358d4bef"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f3164d11efb17abc07731afd7847fc208a6d62df","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  when:"},{"line_number":19,"context_line":"    - container_info.containers | length \u003e 0"},{"line_number":20,"context_line":"    - \"\u0027rabbitmq\u0027 in groups\""},{"line_number":21,"context_line":"    - groups[\u0027rabbitmq\u0027] | length \u003e 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Stop the RabbitMQ application if not in cluster"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"af928c2a_61266869","line":20,"in_reply_to":"4a167928_66efce8e","updated":"2025-05-28 13:53:27.000000000","message":"ack","commit_id":"b2d117e8de6da5b04d8454713f58cba5358d4bef"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d87f3d6cfc45e5f33f36e60416ce9e4cd1ecb201","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  when:"},{"line_number":19,"context_line":"    - container_info.containers | length \u003e 0"},{"line_number":20,"context_line":"    - \"\u0027rabbitmq\u0027 in groups\""},{"line_number":21,"context_line":"    - groups[\u0027rabbitmq\u0027] | length \u003e 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Stop the RabbitMQ application if not in cluster"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"91885ed8_a180156a","line":20,"in_reply_to":"af928c2a_61266869","updated":"2025-05-28 16:29:19.000000000","message":"Done","commit_id":"b2d117e8de6da5b04d8454713f58cba5358d4bef"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"72a20b8cd4e8f0edd86ec798441826cc83245255","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  when:"},{"line_number":19,"context_line":"    - container_info.containers | length \u003e 0"},{"line_number":20,"context_line":"    - \"\u0027rabbitmq\u0027 in groups\""},{"line_number":21,"context_line":"    - groups[\u0027rabbitmq\u0027] | length \u003e 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Stop the RabbitMQ application if not in cluster"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"13d3eff5_48aa438d","line":20,"in_reply_to":"f1779bda_057198c2","updated":"2025-05-28 13:40:08.000000000","message":"We don\u0027t really need that condition, but in the next line I\u0027m directly checking the length of it, so I figured I\u0027d just throw it in there... I don\u0027t know ..should I remove ?","commit_id":"b2d117e8de6da5b04d8454713f58cba5358d4bef"}]}