)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dbd7a7b5cda49a6d30b871469392cf5ce9a7946a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2cf1236_45bb7bef","updated":"2026-03-25 06:47:35.000000000","message":"Merge conflict, please rebase","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"eced4f283612b289ae23be5e3d3bf5c73119d98e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b7ca6c96_7727a64c","updated":"2025-06-10 14:36:14.000000000","message":"agree with Jens about an inventory, otherwise LGTM","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6259b2e0871778e5312ef997869589fa174a394a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"312e7728_eac62bcb","updated":"2025-06-04 14:59:00.000000000","message":"ok, let\u0027s wait and see what other reviewers think","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ee0a6e6131d973a8d3be71ba4ebf99616ac870b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8a6a980b_7b684c4e","updated":"2025-06-03 15:51:53.000000000","message":"thanks for your patch, seems a lot of this was missed when migrating the client to python. some comments inline","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":37313,"name":"Alma MAILLET-CONTOZ","display_name":"Alma MAILLET-CONTOZ","email":"alma.maillet-contoz@infomaniak.com","username":"nicolasmc","status":"Intern SRE at Infomaniak"},"change_message_id":"a7b049265830d0b95acf384d3fccfa00c18795db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"babb58c7_8c25538a","updated":"2026-04-09 19:07:29.000000000","message":"Seems ok for me!","commit_id":"3c0c51eb01dd17cb7497d2e430c3d9ac95ff9ff0"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"42235cc738a456d66b096102de3770ddec91d797","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"889c5e6e_82c0f331","updated":"2026-03-30 11:31:11.000000000","message":"https://review.opendev.org/c/openstack/kolla-ansible/+/982089\n\ncheck here there are even more fixes","commit_id":"3c0c51eb01dd17cb7497d2e430c3d9ac95ff9ff0"}],"doc/source/user/quickstart-development.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ee0a6e6131d973a8d3be71ba4ebf99616ac870b5","unresolved":true,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  This way images built for aarch64 architecture will be used."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"* Container engine"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  Kolla Ansible supports both Docker and Podman container engines. The default"},{"line_number":203,"context_line":"  is Docker, but if you want to use Podman, you need to set the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"42a9b275_48350006","line":200,"updated":"2025-06-03 15:51:53.000000000","message":"arguably this is the most important choice to make, I would suggest to move this to the beginning of this list, in front of \"image options\"","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8c745f4907ebc4a7e3eeaeb0cebe9b3c24004dd3","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  This way images built for aarch64 architecture will be used."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"* Container engine"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  Kolla Ansible supports both Docker and Podman container engines. The default"},{"line_number":203,"context_line":"  is Docker, but if you want to use Podman, you need to set the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8bfa8d79_82ac398b","line":200,"in_reply_to":"32b1f811_bce8fd25","updated":"2026-03-30 10:45:02.000000000","message":"Done","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"5351fedcd872ed86dced583979e3647a58769caf","unresolved":true,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  This way images built for aarch64 architecture will be used."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"* Container engine"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  Kolla Ansible supports both Docker and Podman container engines. The default"},{"line_number":203,"context_line":"  is Docker, but if you want to use Podman, you need to set the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"32b1f811_bce8fd25","line":200,"in_reply_to":"42a9b275_48350006","updated":"2025-06-04 08:38:45.000000000","message":"Makes sense.","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ee0a6e6131d973a8d3be71ba4ebf99616ac870b5","unresolved":true,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  .. code-block:: console"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"     kolla-ansible bootstrap-servers"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"#. Do pre-deployment checks for hosts:"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"cca11a8e_e4e82fd0","line":296,"updated":"2025-06-03 15:51:53.000000000","message":"I would prefer to stay explicit with the choice of inventory here and below, this makes it more obvious that this is a real choice to make\n```suggestion\n     kolla-ansible bootstrap-servers -i /etc/kolla/all-in-one\n```","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8c745f4907ebc4a7e3eeaeb0cebe9b3c24004dd3","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  .. code-block:: console"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"     kolla-ansible bootstrap-servers"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"#. Do pre-deployment checks for hosts:"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"eacf21ad_4964ebba","line":296,"in_reply_to":"0d8a4d45_1b3b1c03","updated":"2026-03-30 10:45:02.000000000","message":"ok, updated to use the current default","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"5351fedcd872ed86dced583979e3647a58769caf","unresolved":true,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  .. code-block:: console"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"     kolla-ansible bootstrap-servers"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"#. Do pre-deployment checks for hosts:"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"0d8a4d45_1b3b1c03","line":296,"in_reply_to":"cca11a8e_e4e82fd0","updated":"2025-06-04 08:38:45.000000000","message":"This documentation is for development and most of the developments are done with all-in-one deployments. We mention that we assume you choose to deploy all-in-one and there is the possibility of specifying a custom inventory with -i, I would always prefer typing less here.","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9c0db556af49626261fa468c95bb5b9d4d082662","unresolved":true,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"   .. code-block:: console"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"      cp kolla-ansible/etc/kolla/* /etc/kolla"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"#. Copy the inventory files to the ``/etc/kolla/ansible/inventory`` directory."},{"line_number":123,"context_line":"   ``kolla-ansible`` holds the inventory files (``all-in-one`` and ``multinode``)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"07731e33_c5122315","line":120,"updated":"2026-03-30 10:51:02.000000000","message":"Should we add these in setup.cfg?","commit_id":"3c0c51eb01dd17cb7497d2e430c3d9ac95ff9ff0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b1ef2eccda66e0e3f24247647cfad9b0a4dae0c","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"   .. code-block:: console"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"      cp kolla-ansible/etc/kolla/* /etc/kolla"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"#. Copy the inventory files to the ``/etc/kolla/ansible/inventory`` directory."},{"line_number":123,"context_line":"   ``kolla-ansible`` holds the inventory files (``all-in-one`` and ``multinode``)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fac3fc36_6f4d6d56","line":120,"in_reply_to":"07731e33_c5122315","updated":"2026-03-30 11:09:12.000000000","message":"I\u0027d rather not, these are just examples after all, don\u0027t want them overwriting your real config by chance. and if you name them as examples, you\u0027d still need to rename them here, so nothing to gain in that case, either","commit_id":"3c0c51eb01dd17cb7497d2e430c3d9ac95ff9ff0"}],"kolla_ansible/ansible.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ee0a6e6131d973a8d3be71ba4ebf99616ac870b5","unresolved":true,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    default_inventory \u003d os.path.join("},{"line_number":150,"context_line":"        os.path.abspath(parsed_args.kolla_config_path),"},{"line_number":151,"context_line":"        \"inventory\", \"all-in-one\")"},{"line_number":152,"context_line":"    return [default_inventory]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ebbf6bbe_9e94e752","line":151,"updated":"2025-06-03 15:51:53.000000000","message":"I don\u0027t think it is good or necessary to change the default here","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8c745f4907ebc4a7e3eeaeb0cebe9b3c24004dd3","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    default_inventory \u003d os.path.join("},{"line_number":150,"context_line":"        os.path.abspath(parsed_args.kolla_config_path),"},{"line_number":151,"context_line":"        \"inventory\", \"all-in-one\")"},{"line_number":152,"context_line":"    return [default_inventory]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"01f388d3_349b95e6","line":151,"in_reply_to":"8c1fe34b_7f0fff82","updated":"2026-03-30 10:45:02.000000000","message":"updated to keep the current default","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"5351fedcd872ed86dced583979e3647a58769caf","unresolved":true,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    default_inventory \u003d os.path.join("},{"line_number":150,"context_line":"        os.path.abspath(parsed_args.kolla_config_path),"},{"line_number":151,"context_line":"        \"inventory\", \"all-in-one\")"},{"line_number":152,"context_line":"    return [default_inventory]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8c1fe34b_7f0fff82","line":151,"in_reply_to":"ebbf6bbe_9e94e752","updated":"2025-06-04 08:38:45.000000000","message":"It looks for /etc/kolla/ansible/inventory/all-in-one by default and we don\u0027t mention anything to copy the inventory to this path. I added this to the doc but to the /etc/kolla/inventory path. I also wonder whether most of the operators choose /etc/kolla/inventory or /etc/kolla/ansible/inventory for storing their inventories.","commit_id":"963db214d7a792d34e447fbf9ac605863ee31b36"}]}