)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dfa340e07e07c3208aec46dc90e9113ae1fd5ee7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Remove ironic-inspector deployment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic Inspector has been retired and it\u0027s functionality has been"},{"line_number":10,"context_line":"moved to Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If178c23249370c7c69744843737e61a6309d6a19"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fe227895_a385f2d9","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":42},"updated":"2025-06-05 15:29:17.000000000","message":"Nit: its","commit_id":"ab7169c69c15726c8e30bcd8187b380cbedccd1f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"22521c6e35280ff9feb97d4a6ec34b5b454d84fb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Remove ironic-inspector deployment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic Inspector has been retired and it\u0027s functionality has been"},{"line_number":10,"context_line":"moved to Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If178c23249370c7c69744843737e61a6309d6a19"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f14b912e_36bc41a1","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":42},"in_reply_to":"fe227895_a385f2d9","updated":"2025-08-06 13:44:00.000000000","message":"Done","commit_id":"ab7169c69c15726c8e30bcd8187b380cbedccd1f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d8fd4f828a2a7ea959c164ba3d03ade7f07bc835","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Ironic Inspector has been retired and its functionality has been"},{"line_number":10,"context_line":"moved to Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Using the opportunity increase CI coverage to inlude inspection"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If178c23249370c7c69744843737e61a6309d6a19"},{"line_number":15,"context_line":"Signed-off-by: Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"d5468a2d_45cb84e6","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":63},"updated":"2025-08-29 07:33:32.000000000","message":"Using the opportunity to increase CI coverage to include inspection.","commit_id":"03fc88886490bf442700a114423720d0c3771904"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"446b70d0ad5ef077b8260da47f79d47a2589d83a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Ironic Inspector has been retired and its functionality has been"},{"line_number":10,"context_line":"moved to Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Using the opportunity increase CI coverage to inlude inspection"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If178c23249370c7c69744843737e61a6309d6a19"},{"line_number":15,"context_line":"Signed-off-by: Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"4ede300d_75dfda12","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":63},"in_reply_to":"d5468a2d_45cb84e6","updated":"2025-08-29 07:40:27.000000000","message":"Done","commit_id":"03fc88886490bf442700a114423720d0c3771904"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dd445f5dac28300b67acd93f9d7ea10936ff93c0","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic Inspector has been retired and its functionality has been"},{"line_number":10,"context_line":"moved to Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Using the opportunity - increasing CI coverage to include"},{"line_number":13,"context_line":"inspection."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"686702dc_090e1fd7","line":11,"updated":"2025-09-02 18:02:56.000000000","message":"lets add\nNeeded-for: https://review.opendev.org/c/openstack/kayobe/+/958885\nto track if this is work","commit_id":"6e4e4e8d406cc9bfdfd067467ee45fbc70347016"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c2780489777b86d454085013fc61984453325717","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic Inspector has been retired and its functionality has been"},{"line_number":10,"context_line":"moved to Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Using the opportunity - increasing CI coverage to include"},{"line_number":13,"context_line":"inspection."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"5c6f08b0_b45c839f","line":11,"in_reply_to":"686702dc_090e1fd7","updated":"2025-09-03 08:33:45.000000000","message":"Acknowledged","commit_id":"6e4e4e8d406cc9bfdfd067467ee45fbc70347016"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3df8dece58ea9782c919f80f2b7ea352e2f3a596","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"ad22d593_18311b3e","updated":"2025-08-28 21:29:53.000000000","message":"Needs upgrade handling (remove inspector on upgrade)","commit_id":"b3d8da59f7ed623c043f0d49c3a480f199e36ffd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e1becc751a0816eb2bd08530aab950c9087031b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"744a1db1_443e620c","in_reply_to":"ad22d593_18311b3e","updated":"2025-08-29 05:49:54.000000000","message":"Done","commit_id":"b3d8da59f7ed623c043f0d49c3a480f199e36ffd"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"5e4ea0a1d5fafd69cd52198a24e5645bcba064f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"59b966ba_ca1b6247","updated":"2025-08-29 06:45:02.000000000","message":"I\u0027ve reviewed the proposed changes for the Ironic Inspector removal, and the approach looks solid to me.\n\nAs an aside, I\u0027m closely following your contributions like this one. It\u0027s a great way for me to learn the best practices and patterns for Kolla development.","commit_id":"03fc88886490bf442700a114423720d0c3771904"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1a31493a7eaf1bb0919dffd1529a05e4d9146856","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"4734ecf8_49b9bc42","updated":"2025-08-29 09:31:54.000000000","message":"do we need new container? https://docs.openstack.org/ironic/latest/admin/inspection/pxe_filter.html\n\nmaybe we should link that in release notes - https://docs.openstack.org/ironic/latest/admin/inspection/migration.html#migration-process","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2c50b41f774b4e86cce74597cff572875a9f2542","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"4285351b_25d90904","in_reply_to":"0c0f5c96_ba5d9513","updated":"2025-08-29 12:25:33.000000000","message":"There is https://review.opendev.org/c/openstack/kolla-ansible/+/939231 - maybe we just rebase it on top of this and make it work?","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"11a95853dbb6e5225c49b1e47ab90d260283e3c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"b4b3a0c6_f1d47911","in_reply_to":"4285351b_25d90904","updated":"2025-08-29 12:54:33.000000000","message":"makes sene","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c9a00cc5e9a00bdbddd3e6250b4d48b64c685dc9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"559e06fc_e46bbbd0","in_reply_to":"4734ecf8_49b9bc42","updated":"2025-08-29 11:19:08.000000000","message":"new container - a new feature, upgrade procedure etc. IMHO no.","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"cba37e3f5d7c9d73e358960aeeb348ff83b7a32d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"d18f65a1_6aa95b22","in_reply_to":"4734ecf8_49b9bc42","updated":"2025-08-29 11:57:37.000000000","message":"or we can run the pxe-filter service in the ironic-dnsmasq?","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8167d3a3ba4c6eb49dfe59e97e2b80af72c1aa23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"1e322b5d_8557fd2f","in_reply_to":"b4b3a0c6_f1d47911","updated":"2025-09-01 07:14:17.000000000","message":"Will be resolved on a follow up (change stacked on top, probably needs some more love)","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4df2ba25413e4fbc2673a96ffae25652829ba4d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"0c0f5c96_ba5d9513","in_reply_to":"d18f65a1_6aa95b22","updated":"2025-08-29 12:11:26.000000000","message":"I think we can, and we do","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b9ad196b139e4782cae3a42c7d19259c87a01d71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"4ce6f9d0_58f22a37","updated":"2025-08-29 14:29:09.000000000","message":"Just flagging this is going to break Kayobe.","commit_id":"f375d487b33e347a1e4eee8903dbe0a94adfd9d2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5b79f5e10accc89a1d207ee34175a2ba3361d272","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"7554ab6f_9d8a31ba","updated":"2025-08-29 19:18:25.000000000","message":"looks like comments are still unresolved?","commit_id":"f375d487b33e347a1e4eee8903dbe0a94adfd9d2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c2780489777b86d454085013fc61984453325717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"bd555f84_6eecfce7","in_reply_to":"7554ab6f_9d8a31ba","updated":"2025-09-03 08:33:45.000000000","message":"Done","commit_id":"f375d487b33e347a1e4eee8903dbe0a94adfd9d2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9f1882b8a41549b6c8d770ccbdba546ae385241e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":53,"id":"c5141884_da240edb","updated":"2025-09-04 12:50:05.000000000","message":"https://review.opendev.org/c/openstack/kayobe/+/958885 is failed with this latest patchset","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b9ac4d4695229ffbc00a64121b51cd583c0b3026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"a1c02448_5a75b9f8","updated":"2025-09-04 13:35:06.000000000","message":"just some minor comments that could also be handled in a followup.\n\nnot approving at once in order to allow kayobe to adapt","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2087275988fd1f582fc16ab0ef23ed3f1eb54e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"e7b342d3_273a22f8","in_reply_to":"c5141884_da240edb","updated":"2025-09-09 11:40:40.000000000","message":"Done","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0233499832fc2c19f1f57498305a9f1574f25bf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"3795c1e4_5eac4d9f","updated":"2025-09-09 11:40:35.000000000","message":"Kayobe fix is depending on this merged, but doesn\u0027t share a queue","commit_id":"cbe6fe7cef02b92aecd12e4e13f312055f49a424"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"debdeb4ef4972a208124413b080cb3802b52a596","unresolved":true,"context_lines":[{"line_number":481,"context_line":"ironic_api_port: \"6385\""},{"line_number":482,"context_line":"ironic_api_listen_port: \"{{ ironic_api_port }}\""},{"line_number":483,"context_line":"ironic_api_public_port: \"{{ haproxy_single_external_frontend_public_port if haproxy_single_external_frontend | bool else ironic_api_port }}\""},{"line_number":484,"context_line":"# TODO(mnasiadka): Remove after Gazpacho/2026.1 release"},{"line_number":485,"context_line":"ironic_inspector_internal_fqdn: \"{{ kolla_internal_fqdn }}\""},{"line_number":486,"context_line":"ironic_inspector_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":487,"context_line":"ironic_inspector_internal_endpoint: \"{{ ironic_inspector_internal_fqdn | kolla_url(internal_protocol, ironic_inspector_port) }}\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"b2c82bc4_c7ad8440","line":484,"updated":"2025-09-03 12:14:21.000000000","message":"This all can actually be removed, will do after this zuul run","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"91690dccbf1f46bfeb5614494301936aac8420e5","unresolved":false,"context_lines":[{"line_number":481,"context_line":"ironic_api_port: \"6385\""},{"line_number":482,"context_line":"ironic_api_listen_port: \"{{ ironic_api_port }}\""},{"line_number":483,"context_line":"ironic_api_public_port: \"{{ haproxy_single_external_frontend_public_port if haproxy_single_external_frontend | bool else ironic_api_port }}\""},{"line_number":484,"context_line":"# TODO(mnasiadka): Remove after Gazpacho/2026.1 release"},{"line_number":485,"context_line":"ironic_inspector_internal_fqdn: \"{{ kolla_internal_fqdn }}\""},{"line_number":486,"context_line":"ironic_inspector_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":487,"context_line":"ironic_inspector_internal_endpoint: \"{{ ironic_inspector_internal_fqdn | kolla_url(internal_protocol, ironic_inspector_port) }}\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"e09d7bcd_b1d40cfe","line":484,"in_reply_to":"b2c82bc4_c7ad8440","updated":"2025-09-03 18:30:52.000000000","message":"Done","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"}],"ansible/roles/bifrost/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"debdeb4ef4972a208124413b080cb3802b52a596","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# inspection reaches feature parity. Please see:"},{"line_number":18,"context_line":"# https://bugs.launchpad.net/kolla/+bug/2054685 which contains links for"},{"line_number":19,"context_line":"# tracking the progress."},{"line_number":20,"context_line":"bifrost_enable_ironic_inspector: true"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"c9767d6d_7008276f","side":"PARENT","line":20,"updated":"2025-09-03 12:14:21.000000000","message":"This probably requires addition to reno","commit_id":"58b83afc64da83104edf1cd79cb439b66167f5f5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"91690dccbf1f46bfeb5614494301936aac8420e5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# inspection reaches feature parity. Please see:"},{"line_number":18,"context_line":"# https://bugs.launchpad.net/kolla/+bug/2054685 which contains links for"},{"line_number":19,"context_line":"# tracking the progress."},{"line_number":20,"context_line":"bifrost_enable_ironic_inspector: true"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"5d3f07af_982553c9","side":"PARENT","line":20,"in_reply_to":"c9767d6d_7008276f","updated":"2025-09-03 18:30:52.000000000","message":"Done","commit_id":"58b83afc64da83104edf1cd79cb439b66167f5f5"}],"ansible/roles/ironic/defaults/main.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1a31493a7eaf1bb0919dffd1529a05e4d9146856","unresolved":true,"context_lines":[{"line_number":213,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":214,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":215,"context_line":"  - \"kolla_logs:/var/log/kolla\""},{"line_number":216,"context_line":"  - \"ironic_dhcp_hosts:/etc/dnsmasq/dhcp-hostsdir:ro\""},{"line_number":217,"context_line":"ironic_prometheus_exporter_default_volumes:"},{"line_number":218,"context_line":"  - \"{{ node_config_directory }}/ironic-prometheus-exporter/:{{ container_config_directory }}/:ro\""},{"line_number":219,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"b8e1c586_9db5ac93","line":216,"updated":"2025-08-29 09:31:54.000000000","message":"it will end up with new empty volume. Maybe let\u0027s copy the content of it to new one?","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c2780489777b86d454085013fc61984453325717","unresolved":false,"context_lines":[{"line_number":213,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":214,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":215,"context_line":"  - \"kolla_logs:/var/log/kolla\""},{"line_number":216,"context_line":"  - \"ironic_dhcp_hosts:/etc/dnsmasq/dhcp-hostsdir:ro\""},{"line_number":217,"context_line":"ironic_prometheus_exporter_default_volumes:"},{"line_number":218,"context_line":"  - \"{{ node_config_directory }}/ironic-prometheus-exporter/:{{ container_config_directory }}/:ro\""},{"line_number":219,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"a61d9fea_ea36982f","line":216,"in_reply_to":"b8e1c586_9db5ac93","updated":"2025-09-03 08:33:45.000000000","message":"Done","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1a31493a7eaf1bb0919dffd1529a05e4d9146856","unresolved":true,"context_lines":[{"line_number":253,"context_line":"ironic_tftp_listen_address: \"{{ ironic_tftp_interface_address }}\""},{"line_number":254,"context_line":"ironic_enable_rolling_upgrade: \"yes\""},{"line_number":255,"context_line":"ironic_upgrade_skip_wait_check: false"},{"line_number":256,"context_line":"ironic_kernel_cmdline_extras: []"},{"line_number":257,"context_line":"ironic_pxe_filter: \"{% if enable_neutron | bool %}dnsmasq{% else %}noop{% endif %}\""},{"line_number":258,"context_line":"ironic_prometheus_exporter_data_dir: \"/var/lib/ironic-prometheus-exporter/data\""},{"line_number":259,"context_line":"ironic_prometheus_exporter_sensor_data_interval: 30"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"88fe4678_6f0e109b","line":256,"updated":"2025-08-29 09:31:54.000000000","message":"let\u0027s mention the variable re-names in release notes","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5f13d2b9be974d3ff277cac14799ee5e78dd2187","unresolved":false,"context_lines":[{"line_number":253,"context_line":"ironic_tftp_listen_address: \"{{ ironic_tftp_interface_address }}\""},{"line_number":254,"context_line":"ironic_enable_rolling_upgrade: \"yes\""},{"line_number":255,"context_line":"ironic_upgrade_skip_wait_check: false"},{"line_number":256,"context_line":"ironic_kernel_cmdline_extras: []"},{"line_number":257,"context_line":"ironic_pxe_filter: \"{% if enable_neutron | bool %}dnsmasq{% else %}noop{% endif %}\""},{"line_number":258,"context_line":"ironic_prometheus_exporter_data_dir: \"/var/lib/ironic-prometheus-exporter/data\""},{"line_number":259,"context_line":"ironic_prometheus_exporter_sensor_data_interval: 30"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"b34c6a2c_7cede844","line":256,"in_reply_to":"88fe4678_6f0e109b","updated":"2025-09-02 09:39:33.000000000","message":"Done","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"debdeb4ef4972a208124413b080cb3802b52a596","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    endpoints:"},{"line_number":292,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ ironic_internal_endpoint }}\u0027}"},{"line_number":293,"context_line":"      - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ ironic_public_endpoint }}\u0027}"},{"line_number":294,"context_line":"# TODO(mnasiadka): Remove after Gazpacho/2026.1"},{"line_number":295,"context_line":"  - name: \"ironic-inspector\""},{"line_number":296,"context_line":"    type: \"baremetal-introspection\""},{"line_number":297,"context_line":"    description: \"Ironic Inspector baremetal introspection service\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"258383fc_5e8d87c2","line":294,"updated":"2025-09-03 12:14:21.000000000","message":"This can be removed in Gazpacho, because there won\u0027t be a release of inspector","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"91690dccbf1f46bfeb5614494301936aac8420e5","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    endpoints:"},{"line_number":292,"context_line":"      - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ ironic_internal_endpoint }}\u0027}"},{"line_number":293,"context_line":"      - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ ironic_public_endpoint }}\u0027}"},{"line_number":294,"context_line":"# TODO(mnasiadka): Remove after Gazpacho/2026.1"},{"line_number":295,"context_line":"  - name: \"ironic-inspector\""},{"line_number":296,"context_line":"    type: \"baremetal-introspection\""},{"line_number":297,"context_line":"    description: \"Ironic Inspector baremetal introspection service\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"97635ecb_1d50727a","line":294,"in_reply_to":"258383fc_5e8d87c2","updated":"2025-09-03 18:30:52.000000000","message":"Done","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"}],"ansible/roles/ironic/tasks/config.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1a31493a7eaf1bb0919dffd1529a05e4d9146856","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    mode: \"0660\""},{"line_number":132,"context_line":"  become: true"},{"line_number":133,"context_line":"  with_first_found:"},{"line_number":134,"context_line":"    - \"{{ node_custom_config }}/ironic/{{ inventory_hostname }}/ipa.ipxe\""},{"line_number":135,"context_line":"    - \"{{ node_custom_config }}/ironic/ipa.ipxe\""},{"line_number":136,"context_line":"    - \"ipa.ipxe.j2\""},{"line_number":137,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"c046fa14_245c1885","line":134,"updated":"2025-08-29 09:31:54.000000000","message":"maybe we should mention such rename in the release notes, as maybe somebody has overrides for that","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5f13d2b9be974d3ff277cac14799ee5e78dd2187","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    mode: \"0660\""},{"line_number":132,"context_line":"  become: true"},{"line_number":133,"context_line":"  with_first_found:"},{"line_number":134,"context_line":"    - \"{{ node_custom_config }}/ironic/{{ inventory_hostname }}/ipa.ipxe\""},{"line_number":135,"context_line":"    - \"{{ node_custom_config }}/ironic/ipa.ipxe\""},{"line_number":136,"context_line":"    - \"ipa.ipxe.j2\""},{"line_number":137,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"f6710b3b_7fba8d7d","line":134,"in_reply_to":"c046fa14_245c1885","updated":"2025-09-02 09:39:33.000000000","message":"Done","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"}],"ansible/roles/ironic/tasks/upgrade.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1a31493a7eaf1bb0919dffd1529a05e4d9146856","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":8,"context_line":"    name: \"ironic_inspector\""},{"line_number":9,"context_line":"    ignore_missing: true"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Wait for Ironic nodes not to wait"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"4d4d78ef_6f721f89","line":10,"updated":"2025-08-29 09:31:54.000000000","message":"I think we should remove also keystone endpoint and service","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c9a00cc5e9a00bdbddd3e6250b4d48b64c685dc9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":8,"context_line":"    name: \"ironic_inspector\""},{"line_number":9,"context_line":"    ignore_missing: true"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Wait for Ironic nodes not to wait"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ff943b3c_dcc50556","line":10,"in_reply_to":"4d4d78ef_6f721f89","updated":"2025-08-29 11:19:08.000000000","message":"good catch","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"79868ff77ed777cc7bb49fa8699b59b1961d4733","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":8,"context_line":"    name: \"ironic_inspector\""},{"line_number":9,"context_line":"    ignore_missing: true"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Wait for Ironic nodes not to wait"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"dd81e0ea_5e7d01b6","line":10,"in_reply_to":"ff943b3c_dcc50556","updated":"2025-09-01 07:23:08.000000000","message":"Done","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"2cc810adf147d9b4d200fa828f9ded60395d6db8","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      vars:"},{"line_number":29,"context_line":"        volumes_dir: \u003e-"},{"line_number":30,"context_line":"          {{ \u0027/var/lib/docker/volumes\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027"},{"line_number":31,"context_line":"          else \u0027/var/lib/containers/volumes\u0027 }}"},{"line_number":32,"context_line":"      command: \u003e-"},{"line_number":33,"context_line":"        mv {{ volumes_dir }}/ironic_inspector_dhcp_hosts/_data/"},{"line_number":34,"context_line":"        {{ volumes_dir }}/ironic_dhcp_hosts/_data"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"62e179ad_bc47eeb5","line":31,"updated":"2025-09-03 12:19:20.000000000","message":"```suggestion\n          else \u0027/var/lib/containers/storage/volumes\u0027 }}\n```","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"484b704516997de66c4b8b1e51afcb104cc41380","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      vars:"},{"line_number":29,"context_line":"        volumes_dir: \u003e-"},{"line_number":30,"context_line":"          {{ \u0027/var/lib/docker/volumes\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027"},{"line_number":31,"context_line":"          else \u0027/var/lib/containers/volumes\u0027 }}"},{"line_number":32,"context_line":"      command: \u003e-"},{"line_number":33,"context_line":"        mv {{ volumes_dir }}/ironic_inspector_dhcp_hosts/_data/"},{"line_number":34,"context_line":"        {{ volumes_dir }}/ironic_dhcp_hosts/_data"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"26165d5d_f80eb670","line":31,"in_reply_to":"62e179ad_bc47eeb5","updated":"2025-09-03 16:17:32.000000000","message":"Fix applied.","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b9ac4d4695229ffbc00a64121b51cd583c0b3026","unresolved":true,"context_lines":[{"line_number":83,"context_line":"- include_tasks: legacy_upgrade.yml"},{"line_number":84,"context_line":"  when: not ironic_enable_rolling_upgrade | bool"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- name: Remove ironic_inspector_dhcp_hosts volume"},{"line_number":87,"context_line":"  become: true"},{"line_number":88,"context_line":"  command: \"{{ kolla_container_engine }} volume rm ironic_inspector_dhcp_hosts\""},{"line_number":89,"context_line":"  when: enable_ironic_dnsmasq | bool"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"d491b7d5_f6adb4b3","line":86,"updated":"2025-09-04 13:35:06.000000000","message":"doesn\u0027t this also want to be removed again after a cycle or two?","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3b0f585d7b9dbc150a8ad8136ab82221e02d996","unresolved":false,"context_lines":[{"line_number":83,"context_line":"- include_tasks: legacy_upgrade.yml"},{"line_number":84,"context_line":"  when: not ironic_enable_rolling_upgrade | bool"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- name: Remove ironic_inspector_dhcp_hosts volume"},{"line_number":87,"context_line":"  become: true"},{"line_number":88,"context_line":"  command: \"{{ kolla_container_engine }} volume rm ironic_inspector_dhcp_hosts\""},{"line_number":89,"context_line":"  when: enable_ironic_dnsmasq | bool"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"ebed5b58_c3546c23","line":86,"in_reply_to":"d491b7d5_f6adb4b3","updated":"2025-09-04 15:47:05.000000000","message":"Done","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"}],"ansible/roles/loadbalancer/tasks/upgrade.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"debdeb4ef4972a208124413b080cb3802b52a596","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - inventory_hostname in groups[\u0027loadbalancer\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# TODO(mnasiadka): Remove this task after Gazpacho release"},{"line_number":31,"context_line":"- name: Removing config for ironic-inspector"},{"line_number":32,"context_line":"  file:"},{"line_number":33,"context_line":"    path: \"{{ node_config_directory }}/haproxy/services.d/ironic-inspector.cfg\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"2ee09307_98c59ff9","line":30,"updated":"2025-09-03 12:14:21.000000000","message":"Can be removed in Gazpacho release","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"91690dccbf1f46bfeb5614494301936aac8420e5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - inventory_hostname in groups[\u0027loadbalancer\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# TODO(mnasiadka): Remove this task after Gazpacho release"},{"line_number":31,"context_line":"- name: Removing config for ironic-inspector"},{"line_number":32,"context_line":"  file:"},{"line_number":33,"context_line":"    path: \"{{ node_config_directory }}/haproxy/services.d/ironic-inspector.cfg\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"0d53e14e_63978878","line":30,"in_reply_to":"2ee09307_98c59ff9","updated":"2025-09-03 18:30:52.000000000","message":"Done","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"}],"releasenotes/notes/drop-ironic-inspector-38fc91c64517ffc1.yaml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"2cc810adf147d9b4d200fa828f9ded60395d6db8","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    ``ironic_inspector_kernel_cmdline_extras`` has been renamed to"},{"line_number":7,"context_line":"    ``ironic_kernel_cmdline_extras`` and  ``ironic_inspector_pxe_filter``"},{"line_number":8,"context_line":"    has been renamed to ``ironic_pxe_filter``."},{"line_number":9,"context_line":"    Also the ``inspector.pxe`` file has been renamed to ``ipa.pxe``."}],"source_content_type":"text/x-yaml","patch_set":50,"id":"7a093f08_6d671b2b","line":9,"updated":"2025-09-03 12:19:20.000000000","message":"```suggestion\n    Also the ``inspector.ipxe`` file has been renamed to ``ipa.ipxe``.\n```","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"484b704516997de66c4b8b1e51afcb104cc41380","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``ironic_inspector_kernel_cmdline_extras`` has been renamed to"},{"line_number":7,"context_line":"    ``ironic_kernel_cmdline_extras`` and  ``ironic_inspector_pxe_filter``"},{"line_number":8,"context_line":"    has been renamed to ``ironic_pxe_filter``."},{"line_number":9,"context_line":"    Also the ``inspector.pxe`` file has been renamed to ``ipa.pxe``."}],"source_content_type":"text/x-yaml","patch_set":50,"id":"9fb3833d_5bc203cb","line":9,"in_reply_to":"7a093f08_6d671b2b","updated":"2025-09-03 16:17:32.000000000","message":"Fix applied.","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"}],"tests/templates/inventory.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"debdeb4ef4972a208124413b080cb3802b52a596","unresolved":true,"context_lines":[{"line_number":410,"context_line":"[ironic-conductor:children]"},{"line_number":411,"context_line":"ironic"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"{% if is_upgrade | bool %}"},{"line_number":414,"context_line":"[ironic-inspector:children]"},{"line_number":415,"context_line":"ironic"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":50,"id":"0daf2398_ba579130","line":413,"updated":"2025-09-03 12:14:21.000000000","message":"Write a note to remove it in Gazpacho release","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"91690dccbf1f46bfeb5614494301936aac8420e5","unresolved":false,"context_lines":[{"line_number":410,"context_line":"[ironic-conductor:children]"},{"line_number":411,"context_line":"ironic"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"{% if is_upgrade | bool %}"},{"line_number":414,"context_line":"[ironic-inspector:children]"},{"line_number":415,"context_line":"ironic"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":50,"id":"7cafe41d_7c772ec1","line":413,"in_reply_to":"0daf2398_ba579130","updated":"2025-09-03 18:30:52.000000000","message":"Done","commit_id":"563d4e1eda4b7a872da370020078b5a97b97303c"}],"tests/test-ironic.sh":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1a31493a7eaf1bb0919dffd1529a05e4d9146856","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        fi"},{"line_number":75,"context_line":"        sleep 60"},{"line_number":76,"context_line":"    done"},{"line_number":77,"context_line":"    echo \"SUCCESS: Server creation\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    echo \"TESTING: Server deletion\""},{"line_number":80,"context_line":"    openstack server delete --wait kolla_bm_boot_test"}],"source_content_type":"text/x-sh","patch_set":28,"id":"0c58f551_12ba1635","line":77,"updated":"2025-08-29 09:31:54.000000000","message":"so now on ERROR we will have SUCCESS ;)","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8167d3a3ba4c6eb49dfe59e97e2b80af72c1aa23","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        fi"},{"line_number":75,"context_line":"        sleep 60"},{"line_number":76,"context_line":"    done"},{"line_number":77,"context_line":"    echo \"SUCCESS: Server creation\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    echo \"TESTING: Server deletion\""},{"line_number":80,"context_line":"    openstack server delete --wait kolla_bm_boot_test"}],"source_content_type":"text/x-sh","patch_set":28,"id":"d6080bb6_99f44cf6","line":77,"in_reply_to":"0c58f551_12ba1635","updated":"2025-09-01 07:14:17.000000000","message":"Done","commit_id":"a2e7d794473790b476bde611bbe53fb47f7c6223"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b9ac4d4695229ffbc00a64121b51cd583c0b3026","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    local attempt"},{"line_number":35,"context_line":"    attempt\u003d1"},{"line_number":36,"context_line":"    while [[ $(openstack baremetal node show tk0 -f value -c provision_state) !\u003d \"manageable\" ]]; do"},{"line_number":37,"context_line":"        echo \"Server not yet active, check $attempt - retrying\""},{"line_number":38,"context_line":"        attempt\u003d$((attempt+1))"},{"line_number":39,"context_line":"        if [[ $attempt -eq 16 ]]; then"},{"line_number":40,"context_line":"            echo \"FAILED: Server did not finish inspection after $attempt checks\""}],"source_content_type":"text/x-sh","patch_set":53,"id":"b10e6279_e8bf3b3e","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":35},"updated":"2025-09-04 13:35:06.000000000","message":"```suggestion\n        echo \"Server not yet manageable, check $attempt - retrying\"\n```","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"70bf4d5d37af6a1728c23ccfb53c083d4714420c","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    local attempt"},{"line_number":35,"context_line":"    attempt\u003d1"},{"line_number":36,"context_line":"    while [[ $(openstack baremetal node show tk0 -f value -c provision_state) !\u003d \"manageable\" ]]; do"},{"line_number":37,"context_line":"        echo \"Server not yet active, check $attempt - retrying\""},{"line_number":38,"context_line":"        attempt\u003d$((attempt+1))"},{"line_number":39,"context_line":"        if [[ $attempt -eq 16 ]]; then"},{"line_number":40,"context_line":"            echo \"FAILED: Server did not finish inspection after $attempt checks\""}],"source_content_type":"text/x-sh","patch_set":53,"id":"4277af4c_98225ed8","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":35},"in_reply_to":"0590fd59_a9fae929","updated":"2025-09-05 09:13:42.000000000","message":"hmm, I actually don\u0027t see it applied?","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26a282b134406eab06e148700b9ab6784ae18753","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    local attempt"},{"line_number":35,"context_line":"    attempt\u003d1"},{"line_number":36,"context_line":"    while [[ $(openstack baremetal node show tk0 -f value -c provision_state) !\u003d \"manageable\" ]]; do"},{"line_number":37,"context_line":"        echo \"Server not yet active, check $attempt - retrying\""},{"line_number":38,"context_line":"        attempt\u003d$((attempt+1))"},{"line_number":39,"context_line":"        if [[ $attempt -eq 16 ]]; then"},{"line_number":40,"context_line":"            echo \"FAILED: Server did not finish inspection after $attempt checks\""}],"source_content_type":"text/x-sh","patch_set":53,"id":"ee932c29_779bb550","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":35},"in_reply_to":"4277af4c_98225ed8","updated":"2025-09-05 09:27:12.000000000","message":"weird, applied now.","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3b0f585d7b9dbc150a8ad8136ab82221e02d996","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    local attempt"},{"line_number":35,"context_line":"    attempt\u003d1"},{"line_number":36,"context_line":"    while [[ $(openstack baremetal node show tk0 -f value -c provision_state) !\u003d \"manageable\" ]]; do"},{"line_number":37,"context_line":"        echo \"Server not yet active, check $attempt - retrying\""},{"line_number":38,"context_line":"        attempt\u003d$((attempt+1))"},{"line_number":39,"context_line":"        if [[ $attempt -eq 16 ]]; then"},{"line_number":40,"context_line":"            echo \"FAILED: Server did not finish inspection after $attempt checks\""}],"source_content_type":"text/x-sh","patch_set":53,"id":"0590fd59_a9fae929","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":35},"in_reply_to":"b10e6279_e8bf3b3e","updated":"2025-09-04 15:47:05.000000000","message":"Fix applied.","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b9ac4d4695229ffbc00a64121b51cd583c0b3026","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    echo \"TESTING: Server creation\""},{"line_number":51,"context_line":"    openstack baremetal node provide tk0"},{"line_number":52,"context_line":"    local attempt"},{"line_number":53,"context_line":"    attempt\u003d1"},{"line_number":54,"context_line":"    while [[ $(openstack baremetal node show tk0 -f value -c provision_state) !\u003d \"available\" ]]; do"},{"line_number":55,"context_line":"        echo \"Server not yet available, check $attempt - retrying\""}],"source_content_type":"text/x-sh","patch_set":53,"id":"f7417dcf_696c12c3","line":52,"updated":"2025-09-04 13:35:06.000000000","message":"not necessary to repeat this within the same function?","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3b0f585d7b9dbc150a8ad8136ab82221e02d996","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    echo \"TESTING: Server creation\""},{"line_number":51,"context_line":"    openstack baremetal node provide tk0"},{"line_number":52,"context_line":"    local attempt"},{"line_number":53,"context_line":"    attempt\u003d1"},{"line_number":54,"context_line":"    while [[ $(openstack baremetal node show tk0 -f value -c provision_state) !\u003d \"available\" ]]; do"},{"line_number":55,"context_line":"        echo \"Server not yet available, check $attempt - retrying\""}],"source_content_type":"text/x-sh","patch_set":53,"id":"b1bcecdc_368ab792","line":52,"in_reply_to":"f7417dcf_696c12c3","updated":"2025-09-04 15:47:05.000000000","message":"Done","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b9ac4d4695229ffbc00a64121b51cd583c0b3026","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    # NOTE(mnasiadka): Wait for nova-compute-ironic to pick up the new node"},{"line_number":65,"context_line":"    sleep 60"},{"line_number":66,"context_line":"    openstack server create --image cirros --flavor test-rc --key-name mykey --network public1 kolla_bm_boot_test"},{"line_number":67,"context_line":"    local attempt"},{"line_number":68,"context_line":"    attempt\u003d1"},{"line_number":69,"context_line":"    while [[ $(openstack server show kolla_bm_boot_test -f value -c status) !\u003d \"ACTIVE\" ]]; do"},{"line_number":70,"context_line":"        echo \"Server not yet active, check $attempt - retrying\""}],"source_content_type":"text/x-sh","patch_set":53,"id":"2133f316_c0abea58","line":67,"updated":"2025-09-04 13:35:06.000000000","message":"this is also redundant now","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3b0f585d7b9dbc150a8ad8136ab82221e02d996","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # NOTE(mnasiadka): Wait for nova-compute-ironic to pick up the new node"},{"line_number":65,"context_line":"    sleep 60"},{"line_number":66,"context_line":"    openstack server create --image cirros --flavor test-rc --key-name mykey --network public1 kolla_bm_boot_test"},{"line_number":67,"context_line":"    local attempt"},{"line_number":68,"context_line":"    attempt\u003d1"},{"line_number":69,"context_line":"    while [[ $(openstack server show kolla_bm_boot_test -f value -c status) !\u003d \"ACTIVE\" ]]; do"},{"line_number":70,"context_line":"        echo \"Server not yet active, check $attempt - retrying\""}],"source_content_type":"text/x-sh","patch_set":53,"id":"2fbfb200_bec8189a","line":67,"in_reply_to":"2133f316_c0abea58","updated":"2025-09-04 15:47:05.000000000","message":"Done","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b9ac4d4695229ffbc00a64121b51cd583c0b3026","unresolved":true,"context_lines":[{"line_number":373,"context_line":"    nodeset: kolla-ansible-debian-bookworm-16GB"},{"line_number":374,"context_line":"    vars:"},{"line_number":375,"context_line":"      base_distro: debian"},{"line_number":376,"context_line":"      is_upgrade: true"},{"line_number":377,"context_line":"- job:"},{"line_number":378,"context_line":"    name: kolla-ansible-ubuntu-ironic-upgrade"},{"line_number":379,"context_line":"    parent: kolla-ansible-ironic-base"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"aaef0fa1_89191a44","line":376,"updated":"2025-09-04 13:35:06.000000000","message":"nit: add an empty line","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3b0f585d7b9dbc150a8ad8136ab82221e02d996","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    nodeset: kolla-ansible-debian-bookworm-16GB"},{"line_number":374,"context_line":"    vars:"},{"line_number":375,"context_line":"      base_distro: debian"},{"line_number":376,"context_line":"      is_upgrade: true"},{"line_number":377,"context_line":"- job:"},{"line_number":378,"context_line":"    name: kolla-ansible-ubuntu-ironic-upgrade"},{"line_number":379,"context_line":"    parent: kolla-ansible-ironic-base"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"86ec21e8_d4e1256c","line":376,"in_reply_to":"aaef0fa1_89191a44","updated":"2025-09-04 15:47:05.000000000","message":"Done","commit_id":"0f615ae54c03eaff97f940d0cb592530fc137487"}]}