)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"31339a08f930d4e64616796e6e8b5703aed11753","unresolved":true,"context_lines":[{"line_number":14,"context_line":"endpoint, resulting Nova to use public Cinder endpoint instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change set proper overriding by replacing ``interface \u003d internal``"},{"line_number":17,"context_line":"to ``catalog_info \u003d block-storage::internalURL``."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://review.opendev.org/c/openstack/kolla-ansible/+/937038"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8f556e29_a1550a0f","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":46},"updated":"2025-06-20 14:16:35.000000000","message":"block-storage:cinder:internalURL","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"62a5869eb755a9e146fe670de04806c3f693ab45","unresolved":true,"context_lines":[{"line_number":14,"context_line":"endpoint, resulting Nova to use public Cinder endpoint instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change set proper overriding by replacing ``interface \u003d internal``"},{"line_number":17,"context_line":"to ``catalog_info \u003d block-storage::internalURL``."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://review.opendev.org/c/openstack/kolla-ansible/+/937038"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff8db5a8_fdcc86aa","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":46},"in_reply_to":"8f556e29_a1550a0f","updated":"2025-06-20 14:25:34.000000000","message":"replied on different comment","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b698cab62093db68e7cbe1378c7a231c29c7463f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"endpoint, resulting Nova to use public Cinder endpoint instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change set proper overriding by replacing ``interface \u003d internal``"},{"line_number":17,"context_line":"to ``catalog_info \u003d block-storage::internalURL``."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://review.opendev.org/c/openstack/kolla-ansible/+/937038"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"089b7a58_50a8854f","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":46},"in_reply_to":"ff8db5a8_fdcc86aa","updated":"2025-06-20 14:28:17.000000000","message":"Acknowledged","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"72deb13d96fda7af17c5004103e04ef420889d5e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"endpoint, resulting Nova to use public Cinder endpoint instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change set proper overriding by replacing ``interface \u003d internal``"},{"line_number":17,"context_line":"to ``catalog_info \u003d block-storage::internalURL``."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://review.opendev.org/c/openstack/kolla-ansible/+/937038"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b5f761ee_6f6e4843","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":46},"in_reply_to":"ff8db5a8_fdcc86aa","updated":"2025-06-20 14:28:34.000000000","message":"Done","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7f3282573e9c66a443e1e03cead44ab5440261c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c433fe9a_d62062ed","updated":"2025-06-20 15:28:10.000000000","message":"Looks good. For reference:\n\n```\ncinder_opts \u003d [\n    cfg.StrOpt(\u0027catalog_info\u0027,\n            default\u003d\u0027volumev3::publicURL\u0027,\n            regex\u003dr\u0027^[\\w-]+:\\w*:.*$\u0027,\n            help\u003d\"\"\"\nInfo to match when looking for cinder in the service catalog.\n\nThe ``\u003cservice_name\u003e`` is optional and omitted by default since it should\nnot be necessary in most deployments.\n\nPossible values:\n\n* Format is separated values of the form:\n  \u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e\n```\n\nA reno would be nice.","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7356b6c29cb758603e8529f66120a1bdb68822dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a31b0c34_b19d8a75","updated":"2025-06-20 14:27:55.000000000","message":"OK, let\u0027s follow the Nova recommendations.","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"c6df5c39b12fcb7215f24686904fc3cdce913c55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5428e22f_77d1e83f","updated":"2025-06-20 14:10:24.000000000","message":"Targetting block-storage explicitly is fine for 2025.1 and later as Kolla Ansible creates Cinder endpoint with service type of block-storage by default","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"79e1d73d5308f41a1665f5841f5ddee5eac9f10a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac0c5aac_35cbb05c","updated":"2025-06-20 14:29:39.000000000","message":"There is a need to add a releasenote for operators to be able to upgrade.","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"1344a63ac07f163f2061ed8ad47b2428d7d8d6f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf5b2aec_12ac1fea","updated":"2025-06-20 14:05:20.000000000","message":"This needs to be backported to 2025.1 but only 2025.1","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3f5f95fe8cf854fc3f4b6e8079f9d28232069dea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d236adca_fb2a4674","updated":"2025-06-20 14:14:09.000000000","message":"This was a decision for a while.\nBut, this was merged: https://review.opendev.org/c/openstack/kolla-ansible/+/937038/12/ansible/roles/nova-cell/templates/nova.conf.j2\nAnd backports not-allowed, but I\u0027ve asked to do it another way till 2024.2.\nI prefere the 9th patchset: https://review.opendev.org/c/openstack/kolla-ansible/+/937038/9\nSince the issue with naming was fixed in all stable versions: https://review.opendev.org/q/I9a57aa72cc9589cec08b0f8d5797108043747ef6","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"982d46b106d03fe88ee0a8baf3e4376193ba727b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c7de3ce_e097849d","in_reply_to":"ac0c5aac_35cbb05c","updated":"2025-06-20 15:46:09.000000000","message":"Done","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"62a5869eb755a9e146fe670de04806c3f693ab45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b9e4f8b_a4940065","in_reply_to":"d236adca_fb2a4674","updated":"2025-06-20 14:25:34.000000000","message":"Okay, but that is already merged with patchset 12. Let\u0027s fix the problem with this patch.","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"850db378c7604b19a59a0473e455841788f81567","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"948e4d14_5fb9a377","updated":"2025-06-20 17:46:46.000000000","message":"Why not revert the faulty patch?","commit_id":"be66b050a609d76d727449306a26f3dec4834b85"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2baf489a25624695802f3f2285e6753c3e4a7798","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb013014_4ffc64b5","in_reply_to":"948e4d14_5fb9a377","updated":"2025-06-20 17:53:37.000000000","message":"because actually not all from that patch should be reverted","commit_id":"be66b050a609d76d727449306a26f3dec4834b85"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"159ff8f36981d2330c49d428c9412160c0a49308","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc2d3d2b_c3b0187d","in_reply_to":"eb013014_4ffc64b5","updated":"2025-06-20 20:04:44.000000000","message":"I see - and it seems nova really does not support setting interface (see https://github.com/openstack/nova/blob/41773f8c6515021eb037e6d9d385b34e89191c8c/nova/volume/cinder.py#L199)","commit_id":"be66b050a609d76d727449306a26f3dec4834b85"}],"ansible/roles/nova-cell/templates/nova.conf.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"69cc852d02b557d82f5d9e1f3084d5e6f450b984","unresolved":true,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"{% if enable_cinder | bool %}"},{"line_number":111,"context_line":"[cinder]"},{"line_number":112,"context_line":"catalog_info \u003d block-storage::internalURL"},{"line_number":113,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":114,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":115,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d670282d_b290f435","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":41},"updated":"2025-06-20 14:15:28.000000000","message":"```suggestion\ncatalog_info \u003d block-storage:cinder:internalURL\n```","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b698cab62093db68e7cbe1378c7a231c29c7463f","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"{% if enable_cinder | bool %}"},{"line_number":111,"context_line":"[cinder]"},{"line_number":112,"context_line":"catalog_info \u003d block-storage::internalURL"},{"line_number":113,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":114,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":115,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bef192d3_10b44faa","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":41},"in_reply_to":"2e6748cc_997f05f3","updated":"2025-06-20 14:28:17.000000000","message":"Acknowledged","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"72deb13d96fda7af17c5004103e04ef420889d5e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"{% if enable_cinder | bool %}"},{"line_number":111,"context_line":"[cinder]"},{"line_number":112,"context_line":"catalog_info \u003d block-storage::internalURL"},{"line_number":113,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":114,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":115,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"332aea67_9b8b16f0","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":41},"in_reply_to":"2e6748cc_997f05f3","updated":"2025-06-20 14:28:34.000000000","message":"Done","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"62a5869eb755a9e146fe670de04806c3f693ab45","unresolved":true,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"{% if enable_cinder | bool %}"},{"line_number":111,"context_line":"[cinder]"},{"line_number":112,"context_line":"catalog_info \u003d block-storage::internalURL"},{"line_number":113,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":114,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":115,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2e6748cc_997f05f3","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":41},"in_reply_to":"d670282d_b290f435","updated":"2025-06-20 14:25:34.000000000","message":"I think it\u0027s better to follow the principle of Nova upstream saying\n\u003e The \u003cservice_name\u003e is optional and omitted by default since it should not be necessary in most deployments.","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"69cc852d02b557d82f5d9e1f3084d5e6f450b984","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% if enable_cinder | bool %}"},{"line_number":66,"context_line":"[cinder]"},{"line_number":67,"context_line":"catalog_info \u003d block-storage::internalURL"},{"line_number":68,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":69,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":70,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e9545065_ce5c71a7","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":41},"updated":"2025-06-20 14:15:28.000000000","message":"```suggestion\ncatalog_info \u003d block-storage:cinder:internalURL\n```","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b698cab62093db68e7cbe1378c7a231c29c7463f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% if enable_cinder | bool %}"},{"line_number":66,"context_line":"[cinder]"},{"line_number":67,"context_line":"catalog_info \u003d block-storage::internalURL"},{"line_number":68,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":69,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":70,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e79e7a25_945fd5ea","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":41},"in_reply_to":"51733540_79be4b0f","updated":"2025-06-20 14:28:17.000000000","message":"Acknowledged","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"72deb13d96fda7af17c5004103e04ef420889d5e","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% if enable_cinder | bool %}"},{"line_number":66,"context_line":"[cinder]"},{"line_number":67,"context_line":"catalog_info \u003d block-storage::internalURL"},{"line_number":68,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":69,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":70,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6ae6f8ae_ad20d837","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":41},"in_reply_to":"51733540_79be4b0f","updated":"2025-06-20 14:28:34.000000000","message":"Done","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"62a5869eb755a9e146fe670de04806c3f693ab45","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% if enable_cinder | bool %}"},{"line_number":66,"context_line":"[cinder]"},{"line_number":67,"context_line":"catalog_info \u003d block-storage::internalURL"},{"line_number":68,"context_line":"os_region_name \u003d {{ openstack_region_name }}"},{"line_number":69,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":70,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"51733540_79be4b0f","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":41},"in_reply_to":"e9545065_ce5c71a7","updated":"2025-06-20 14:25:34.000000000","message":"replied on different comment","commit_id":"5364bce313620a75698d2e271c7d656f3df437ac"}]}