)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9ec8f79c5ec24c818b25124054818a59a9c7f433","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Mariusz \u003cmariusz.karpiarz@codethink.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-27 08:16:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prechecks failing for encrypted passwords"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"is string\" conditional fails for variables of type"},{"line_number":10,"context_line":"`AnsibleVaultEncryptedUnicode` (Ansible Vault-encrypted passwords)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fadb8d79_bd4542b5","line":7,"updated":"2025-06-27 09:51:26.000000000","message":"If you want to fix (and I assume backport), then there needs to be a bug report linked, especially that you mention that the precheck is in K-A since 2024.1","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fda635e87faff0f68e381fd3276ba7169034dc6f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Mariusz \u003cmariusz.karpiarz@codethink.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-27 08:16:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prechecks failing for encrypted passwords"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"is string\" conditional fails for variables of type"},{"line_number":10,"context_line":"`AnsibleVaultEncryptedUnicode` (Ansible Vault-encrypted passwords)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0bafe0cc_43bfdc4b","line":7,"in_reply_to":"0b8cc3e8_44a7ae39","updated":"2025-06-27 10:09:07.000000000","message":"You don\u0027t need to rename the branch, just add \"Closes-Bug: #12345\" to the commit where 12345 is the bug number in LP","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d80c7355d7b19b7844305bf7a161f57bd343b6d2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Mariusz \u003cmariusz.karpiarz@codethink.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-27 08:16:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prechecks failing for encrypted passwords"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"is string\" conditional fails for variables of type"},{"line_number":10,"context_line":"`AnsibleVaultEncryptedUnicode` (Ansible Vault-encrypted passwords)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b8bffe4b_e44cbeba","line":7,"in_reply_to":"0bafe0cc_43bfdc4b","updated":"2025-06-27 10:09:26.000000000","message":"to the commit message of course","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"fb1ec0a12f0e91ba4ca8d131ea0bfef608005013","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Mariusz \u003cmariusz.karpiarz@codethink.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-27 08:16:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prechecks failing for encrypted passwords"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"is string\" conditional fails for variables of type"},{"line_number":10,"context_line":"`AnsibleVaultEncryptedUnicode` (Ansible Vault-encrypted passwords)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"056ec708_5c0af30a","line":7,"in_reply_to":"b8bffe4b_e44cbeba","updated":"2025-06-27 10:14:36.000000000","message":"Understood. I\u0027ll submit a bug report then.","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"ea9ea5bced7b8662282df4734e233a8271dd618a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Mariusz \u003cmariusz.karpiarz@codethink.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-27 08:16:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prechecks failing for encrypted passwords"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"is string\" conditional fails for variables of type"},{"line_number":10,"context_line":"`AnsibleVaultEncryptedUnicode` (Ansible Vault-encrypted passwords)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0b8cc3e8_44a7ae39","line":7,"in_reply_to":"fadb8d79_bd4542b5","updated":"2025-06-27 10:03:38.000000000","message":"Do you want me to create a bug report then? If I do this, will renaming the branch (so that it includes the bug number) cause Gerrit to create a new change or will I be able to keep using this patch?","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"dae95b4552fe866a6eee6617c4f6d381e21ac54a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a31f255_ab3dbf44","updated":"2025-06-27 09:26:05.000000000","message":"Alternative conditions we could use here:\n\n1. \"X is sequence\" - a single statement covering both encrypted and unencrypted passwords\n1. \"X.isalnum()\" - may not work for the character space `genpwd` uses\n... possibly much more options\n\nIs there anything better you guys would recommend?","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"e1d045508ee8a5c76c19a88cb79edb7ec2218bd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49b90293_e8a3e327","updated":"2025-06-27 09:31:21.000000000","message":"This is the change which introduced these conditions to the prechecks:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/828695/30/ansible/roles/prometheus/tasks/precheck.yml","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"}],"releasenotes/notes/fix-prechecks-for-encrypted-passwords-f313aa51ac39f6a3.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9ec8f79c5ec24c818b25124054818a59a9c7f433","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes prechecks failing for Ansible Vault-encrypted strings represented by"},{"line_number":5,"context_line":"    type ``AnsibleVaultEncryptedUnicode``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c9472a31_cc0452e8","line":4,"updated":"2025-06-27 09:51:26.000000000","message":"Please use reno template for bug fix","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fda635e87faff0f68e381fd3276ba7169034dc6f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes prechecks failing for Ansible Vault-encrypted strings represented by"},{"line_number":5,"context_line":"    type ``AnsibleVaultEncryptedUnicode``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a197acf4_a8d58793","line":4,"in_reply_to":"6ad39c69_3171b560","updated":"2025-06-27 10:09:07.000000000","message":"https://docs.openstack.org/kolla-ansible/latest/contributor/release-notes.html#fixes","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"fb1ec0a12f0e91ba4ca8d131ea0bfef608005013","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes prechecks failing for Ansible Vault-encrypted strings represented by"},{"line_number":5,"context_line":"    type ``AnsibleVaultEncryptedUnicode``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c7cf968c_a9b64181","line":4,"in_reply_to":"a197acf4_a8d58793","updated":"2025-06-27 10:14:36.000000000","message":"Thank you for the link. I\u0027ll send templated notes with the next patch (so after submitting my bug report).","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"ea9ea5bced7b8662282df4734e233a8271dd618a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes prechecks failing for Ansible Vault-encrypted strings represented by"},{"line_number":5,"context_line":"    type ``AnsibleVaultEncryptedUnicode``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6ad39c69_3171b560","line":4,"in_reply_to":"c9472a31_cc0452e8","updated":"2025-06-27 10:03:38.000000000","message":"Could you point me to the template I should be using, please?","commit_id":"80e88913b9530a738221c3ac68558bf4bc84a6b4"}]}
