)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"87b27e24e33807d4336a64449ddd0da52e675071","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-09-18 10:37:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Split out cron to a separate role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia74c7d1e78e9d756a83c8adc7d9d8d9adb371751"},{"line_number":10,"context_line":"Signed-off-by: Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"51db638b_d1e1f825","line":8,"updated":"2025-10-01 08:17:06.000000000","message":"a bit of explanation why this is done might be helpful","commit_id":"94a46ddecf99763cee490ed31d0b66decf05f5e2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d1250c6555cbeeead70717eba15d5c71c1c88f0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-09-18 10:37:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Split out cron to a separate role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia74c7d1e78e9d756a83c8adc7d9d8d9adb371751"},{"line_number":10,"context_line":"Signed-off-by: Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"76b4ae8d_09ac6e65","line":8,"in_reply_to":"51db638b_d1e1f825","updated":"2025-10-01 08:45:19.000000000","message":"Done","commit_id":"94a46ddecf99763cee490ed31d0b66decf05f5e2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"6c861a16daa9796545ef2370d7e1cc9e584e032b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"722cb385_433f6677","updated":"2025-08-13 11:58:24.000000000","message":"Are you planning on changing the inventory groups for cron? It still has common as the child group, `grep -rA 3 \u0027^# Common$\u0027` to find them","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ccc5bdc2e7d4edace61cb13741265da77e9d89cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"49e2288e_e6b08813","in_reply_to":"722cb385_433f6677","updated":"2025-09-05 07:55:00.000000000","message":"That probably is not required yet, we can do that as a followup when renaming common to kolla-toolbox","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"87b27e24e33807d4336a64449ddd0da52e675071","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"2433e346_3bda613a","updated":"2025-10-01 08:17:06.000000000","message":"lgtm in general, but needs a bit of refreshing and how about some reno?","commit_id":"94a46ddecf99763cee490ed31d0b66decf05f5e2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e2917d5013078f2d42c0683f70777540ad8940b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":26,"id":"a1663216_be4fc3f8","updated":"2025-10-01 12:10:16.000000000","message":"I\u0027d still like to see a reno for this unless you can explain why it is not necessary. won\u0027t block on that, though","commit_id":"7b55aac53de862cffea8014e24b92ddd48701c21"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8565a5d932570642abbbf7b5460a82591cc97081","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6bb0835e_af20e2de","in_reply_to":"a1663216_be4fc3f8","updated":"2025-10-01 12:26:15.000000000","message":"Done","commit_id":"7b55aac53de862cffea8014e24b92ddd48701c21"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c0f91cf144c38065d21759f43496fd03c8c4f76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"cec9e92d_a0404c0f","updated":"2025-10-02 08:06:06.000000000","message":"good catch with the doc update","commit_id":"afbbacd00472478dad8ab5c667dd6171a4a3808d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e0a60d6bb282fdc40ec0a7f96e78e774f4d46533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"5fa15921_f52a2b7a","updated":"2025-10-02 12:20:36.000000000","message":"recheck noble podman unrelated placement ssl error","commit_id":"afbbacd00472478dad8ab5c667dd6171a4a3808d"}],"ansible/roles/common/templates/cron.json.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"87b27e24e33807d4336a64449ddd0da52e675071","unresolved":true,"context_lines":[{"line_number":7,"context_line":"            \"dest\": \"/etc/logrotate.conf\","},{"line_number":8,"context_line":"            \"owner\": \"root\","},{"line_number":9,"context_line":"            \"perm\": \"0600\""},{"line_number":10,"context_line":"        }{% if kolla_copy_ca_into_containers | bool %},"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"source\": \"{{ container_config_directory }}/ca-certificates\","},{"line_number":13,"context_line":"            \"dest\": \"/var/lib/kolla/share/ca-certificates\","},{"line_number":14,"context_line":"            \"owner\": \"root\","},{"line_number":15,"context_line":"            \"perm\": \"0600\""},{"line_number":16,"context_line":"        }{% endif %}"},{"line_number":17,"context_line":"    ]"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"39e93d19_e8e63eb2","side":"PARENT","line":16,"range":{"start_line":10,"start_character":9,"end_line":16,"end_character":10},"updated":"2025-10-01 08:17:06.000000000","message":"you are dropping this part in the new file, is this intended?","commit_id":"b36c7d741de969dead68eb45554ee5e7f7ae2a8e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e2917d5013078f2d42c0683f70777540ad8940b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"            \"dest\": \"/etc/logrotate.conf\","},{"line_number":8,"context_line":"            \"owner\": \"root\","},{"line_number":9,"context_line":"            \"perm\": \"0600\""},{"line_number":10,"context_line":"        }{% if kolla_copy_ca_into_containers | bool %},"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"source\": \"{{ container_config_directory }}/ca-certificates\","},{"line_number":13,"context_line":"            \"dest\": \"/var/lib/kolla/share/ca-certificates\","},{"line_number":14,"context_line":"            \"owner\": \"root\","},{"line_number":15,"context_line":"            \"perm\": \"0600\""},{"line_number":16,"context_line":"        }{% endif %}"},{"line_number":17,"context_line":"    ]"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"abe1fd1d_d8946c8d","side":"PARENT","line":16,"range":{"start_line":10,"start_character":9,"end_line":16,"end_character":10},"in_reply_to":"18cb93e9_8113e887","updated":"2025-10-01 12:10:16.000000000","message":"hmm, this was introduced in https://review.opendev.org/c/openstack/kolla-ansible/+/924651 which simply did the same thing for all containers. I\u0027m a bit torn between agreeing that is isn\u0027t needed and keeping it in place for consistency","commit_id":"b36c7d741de969dead68eb45554ee5e7f7ae2a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d1250c6555cbeeead70717eba15d5c71c1c88f0","unresolved":true,"context_lines":[{"line_number":7,"context_line":"            \"dest\": \"/etc/logrotate.conf\","},{"line_number":8,"context_line":"            \"owner\": \"root\","},{"line_number":9,"context_line":"            \"perm\": \"0600\""},{"line_number":10,"context_line":"        }{% if kolla_copy_ca_into_containers | bool %},"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"source\": \"{{ container_config_directory }}/ca-certificates\","},{"line_number":13,"context_line":"            \"dest\": \"/var/lib/kolla/share/ca-certificates\","},{"line_number":14,"context_line":"            \"owner\": \"root\","},{"line_number":15,"context_line":"            \"perm\": \"0600\""},{"line_number":16,"context_line":"        }{% endif %}"},{"line_number":17,"context_line":"    ]"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"18cb93e9_8113e887","side":"PARENT","line":16,"range":{"start_line":10,"start_character":9,"end_line":16,"end_character":10},"in_reply_to":"39e93d19_e8e63eb2","updated":"2025-10-01 08:45:19.000000000","message":"I don\u0027t think cron needs ca-certificates - happy to restore it if we feel it\u0027s required.","commit_id":"b36c7d741de969dead68eb45554ee5e7f7ae2a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f3536ead6f8164fdf8208cc0f16c5cc5968f3ceb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"            \"dest\": \"/etc/logrotate.conf\","},{"line_number":8,"context_line":"            \"owner\": \"root\","},{"line_number":9,"context_line":"            \"perm\": \"0600\""},{"line_number":10,"context_line":"        }{% if kolla_copy_ca_into_containers | bool %},"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"source\": \"{{ container_config_directory }}/ca-certificates\","},{"line_number":13,"context_line":"            \"dest\": \"/var/lib/kolla/share/ca-certificates\","},{"line_number":14,"context_line":"            \"owner\": \"root\","},{"line_number":15,"context_line":"            \"perm\": \"0600\""},{"line_number":16,"context_line":"        }{% endif %}"},{"line_number":17,"context_line":"    ]"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"cd05918d_d0db6ec3","side":"PARENT","line":16,"range":{"start_line":10,"start_character":9,"end_line":16,"end_character":10},"in_reply_to":"abe1fd1d_d8946c8d","updated":"2025-10-01 12:21:06.000000000","message":"Added it back, prefer consistency, although didn\u0027t think about that when removed it.","commit_id":"b36c7d741de969dead68eb45554ee5e7f7ae2a8e"}],"ansible/roles/cron/tasks/check.yml":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"6c861a16daa9796545ef2370d7e1cc9e584e032b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Checking Common containers"},{"line_number":3,"context_line":"  import_role:"},{"line_number":4,"context_line":"    role: service-check"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7b36a786_f5275c26","line":2,"updated":"2025-08-13 11:58:24.000000000","message":"```suggestion\n- name: Checking Cron containers\n```","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ccc5bdc2e7d4edace61cb13741265da77e9d89cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Checking Common containers"},{"line_number":3,"context_line":"  import_role:"},{"line_number":4,"context_line":"    role: service-check"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"38edeefd_90df590b","line":2,"in_reply_to":"7b36a786_f5275c26","updated":"2025-09-05 07:55:00.000000000","message":"Done","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"}],"ansible/roles/cron/tasks/copy-certs.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b00b069df0c21b571caf096d0948a8fb8e3172a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8d89f614_d1f4ca38","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":0},"updated":"2025-08-12 14:03:31.000000000","message":"is this really needed for cron service?","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dcca76cad6e8b0f4517065f172e35a1cc4f9b350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"90626d2d_72e48e43","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":0},"in_reply_to":"4cf94f43_1952d698","updated":"2025-10-01 12:53:51.000000000","message":"It\u0027s in every role, so it\u0027s here for consistency.","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"05aec9b90c2d88f6efb82859fe1a67c05f0d383a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4cf94f43_1952d698","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":0},"in_reply_to":"6496a0d5_3c3a1c30","updated":"2025-10-01 12:32:46.000000000","message":"I see its back again","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2c6b4a9170e4d1c0d6a48ed0904c15d030902023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6496a0d5_3c3a1c30","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":0},"in_reply_to":"8d89f614_d1f4ca38","updated":"2025-09-05 07:56:02.000000000","message":"Done","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"84311119e928f85583567e3c42f0b937fe6e065f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7ad36be5_c82351ba","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":0},"in_reply_to":"90626d2d_72e48e43","updated":"2025-10-01 19:29:30.000000000","message":"It\u0027s strange. It takes extra time to deploy and makes the useless operations. Nevermind, OK.","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c54a4d9f8685b6f384f0377dc9b7af3389abc625","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  import_role:"},{"line_number":4,"context_line":"    role: service-cert-copy"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    project_services: \"{{ cron_services }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"aaff81d9_cfa7894f","line":6,"updated":"2025-10-02 06:11:01.000000000","message":"finally some linter result I 100% agree with ;)\n\nERROR:__main__:/home/zuul/src/opendev.org/openstack/kolla-ansible/ansible/roles/cron/tasks/copy-certs.yml file error: no newline at end of file","commit_id":"a215f99753dc385c0c8c359bb832d98ad257b74e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cbb31585671c806d586d793de7e9423b2330e766","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  import_role:"},{"line_number":4,"context_line":"    role: service-cert-copy"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    project_services: \"{{ cron_services }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9991667c_941bda40","line":6,"in_reply_to":"aaff81d9_cfa7894f","updated":"2025-10-02 07:14:30.000000000","message":"Done","commit_id":"a215f99753dc385c0c8c359bb832d98ad257b74e"}],"ansible/roles/cron/templates/cron-logrotate-ironic-inspector.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"87b27e24e33807d4336a64449ddd0da52e675071","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\"/var/log/kolla/ironic-inspector/*.log\""},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"31dafb93_f5ecae00","line":3,"updated":"2025-10-01 08:17:06.000000000","message":"removed in If178c23249370c7c69744843737e61a6309d6a19 so no longer needed?","commit_id":"94a46ddecf99763cee490ed31d0b66decf05f5e2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d1250c6555cbeeead70717eba15d5c71c1c88f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"/var/log/kolla/ironic-inspector/*.log\""},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"24a2699f_a34fc50f","line":3,"in_reply_to":"31dafb93_f5ecae00","updated":"2025-10-01 08:45:19.000000000","message":"Done","commit_id":"94a46ddecf99763cee490ed31d0b66decf05f5e2"}],"ansible/roles/cron/templates/cron-logrotate-neutron-tls-proxy.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"87b27e24e33807d4336a64449ddd0da52e675071","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\"/var/log/kolla/neutron-tls-proxy/*.log\""},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"5ef7b004_be7f446d","line":1,"updated":"2025-10-01 08:17:06.000000000","message":"removed in Iac99be59139eeb232dd3b00ec90fae0a4ea7547d","commit_id":"94a46ddecf99763cee490ed31d0b66decf05f5e2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d1250c6555cbeeead70717eba15d5c71c1c88f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"/var/log/kolla/neutron-tls-proxy/*.log\""},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"372fc5ba_208ce9cb","line":1,"in_reply_to":"5ef7b004_be7f446d","updated":"2025-10-01 08:45:19.000000000","message":"Done","commit_id":"94a46ddecf99763cee490ed31d0b66decf05f5e2"}],"ansible/site.yml":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"6c861a16daa9796545ef2370d7e1cc9e584e032b","unresolved":true,"context_lines":[{"line_number":87,"context_line":"- name: Apply role common"},{"line_number":88,"context_line":"  gather_facts: false"},{"line_number":89,"context_line":"  hosts:"},{"line_number":90,"context_line":"    - cron"},{"line_number":91,"context_line":"    - kolla-logs"},{"line_number":92,"context_line":"    - kolla-toolbox"},{"line_number":93,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"e4645c1c_d8d0027e","line":90,"updated":"2025-08-13 11:58:24.000000000","message":"No longer required?","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ccc5bdc2e7d4edace61cb13741265da77e9d89cd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"- name: Apply role common"},{"line_number":88,"context_line":"  gather_facts: false"},{"line_number":89,"context_line":"  hosts:"},{"line_number":90,"context_line":"    - cron"},{"line_number":91,"context_line":"    - kolla-logs"},{"line_number":92,"context_line":"    - kolla-toolbox"},{"line_number":93,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"536a2eee_95aa1766","line":90,"in_reply_to":"e4645c1c_d8d0027e","updated":"2025-09-05 07:55:00.000000000","message":"Done","commit_id":"98c48986f78511b45ced3938b58dc885e977df5e"}]}